From: David Rientjes <rientjes@google.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: gumingtao <gumingtao1225@gmail.com>,
cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
gumingtao <gumingtao@xiaomi.com>
Subject: Re: [PATCH] slab: Use %s instead of function name
Date: Fri, 18 Jun 2021 12:32:53 -0700 (PDT) [thread overview]
Message-ID: <c51952f7-a355-b038-4377-f6673c413d1f@google.com> (raw)
In-Reply-To: <CAKXUXMxyDaEnWeGNZpCmAFG-5OG0JVrHz0RPk18n_z+ZDKQ-cQ@mail.gmail.com>
On Fri, 18 Jun 2021, Lukas Bulwahn wrote:
> > It is better to replace the function name with %s.
> >
> > Signed-off-by: gumingtao <gumingtao@xiaomi.com>
> > ---
> > mm/slab_common.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/slab_common.c b/mm/slab_common.c
> > index a4a5714..36127dc 100644
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -381,8 +381,8 @@ kmem_cache_create_usercopy(const char *name,
> > panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",
>
> I am just wondering:
>
> Can you also make that refactoring change for the panic() call as well?
>
> How about checking the whole file for such patterns and doing that
> change for all occurrences?
>
Yeah, that would be ideal if gumingtao is willing to do it. These are
some instances where the function name actually mismatches. gumingtao,
would you be willing to do this?
prev parent reply other threads:[~2021-06-18 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 10:59 gumingtao
2021-06-18 12:03 ` Lukas Bulwahn
2021-06-18 19:32 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c51952f7-a355-b038-4377-f6673c413d1f@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gumingtao1225@gmail.com \
--cc=gumingtao@xiaomi.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukas.bulwahn@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=penberg@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox