From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07145C46CD2 for ; Tue, 2 Jan 2024 11:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C83F6B027B; Tue, 2 Jan 2024 06:07:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 978AC6B027D; Tue, 2 Jan 2024 06:07:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 840686B0280; Tue, 2 Jan 2024 06:07:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 72F176B027B for ; Tue, 2 Jan 2024 06:07:01 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 42D8AA075A for ; Tue, 2 Jan 2024 11:07:01 +0000 (UTC) X-FDA: 81634093842.23.26FDA94 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id D95EB40002 for ; Tue, 2 Jan 2024 11:06:58 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JCKKkR9J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2quGy2Uk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JCKKkR9J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2quGy2Uk; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704193619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z3u5LS27lpG6RgGhD4cQr+0Nm3zxOMnVlotUFDEOZGc=; b=VMfxitlAkK7D4AvYSt82LITSY87G7mGZY98Iy+TppKjtd00adzqVzNDfiIQFwY7/weBvYr bWcK2rHf1t3O+VXSdmRJyQrxSHbSqVhbRGNz5oLgdv+Rzor6J4/pnK87N3G7Hz7Gibk/OH NDOMJyGj97uIqeeM5MNpVgRNAioHeoE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JCKKkR9J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2quGy2Uk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JCKKkR9J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2quGy2Uk; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704193619; a=rsa-sha256; cv=none; b=sP6d+oUxn7gJg0X4wQcObq/3nPTa45wmHGpF/7G0HoeH4cXHXdsBk+JIDApX4GcoGEM8z5 e1hNt2kP/7mTyIMjMd+NihKTyuev8MsYVbXYujvUA1DW4k71rVvCZIq/UNRAZlwTVyRLAK ucQhUYzbpiwGWyY5mqbJKcDxF6wbso4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D0F461FD55; Tue, 2 Jan 2024 11:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704193616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3u5LS27lpG6RgGhD4cQr+0Nm3zxOMnVlotUFDEOZGc=; b=JCKKkR9JBeZWqMt1vE2M1NIcTIjYjvDSvnRAK69fjdw8lD3hEU4yNvo29/6riD3RAs1K+M 5aSAqEtR/as/1StPA8XVLB5f2XDs1/oe2XEi47XzvYJM718p3Zm9EJgR4X6Ec3g5H1JTir +VcYaBQoVlnsGW2IW9RpMjXh8pZJRmw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704193616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3u5LS27lpG6RgGhD4cQr+0Nm3zxOMnVlotUFDEOZGc=; b=2quGy2UkIdo4kUiikZNaQ3/AG6hCrwxeeC0IiAzhY9kg95S3usSrglU48YW14oW2dJMTe5 M+OvHypbySlbPFDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704193616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3u5LS27lpG6RgGhD4cQr+0Nm3zxOMnVlotUFDEOZGc=; b=JCKKkR9JBeZWqMt1vE2M1NIcTIjYjvDSvnRAK69fjdw8lD3hEU4yNvo29/6riD3RAs1K+M 5aSAqEtR/as/1StPA8XVLB5f2XDs1/oe2XEi47XzvYJM718p3Zm9EJgR4X6Ec3g5H1JTir +VcYaBQoVlnsGW2IW9RpMjXh8pZJRmw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704193616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3u5LS27lpG6RgGhD4cQr+0Nm3zxOMnVlotUFDEOZGc=; b=2quGy2UkIdo4kUiikZNaQ3/AG6hCrwxeeC0IiAzhY9kg95S3usSrglU48YW14oW2dJMTe5 M+OvHypbySlbPFDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B396513AC6; Tue, 2 Jan 2024 11:06:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QqUUK1Duk2UQKAAAD6G6ig (envelope-from ); Tue, 02 Jan 2024 11:06:56 +0000 Message-ID: Date: Tue, 2 Jan 2024 12:06:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] slub: Use alloc_pages_node() in alloc_slab_page() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Johannes Weiner , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20231228085748.1083901-1-willy@infradead.org> <20231228085748.1083901-3-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20231228085748.1083901-3-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: yehpxe4s6uthztzfgb15qdcmk1psdwdr X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D95EB40002 X-HE-Tag: 1704193618-616878 X-HE-Meta: U2FsdGVkX1/IY2kJqjiPgtekzZxKQ1Wu//UZ9gWFn+fQKa15FiHvXl7XoEGTY5u1bAVQchujCnGuaiQh5Zd3S7wD3NKAHGlMguS+beipyNd1nNdCEuRQpCuJbk8n0LOgsCmJWC61xE/2cWNTtrTah99pT/zcOfzyr53gLk84Yvj446g3VEh1QEff+0i6BxJg8BsbJzykYESFVdacu0Z/K9jJxX2VyTHjWUCFCaR4lCyq5Dw/SGgjn7OnsP0tXnlheaE7DfgbJvXA5EYJmOI7SBD3wDlLV8nODNCWXaLONOL8O4gKa/IsuvnXBsRh+4UeSzgvsAUaYx8JXPZXPHwzYJSkbk4/dJdH1seKqHDnR2Sjgt6vqqu9YLhBp0aL2Psq7wmwR3XC/mVS+eBfR0zxtVVFPsdyBHW76rU+w1fs94EXZEHh9FFF069nBGlvEtDDWcdJziz9SKCNxYEvGtx7svb6K0BBMWWS5M1DZ7gnmE/goCcSA0eYfR+x+J97oWsvf/v9g+t+ckRVmg83SpoXfT5e1pwVCdR3NR++N72r+CYrNiwMqxk8FihTurhT+pOW3QjCD0e4gUQxYAcTRM1U3QrXi8IrF6H2g6+Z7QpCGTdr6RAUoE7GJTHS5S8jdYVfebvhqiFzvV0MlAl+y+NIXleva9RT0njwq2Rjs5ZOVRpGOVoNRRXfwdf4YDicNvppXixrkVHpBzlxR7UdArV7Dv6k1GrbixN1T4kafNmRmASWDTwJwWfrRM5kve1d6n8WJ927j0vO+55+dTRoeVQJpv804RZwdMoxAaK9jtZHsDD5YZYVwdQRTniYcNUF5kXEMxO+CO3bylVYj8b8dg4iDv/A5BQ2ThCxfw7IkumAb9NSvh2Ixgu1IE8HnEuIkxc902xd53ZO/n+FsG4wLoNRgcBKU94EhL9JGzbmRxubTDFL4sDIVnT654wDyxaF8WXLvKmgfvXPLGPD9yZgk5L pEhjBWoG tD+J6TEGaOHyUgBaSV7fG1X3nGyjalxOnhMARL4KQWFbiF6o3ammSrFBUj5mt3e0qHd6FtklDk/aZnOPZeZqOz/u5u5sNg/M33mShCv9UiqxjficBBsNcrElS6f8P7/xsF0lNE8iCgMT01U/RgZWH8pGqKeI5PdyI5JtIgUJeyccAFXRlOPaAzEzRcBpEDN5UIbyFGY/A0weEFd7VDx48MpaMpClatVyQuzam4SX5JYB562J6P7heMkm4Fr9gDHNf+1wTdAyNiVQmY1wQOnjytA9KCY7Vod3P87ZqdvQLu9WRhytj6TugDWKDVwNR9vo5EelA+7buTeIzEiTyt8Tj1kq7UCIjcDiF1UblM+gz/VPguEw7SKUdgYpLJQa/3iLDJGmVmIBj9hqrEXa1f/FytElGGEgWSB5xkZfGf6rPcC0stImRiQg4fcqSZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/28/23 09:57, Matthew Wilcox (Oracle) wrote: > For no apparent reason, we were open-coding alloc_pages_node() in > this function. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 35aa706dc318..342545775df6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2187,11 +2187,7 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > struct slab *slab; > unsigned int order = oo_order(oo); > > - if (node == NUMA_NO_NODE) > - folio = (struct folio *)alloc_pages(flags, order); > - else > - folio = (struct folio *)__alloc_pages_node(node, flags, order); > - > + folio = (struct folio *)alloc_pages_node(node, flags, order); > if (!folio) > return NULL; >