From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28904ECAAD8 for ; Tue, 20 Sep 2022 12:35:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A37C9940008; Tue, 20 Sep 2022 08:35:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E857940007; Tue, 20 Sep 2022 08:35:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AF8D940008; Tue, 20 Sep 2022 08:35:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7C717940007 for ; Tue, 20 Sep 2022 08:35:37 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 549A440CF9 for ; Tue, 20 Sep 2022 12:35:37 +0000 (UTC) X-FDA: 79932409914.02.493BADE Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf28.hostedemail.com (Postfix) with ESMTP id 3996BC000F for ; Tue, 20 Sep 2022 12:35:34 +0000 (UTC) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MX1B51QzRzlVsg; Tue, 20 Sep 2022 20:31:25 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 20:35:31 +0800 Subject: Re: [PATCH] mm/secretmem: remove reduntant return value To: David Hildenbrand , CC: , References: <20220920012205.246217-1-xiujianfeng@huawei.com> <3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com> From: xiujianfeng Message-ID: Date: Tue, 20 Sep 2022 20:35:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663677334; a=rsa-sha256; cv=none; b=w7HoPz2rw0av50psI876G0XYmVjSILuHtXbfdk2g4ibehEa5cHI2qaU8HI73p5n0RaiEfu YI1qpiNTFEwwy1YduD7/OoAmcDdnl0F2XNhsP8Za7jKtZltOV8vWfxOe+WIYiznwVb2XLH 9ouP/3eGd9IYY6W5QWrdPClmGmQZ5Mo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663677334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VUknUsDsmRwSramlHU9UIJD51nUMOQR7aajwIQHchP4=; b=y+oq+Ti4rl5h5lEeDezaGkCNjHQ9VCQSxH5TuwQAACQTIqqTy3g0RFJaqJ2eWDqW3sxY24 JQKcPk6XO5CfpAchGCpIs3tcHzLl5UHc576UoeY2ccBDBC2y2eSHbABL2g0nQhwgiC9CV0 v1e3n7XezamZoPJINHCFTkblexv7oMk= X-Stat-Signature: 9q3arqci9ykuw4r991ob75jgjbtd17h9 X-Rspamd-Queue-Id: 3996BC000F Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1663677334-413066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, 在 2022/9/20 20:10, David Hildenbrand 写道: > On 20.09.22 03:22, Xiu Jianfeng wrote: >> The return value @ret is always 0, so remove it and return 0 directly. >> >> Signed-off-by: Xiu Jianfeng >> --- >>   mm/secretmem.c | 6 ++---- >>   1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/mm/secretmem.c b/mm/secretmem.c >> index 6a44efb673b2..04c3ac9448a1 100644 >> --- a/mm/secretmem.c >> +++ b/mm/secretmem.c >> @@ -278,10 +278,8 @@ static struct file_system_type secretmem_fs = { >>   static int __init secretmem_init(void) >>   { >> -    int ret = 0; >> - >>       if (!secretmem_enable) >> -        return ret; >> +        return 0; >>       secretmem_mnt = kern_mount(&secretmem_fs); >>       if (IS_ERR(secretmem_mnt)) > > On top of which tree is that? > > 6.0-rc6 has here: > > if (IS_ERR(secretmem_mnt)) >     ret = PTR_ERR(secretmem_mnt); > Sorry, it's on linux-next tree, I should have used [PATCH -next]:)