From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F3C8D1AD48 for ; Wed, 16 Oct 2024 11:47:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AFD06B0083; Wed, 16 Oct 2024 07:47:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05EC86B0082; Wed, 16 Oct 2024 07:47:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8FBD6B0083; Wed, 16 Oct 2024 07:47:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C9D426B007B for ; Wed, 16 Oct 2024 07:47:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0926E80E0E for ; Wed, 16 Oct 2024 11:47:17 +0000 (UTC) X-FDA: 82679289924.02.860DA7F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id 1CDC9180014 for ; Wed, 16 Oct 2024 11:47:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729079126; a=rsa-sha256; cv=none; b=RKglk+vE3ofX/8+60qvlqpZQG7gP71QyEP/kf/DeCvrnOo08VY2zyRlcJysVLwaOwliCYT WHE5J4TANLAAzt5sBBTRWRTMf0cteZpjPfdIMjeHPoi1qBWcTwt44tQ8OJYe+gXPg0T8sz 6EUXwVpb73IVD2gMmfMA6nU0vHKoN50= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729079126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7qOkr2ZZNC+f4DYmi6YSxW8rCeBlgLEonmkuTQvgXWY=; b=QlCEWlFynolFpUbjAadL7kVAnsdidat6BDHh1/BH4Vxo1FWy24PZRaFKWgq0sqUGiMRTNp fXPOJ1QBU9j/FLPHmtXLdTqIYyFKRl62hmBUgrhUV8bsd747hViFc36Yae6fttbAuXplMR 6AHcAqBI2m6bKDvQqvo40EzYc6gDudM= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XT8L71qHTzyTK6; Wed, 16 Oct 2024 19:45:51 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 381F41401E0; Wed, 16 Oct 2024 19:47:15 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 16 Oct 2024 19:47:14 +0800 Message-ID: Date: Wed, 16 Oct 2024 19:47:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] Improve the tmpfs large folio read performance To: Baolin Wang , , CC: , , , References: Content-Language: en-US From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1CDC9180014 X-Stat-Signature: i3bz8x44tb1r1ipeqydxn5agy4j85e8o X-Rspam-User: X-HE-Tag: 1729079235-893903 X-HE-Meta: U2FsdGVkX19oYNiuquYnSVq9Wo+l8u4zrmU22VXy5nyNT8GXUXf6JETEIHfAF6BR+8ZtruCY9khl3WRIEmGdLRkrSrlFwbWcawfAXfSzE8klcLO3QKe70frhjnMDzeNWHUEDGtUepRCPSr9w4r8z7W/6bTAF3EMkYJFhkDq5OD/vsZZ13MO7QavZLqt2vK2KOMkMtDnt/lsM2sng1C2SCqPgaMJZG2iZWBMADPSZcWexb3CA8vwysqMDn2f5app/ftANuVfhF2P/j+gFL4jEI6I9v+NX4I6fi8A3e7BoPyWpzvAh0/+ENyVXDOXXUen77k2nQjnSY7zOaqJG7KmhxV94JtYnd+cURVqPdNeBwIxcmLyma9d7PhqAzScyHJokLtwpE1zdDm0LupknM0mCzsxs4iVxb+WHdFbUcqOE3OKHQGTm6NRWdr4r5SxjMg2XT04U/ObhLidzcXk7ANzwJctfT9nT4YF+zKTEqUHBxLPvjCEv68rzafRXblXqsNbC+WwFCQgZk79aH+rn7nYq0Np3qajOeAEMDDyZeiDwphDx6DCVR57UmAcYYR9N2n60eUcFiVoWEZZ4+TCznc463qeWhQnhFG51Ceiq/re8wqAZGxqCLJx0oIvS1O4StpPUEkybOI0ms0JnCkPqbp2otOo3VNTyb+SIV9vXlobu+uqMqlxu9Sb09PHhbIq7iAVQw1uuzeaPVlw1UVII6D9NAM6OP6qDclzWMN8W02XpkweOsYDcI3nPECtLXOYx2Tcfd4HzkWHt6EEUCE5oDJNtL30LyHdIKxnoyGHaO+IyH7MsXL0D4sryHOHTieDor8Kv0neVQIp/9fTn0WxQdO8uHOO38mRtn3P0lEZ5i/NPX96rxCRj3QlJYQeceB6VoCey4pmaRvDhC0IWlJUTO32Ksjbt4AsUcrxHa8Om9sBBrYKik+SCGiEUorsEHPlOl7GPBnN+S+1S3+hIkouQ7TJ QK3Kys5R CgU6+qcrjH/jg/Zp+ZuC0zQmGCGoMbYGcXpTMwAk2Oa6zp4weL4Ck4+ISTrMrKnpI0svs+6P0qix/V40WGL8ONoMD4UZnpb50xFBsylSs2UUI2bzv+IYISfz4kaKabTEi4NLUTiMl1OUNUlKcPbxZHMtbU5P/LkGtsgmxBn6rWWShJJeQdcuhoSO6f3FO/yaI+dBa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/16 18:09, Baolin Wang wrote: > The tmpfs has already supported the PMD-sized large folios, but the tmpfs > read operation still performs copying at the PAGE SIZE granularity, which > is not perfect. This patch changes to copy data at the folio granularity, > which can improve the read performance. > > Use 'fio bs=64k' to read a 1G tmpfs file populated with 2M THPs, and I can > see about 20% performance improvement, and no regression with bs=4k. I > also did some functional test with the xfstests suite, and I did not find > any regressions with the following xfstests config. > FSTYP=tmpfs > export TEST_DIR=/mnt/tempfs_mnt > export TEST_DEV=/mnt/tempfs_mnt > export SCRATCH_MNT=/mnt/scratchdir > export SCRATCH_DEV=/mnt/scratchdir > Oh，we make same changes, my bonnie test(./bonnie -d /tmp -s 1024) see similar improvement(19.2% with huge=always) with out inner changes :) > Baolin Wang (2): > mm: shmem: update iocb->ki_pos directly to simplify tmpfs read logic > mm: shmem: improve the tmpfs large folio read performance > > mm/shmem.c | 54 ++++++++++++++++++++++-------------------------------- > 1 file changed, 22 insertions(+), 32 deletions(-) >