From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAF3C4828F for ; Fri, 9 Feb 2024 11:17:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB0CC6B0083; Fri, 9 Feb 2024 06:17:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A38D16B0087; Fri, 9 Feb 2024 06:17:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B3EA6B0089; Fri, 9 Feb 2024 06:17:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 762D26B0083 for ; Fri, 9 Feb 2024 06:17:25 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 47EBE141000 for ; Fri, 9 Feb 2024 11:17:25 +0000 (UTC) X-FDA: 81772014450.27.5068E66 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf07.hostedemail.com (Postfix) with ESMTP id E6F664000D for ; Fri, 9 Feb 2024 11:17:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707477442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o3/Cx/pOo3nTGAbMN3DS5gVXvK4P/UmUtvJlc0j+tsU=; b=oAThQG2EfH47kJqgdweUBKpTf/um2s6SM9hlTGKpNTW6XtMS7gGHEDqQa9Sz7hcEXMB3BK iHjAHsRqHRIBQsFg96ynvH9Cm+dBSE9hypd+8OSXYYKe7ppRw+ZmgrZheJ8FhaneQtjK3G 6A8vBJb7Y97CV1MDrzaZiaGjdHV+G3M= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707477442; a=rsa-sha256; cv=none; b=Uu03E0J8lItC2N56uU6awhQDl2w1oE8/e0v/u/kIRPm44x8tFzc4nLs2T04vMyWJ9MVyzj +jCQIAtZYKqc1TW8vdbOB9+wnx+sIYZZ+O9syIkQKrC3NUCr6AgbAr7CNuz8fwwQvl8tSj ys65leS1l7DSy5PDq+Jgduz+gpuiZ7c= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TWWSk1S8pz6D92M; Fri, 9 Feb 2024 19:13:58 +0800 (CST) Received: from lhrpeml100006.china.huawei.com (unknown [7.191.160.224]) by mail.maildlp.com (Postfix) with ESMTPS id 8A631140A35; Fri, 9 Feb 2024 19:17:17 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (7.191.161.198) by lhrpeml100006.china.huawei.com (7.191.160.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 9 Feb 2024 11:17:02 +0000 Received: from lhrpeml500006.china.huawei.com ([7.191.161.198]) by lhrpeml500006.china.huawei.com ([7.191.161.198]) with mapi id 15.01.2507.035; Fri, 9 Feb 2024 11:17:01 +0000 From: Shiju Jose To: Davidlohr Bueso CC: "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , Jonathan Cameron , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "dan.j.williams@intel.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "tony.luck@intel.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "mike.malvestuto@intel.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , tanxiaofei , "Zengtao (B)" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [RFC PATCH v5 01/12] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command Thread-Topic: [RFC PATCH v5 01/12] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command Thread-Index: AQHaRJCaD0DwIp3NPkK9UMNuy7XDp7EBGDoAgADt89A= Date: Fri, 9 Feb 2024 11:17:01 +0000 Message-ID: References: <20240111131741.1356-1-shiju.jose@huawei.com> <20240111131741.1356-2-shiju.jose@huawei.com> <2k3fvg2xlp7ie47cy7finxchmb6sinkut2mp23wfvv73ik3erw@wohmod7labx5> In-Reply-To: <2k3fvg2xlp7ie47cy7finxchmb6sinkut2mp23wfvv73ik3erw@wohmod7labx5> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.195.245.51] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Queue-Id: E6F664000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: hqxieosymucr9r99wp8ccx5znib513bc X-HE-Tag: 1707477441-857081 X-HE-Meta: U2FsdGVkX1+1E2mqmLd1pjgH2/7vBeBCU8OoZS1jrKnL1tEKSegR3ms5AkwAnVXv1082d9GcKumgJcZqyQMXKeN+Vx/oNCTu/KjAsmpvKwS/VS8VnmQyXotElOGEgcNU8pux8Ocruz94N6kcidl9w6AjdvDVcnFwHX9M1zymPe1chLZoiZqQ5Uqd2HaQBGSo4CLKkAWzFLwE/yo/k9UGXuySH1jgLDmxCnv0QiZc/Fc2QMY0zpc7Gr0Pifs+9EuInjtQo2VLVXTBbfkZB8G/g/qklcAAZP8PKFY/iVwWFNaDoo2n2FeUZpnQqsAYdM7yTTeJqfAN3wO1GOdhAji2jt5o77Lt2R49dXRqDVfUWMZEgPNc+cl5+zUKkrgStC2OxSAFKiBseuGiAT4qQ2AU5bivv6JPA33b4Idn9aUG4T/POyQRnBAX962ZcKMM0fALqrutdRJXqc5jMisBsnU+Ao6NXMlUzr3GrZsR/T9E+9w/gV140s9WKkfYlzSyzX/Cp8smvN7ZZynPdUYQEWH57Gh4s0BnqSWun8mGtcm9uDAhMZLBgvPzfp51SSMJ4srqTrJ++HHexHeCknnK22/WCRLWWGh7joRFlpRk0jIckTjp5AICHYZEw1a9Zf8IExNxtNHjV/yeMOg7Zm53WrB6jNhlPSt9VOfbZ0GrHfJlMLsIYljiDBe3z5apzIoE4B3gkttp5GPy7uCXmTTNDOa9fvChUybvg/94lmsjTYLT2xt420iMjT3d+DGTf0teTPq4Fn7quDOb4KcX8rK5B8Sj1Rm+GQdGBLO9tqBlwXm5PY+Bzjj8avToKmg/HMfGyEaOt63ozPQltyZYPuySuTxwijMpJU5yngFHN08vm4s9Q1VU4XP6AcggBvyjZUBePEEvEcDOItjsCp3oxkGzHMHxh6kGb0Wl/IKfZf62rhUzD5/RO7+kuBljG6ViZpedWzD+NIy7eZvH5B/HBbgqGVb Mx7TT6ll glqTr7hVG/0CjlDRxV/ewMC03GbecdLaALhoWaQU7Di1Y38JcG/ta0jbrdzEQxZY+5uNxifNbXtvHeTrJnbPIl28ucM6b1+WdGcK66SZcgpT6DLO03r9WiqeRKq0/HFZlfNwNpeLB3r6yXo5K/Xf6c0voCotu1d9wECCvR1GHFQEAhp0AFSzbnFQ+k+ylRWwxbx+JDdBgmOFpHEvzLYVEAMQyON8j9q52Z7I0fr/HarAwoaduUOhhAVU9JUbJOkvQvZtrOR0etuHB2phuUnCj6RNPo34iM7ktLkQsLOsJzFi7aVBpE2ibaJy4WqLblgge09JBpEmR2On2Ry8wTLyBsczjCbHVIBXfjNnLEB5+7dt3JDIhbFihikJbzriOrfbGnHQ6toC1sdDnMQEPi2BMG9nNtYPlGu0SSFzvwOBnGq6jE8Us2OZmXFn/sNQpN3bB0189AFDDDPeuwosuCX6Cv5pRF48cRZMGeuJNNtmYWVjuG6uh/jtlN+C+PN97MO0WQywfm+AFvHB+CrTHYLaHp+xTRbu3DA1aHoAA0n5maCI3JRKkfpbEwFFsn7wDKhCzWPpJhq/RLT0Tod0BOGZOemKYUaNQUTVFoB1cqZY2mGYTtgTG+fy5V5kCtTaTfmza+1XEQGIiXvO1PhkIy667ORq4N/KaIhTMuEMM2OUCUhoa7xCCfwaYLZR6e+V7IRXZKpX/tnAWu0ojSUJa5wDVYZyMBR8nF78E5l0Gt28wxmqKCxEsKTxY+P9/WbCdVA03ZHdUPJw1NlrYguMdTwozojqxaj/Wo34BOiHOeaqOjZfzd1tfVLGmymXjB9BaIPetdrXzLaodMb2LXgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Davidlohr, Thanks for the feedbacks. >-----Original Message----- >From: Davidlohr Bueso >Sent: 08 February 2024 20:52 >To: Shiju Jose >Cc: linux-cxl@vger.kernel.org; linux-acpi@vger.kernel.org; linux- >mm@kvack.org; Jonathan Cameron ; >dave.jiang@intel.com; alison.schofield@intel.com; vishal.l.verma@intel.com= ; >ira.weiny@intel.com; dan.j.williams@intel.com; linux-edac@vger.kernel.org; >linux-kernel@vger.kernel.org; david@redhat.com; Vilas.Sridharan@amd.com; >leo.duran@amd.com; Yazen.Ghannam@amd.com; rientjes@google.com; >jiaqiyan@google.com; tony.luck@intel.com; Jon.Grimm@amd.com; >dave.hansen@linux.intel.com; rafael@kernel.org; lenb@kernel.org; >naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com; >somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; >duenwen@google.com; mike.malvestuto@intel.com; gthelen@google.com; >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; >tanxiaofei ; Zengtao (B) = ; >kangkang.shen@futurewei.com; wanghuiqiang ; >Linuxarm >Subject: Re: [RFC PATCH v5 01/12] cxl/mbox: Add GET_SUPPORTED_FEATURES >mailbox command > >On Thu, 11 Jan 2024, shiju.jose@huawei.com wrote: > >>From: Shiju Jose >> >>Add support for GET_SUPPORTED_FEATURES mailbox command. >> >>CXL spec 3.0 section 8.2.9.6 describes optional device specific features. > >For the whole series, might as well make it 3.1 based. Are you aware of an= y >major differences (I have not checked) between versions in either this or = any of >the two users that use feats? Sure, I will make 3.1 based.=20 I checked, no differences found in feature commands b/w versions 3.0 and 3= .1 other than new users of the features commands are present in v3.1 such as memory spari= ng features and Advanced Programmable Corrected Volatile Memory Error Thres= hold Feature Discovery and Configuration. > >>CXL devices supports features with changeable attributes. >>Get Supported Features retrieves the list of supported device specific >>features. The settings of a feature can be retrieved using Get Feature >>and optionally modified using Set Feature. >> >>Signed-off-by: Shiju Jose >>--- >> drivers/cxl/core/mbox.c | 23 ++++++++++++++++ >> drivers/cxl/cxlmem.h | 59 +++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 82 insertions(+) >> >>diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index >>36270dcfb42e..6960ce935e73 100644 >>--- a/drivers/cxl/core/mbox.c >>+++ b/drivers/cxl/core/mbox.c >>@@ -1303,6 +1303,29 @@ int cxl_set_timestamp(struct cxl_memdev_state >>*mds) } EXPORT_SYMBOL_NS_GPL(cxl_set_timestamp, CXL); >> >>+int cxl_get_supported_features(struct cxl_memdev_state *mds, >>+ struct >cxl_mbox_get_supp_feats_in *pi, >>+ void *feats_out) >>+{ >>+ struct cxl_mbox_cmd mbox_cmd; >>+ int rc; >>+ >>+ mbox_cmd =3D (struct cxl_mbox_cmd) { >>+ .opcode =3D CXL_MBOX_OP_GET_SUPPORTED_FEATURES, >>+ .size_in =3D sizeof(*pi), >>+ .payload_in =3D pi, >>+ .size_out =3D le32_to_cpu(pi->count), >>+ .payload_out =3D feats_out, >>+ .min_out =3D sizeof(struct cxl_mbox_get_supp_feats_out), >>+ }; >>+ rc =3D cxl_internal_send_cmd(mds, &mbox_cmd); >>+ if (rc < 0) >>+ return rc; >>+ >>+ return 0; >>+} >>+EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); >>+ >> int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, >> struct cxl_region *cxlr) >> { >>diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index >>a2fcbca253f3..d831dad748f5 100644 >>--- a/drivers/cxl/cxlmem.h >>+++ b/drivers/cxl/cxlmem.h >>@@ -506,6 +506,7 @@ enum cxl_opcode { >> CXL_MBOX_OP_SET_TIMESTAMP =3D 0x0301, >> CXL_MBOX_OP_GET_SUPPORTED_LOGS =3D 0x0400, >> CXL_MBOX_OP_GET_LOG =3D 0x0401, >>+ CXL_MBOX_OP_GET_SUPPORTED_FEATURES =3D 0x0500, >> CXL_MBOX_OP_IDENTIFY =3D 0x4000, >> CXL_MBOX_OP_GET_PARTITION_INFO =3D 0x4100, >> CXL_MBOX_OP_SET_PARTITION_INFO =3D 0x4101, >>@@ -740,6 +741,61 @@ struct cxl_mbox_set_timestamp_in { >> >> } __packed; >> >>+/* Get Supported Features CXL 3.0 Spec 8.2.9.6.1 */ >>+/* >>+ * Get Supported Features input payload >>+ * CXL rev 3.0 section 8.2.9.6.1; Table 8-75 */ struct >>+cxl_mbox_get_supp_feats_in { >>+ __le32 count; >>+ __le16 start_index; >>+ u16 reserved; >>+} __packed; >>+ >>+/* >>+ * Get Supported Features Supported Feature Entry >>+ * CXL rev 3.0 section 8.2.9.6.1; Table 8-77 */ >>+/* Supported Feature Entry : Payload out attribute flags */ >>+#define CXL_FEAT_ENTRY_FLAG_CHANGABLE BIT(0) >>+#define CXL_FEAT_ENTRY_FLAG_DEEPEST_RESET_PERSISTENCE_MASK > GENMASK(3, 1) >>+ >>+enum cxl_feat_attrib_value_persistence { >>+ CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_NONE =3D 0x0, >>+ CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_CXL_RESET =3D 0x1, >>+ CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_HOT_RESET =3D 0x2, >>+ CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_WARM_RESET =3D 0x3, >>+ CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_COLD_RESET =3D 0x4, > >Just leave the enums without explicit values - you are not changing the de= fault >counting. Sure. > >>+ CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_MAX >>+}; >>+ >>+#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_ACROSS_FW_UPDATE_MASK > BIT(4) >>+#define >CXL_FEAT_ENTRY_FLAG_PERSISTENCE_DEFAULT_SEL_SUPPORT_MASK BIT(5) >>+#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_SAVED_SEL_SUPPORT_MASK > BIT(6) >>+ >>+struct cxl_mbox_supp_feat_entry { >>+ uuid_t uuid; >>+ __le16 feat_index; >>+ __le16 get_feat_size; >>+ __le16 set_feat_size; >>+ __le32 attrb_flags; > >Nit but rename to 'attr', it is more along the kernel coding style (just c= ompare a >git grep of attrb vs attr). Also applies to the whole series. Sure. I will modify. > >Thanks, >Davidlohr > >>+ u8 get_feat_version; >>+ u8 set_feat_version; >>+ __le16 set_feat_effects; >>+ u8 rsvd[18]; >>+} __packed; >>+ >>+/* >>+ * Get Supported Features output payload >>+ * CXL rev 3.0 section 8.2.9.6.1; Table 8-76 */ struct >>+cxl_mbox_get_supp_feats_out { >>+ __le16 entries; >>+ __le16 nsuppfeats_dev; >>+ u32 reserved; >>+ struct cxl_mbox_supp_feat_entry feat_entries[]; } __packed; >>+ >> /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct >>cxl_mbox_poison_in { >> __le64 offset; >>@@ -867,6 +923,9 @@ void clear_exclusive_cxl_commands(struct >cxl_memdev_state *mds, >> unsigned long *cmds); >> void cxl_mem_get_event_records(struct cxl_memdev_state *mds, u32 >>status); int cxl_set_timestamp(struct cxl_memdev_state *mds); >>+int cxl_get_supported_features(struct cxl_memdev_state *mds, >>+ struct cxl_mbox_get_supp_feats_in *pi, >>+ void *feats_out); >> int cxl_poison_state_init(struct cxl_memdev_state *mds); int >>cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, >> struct cxl_region *cxlr); >>-- >>2.34.1 >> Thank, Shiju