From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B16C021A9 for ; Mon, 17 Feb 2025 14:59:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF32028006C; Mon, 17 Feb 2025 09:59:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA30728006A; Mon, 17 Feb 2025 09:59:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D8928006C; Mon, 17 Feb 2025 09:59:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 84E4628006A for ; Mon, 17 Feb 2025 09:59:09 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3CBE1A08F0 for ; Mon, 17 Feb 2025 14:59:09 +0000 (UTC) X-FDA: 83129744418.20.436D6A2 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf14.hostedemail.com (Postfix) with ESMTP id 2D42B100004 for ; Mon, 17 Feb 2025 14:59:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fAFpjKqu; spf=pass (imf14.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739804347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V3nen2ZQWjVU3j6z5FoLCBIj9fu+yhn4VYwilHW5oo4=; b=S8bp7wxC6d1OnFTFHMwhhUVYdV6q21I/NBU0kLveokfyM7SEsSAO9fftk5T+UgTpYM6Wjs zq8sU+DjDWml81wsDk8Q1v6HlBPtMeayaZOJviGL8cVzbCDGSDOgM/3yv0N1uRBg+xqc9H K6plS6hjBCSNs3orG8be4N1Z5Z2UuGY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fAFpjKqu; spf=pass (imf14.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739804347; a=rsa-sha256; cv=none; b=UO1bncc/XjtuKECEJO8B/i7osLA1sKawHvtM6YMmQK/tTQ3QXZbdjF7X/1tfLOCVr0NxgZ tBMU5LsFEsEFZ9F1vNTN7jFd6AOxe+QzNuWuKamgbmOZdydhkuhPBmaW7F9ATH9PjUWX9j 0IzVCsW5qo5dEotf8cCmjU/ERwcuT4g= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5e0452f859cso2374481a12.2 for ; Mon, 17 Feb 2025 06:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739804345; x=1740409145; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V3nen2ZQWjVU3j6z5FoLCBIj9fu+yhn4VYwilHW5oo4=; b=fAFpjKquftYotdBgYqmz/MF8dDeLCz1d70AIiTkUNl+v6mPRI7uoLLy1seZZuGu4Az jtPHJZMPsdWZoTerP4KGCn4xZUjJix7XljBxh4YYCNEsnNooDYpJIv8gSIkmVCicOga0 xOIUohx+4LEGJx9UA4lRoFUrtnB8JTuLYb1OEZsDIWvowDuoVTOY6EO9TVCuwMIFKvFZ AtahtqES4DU9VVV/7p2tGwH9uLnWxx+DRnKkXXO0l6L83LpxPyVNwqMLMy+yA6jvr4aa sPGWnelJoIHZWK4DrthkfsmptpwFFq5B1874JlKAwDX2+0KWqrNtqMXNyxOYI2kocH0i eFCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739804345; x=1740409145; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V3nen2ZQWjVU3j6z5FoLCBIj9fu+yhn4VYwilHW5oo4=; b=jeVcon080eS6pICNJBMadwlQkCjk2ujCB1+9quMqF0+faO0qUFqTN+NY4EVcwsigeo kTV1yCL1od74Arzj7UQrQ0d+GQkAtbs+2Ke+Rt5lAAPBP0MammAqdN2E+XcYmPnmWjaz kp+vdRYRPSLud3VSwm5nG2zQ4TvaKD5VHFO4V/1r9YxjQsfo9l8uxBRTb6H3s17IXdA/ /VlhNKQ6iGOQ2nBdoPpTnmJW6AG4cl1ANv3PQzovxNYZYANcWqmqB4+6mnpz51aptzwG qmKzer4B8E4yQ3eyH7h4T3e+wkTKzs7gcgl+wpkbSCaJ4AX/sZNNMO+3REZYKG0Tdg9n 1pwQ== X-Forwarded-Encrypted: i=1; AJvYcCUVKKEq56a3id/c78GAn28alP5jemKfzzGIk14eGlB+kZwcM6uoN40gdRLP/cxpjK1JykKUfh8DRg==@kvack.org X-Gm-Message-State: AOJu0Ywexv/in0jNSAnxQdAb7YhafCJjiXUF/aPEDsC7eV7ZzDJLuiXr z7DOwEbqhq7ga7e+ifWiR+cOaBawVNd94WEKFP1Lq0n4tEnkm4Ss X-Gm-Gg: ASbGncsw9g5zvo+ycEu/R5kt6uzZZ/BOwoXZJbEW19lW340KdxiHyxuKOIggHlHl9L2 bXP7o9uTKZUk1cB8192sKUmODyWKU6vw2phTUyY92kF6faszfrnt9nKpEEQKryeCRkQEo1aSrjr W2oonbqERiu75zD1BhYEXKawZXMape8l/fmxSlxpHGd5gjBeTw7zBP3KbZHcbSkUVD+o5Iw9LJv RAO1hVs8L7g8bYlbtZc4PDMkh9v2SMXJGf57z0zMI1PE+wFFLPf04S0T8togdZ/hQJslVhoMaTB I3SWGcxDO29sfmjZIo7iZ3Azc/5ByawnFBMPU0RLpKlssTxD5ozI4lCaYdObVw== X-Google-Smtp-Source: AGHT+IHnTe7KbjcGi7WwFaMqNdoMpfbMfKQ+td8TFe4oH2WZRF5Wq21aBNuVyz43A+JwkZE5XJcgAQ== X-Received: by 2002:a05:6402:2114:b0:5de:bdbd:6f19 with SMTP id 4fb4d7f45d1cf-5e036171605mr9768671a12.27.1739804344242; Mon, 17 Feb 2025 06:59:04 -0800 (PST) Received: from ?IPV6:2a03:83e0:1126:4:fb:39c9:9a24:d181? ([2620:10d:c092:500::7:6466]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e05168c467sm2448555a12.48.2025.02.17.06.59.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 06:59:03 -0800 (PST) Message-ID: Date: Mon, 17 Feb 2025 14:59:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 1/5] mm: defer THP insertion to khugepaged To: Nico Pache , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, willy@infradead.org, kirill.shutemov@linux.intel.com, david@redhat.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, sunnanyong@huawei.com, audra@redhat.com, akpm@linux-foundation.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, tiwai@suse.de, baolin.wang@linux.alibaba.com, corbet@lwn.net, shuah@kernel.org References: <20250211004054.222931-1-npache@redhat.com> <20250211004054.222931-2-npache@redhat.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20250211004054.222931-2-npache@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 2D42B100004 X-Stat-Signature: 6g77wdk18dsjjcgoctmh37hg5iwmdcxg X-Rspamd-Server: rspam03 X-HE-Tag: 1739804346-627073 X-HE-Meta: U2FsdGVkX1/fBHHrUyECxPkOVZSLamJHTRkh/eYBkSmBa6JN7j5gTijBAA6fIgmhN8nq6iwTfBCvMFhgI5SNPZpEYic54iZjYJqfo/EFOW3s5Kq8wZ62Fvzt/NUtcMr5123DygwlwrELD94HaQhzYfQcEKODTnn6QybeA7totOZefkET+swCpaqDbRw0/jWaXYkdtGkBu4HI9q9/Wgrc5A7ne5n1VJ4B2b25SEPjyaapxDwWJllQwi+bIEE5Pl4bGav4rmN+0Ft1oTbPvbCssUrFQq3H9ivW5//ORjHuMPFqCt87IDMYs5wTk7OCo6fjewdJLFKnVA1iMCQjcOGzNCbO3C9ACQmSa5nsg/AuEhpcxE/RvEOqxUlEG0lYpG6EAEaA72ezUTGAZ9YwACACI2BqmeoREakE/nFF6p3Dx69QBbctqt+CkuO/+5zs2ACErAzGZ7IJ7+L+RJC47A0RDRZ/7ZnZFyTDIbAW97tqrZWW5mKNRBRXxpqTcD4SbiwtX+7nIYziddiDQqHg7SpkswDlTqCi8mY4riXrZW29fvoC6txU72u5ZrcRicC8N9VDqvGXpNb5xOHH7xtygeMtvGQ+o+gMlGTevGgyCHxH5KiRjBAzSounW4wF1URjHSYtA4tumHfm/JaoVbO8ZWtERwntOq0LzKEmdQqpoLu73hFBSG0yfMUynsZkIdSLfe/0YQXZml+igWt/Kdk9lF+cSIDuh77q/OFrQaN2yfztIg9dl6iHo2ZoAeLhoRO/ryiRdvn1XwsDbfsk1+rp1TrlnVn0/gQymW7d1+wLYImeRCY5KdFVdJi3sJ3sTPhynGHuPVEHx4A+jaVExLaqumPD7J4GJMUH1ryBvaZ2y5LVM+8+TLLWdVoigPZ3zHx5zzY1CPaM7ZKfTu9qrVWvwKakC/BqQN1QgmRyKoeNmaQcTonNrbLMoG3r3y9Zv2lJ0KqOBQWTLTySGR6crqyDjGF bvSLZ6vK iRTH1Dm79VAA0jWeZK/d8OHAYO1LuY7MkhuDr/J1ISO/V+NaqZwYrhp5mzvVa815OJ7B4iAYVndVoRnN5o0RnFwpkTF33z6da8JzkZmGes+murqnlE2S7czraH2kqrIDjI53vSrlNI0Mc95wExTgovLKkJodKTz8gGx9HvCk0LWAbgGKrc6xEPUNf5Cf7vIrf9rQgrI6RQ7zYjXjdTxzjx2hYByJWYizNre/E0NAoDVb+CvrX5rHqMtNJwYWEskJ9K6uSdJP13sJkyJKGt7r/rYDuc3OGwoQHjGaJveu4VVM6Jrlsp4clK5zAalOYnc72h3S5AF6mjCgWXkJ/GcxYsc7DT1n+50c/Hs5NvOnvoOCQnmxL0ItI4enzw869sKnvlbL7pgVq3eQzoMdHk71c6SkAMTaOYW82KMZ+i1EnJLDzj8q5md9hCdHtTS3CPvZeFc7K4VUwSpe6BwZFLKwGQArapBuMD3gB2K9BnHbfPvMEnE12DzbP89p1RGPjqlGHFEuMNhtuUGvSOyNILSGm7bP72hy57mE4GQ5XMIGIpqhxiDd4hvBzy/Ch89EUr2XBYePl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/02/2025 00:40, Nico Pache wrote: > setting /transparent_hugepages/enabled=always allows applications > to benefit from THPs without having to madvise. However, the pf handler > takes very few considerations to decide weather or not to actually use a > THP. This can lead to a lot of wasted memory. khugepaged only operates > on memory that was either allocated with enabled=always or MADV_HUGEPAGE. > > Introduce the ability to set enabled=defer, which will prevent THPs from > being allocated by the page fault handler unless madvise is set, > leaving it up to khugepaged to decide which allocations will collapse to a > THP. This should allow applications to benefits from THPs, while curbing > some of the memory waste. > > Signed-off-by: Nico Pache > --- > include/linux/huge_mm.h | 15 +++++++++++++-- > mm/huge_memory.c | 31 +++++++++++++++++++++++++++---- > 2 files changed, 40 insertions(+), 6 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 93e509b6c00e..fb381ca720ea 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -44,6 +44,7 @@ enum transparent_hugepage_flag { > TRANSPARENT_HUGEPAGE_UNSUPPORTED, > TRANSPARENT_HUGEPAGE_FLAG, > TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, > + TRANSPARENT_HUGEPAGE_DEFER_PF_INST_FLAG, No strong preference, but maybe just TRANSPARENT_HUGEPAGE_DEFER_FLAG might be better?