From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74138D778AE for ; Fri, 23 Jan 2026 20:05:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8710F6B054B; Fri, 23 Jan 2026 15:05:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81F936B054C; Fri, 23 Jan 2026 15:05:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 682136B054D; Fri, 23 Jan 2026 15:05:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 557AF6B054B for ; Fri, 23 Jan 2026 15:05:08 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C591D59C91 for ; Fri, 23 Jan 2026 20:05:07 +0000 (UTC) X-FDA: 84364307454.28.1D9BDBB Received: from relay.hostedemail.com (unirelay09 [10.200.18.72]) by imf06.hostedemail.com (Postfix) with ESMTP id 4945E180010 for ; Fri, 23 Jan 2026 20:05:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=2") ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1769198704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aFNZOBetYuHjbH5MvMJiA4O3p22mTWdGiiaxKoye1JQ=; b=jZpZUJaa/ppcD6Dljl8JzymN3Du/jkL27yPSJ9AmvrsOck0tbmlT/FtJQK7nBfrkWOSdxf irhkpBMFHpg7UKZdgjYv++1bv4r7/Kl/hl4tetx+lWh7OgV9hMRtlGgj9xVu6j8bMmUk7C JRWSHqFZvK3QUh2LyH0uYQCW0DZf4G8= ARC-Authentication-Results: i=3; imf06.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=2") ARC-Seal: i=3; s=arc-20220608; d=hostedemail.com; t=1769198704; a=rsa-sha256; cv=pass; b=iIyUxjKvyC5YWFoR9p8CngwNmlc6phA10Yn3v1pJ1HUGsboV+qbV6oUPdxni+LpN8Qpxkh f+zZwSUydX2WwlffO0UX1I+iB7V0eYC+EogI6MMVW7O1BRRPPC7T/cYJVHlingSx1UgqGw Bt/EK5R66/xsnjiruTWFzybBSQPkNwQ= Received: from relay.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C21AB8C143 for ; Fri, 23 Jan 2026 20:05:03 +0000 (UTC) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8C49713B51E for ; Fri, 23 Jan 2026 20:05:03 +0000 (UTC) X-FDA: 84364307286.07.86A062F Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf07.hostedemail.com (Postfix) with ESMTP id 138F24000C for ; Fri, 23 Jan 2026 20:04:59 +0000 (UTC) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1769198700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aFNZOBetYuHjbH5MvMJiA4O3p22mTWdGiiaxKoye1JQ=; b=ZEiPUQZj7HpVGiVFKORokC3caCL28zb01QVHIYlo6rct3cQ+JahNhaOuhr88izNWhCd9+e ncNwfRxRKLjI6sM4f+s5KXnMCO/pJF8EmhfhlTH1C6oC+gyAx3kB2BhZciImpH2L31rz43 haKH4PbiHqEFNhN1yf0G6ci55ApVlZ4= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=Uz+h9x1C; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=BSN1AIdx; spf=pass (imf07.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1769198700; a=rsa-sha256; cv=pass; b=2d5UmPdt4IhG/8Yb2jkAdKcw6ek1bACUt90HlAmqWKKVZDZn0czJjWbDX7fbnhG5RYQmmM dMe8FEm9d1QJjAJLpjNphDJgNN1JN9duFPFqzPWDuIp+YMhClgT5bi4D45PHgJ+6TG+oEo VSMUMF3ZaY7N+z0b3SA0CtOtZfXKRnc= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60NAU8sR1631858; Fri, 23 Jan 2026 20:04:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=aFNZOBetYuHjbH5MvM JiA4O3p22mTWdGiiaxKoye1JQ=; b=Uz+h9x1C5EIN+skOTD4j0xdckRDlTJiGw3 2sE7gbrLpklRKdFHzAm0I25OeAd4xjUlqGM+rT79RmJ0GnG0NyeMkRAFFF2To2Ak lp1COI7VY+e+1p3PuDIpc+pYs63nDJ/ipvwIU7Nke7H9ZfOLFE2Do9sRhkSM/vtA dz9ER86Mtfs8osPHl6GWUR53yh5xkWJocp/FPyUHPxxUKAfK7eyMgT6+6JRpWWCj fFlUCRtsbPIdlxQutt8SFCaMMZn6cwj8QNbiLAl1kNK52Iyn2uF3QDTic5izLUoC lv1+7FPvjr3tPv7FqRQTheIZL9ZW5RLhjwBCE547i+CCe5pxbnlQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4br2yq2yc1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jan 2026 20:04:48 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 60NIZroV013542; Fri, 23 Jan 2026 20:04:47 GMT Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11010031.outbound.protection.outlook.com [52.101.46.31]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4butv0vx6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jan 2026 20:04:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FV6G0SEokmH7MMykR3wf9RUYZiozD3uAog1qfHxLES+0hpezHX+5nLhi4Gpc7e7PHN+PT1v80AUzp1cRjnPcXqqqczIaY1IiRMYoN2Kpy6RDd6HUK7Pdra8b9rdR0uXN5bZF03bNTpkJ1dylfdcp+5kH5MzWjN3K9LCJXp5XxYN+yZc9DXR8f6SM2+pTC6BO464CA1MFBTXF3KKLGiXcb7nN3c6i8iUrv5eMrCqcU6UHXLYZxf0IPWe1HVNOR74gsF7+CSRu447DXzqPlPypAYQEHsKJtJZRK+cX0Z5UWZkFgKOR+HsrcV2z1ptf6lqlBPHIll3+eAUG5GuFy8sgew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aFNZOBetYuHjbH5MvMJiA4O3p22mTWdGiiaxKoye1JQ=; b=AB+KE6rQDrJIIPyWPNEfD9fKpFF9UDMtdXHXm1Kq+wiDX7AoZqoMvWr7AvDurVKMsRiRzSP3bsO20Pq6Ew7mOQAjzmGMzoF6zjqtbeGwJhp6l2GGdxLt7tYAKFlKEZWuQ+TN590lXdlIjSJTql8J0SZCFxF0uQkkM8MuVZaMMIbM47OVXZW0SKBomHBxTuoUO4LOnKGpYINdNxfEURFUNnkcRfTQFdOtu93VzJlwK0OT+mJKLADf8ZP15EFN+DM87PHptLI5nx0SNUe/FBvFk6xQoWRzLGS8f66+f1Dp93DCF+MvpRFeF+QGsT+KVSBtflhGRIJCXnw7Y15V0X5lEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aFNZOBetYuHjbH5MvMJiA4O3p22mTWdGiiaxKoye1JQ=; b=BSN1AIdxjCpDWGlx8lZE18zMxV3Wg476wKJHQsAWxlfXw+eUewqcnV5H2SwEGXoLHckwVhybBi3vvMKBDeKci0y9EW7Gkh+6LIbeLCzG90lH7eQarYtH9bivaydbiPu4viVhA5t9uBO6nFlKPdgRBKbOBc5BG2vxBq45bmWifE4= Received: from BL4PR10MB8229.namprd10.prod.outlook.com (2603:10b6:208:4e6::14) by DM3PPF0275307EB.namprd10.prod.outlook.com (2603:10b6:f:fc00::c06) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.10; Fri, 23 Jan 2026 20:04:44 +0000 Received: from BL4PR10MB8229.namprd10.prod.outlook.com ([fe80::552b:16d2:af:c582]) by BL4PR10MB8229.namprd10.prod.outlook.com ([fe80::552b:16d2:af:c582%6]) with mapi id 15.20.9520.005; Fri, 23 Jan 2026 20:04:44 +0000 Date: Fri, 23 Jan 2026 20:04:47 +0000 From: Lorenzo Stoakes To: Suren Baghdasaryan Cc: Andrew Morton , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Michal Hocko , Shakeel Butt , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Subject: Re: [PATCH RESEND v3 07/10] mm/vma: introduce helper struct + thread through exclusive lock fns Message-ID: References: <4f95671feac6b6d4cea3c53426c875f3fd8a8855.1769086312.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0103.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::19) To BL4PR10MB8229.namprd10.prod.outlook.com (2603:10b6:208:4e6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL4PR10MB8229:EE_|DM3PPF0275307EB:EE_ X-MS-Office365-Filtering-Correlation-Id: 036cbb8c-29b7-4b64-53eb-08de5abaa6fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Jw8UaCrVfvhFnOy0q8EgRpx39R/E19wpNU1z/4d0l18FkndtcUTC/WmhX6V6?= =?us-ascii?Q?7xHnSUbt86GRZbM+1po5oKO5eDQT1iGbPmL+zTHTzEDKICaClRtttSBzZJB1?= =?us-ascii?Q?h5eGha6kcRAWOTLE3i1m+Kw2ax5ou6nSU0UytToaG0GhlfseMCNQXpJO3w/Z?= =?us-ascii?Q?ImCBkKnZ4gaw8NoqCgHPljquHiYvCdOv606IeKWlEx6evWbE9EHqe89NME/S?= =?us-ascii?Q?qstXzKQkYK+ZhAYPaJfJAwtxKEzJjtCvBhdhbRspzUkaw8k3N2R7TkkGSyhd?= =?us-ascii?Q?p/y9pAIletR5V0Ye9bYcYJuPIF0jXcA4GG5GbylBL1TWJtWQygYdPQFodbpF?= =?us-ascii?Q?N58kGdcSUQvoV+GDBfHJBWMeBMLglmpPw36+9/TZB2KeCi+Jx1e/H3tWMXic?= =?us-ascii?Q?IhgEi5gPgknAmMgXdqy+mtnxzQLNrGoE/w00BJ47oHfAecKBKW5fWkhDLQET?= =?us-ascii?Q?r/0sPpa++sp5mpus+eFdL4qpnYTXU2qZTkmshnkEjW+/N9mE50Fu1Oc6xmVf?= =?us-ascii?Q?0gxF7k3PDPgHgaQx4SrlzstIvjSJhd8mj+ea89zymIwqXjaZBWo/Ng2/Bxss?= =?us-ascii?Q?28zbxVvlYbFURnIXQHhzHxM/gm2dwkxbzhfu7LfH/CO4EgiFeKKadjpEG8M7?= =?us-ascii?Q?0/sXu6Lab9WLMWxa7FncS4C/LwJyzr6WrUGBQWlDjNM3slshUNjbNf1+vi9t?= =?us-ascii?Q?Ay+t4tGnxklD3cHLpstUzHmDxSTNlaEDHwirMpILRYL861J1rymXSdde6kjR?= =?us-ascii?Q?Syw6onjQ51a3owDyXJOfkB4Qk52ySJUASXrQ1MwRhinV7m2W17ZF9apZrpbD?= =?us-ascii?Q?iGfb9WIyiW2Qf65LctglcumejRgUsjI45tSpCFZ+//zSPuoBFtqqQq6J85cP?= =?us-ascii?Q?hxN33YUoXt5X/Oaf4qDJ1rOffQPiA8efYytpmI5vX4i3bDfSXtdLIRe0R9Xt?= =?us-ascii?Q?A2nQs9SOhLRx0RSJ7RN3B1Dwto74D6CIkz6sPkrjXFaj39u4D1LeKX3MF3sj?= =?us-ascii?Q?Z4HDh+m7LoX1kwQ2h9fGHMFMqx1m9HJfDYEJ0oTHvPpehIVofPeZzjhAC3Bk?= =?us-ascii?Q?9o60yxWPLsa43az1REfyEqUxI2/TnCac2MQDXhzeVBjE3gVdoWLRCmECrU6X?= =?us-ascii?Q?cjomDR1Rjlx1sdfsGBs+BjoVPQtGWhsLjkuCHwTMonQhFTXFs1GCFxUA6dkV?= =?us-ascii?Q?IbM4LXYTP73HYCX1gHZtiH5eVQyZpoL7B9jfPYjTvGda05EiILg/2S/tCNvz?= =?us-ascii?Q?MfH/JG/E3R3F7kujjlldPzOy2ilsp8MYsKEX5tjYdJungcKlIXwLCtiqFbY/?= =?us-ascii?Q?7s3pIbsU/VWp3r3xNXxcgPnGouSZviHXFTJPzdRdWwy3cFIrnwsA5qj4EVfY?= =?us-ascii?Q?zKkdb0CPgSQm9KDmYTTSntahXteKh/J4LhSqfAlFbywECD2z7kZzAtrNfHnd?= =?us-ascii?Q?1RNKDPjj2IDakYAv4Qv7RloKJW0b+oYVwWuamY3YKrmqF/pFGESkJ2i8SBrN?= =?us-ascii?Q?CxnqPSrcp9lk7/dcFvlUMFFL3aa6fPgQEvPh/BW5Btktuw8Q5zXYgVuV0SCW?= =?us-ascii?Q?LkSJlRA1Q4LDP4l8v0s=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL4PR10MB8229.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xZImcNMr22CqEEjhyjGHBRFD2JpZQLymEuyWmfQpJa/wN5TLhYBioQsRbJK8?= =?us-ascii?Q?e7FR0lP+Ri4zd3oPZbwoBC8zBZ2xPk5Paij6O2UqSsBhVtfTNDEjEmkWWHx9?= =?us-ascii?Q?WxLvILke7h9K2/F38KoQeGluBR1HjmExmoBMyab3w0p8XwyANPyYtiDCihS2?= =?us-ascii?Q?XxOF0wcHleohMaEqsycy+q/3PdSImEsbpId7Rldrk/OVJM7ZN6A0d3wWmD+k?= =?us-ascii?Q?hXzrYQyt0N8PTwTNsRDZcdsKUgYJyds0r2KGj2RhlTz027rm0ZNcS6d4IEgW?= =?us-ascii?Q?gcZjAM0sxz+1qpX7wXMz/g7KVZSn6f98H79UmaIcgW6yDq1QRdDwgydkdF/D?= =?us-ascii?Q?TrWKQNQZRHPLyx+zRa/tx2S6RPhaAhFgJ+h+B+dRbHyES/O3FZ/ln8dJv3bt?= =?us-ascii?Q?YCYjWM+eF1THBNLJ8gxjQ0xjnPVp0X9Sbc2NGRSxfjjyOUx2oBFb8k0/v3Gt?= =?us-ascii?Q?ByYn68TWW0KKkkglunqzONd/b8bzShklz5po/9FEbAQXQjyIbxvnbjSxK0jI?= =?us-ascii?Q?2lV2GdSYYucndUSkQdYBErMm1Q1cXyzRlO/eava7B9JSieJ480DuIds/7n+B?= =?us-ascii?Q?ndlqhXS7bWYWOV9qPzzAisz3m7jSQxxxmPKX9tK34yGw43ZkMedx5lGlWzUs?= =?us-ascii?Q?OxZU5hlrDknJZsHZMyWxFXLfvRVJSZOA0pFY+GbvMwRgu5e+MilYf8r5tH2d?= =?us-ascii?Q?FdsjCErpctg2amJV2G3BFbuc0Z26U6X60ce+Wt/cokwjYewvQ2s2ljMalHRT?= =?us-ascii?Q?VQtqvqPauQBSBDGtzQv+E0YODXUJunWK+K/oJ7GC00rdcYN883EWx/e4oo3q?= =?us-ascii?Q?TVJV+VSqmmTF5ELeOzDGOkIGG1WAk6rf903bzirFtiTkv7gvximgcpPdQwj2?= =?us-ascii?Q?Ch8rYz3MW3VbSPbrk8zb7K21X1bMqhRB0aNMJ1ZP9NucG7IW7RrYHTovwo0M?= =?us-ascii?Q?ENP+2A5kStwXQsrrVywLDBkiLPN21MEuCr8BZR38VhbtI5601LMj7Kdw/jcG?= =?us-ascii?Q?DDMQRw+pHXdFuL3EuWvzq+RCiJzp5HCrcozQLNEfnD46kC9Ly9O/afkQOmO9?= =?us-ascii?Q?SdqLsudBVGJDnVl8/UnXF4vZuNrOYf7X8BGV8dbSgOj4mIUUY3J61p91z9Pw?= =?us-ascii?Q?Aj+9wlnD8151na9yfUvjif2V0zF0Oks7AbUQ8v6xvTy+G8arvX4egQBbawQZ?= =?us-ascii?Q?qrFB9YKmAH+hVIpezd2hpk6eZeAcDcM9T695B/B4QfB1S1XXvSpNdlrEau0M?= =?us-ascii?Q?2jw4GRvxpHDgIhiSXztqH+tOT9FLlxXTbZ12iA/DinpvLlM5qLYK+oAP24mh?= =?us-ascii?Q?KXieSKcgIhTNeS594lxJesUIYq0uIHz9lc9X+wgk2pBKJz3PTXwoJmIjDnzd?= =?us-ascii?Q?jL3ZJTN2aYSBTPRA7TZEVPDsRqPsZ9B8xiHzOjtqUn73tRWIv6zzI8CzxqVo?= =?us-ascii?Q?ROusCFBpo5P9TuoSBCR97gAud1Umy+xuaJAr9DsAxVZMmu8EEMBhGdlHdMdm?= =?us-ascii?Q?yUksf4b3nSiOCnsphCk9RqSrKLYSfhWyJYufku4yGXy3omvMxW2XG4PK6hKd?= =?us-ascii?Q?S8s9zBJjeXz+6Tm7YxrPLuezzq0obPDHKjJ/CfFC4g5GVBBp0apGH/8neW2v?= =?us-ascii?Q?8TEe5K1vro8HUHVFsZoLT7s9IjgZaqaSxRlGBjzCh0Ri7LhiQPI2YnP7Xu1U?= =?us-ascii?Q?E2+llPQYQ6Rb478R0bxfZgCdwvUoyXAErKxExolRemiNddOfP5VICba6E1mJ?= =?us-ascii?Q?XaKff12tt/zdly78ShiXnccuFYjpYS4=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Caqj8aSr9sTRfgu2avietnLgj1Mt/3t5Q+zT3zES1UCrZDy7qtprkTJC1UZA+b7KA9lTMMRdE9oftACcBslsDPHtYXMZvtmyPfurGx+ZLWUxvzKzvTxfiYvaFX3mmhRqJlXpes6q/d43AVUdynKKhea1kYGmvexe4ILQllOetzpHu2SQ18+8eCsbZFO10RLFxFnmeCSFPRXVOIdTECYEe9Ge302Pj03g8Q63xBmfq8C7UtXtFo9jarhH/cHyuFwMpWU+7khF2ALZLZ2EW3+dz/aQeqvNzJhJTExKnGs24AnRFslggYSYi1LviOgG2ggEogB3zPny9Bz18pNwrkPt8M1BQkWCveWptSh+XwaTKQsADBXhbldGO8fkIDihu17CKFm5Pl+YOK8CNSEiZV9f+J2jbYX2sa+6XsAbf56Q5AgydeknNSbXNrWrtTpxHwHg8qS5Sbjx/689b9/Rfxp3cEPC9uCP7fIoy5Ag/yPLu2en/Qz5mR4BbzcOin3cyYJTnlGC1Lx6plZyO7baeNTgPq/SaamfHtsTUusfhxK98iPRqL8gtx7eke6/orp8ue13OKBmsh4NKuH/uiGUwFFh9aGIFMhHni5TOHrgnXAXFWo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 036cbb8c-29b7-4b64-53eb-08de5abaa6fe X-MS-Exchange-CrossTenant-AuthSource: BL4PR10MB8229.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2026 20:04:44.6106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ma5uAwAhiEiLvxrSrMQ38y0IBVSTBfM6+R/x42eqQqSAodjl6huiNIXNdhLPqmRCCThei69N9H02y26ECp+tr7GXawTR3Bc0cfvkWD1dWuQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF0275307EB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-23_03,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2601230154 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIzMDE1MyBTYWx0ZWRfX8VNvzgR+cTr3 PGCrADMDCI4NeIJyEp0PFXF6MWXIF4v+0UxmEEBbcMm8JynAU0f8RO8epGDiyBR2lurfKAG5VxR ifSqL54Z8uiJZ2VY0qC8uCPMEJDjOboao0rZGiCnW2rjEeW6ZgCr5zPlAVNp6ZuHfHMk+wN2AbO eoCY5Ag3q3YaLfZIb3bxFup9X/Tcim4fpLZq1FYmZuzDYxld+H9QKacpoBo2CLmfhuSFbcuMdAO Hi2fDSo0L+oGJ/mxhYMUg49f5L6n3nJn4BGGIfJ920SwNMhCPvOL8FL9phAdy/mnKi4RvnH0t8p a5tman5s7s2uNvLzbFKZLDqI2wFpkE9aDI47ahy6VvWNy9BET7HTdcsJZdDA31U8nP8cTJaoPY1 FDrd/pVPJDfAGtihj3Kj8RRed+itkD5/0rbV7k87Y8NKYdwsPFTBumFoRbNJa03DwixxtnGZKao MeKjqr1PDv+2a5YvBNA== X-Authority-Analysis: v=2.4 cv=de6NHHXe c=1 sm=1 tr=0 ts=6973d460 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=JL-34Ru-T-camZ2jayQA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: QTIZBc-yQgwtxQM-ruJ7g6fxHB94hDBo X-Proofpoint-GUID: QTIZBc-yQgwtxQM-ruJ7g6fxHB94hDBo X-HE-Meta: U2FsdGVkX1+1ulS0M9dm1/ik3e2eQJxnVlfGdO8q2UmxOFMr9sMRUXCBC4cI8dVu+dLk2uWf+oreyTqCGWn+vKA8jO5Mw0iy6H90AmMBgX+Oo6fooP0cFcwQH5Wm1hB9AAWDGNDkMhoMMeSGVBrBeTdAwUjCk/gseZn+gNEJ7n3q3WSDCnpxewjQIJ3gK65ZcScvWxVX7MDuXXFf/noXpKWWmviV5ZjpVK9Xz/xmSLIiqlFFxDdfttzlILw/mTjPaEkQqjvc3eXESEyBemFTdkWUk4HVcj/NVf36rJOSYtCXfsEueMghULmIxqrtu8a6F2upQ0na2XUl3JF4BZ/NoI7CYE/SKSLSae/uSjIDH4Js8I3b9AWWGNczOKRRYK7ZcYpaVePd5i4YNdktUmlHUObkyDy2d8YJ3OnylQqQGcnG120IgEzzP92K7Q94MpUgkGwNW1tcYDIM09QL2Q9B218R2wBfleEt25iwBlRMNO+SzH75j2UkJmb1Y2gspBHRGFyBmHp4/e5zdVQYZMNZVeIJwOWRoV6ReqEArOxYcxat1MCwUI/DY0H5zDZB2xmarq421vKNSrWyqpkgnnbvhQfnuKf/+K6HE4icGq6TDygQwDZQB10BWjHCfmF1oa1ti92HAmZl8svaIAU+LhQ6Xw/O+QhcWFAcwVyxwugg6aVcH0qEis9198mjIr8pcSMoF5tzW34d3t5pChVWrB265NUdkH7M4SYzj7gFGju8F9CEpU3MmY49jvkB75t9wPFWAgRYQmM1lIwF3IXb4XNo90t8V2GMjfTZaUkFyVo77IruqJNuwTMdbA8rtWg49aPTtINVJpMMEVRqn+cAiEa8vZIcL+2vRmf6NkjROCoUmMfHIdtDrB5MunEOexMfcKWJpr625a4Lrjk9mElKB97F+iDQ1aZL5g7h/q6TFKTeFjtXmqOCe6NnlZZ5Ne2yhGprc9/RZfEs3Gab51ohtXy K8+t0J2R 4QrHxLnWvy9Sm/p2ERVDlcIVhFHqUokgUuCzC346ozDgMlmVdD4Rdlbu0fggFJkCqKlCdcaNPycgVKgvFSrDCRY9XGWeeH2nvi/+MVHU4fgV33RdRtYLSsmjxLuFu+9tbzSZ1PmqyIz1wdcLhdA0mTkwbW+4QzXmAAqKZL8qTIJjsB3hQRXuMSb9VZvip26aGp21cufZh5Utu7NOd4pX8AJt/hWIKiDfF0ysMzaTbFrSBDaF6+vLJDF6INMj3rpyLPiq+bMe9qBB4MzD5YwudZiF0JsViaNWrU0siUOFDMbM7nzccHAodcflkomBDtwOq6tHpxNJrNFQSmXN6s8VLFQk0Rra4fQGh2gbI8Rxaog0LIRcIfGIwjj3vUjlvVTtbpUeQUD6NBuFbDFHe55rqJaj/enB/FAzhO2/Y5jx0R9053fWqma9DOMrfF5hnZf7L5rcgUtSTvBePC3QY+1nB9xFkV2f5X1PT/FWB6GL0ZnxnJ0W2dHGTwRDDDGapAIfiWttLHHX71SkH0EMxgPzRvDmx04FU5s0c0LW7zOSNa0U6TG6NzEW/6CM3w6zeWWMxmVoJmuVk57PVQTsvYfWXSlCU2VoUDcZ1QanZe6f1c39EoXCzZ4LnggnfxXJ9OrOEUL3Zehxd93oy8tDbCnhuFpF40oRj3BxNaL7dOjqU0/wniXDTyb4n2Ybq8tEp9CCTrhGs X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4945E180010 X-Stat-Signature: qqosw3tm1hczbgfstw947o87xif97du5 X-Rspam-User: X-HE-Tag-Orig: 1769198699-917273 X-HE-Tag: 1769198704-1648 X-HE-Meta: U2FsdGVkX19MuIAFNcd+EBY5ZNRrLxWovFxt6kBqG2vyzFrzYuVihWYRdkxFsXhJ6AirBz8pL/ib7dvkodndkvDwljQ6yb688LIzmJ8BzDjvR4KvyAhkfe8qpThF5SFbB7igLR8VmxWwwdjdwOckLl3atp9cQ4ChmaVgsTvnp/aCu3NgUsh0L/njrpTSjT9yDA5VIwdzZD+NpIvCMJkjYUpyQ0XxJDzPfR2HFZK46luViWCdil8jX7tK4B/fvx4NGDxmdvWwWrt38DsRt+1atdJ6NBgYKsAKxdr+fAVBAAQrsLLhu0AgL0KV4OGRQdOQpJddSSOYuuHEzGMlO1Nqw6z2OwHyDquYLJDhdLLz5iTeA/YvXzmIAKZTCI5rf33pcgcIwxRueZWcIrg47+4a6SD9FSVzjZ4QGLh1KKgGOUs3xR4zS8w49DaGFaXJiDJj4NcNgqBzPwzdNIgMBHbgV1s6HAQzDjLNbonHGE7C0FjfVxPI6SqYo6bQYmvwX5sn0X5kh4RFvGd5f1rNIPfuZd7Neim3equQLklxKei3PuPt4lTi9EJUBIXqDq2K3rI6mSC4sIKbzsMVe533x3jsa4pVs+m0eeYTfYvJaqGps31RKQ2qYzNgLiDRKdE5Tzew8nXQhDGMUDNTyZXXqSItE9Qh3f0eqnvu8toVoIzgVcsOK2OgcuzdktQ+6iWOmneNRxgO0B9gB6caoH8goR2hzkaJ4BliCW/aJj5ftJrn0xZdGnvFfaxK4F0ejoGbLA4qnqWjJM1tO2pJjicZGaSdK+Hq3wwAiZWODI18GZXCYsNLa9cIOBXvs4vRnebkDqxrRxoI0xBMAIy/Mr16pVD1Ly2IIYAzDEyxX8BZ09cNiZ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 23, 2026 at 11:34:25AM -0800, Suren Baghdasaryan wrote: > > > > int __vma_start_write(struct vm_area_struct *vma, unsigned int mm_lock_seq, > > > > int state) > > > > { > > > > - int locked; > > > > + int err; > > > > + struct vma_exclude_readers_state ves = { > > > > + .vma = vma, > > > > + .state = state, > > > > + }; > > > > > > > > - locked = __vma_enter_exclusive_locked(vma, false, state); > > > > - if (locked < 0) > > > > - return locked; > > > > + err = __vma_enter_exclusive_locked(&ves); > > > > + if (err) { > > > > + WARN_ON_ONCE(ves.detached); > > > > > > I believe the above WARN_ON_ONCE() should stay inside of > > > __vma_enter_exclusive_locked(). Its correctness depends on the > > > implementation details of __vma_enter_exclusive_locked(). More > > > > Well this was kind of horrible in the original implementation, as you are > > literally telling the function whether you are detaching or not, and only doing > > this assert if you were not. > > > > That kind of 'if the caller is X do A, if the caller is Y do B' is really a code > > smell, you should have X do the thing. > > > > > specifically, it is only correct because > > > __vma_enter_exclusive_locked() returns 0 if the VMA is detached, even > > > if there was a pending SIGKILL. > > > > Well it's a documented aspect of the function that we return 0 immediately on > > detached state so I'm not sure that is an implementation detail? > > > > I significantly prefer having that here vs. 'if not detaching then assert if > > detached' for people to scratch their heads over in the function. > > > > I think this detail is incorrect anyway, because: > > > > if (err) { > > if (__vma_exit_exclusive_locked(vma)) { > > /* > > * The wait failed, but the last reader went away > > * as well. Tell the caller the VMA is detached. > > */ > > WARN_ON_ONCE(!detaching); > > err = 0; > > } > > ... > > } > > > > Implies - hey we're fine with err not being zero AND detaching right? In which > > case reset the error? > > > > Except when detaching we set TASK_UNINTERRUPTIBLE? Which surely means we never > > seen an error? > > > > Or do we? > > > > Either way it's something we handle differently based on _caller_. So it doesn't > > belong in the function at all. > > > > It's certainly logic that's highly confusing and needs to be handled > > differently. > > Just to be clear, I'm not defending the way it is done before your > change, however the old check for "if not detaching then assert if I mean you basically are since here I am trying to change it and you're telling me not to, so you are definitely defending this. > detached" makes more sense to me than "if > __vma_enter_exclusive_locked() failed assert that we VMA is still > attached". The latter one does not make logical sense to me. It's only I don't understand what you're quoting here? > correct because of the implementation detail of > __vma_enter_exclusive_locked(). Except that implementation detail no longer exists? Before: if (err) { if (__vma_exit_exclusive_locked(vma)) { /* * The wait failed, but the last reader went away * as well. Tell the caller the VMA is detached. */ WARN_ON_ONCE(!detaching); err = 0; } ... } After: if (err) { __vma_end_exclude_readers(ves); return err; } So now each caller receives an error _and decides what to do with it_. In __vma_exclude_readers_for_detach(): err = __vma_start_exclude_readers(&ves); if (!err && ves.exclusive) { ... } /* If an error arose but we were detached anyway, we don't care. */ WARN_ON_ONCE(!ves.detached); Right that's pretty clear? We expect to be detached no matter what, and the comment points out that, yeah, err could result in detachment. In the __vma_start_write() path: err = __vma_start_exclude_readers(&ves); if (err) { WARN_ON_ONCE(ves.detached); return err; } I mean, yes we don't expect to be detached when we're acquiring a write. Honestly I've spent the past 6 hours responding to review for a series I really didn't want to write in the first place, updating and testing etc. as I go, and I've essentially accepted every single point of feedback. So I'm a little frustrated at getting stuck on this issue. So I'm afraid I'm going to send the v4 out as-is and we can have a v5 (or ideally, a fix-patch) if we have to, but you definitely need to be more convincing about this. I might just be wrong and missing the point out of tiredness but, at this stage, I'm not going to hold up the respin over this. Thanks, Lorenzo