From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38040C19776 for ; Fri, 28 Feb 2025 14:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FF9A6B007B; Fri, 28 Feb 2025 09:42:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5879A6B0082; Fri, 28 Feb 2025 09:42:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DA08280001; Fri, 28 Feb 2025 09:42:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1C6746B007B for ; Fri, 28 Feb 2025 09:42:08 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91507120CB8 for ; Fri, 28 Feb 2025 14:42:07 +0000 (UTC) X-FDA: 83169618294.17.167291D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf09.hostedemail.com (Postfix) with ESMTP id 16821140011 for ; Fri, 28 Feb 2025 14:42:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=X9Nz2mFt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BWBXdHZa; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=X9Nz2mFt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BWBXdHZa; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740753725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MytUvU3RI7DRBJltO6l/dBaxsuM8bLTg2W92VqPhqcM=; b=pByAox4xOPkHrOTc3Os37VRm+G4dQW2NYkZPLOfD28hesQrz9s/Mbnjvm8t8/x0+bFZrqG GaOdlbGC5KuFwNakprqWqsgzDECsAHW/Im5ysAonQHGSSgxWzvmSX381JZM6uh8JQTPQq2 OFYYfNTic7bFdsjud3QnvQ8hv6/SxeQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740753725; a=rsa-sha256; cv=none; b=ydX7tZNPlnhyygP/gGWSEm/dAMdBH0nsd4TOtvKZD2EHEI4jFG5JZUPQm/qkKXQ1DQ109+ tvTnUjgZ/DFfR/8urDVn8w4v8ag2o6cd3zusHT96s9N7kIh2Mzyvi0q3pSFksJobZAHoKo HOQrt1AD2s5JqR6Eo/NH/7Sx2HEP9Ec= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=X9Nz2mFt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BWBXdHZa; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=X9Nz2mFt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BWBXdHZa; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 453B01F38F; Fri, 28 Feb 2025 14:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740753723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MytUvU3RI7DRBJltO6l/dBaxsuM8bLTg2W92VqPhqcM=; b=X9Nz2mFtWSZ7MehiT0TqpIxzVpBl/UJ8TjhTeCOlpCk05dxU6tblLP7mPRQj8lywZ3rfq+ zMYEMaBmH03nGiV4r9Y+8CF8JdKHJGUkRhNJuDbofE3gGqgjL9dagPhoH/7BirtLAhYPV1 k9RplJUbS5+/cPxgZnpsZZHvpv711Wg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740753723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MytUvU3RI7DRBJltO6l/dBaxsuM8bLTg2W92VqPhqcM=; b=BWBXdHZaYTqumZfQfBpPWmcmJHMmDOKZJXpc2ybe74TtzeTx3vNE41bJrv6MNDchRZvJ2F BF+8e0cTNX5zRqCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740753723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MytUvU3RI7DRBJltO6l/dBaxsuM8bLTg2W92VqPhqcM=; b=X9Nz2mFtWSZ7MehiT0TqpIxzVpBl/UJ8TjhTeCOlpCk05dxU6tblLP7mPRQj8lywZ3rfq+ zMYEMaBmH03nGiV4r9Y+8CF8JdKHJGUkRhNJuDbofE3gGqgjL9dagPhoH/7BirtLAhYPV1 k9RplJUbS5+/cPxgZnpsZZHvpv711Wg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740753723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MytUvU3RI7DRBJltO6l/dBaxsuM8bLTg2W92VqPhqcM=; b=BWBXdHZaYTqumZfQfBpPWmcmJHMmDOKZJXpc2ybe74TtzeTx3vNE41bJrv6MNDchRZvJ2F BF+8e0cTNX5zRqCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 25504137AC; Fri, 28 Feb 2025 14:42:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GZLICDvLwWfLOgAAD6G6ig (envelope-from ); Fri, 28 Feb 2025 14:42:03 +0000 Message-ID: Date: Fri, 28 Feb 2025 15:42:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] mm/slab/kvfree_rcu: Switch to WQ_MEM_RECLAIM wq Content-Language: en-US To: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton Cc: RCU , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Oleksiy Avramchenko , stable@vger.kernel.org, Greg Kroah-Hartman , Keith Busch References: <20250228121356.336871-1-urezki@gmail.com> <20250228121356.336871-2-urezki@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250228121356.336871-2-urezki@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 16821140011 X-Stat-Signature: krigbpmyd9qema7e4yn6gwpikfjudu56 X-HE-Tag: 1740753724-761697 X-HE-Meta: U2FsdGVkX1/tP6s4HQ8PgoKzBDlmsb6VxfxSXt5qbScwz241wZt0+7k7ixemYByoQmyNeaFtRibLP5SnYb5vMrkrIRIZy2PGhSjZ5kJ3aS46zE0sWTLOJyTyg3mO6MraebLhqWgY3/VLikt1kDvDkSYI4L/rEyDK2XrHyJ9gVgxXzsSVz/EFbv2BR1PlElUZihGdQQi3m+W9rwX5I3F9Ktxm275UiASTRRCmFl8gj0kqV3Ql0m46CKTCOsaqVd76aR0clFYesvG7IeISWu5ZBvDVSAVIJZ4qt3MBb40A03VFkgorxt3D5B9ufMsuYsCMr4AvpP+ohSQ3WrgDRowHgBrGxKPZ9RjQfVg9DckuIf7njMC+i1qGYz1/zY8o6kKUdKYMVEUVNjORNTsbNVI/Qg+z/1rPQOpxfjyb45aI5jXU/x4UN9puOA6RCFNwjdpj5xvsh9soiv0R8XM5QxFEcLvOMz5YuqdDgWYRAdPxrJhaXyNSNcAP6RNPSJ37lgtAAaPsFK9CU7hCT+aykCdgt0jSbLGKD8iB7Gyz1AzazkwoIAl8e+G3+agrygjV9APFjr8ng0+nLTDDhpHb7+pVIZwhOKALv0FTSbC3+vadFjRPvPHNZ+3pSPr2CYUfJJlbqeLIlb4cJQ2HIbI7aVXpZWtMemL5wHlfor86v4g0QX/4IergOAxpU6l+ZDlQyXcm7Zt5J6/PpagmvzaXLUpYJwwvuMmRzQ0isytQLFgx8Rp3JwlRwniTIXqghZg510evh3Jbz//54riPvRmoOlz1oAOecxBdsU3e4z2mFHBX2EpBw+nmIgVw/7E/Go35+Sa7gn8Sy5hHw70spQZiylIyI0GwSIRnGRBJ8tH7uXLSXFlKTUFra7Wxf+4txGrJjaY1S4GwB43bj8R3+q3B7PUA6tEEb57nkanKqKo1nxiN7XMQEIUcqb7Yv/rpqu9y9q1iS5ZBva31OPDmqb6KOAK GWBFNmBN AnX3IL6ITbz9WtrARuL5MBDc+an+0nLJPPGLwmCLrNF10iceMlhbffw21638Xv7l/Yh/8V6MqO/XOLxnOU3UmwKBPAIENoc1bfSZ/mFNbls3A641KYth3DjazFzq/I1p89CeKWnwr30FgxurffwDJO3GnteH0jFTzLaK4e28IZB/p2daojbkZYQuwKz1+nE8iX/aAuyTDlFp3dvbb/Zq9L8DQlpPhwd1EhK3nFe702vT1wJFL6YLlqZxTrWEcVZHCY+w5IA/tFE31IaIyF678QdlnHldEuQLgauG745sV2pyAp/KEu59lXYMNkcra9x/Lq/mQlLlJD63+J/lpwmRMvCymcHEvjpDff1gCrh7qNHtlEwoQXxwXdegQ3Nt9QxtYgWPW274i7uQ05CQBchVe7G2I1EcwYJf5rJ4hWAmgdpSqWQLYTXu4u4n7AL7fBzGEWjnvpT2HDRrezcDc3QFcY9rC71EfAIU02di4c9NKfZXE7igw07irTTxh7/0Gph/BIEpCuNkOOZO8DdC9fjcbGN3HfWy60lLR1/SdL7CrAAXujUOtb6TLz9/HpNulNdUfmmxmvffSqyUcNLZko9mtBajrBqR594RxZtjyqyUrYPZvNcQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/28/25 13:13, Uladzislau Rezki (Sony) wrote: > Currently kvfree_rcu() APIs use a system workqueue which is > "system_unbound_wq" to driver RCU machinery to reclaim a memory. > > Recently, it has been noted that the following kernel warning can > be observed: > > > workqueue: WQ_MEM_RECLAIM nvme-wq:nvme_scan_work is flushing !WQ_MEM_RECLAIM events_unbound:kfree_rcu_work > WARNING: CPU: 21 PID: 330 at kernel/workqueue.c:3719 check_flush_dependency+0x112/0x120 > Modules linked in: intel_uncore_frequency(E) intel_uncore_frequency_common(E) skx_edac(E) ... > CPU: 21 UID: 0 PID: 330 Comm: kworker/u144:6 Tainted: G E 6.13.2-0_g925d379822da #1 > Hardware name: Wiwynn Twin Lakes MP/Twin Lakes Passive MP, BIOS YMM20 02/01/2023 > Workqueue: nvme-wq nvme_scan_work > RIP: 0010:check_flush_dependency+0x112/0x120 > Code: 05 9a 40 14 02 01 48 81 c6 c0 00 00 00 48 8b 50 18 48 81 c7 c0 00 00 00 48 89 f9 48 ... > RSP: 0018:ffffc90000df7bd8 EFLAGS: 00010082 > RAX: 000000000000006a RBX: ffffffff81622390 RCX: 0000000000000027 > RDX: 00000000fffeffff RSI: 000000000057ffa8 RDI: ffff88907f960c88 > RBP: 0000000000000000 R08: ffffffff83068e50 R09: 000000000002fffd > R10: 0000000000000004 R11: 0000000000000000 R12: ffff8881001a4400 > R13: 0000000000000000 R14: ffff88907f420fb8 R15: 0000000000000000 > FS: 0000000000000000(0000) GS:ffff88907f940000(0000) knlGS:0000000000000000 > CR2: 00007f60c3001000 CR3: 000000107d010005 CR4: 00000000007726f0 > PKRU: 55555554 > Call Trace: > > ? __warn+0xa4/0x140 > ? check_flush_dependency+0x112/0x120 > ? report_bug+0xe1/0x140 > ? check_flush_dependency+0x112/0x120 > ? handle_bug+0x5e/0x90 > ? exc_invalid_op+0x16/0x40 > ? asm_exc_invalid_op+0x16/0x20 > ? timer_recalc_next_expiry+0x190/0x190 > ? check_flush_dependency+0x112/0x120 > ? check_flush_dependency+0x112/0x120 > __flush_work.llvm.1643880146586177030+0x174/0x2c0 > flush_rcu_work+0x28/0x30 > kvfree_rcu_barrier+0x12f/0x160 > kmem_cache_destroy+0x18/0x120 > bioset_exit+0x10c/0x150 > disk_release.llvm.6740012984264378178+0x61/0xd0 > device_release+0x4f/0x90 > kobject_put+0x95/0x180 > nvme_put_ns+0x23/0xc0 > nvme_remove_invalid_namespaces+0xb3/0xd0 > nvme_scan_work+0x342/0x490 > process_scheduled_works+0x1a2/0x370 > worker_thread+0x2ff/0x390 > ? pwq_release_workfn+0x1e0/0x1e0 > kthread+0xb1/0xe0 > ? __kthread_parkme+0x70/0x70 > ret_from_fork+0x30/0x40 > ? __kthread_parkme+0x70/0x70 > ret_from_fork_asm+0x11/0x20 > > ---[ end trace 0000000000000000 ]--- > > > To address this switch to use of independent WQ_MEM_RECLAIM > workqueue, so the rules are not violated from workqueue framework > point of view. > > Apart of that, since kvfree_rcu() does reclaim memory it is worth > to go with WQ_MEM_RECLAIM type of wq because it is designed for > this purpose. > > Cc: > Cc: Greg Kroah-Hartman stable is sufficient, no need for greg himself too > Cc: Keith Busch > Closes: https://www.spinics.net/lists/kernel/msg5563270.html lore pls :) > Fixes: 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"), > Reported-by: Keith Busch > Signed-off-by: Uladzislau Rezki (Sony) fixed locally and pushed to slab/for-next-fixes thanks!