From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D6B2C02193 for ; Tue, 4 Feb 2025 20:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C00A6B007B; Tue, 4 Feb 2025 15:48:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06FF26B0082; Tue, 4 Feb 2025 15:48:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2B4E6B0083; Tue, 4 Feb 2025 15:48:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BF58D6B007B for ; Tue, 4 Feb 2025 15:48:02 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7D7C1AF662 for ; Tue, 4 Feb 2025 20:48:02 +0000 (UTC) X-FDA: 83083449204.02.E6B0F46 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id F113340012 for ; Tue, 4 Feb 2025 20:47:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=erdcAZJX; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738702080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z4vImUuz5gXwBthaSk4zpKVBhpNpdK0P0dtelk1zWfg=; b=gBZBk/SsGAibQh63IrHsfSQzH3uMsMOF804n3yd1X0UdAgDJHoJYZRKD1AZxdOGeGcRePt NZ1/3H0yRwejpl/v/e3pFeHsDfQGn4k+kxlgzJvEO+wE8pI8Ob3t+eFAVqTMZFQ/Nvb91m qm7tG+q/MpDhVAidcKZoSheRDscszSo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=erdcAZJX; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738702080; a=rsa-sha256; cv=none; b=7/LculfguQx8LMUH0qul8rf0XI1kxEqmecUbYbmPuQOHCGdljw/XS1abP4SbWpi2TenB/+ P9UR+TSR7dRTeJUKvPIwM/qQATxITyu6KFUMf1NDjM/MwKwVv50IAikQVTWfiidxz+aOSr x5mCR+Bmp5gla5yZcp139wmlA6FO34g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738702079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=z4vImUuz5gXwBthaSk4zpKVBhpNpdK0P0dtelk1zWfg=; b=erdcAZJXt7tBAvd27c1NzhtBXCJTFR7vYNI5WA8lsugPKWaz6AlbHawU0i7Jqxs3u7NMGF UyYYkG/yYR7MJIJ305pZF2GsNim7wAzdz7IKWVcV6+PMJo7hByKndDrIlombCaGEtiDh00 Ula04ROpuXvYD22A8w+pAaplXmzfjxg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-ngVzgJbtPvmTUTT6FGQstQ-1; Tue, 04 Feb 2025 15:47:58 -0500 X-MC-Unique: ngVzgJbtPvmTUTT6FGQstQ-1 X-Mimecast-MFC-AGG-ID: ngVzgJbtPvmTUTT6FGQstQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361efc9d1fso47894485e9.2 for ; Tue, 04 Feb 2025 12:47:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738702077; x=1739306877; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z4vImUuz5gXwBthaSk4zpKVBhpNpdK0P0dtelk1zWfg=; b=XG/X1YlSkfnjiqrSVetaLIwRyv2kE5ogUhzDcB7CoWfWZaRG7N5e46Gw0izVydGBt5 LkRlKwujVtaThWvTpuwSHH+faYRj9b2QcFkVlgnKvO9gSks0ALFTUb4G6RUXhv0iiejP UpFFxoHpYFWt51fFCEdkR5gZD0qM2UP5e5BIMxmq6TPwvh2sGAbN3ZwXGnh2kBIk64jW S9JUlUUbmm1CTSaHiX6+paratgXNtB8bH1DNGkW75RVKcdA/HXWRjwNqOkKoCo0uH1mD OhW+OAVFAHjJu3JlHLHDLMw2jpGyXUa+5ASqVhWXVP3lZfwmpGDZN2JYGOKShKTwSskZ Pwrg== X-Forwarded-Encrypted: i=1; AJvYcCXPWPMy7oEiSgMs9jk8FXfg+UqaYL5ZbDodgDmW0HB697i3g2l4iXVCxJhbt0IPvq3kFEe6cCgFsg==@kvack.org X-Gm-Message-State: AOJu0Yx7q/H/61uj0FlNB2FagjFyBGD2TboNJ0yHsCA3ld9ve32tG87i zmwgiNrlA93k6y35LVzuxnnMXDzSd4yCBGVYPLIswULJRWHaoA+ckhX6VMgdPMZaQP4H9Tx+7Uj bGnFHUMMlvV8eG0nnw6akPtQH7PiTp6gCAs7sdAVYlGLklXfg X-Gm-Gg: ASbGnct2WqyQFhVTd02PyUQuYC6EzrudkJ9Uq988CfofFWhZUxhILwbBrx+lZU9yQaj EfQbymojXAnyU4O+qwBMhaked8q3oy/Shnc2TvPsiFD5YlmvWRxvaWUDYgY7mHX3OOzlYmSUJSb CFFwFNaUfN+3OkNpYg0M+BD8BUYZ5QoLjUo5rPReN/l92nKBsc+0aEZuSJPbJMEiXVaB2ZjOC/k 7Db71PHU1FNAtoDdm1VUjmA88OhUMWihNZeqLDYcJweabqitNTRfdUcgj+C3QRS6e+OD0mbXbI8 Ow5tZaLXNMEzrZNm90RLD44dGA6g0HGK X-Received: by 2002:a05:600c:5252:b0:436:30e4:459b with SMTP id 5b1f17b1804b1-4390d43e153mr631505e9.18.1738702077055; Tue, 04 Feb 2025 12:47:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8MfxYAnnJeUXQFxt7doefvYBPuFEStFKJefTGH1z0tD/45gZRF4e/Q5kb3BA51DWWjYy/Lg== X-Received: by 2002:a05:600c:5252:b0:436:30e4:459b with SMTP id 5b1f17b1804b1-4390d43e153mr631415e9.18.1738702076694; Tue, 04 Feb 2025 12:47:56 -0800 (PST) Received: from [192.168.3.141] (p5b0c6602.dip0.t-ipconnect.de. [91.12.102.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e245f41esm202542205e9.36.2025.02.04.12.47.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 12:47:55 -0800 (PST) Message-ID: Date: Tue, 4 Feb 2025 21:47:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] rust: page: Support borrowing `struct page` and physaddr conversion From: David Hildenbrand To: Jason Gunthorpe Cc: Asahi Lina , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jann Horn , Matthew Wilcox , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <1eaf66ba-b2d3-448f-938b-913f17ca98a4@redhat.com> <20250204183933.GJ2296753@ziepe.ca> <1d379007-97c3-4bb9-93da-1a828f955fc4@redhat.com> <20250204202656.GL2296753@ziepe.ca> <08ce9562-9ded-4d95-a495-b60f90d75490@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <08ce9562-9ded-4d95-a495-b60f90d75490@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ebZzx_euxAvSPt-jsdY2qgDAmeoa__A522EJKVyZKdU_1738702077 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F113340012 X-Stat-Signature: 9u88wydfdhfpyu6mwp78kgifb6dwnec4 X-Rspam-User: X-HE-Tag: 1738702079-758538 X-HE-Meta: U2FsdGVkX188wZ5L69XGobYvuPavaIQtwNYPKZ3/W76sVqSgFv9OQ1REUD87sI1dusrBkGdqT4ezEgXrOgh0+FiUSgHtM1oWylyQS8vlJRU6oVv9QKaS9Oq4GV2Aq0qBTYi2+dL9qyDIC+hc9+rrKs4IAEBfwUCcIWfDxzLmAJZwRj8l9qXcI5LV8u0jvWDx9bA4g2txe0F2KBXi8YqY4h+68rShQjP0tl9PVbBmOdCUmELcuFPsLzfqJUBwngzaksWAOSg02svFF4ZHaV6p76aCxjuULzf0b2GV8CdfvcpLPCwy7/54XrZ2DWYYvE4WePQ9SlgP1kX/CGhAekvavSh26BK7LUNPNq8fDHdI7GqQvEhcBjB6vqfUEgh5tib+I+84VaBB4iaueQNZgZwFAqMe/JB4QW/6E2t8SgAMF/U+j4CZhHWNe/E90xw8u6EQ6puebIsIx22qT+mwrv6jsGDaRb5F+bV2LyIxbb29s06fm47MDUJIezFCV8hq/leK8Hsqcan3t1AFrCseRNVi0M7yYnjU1U1OhQok3PxQTtyMflMCvSC90jbjWnrsE0QsnhH3uY3zdaLY9bsHYgBe+wflcCxyfXIRES61EmtyWr3cs/GGA9Wh9XL7rYfkkJKTkDBZVmAcULTbzxVPfz9xraZqFN/NrljhpKNPvzixzloAejTju6D2phQ8OkTPmiyyGGboyBAlVL1toMMm8hXooIzzQ0WPty4CabMHAXZuefHIujen3PryWe2wqo9KFkKYQYXZV8r7ZsmEHsshvkyX35BdxshF7Zk1iuY/+piP/Jr5i//ZlDepNWzgGPUQmQJY9i/G/+nKfKHPbeczq9/ym56RaA33uwJbLZrEi3RMAB/xWy+iWFu1jU7h01B8SA1B9dd0I6MYUShzkjPdwLxMGS6/eBX0PbT9rgxjxMv0rPVGn7GQiYy4scE22tUJYhqteW0fbSHYiP6i7XpxCuU fM2KHAel ryg4lTFKitYD9xPgoVRnQNf1F6uNtp2LYqEKnc84C/wkHuFHQiTmkR6IoG6qyquHU/WWeA+faFEgNMGYSdFyGw5i474hNTsCT+xR4+zzGr5dLHMi9Lt3VnSdl+MLakWAqK6u+gfg4C0FcuVNlcUcmIl+M5JMzwmxDhHS7bD/5v2TOeKe/Dph03zz6rvVa6YweccV3vty2d5jQjKG6W/Isn9dNNo1LmAIMAknPvtAC5OFXucFhBPDFK205mr553lkyBsF1Ee3P76kWsDQKgI2P87N86PChjHBRgOi+vW4jX3+qbsiGGxT8nT3XxvpFUuwl8iYctC2m/HP8XfZMWd5lI1bcNWB15N+07UwVajKerLy2f8K3wXOtWXs8nUCtNrVit6jqYjt0VkVgLnb+NUOBFDd5Ne+NWHRa6DatB4nW5c5IILOPswMz9Q83jcd9FQQLOK20+WaueZU4GwgvvodE0bziv8APfi0hi/eiKV/4Ip6vK1k= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499970, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.02.25 21:41, David Hildenbrand wrote: > On 04.02.25 21:26, Jason Gunthorpe wrote: >> On Tue, Feb 04, 2025 at 09:05:47PM +0100, David Hildenbrand wrote: >>> Fully agreed, this is going into the right direction. Dumping what's mapped >>> is a different story. Maybe that dumping logic could simply be written in C >>> for the time being? >> >> ? >> >> Isn't dumping just a >> decode pte -> phys_to_virt() -> for_each_u64(virt) -> printk? >> > > IIUC, the problematic bit is that you might not have a directmap such > that phys_to_virt() would tell you the whole story. ... but it's late and I am confused. For dumping the *page table* that would not be required, only when dumping mapped page content (and at this point I am not sure if that is a requirement). So hopefully Asahi Lina can clarify what the issue was (if there is any :) ). -- Cheers, David / dhildenb