From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48398E71062 for ; Thu, 21 Sep 2023 12:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D95336B0203; Thu, 21 Sep 2023 08:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1B8A6B0206; Thu, 21 Sep 2023 08:27:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD3F6B0207; Thu, 21 Sep 2023 08:27:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A543A6B0203 for ; Thu, 21 Sep 2023 08:27:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E5CF1A08B4 for ; Thu, 21 Sep 2023 12:27:42 +0000 (UTC) X-FDA: 81260530764.22.8C8BF6C Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by imf03.hostedemail.com (Postfix) with ESMTP id 54B6F20003 for ; Thu, 21 Sep 2023 12:27:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Xdx4hQsT; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=AsHXnvbT; dmarc=none; spf=pass (imf03.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.17 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695299259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XqU4+PADbmN/YvqQXLrRCGcZ07y18plfxqgBBJgIpjw=; b=Ow9pidYwfYFx9M1ak3SPt5lkc8iCseI1kCtfvKwJgWrG/9FahexrfpDAwN+B5ncZxDi2EM ZQVElbiCYfdQv7IejynGB+9bmU5psYUTyvHq2kYVmft9mFzsjD1Ahz2DhjhA1eXPBXkZEV zvuAwLMvh3jjoKKSNwF1gEBmckQDX20= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Xdx4hQsT; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=AsHXnvbT; dmarc=none; spf=pass (imf03.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.17 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695299259; a=rsa-sha256; cv=none; b=UwRQ+1yMyHGmL0V4YWI/8FY7XvadbsdWPnMBLPtmtygA8bveqm9dSKBGsJbWb618e2ODmz dlNt45LWQTDIN1uHkbQ9/+z6vUpF2SBFpW1Qq1C6jZvzVLVryUoM6jDBKbOQ7C6a6miNQy ZCHKbjFk3sVGt1kPg2VpVh7mf2KpNCY= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 0FCFB2B00167; Thu, 21 Sep 2023 08:27:35 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 21 Sep 2023 08:27:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1695299255; x=1695306455; bh=Xq U4+PADbmN/YvqQXLrRCGcZ07y18plfxqgBBJgIpjw=; b=Xdx4hQsTzl4c24llIz 192HiWdE2r0Z17h7hha/5B+uybwHOw+lHySp5dgSFIyremltJv6BupWCCE7vqAtS DUduuni5p7SDjaoxP7Y0c3dI1L3DDC96hM3q6xwLck95D6CeqCmsxrkKZ6Zgv2mQ ih8pZz4GlPyAEKT2EByi/sbL53k7F9MpaztW3ubpkI67GluVKqoEgJAoZkJac6xf L40yx+zPXQSonM/qQqXr+/44QEGY/LW3tmoWxfCIXGmvbDY8YlzEj56Y1t4Q3Ooi aLhMW+mRkUenODaIJ7pTKXCN8HhFkJ2SLPpatk0e1cLMSpNqYk1QxmquZjzyFqfT dFiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695299255; x=1695306455; bh=XqU4+PADbmN/Y vqQXLrRCGcZ07y18plfxqgBBJgIpjw=; b=AsHXnvbTE0NoKn8UR1wNiZEQ0Izgl oJ1le/svDXQKmB5iunzfl757K0xMqaKgwpjVCaw2UuP2Vt2mi2RMkN55AQsiD+0o /NGYpK0Q1N3N8f+y8hlvcaJaEnVYzzUXulTecLj6OPE2kfCABIE81WZlt/TQWRym a3YS2kb9o3UDiIqmT6Muw7WaDcpWDjOLS4FEg9ERk6Zsv5Hp/uVcGqvfRusPbRxs /TkNZpWQa1QyBFLzjTES+Opz/HvajxF5Bnwti4DvpslyUHWi81WsLXmneMghKGmm 5uLl0cSZ1BQNDmkjOK4WmcBmk5Rvp6jy4BVNblrnY0nqT6NYPATO7irCQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekiedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0F24AB60089; Thu, 21 Sep 2023 08:27:34 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-761-gece9e40c48-fm-20230913.001-gece9e40c MIME-Version: 1.0 Message-Id: In-Reply-To: <20230921110424.215592-4-bhe@redhat.com> References: <20230921110424.215592-1-bhe@redhat.com> <20230921110424.215592-4-bhe@redhat.com> Date: Thu, 21 Sep 2023 08:27:14 -0400 From: "Arnd Bergmann" To: "Baoquan He" , linux-kernel@vger.kernel.org Cc: Linux-Arch , linux-mm@kvack.org, "Andrew Morton" , "Jiaxun Yang" , "Michael Ellerman" , "Geert Uytterhoeven" , "Luis Chamberlain" , "Christoph Hellwig" , "Thomas Bogendoerfer" , "Florian Fainelli" , "Helge Deller" , linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures Content-Type: text/plain X-Rspamd-Queue-Id: 54B6F20003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ckzxczbfzhbpgabja6ia5a7u7sr4yoy5 X-HE-Tag: 1695299259-790754 X-HE-Meta: U2FsdGVkX18Boy9+zPTxOhk7OeN56Qb+wq8+ON3SzwwDvWbxF8BpnuvdjEapMbUokIQ8xZeZdHuoV9zQkGhv1I/VDLdaDUI5fcWRhWCXWoeh4+NKqe1PMOrNNwYvkT08KfVOOJ1Xwq0vLYTJoyjl8L6peXUP567G3VJ6NelxD46w/ZWrnkEt1ZWKenOWkj5Gnzx3SpefRYsbATbHabu8vOtzFRxyrrzMmc+3HTBWn8pn7lYurNdnGOBq+FqB0qFOX+qS/ZoBSG35WEEZwtFDnl8bXQbrM06xc1LiOmMnlw4YAPjMmNKj/10jetQQlrSBGxfL/GTi247rSJ8SQojMVjvhv2PKiE6RzUPR07mQbRHrI8LtIy7iE3J6Nb3Ukeryt1vIXsOnNbJqNkBwLTeyrZ3t1E92WJGmbr8Uu43F4A71r7IoneECwMGyIiDuHCPe9YyLgCT3OzI0zRnHLpHfGUb5E5JQrzVchItOUbzVzPVpN6MKTsJopvmvO0bnGqBco3E6Pd+gCHaq7+f91HJ+6LnXyIeyZs2ibRpaGZjLmcTgzvEZGb+fXz+mFAJx94jcMkPZSCJie1jtPDzAuZOF1ey1kp8UHXReGZ2eZ6R86KYkGKKgsolWU46GNIOQ1UoMw/sxY/Lg9A96pgEWRCDKPeGurseWpWbYI7Kw0W3aOTFpyH8aRAZ9lFkWtUDzHDrzW3XbpynhH14dJujroQIf9SVBuV645ns3EgWp6ZqSl0kIk6AMB115jQshIsX5QbpB/oChAWavWiZUOrecJXWa6mtpxuN8T/pzG+AfsjbDZYTnfyEk41i7E0ztaJaQqtvU6z82/LOqwbTNSFpUsaIyJHV69FBJS5LNPrcj4MSdFtHRp2hWGKTGOlGqlQ07xPIXlSSrv6IiYtoajFdpFGmtY7fFPgLbfZzv6JBHAqQTnqTjE71e9w29Rwk1GGFijUiQch7+5EaJElRf8TDPUAl aESzlNzq U7j1sLgyACcCxaj793KkzrXpebHXgcK6K6MfbqyjRuc+Mo+4T8Iheg1B5gl93zwjdWSlPuxUUxB6NCxcJTuMgEPcYG7Ku0ha6o4YW2LJzg94ZM5dWRK5q2OQXpeqZRCyrhpKoKHb7PdUYbPW4QGoldyo3HNIqa9CJP7wSFf+outXZW22LkNSY92VStZtj2c/n08l363Hf8SrvCnB3az7HH2HS0hHx8QI2n1Y9Ek5FuyGRMgnVQewWu/jC75/l4wUQICNu5N29ZtLqvsEg8KTsMHn5RpLeKoogeREvdRsFBkdK97nrlmMA4bR5cyWYazICO+cEj7tkGWMJzyXNxLf0Ti99MZoElEbV6CxMqnuxXEBfJRpgo1dYpl4lOa5PpifN+LzVsxI7Cnqfc3k7cGAaHsOmKdZk6oXsRMmXDKcU7uW+9vqNxCTQGs4YSOCEdVEYQH+mEgLTAhjjKIaPyK5nxeI3hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023, at 07:04, Baoquan He wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior. So remove the ioremap_uc() definition in architecutures > other than x86 and ia64. These architectures all have asm-generic/io.h > included and will have the default ioremap_uc() definition which > returns NULL. > > This changes the existing behaviour, while no need to worry about > any breakage because in the only callsite of ioremap_uc(), code > has been adjusted to eliminate the impact. Please see > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. > > If any new invocation of ioremap_uc() need be added, please consider > using ioremap() intead or adding a ARCH specific version if necessary. > > Signed-off-by: Baoquan He > Acked-by: Geert Uytterhoeven > Acked-by: Michael Ellerman (powerpc) > Acked-by: Helge Deller # parisc > Cc: linux-alpha@vger.kernel.org > Cc: linux-hexagon@vger.kernel.org > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-mips@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org Acked-by: Arnd Bergmann