From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C3FD2FFE1 for ; Fri, 18 Oct 2024 09:51:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A02596B0092; Fri, 18 Oct 2024 05:51:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B1D66B0093; Fri, 18 Oct 2024 05:51:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8524D6B0095; Fri, 18 Oct 2024 05:51:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 67E956B0092 for ; Fri, 18 Oct 2024 05:51:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1C2BBC1814 for ; Fri, 18 Oct 2024 09:51:42 +0000 (UTC) X-FDA: 82686256296.15.FC2BE48 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id A4C68180012 for ; Fri, 18 Oct 2024 09:51:43 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jQNn36iu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/7HpVTF/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jQNn36iu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/7HpVTF/"; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729245063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FxoA0IWubQTFFZYsZLwFdw69WWfeB5BHrKx5lHw6Xt4=; b=KzBA0Gb6MxYohiO4TV80XUYkYouxxkP23wCuSz6Es27zYLhKso4iGF1STqMsRCE/QfpQHf BC1tEeCGbcE+mvC2/SheXoIP969nHqg3unErx+NGxTnGgYjZ04qBmg1QP1U2gFwSEtLwrB YDTNi8T5pYt9B0krJOpVMoO6wJsgw1g= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jQNn36iu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/7HpVTF/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jQNn36iu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/7HpVTF/"; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729245063; a=rsa-sha256; cv=none; b=cD/tN0fAJmVWrtyLw87gvCC5v0jGbsEK3xVyEfX0WeRxZN8NWF71VVTYid86HnSzcd1psa 7L3DqwX2AWRg+eVB+Fp7PyBTX4niwI7cO16pGWurAdouKDuMnutHrwV6rxAltJDAgwuxpk RgfODcHn51aJyYPxILJHNkGVzb+YCM8= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CFA0C21B5A; Fri, 18 Oct 2024 09:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729245109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FxoA0IWubQTFFZYsZLwFdw69WWfeB5BHrKx5lHw6Xt4=; b=jQNn36iuPUUwCj3oQjt6lu0TVsoXLgkbMGD82EQqHenyzrrIj9FaN+zAPfKA/qlGLSGQzA NB9ew+QcZ0zaU3uZ6CULNe06srxUxp0wGlKICcnzO5y0IBaNmTfjMVVoKWQnWtgUtn8oW2 3SaRI+XJ/1XCT8C5p9JvL9cqaFEQolc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729245109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FxoA0IWubQTFFZYsZLwFdw69WWfeB5BHrKx5lHw6Xt4=; b=/7HpVTF/ESny36ajQiQhdxYXPQJjofaim0rvTUg3/qWp4Hsaofuz9uc3VRGRrL+RjcpPUT RKOdqRuhQUFYYWDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729245109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FxoA0IWubQTFFZYsZLwFdw69WWfeB5BHrKx5lHw6Xt4=; b=jQNn36iuPUUwCj3oQjt6lu0TVsoXLgkbMGD82EQqHenyzrrIj9FaN+zAPfKA/qlGLSGQzA NB9ew+QcZ0zaU3uZ6CULNe06srxUxp0wGlKICcnzO5y0IBaNmTfjMVVoKWQnWtgUtn8oW2 3SaRI+XJ/1XCT8C5p9JvL9cqaFEQolc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729245109; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FxoA0IWubQTFFZYsZLwFdw69WWfeB5BHrKx5lHw6Xt4=; b=/7HpVTF/ESny36ajQiQhdxYXPQJjofaim0rvTUg3/qWp4Hsaofuz9uc3VRGRrL+RjcpPUT RKOdqRuhQUFYYWDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AD9E013680; Fri, 18 Oct 2024 09:51:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qTMCKrUvEmdHYgAAD6G6ig (envelope-from ); Fri, 18 Oct 2024 09:51:49 +0000 Message-ID: Date: Fri, 18 Oct 2024 11:51:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] mm/slub: Improve data handling of krealloc() when orig_size is enabled Content-Language: en-US To: Feng Tang , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Danilo Krummrich , Narasimhan.V@amd.com Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org References: <20241016154152.1376492-1-feng.tang@intel.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241016154152.1376492-1-feng.tang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: k86i8atwjxiod6rfmbxfwywxa9t491qd X-Rspamd-Queue-Id: A4C68180012 X-Rspamd-Server: rspam11 X-HE-Tag: 1729245103-866918 X-HE-Meta: U2FsdGVkX1/M52XsNsV2wGkkdYRln9yJk46loO8Y5e86tPY7KRmVL+m9vMM5oL9AwZKelA+uyabY3ZV380E8hkT0tELNd2YdoonuoVPRClx79nVSRozuZ6yt3icW+gc5CwtQp/OyrwjDVrQ0TFsz4Nc5M90RSB/uafWHfnE14kQtgLu44RbLLdN7j9l0h3wzPTgEHnFfwtbVD5/HfZ+FSSOL841uCQOi+xC/SH5erief0PihemyrCvZ/0T8k5mcmbuOtRpd5hzSkyObUi0YaeshS8V6kdQ60OEKDUNikOIp6E+1BYUS7c7T7Fx4ra4W2dQ5cVF4TLJqYVlSu7ifwrKBBztuGWSSZkHKWeEavNXsYJcTCAcRDn+uOEV0qPtx3Ctb8dYGP8aJiCOp7iPqz2r7OpWwXl/3locmfNjAxsR2ibMbF1IECisyR4Haz2GhTI7g7XfW7gi4Z+BdZJ3/fitnxyZgi0uA2/xm+8oJSUvryxEarazgPxcW33zFUWeL1265qxvX/fK/+CIyaUlYBVrqMnvV0RuVatsM5dXhg54lLJzq+4Jn80i7ANntO2sYDIiAprxWUJK0/X5JzsycVlJaJSHowjWse+2qhXC1Z0K+dFAWI/T+jYvGbgi4rPLgbtODHJpWJDZyXEV/0NV0yjrNCFM09T4b+BDxkhHvY8TPndGYZ2JuZ6V/UWa0DXlcy+eW7G1igaznhRgVM3QvL8IfsfpNUsntman0AFZyCgIYC+49UynYPxFrmDSx4MhxdUQJLNHdCMkYTOYNXM+s5Uc9FE0XUXqrvzqpWeKoDxy8b9JSExj/ec3Pk4+1UYJhCo2JEx2h6ArRHVt+53OIAVnIoBIcwMhGqx5He9xUI/57Ag3ABZ7x8mDxWeEbfBP0jWk4A10ZgR+vp71wpfBqEdI//8AtsTZXorsbb7UaX91ynyGoHlG3sMunibRtXbGEPPE3icpxXhdaomLObGtQ 2xSSg08U wpBl0Gd5ytiRx+RpBFgDK1pWplqjbFOmuQRmyPe1xfAlsnd/r32cdgzFa3/xKKKPGYwTuBL63MAxp9WSc2ZnHuMEfppoc9t+wMjk/gE5Opn79CtH9meR5ojr3fPcZvb+iFKFfDYx+YMX5u0lTDyar3d1+oMlxtwd1wB4K42vJjG64F/E+7+S3NetTaeoYBJsdORvNtcQQ6nx8c1QzoulWh4UF3OCRk9gK+myPMh5+Q2VfObc7hhFpc3YLYOlp0/GDZAhUyuC+TVtUdgZ+oB0dkADsXK38kwC6aZUNs5gdiyOpSuEHwyqo/gLY08FgjL1MBL1eCjTf+b8Zk7V0GP/IHIJeBELgWSiHExcnXf9kbYYy5XHMy78jfLVcA8XV5IfzOi79UPWDVyQM40xVjwDLeoeDnhBE3z5C0RvF3iYE6rhy0j/PCzG5MlDnng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/24 17:41, Feng Tang wrote: > Danilo Krummrich's patch [1] raised one problem about krealloc() that > its caller doesn't pass the old request size, say the object is 64 > bytes kmalloc one, but caller originally only requested 48 bytes. Then > when krealloc() shrinks or grows in the same object, or allocate a new > bigger object, it lacks this 'original size' information to do accurate > data preserving or zeroing (when __GFP_ZERO is set). > > Thus with slub debug redzone and object tracking enabled, parts of the > object after krealloc() might contain redzone data instead of zeroes, > which is violating the __GFP_ZERO guarantees. Good thing is in this > case, kmalloc caches do have this 'orig_size' feature, which could be > used to improve the situation here. > > To make the 'orig_size' accurate, we adjust some kasan/slub meta data > handling. Also add a slub kunit test case for krealloc(). > > Many thanks to syzbot and V, Narasimhan for detecting issues of the > v2 patches. > > This is again linux-slab tree's 'for-6.13/fixes' branch Thanks, added there. Vlastimil > [1]. https://lore.kernel.org/lkml/20240812223707.32049-1-dakr@kernel.org/ > > Thanks, > Feng > > Changelog: > > Since v2: > * Fix NULL pointer issue related to big kmalloc object which has > no associated slab (V, Narasimhan, syzbot) > * Fix issue related handling for kfence allocated object (syzbot, > Marco Elver) > * drop the 0001 and 0003 patch whch have been merged to slab tree > > Since v1: > * Drop the patch changing generic kunit code from this patchset, > and will send it separately. > * Separate the krealloc moving form slab_common.c to slub.c to a > new patch for better review (Danilo/Vlastimil) > * Improve commit log and comments (Vlastimil/Danilo) > * Rework the kunit test case to remove its dependency over > slub_debug (which is incomplete in v1) (Vlastimil) > * Add ack and review tag from developers. > > > > Feng Tang (3): > mm/slub: Consider kfence case for get_orig_size() > mm/slub: Improve redzone check and zeroing for krealloc() > mm/slub, kunit: Add testcase for krealloc redzone and zeroing > > lib/slub_kunit.c | 42 +++++++++++++++++++++++ > mm/slub.c | 87 +++++++++++++++++++++++++++++++++++------------- > 2 files changed, 105 insertions(+), 24 deletions(-) >