From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA5D1C6FD1F for ; Sat, 25 Mar 2023 06:35:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 377D86B0071; Sat, 25 Mar 2023 02:35:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 327926B0074; Sat, 25 Mar 2023 02:35:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F0716B0075; Sat, 25 Mar 2023 02:35:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0F2096B0071 for ; Sat, 25 Mar 2023 02:35:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BC7FFC0112 for ; Sat, 25 Mar 2023 06:35:28 +0000 (UTC) X-FDA: 80606459136.03.60908D9 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf20.hostedemail.com (Postfix) with ESMTP id 67DE71C0006 for ; Sat, 25 Mar 2023 06:35:23 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679726127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0XaCvTfJs131g1ha1Z9TVSjyhWOj4mMct+iMBVg/fSQ=; b=25VeHzhgOumI5lZCniDtxC95BsFM4wO1wSRIAVk5AzZ4XEg099/CKCdL3PND0k+I0wFMe0 DxHokk3qTkdoPzufdDI4J55E/Ai+obuTJACStvzBcPrpCF+5pTwuayVMj4nJCN1YvpjKNg A9vPfIvf5jSF1bi5rQDWsr2EI/1GZCw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679726127; a=rsa-sha256; cv=none; b=L+uOeju14O3MVOBxLUcCsQ9XgpCoPetljlxBx1ZScOJDJ3dDc1Y8BLyWycFzrbJkMSpSaL jCu94FvzSmAeIImTlxp6Ut3uyzbZ5EC6ZnWX17JfaFNIKjvyFuxvjc17oe+10paKaN7LVm 6kdm5CwFTcZmSpZ2TqXogtHPLUy8mx8= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Pk8Pj2Yl7z17Nsw; Sat, 25 Mar 2023 14:32:09 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sat, 25 Mar 2023 14:35:18 +0800 Message-ID: Date: Sat, 25 Mar 2023 14:35:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER Content-Language: en-US To: Mike Rapoport , Andrew Morton CC: Arnd Bergmann , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , , , , , , , , , , References: <20230325060828.2662773-1-rppt@kernel.org> <20230325060828.2662773-3-rppt@kernel.org> From: Kefeng Wang In-Reply-To: <20230325060828.2662773-3-rppt@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 67DE71C0006 X-Rspam-User: X-Stat-Signature: fej4p6w4hkwn5jcnrwy1dya35ra8i4c9 X-HE-Tag: 1679726123-774124 X-HE-Meta: U2FsdGVkX1+5wl+inc94h4BAyBA4e2kKp9EksiXlnHBYoDmeQc/5pTBNne7N4zAkTDbBdPpFMFeH3yqiikkyfxB7meVkBS8XhydDniu+BMBtDCClLyHxaiFWq4zEIDpMuSvDviAv1l45fv1iyCKQkmbI0xkPrsg+9P4f3XeAEWkLtFH0AE6Y7X54TYzT4vVg0MAFFQUw3dkJDefmVZ/yNKu67j7plD1RFVQRiEbM00eFKmnK9gPzGLEaVCbEERodO7IjxGn8CmaPm2hm5XkGGbYlsxUjeIjmu45brmvyPzsmIPy/Eb0SH78cVq87iikrJet9bSpMZOLLz70520lrUB2w5jEI4xpEiNwR9SZnoNJFd4L0lJSXGIsxpkZjBRciVysSeFKqvhem0mXxY4bjfHSg7IvHQQXPHjxcHNZWQ40PzuyCAelFCbSxbEwkHxTVNMck13bN2xHONSfNCTu+4AFVyMUM3kSmHDnHX/fndCRN7El8eMVyvTc0R92ja3L126OqA92Gb2RwvM1Jtfr4TVXCGt1KygX+ISWkfAy+y47t+5db6xktfVuUHqWVvE/FOGZ0lVCZ0VvXTx60gBHtX+MfRqzHU/+ADtKUkhwbUB6xtaaixDc9axxZiLTDzVAj+6QZS1UJLbbqptmmJ5r/ZA7FdMv9vfsVBImTz2sVIkYEuO3Sz9MLRY8oR8UMfGa/osHa6MLauL+AGCCD9BE2k0uf8E+sBXObUs/oHbRrJ3Ml8OXJSMhd/0gIxFAiQxXCFBTvOdOM9E+ouyj+UfiH5jYzfUzvlXVy+EMxv/GmQebdGQ4t1oMgvD1GcZ0OE2jAhueP3nNlWcUa5UEfRmYCYhz4Ovmk/+aPpRW1ok1Gu5txHiyjDVlxhkXqLa+UEivtZF3eZZI4X1T+Haxej5lWg6lDZ9XDrTuPWv9KIJh0DgcscNMGtD6sv1sb0/bzVCIGVAOT3TuNqfM879l3D8l WEhGTWUU f0z5ypDXUhdp3lZrYeZPU/u/yPvZ4TSIwUIblF5ff8STjqohACrCmh5YGxczKY9bEdNSoH3Hr3fJ78WkgJM0/60WYltHZ5lPtij1pOGU/ofT8lgpgc1s1aJDK3N8P2nWD96dG+0U7zJN9jEsm3Iny7PWmU2Z3AJeGbX4/U5hefymryGvn6qfc8eMVjlo+/6eNq2BZOcpN1/Vp5FdDYmScFA6/EGcuzsgcevIyEoL3MafpcyNd8ye0xuYflHtTOHt7wgMSCr1ybkI/pN692Wd43BDg7HygrLQD6UwGDnA++ryBbhZDhsGgHczxKnFuuEHaM50JKIVqDe9BNv7WUXgU5yX/4JFQedmoTLxgm7GoyAUQpPg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/25 14:08, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > It is not a good idea to change fundamental parameters of core memory > management. Having predefined ranges suggests that the values within > those ranges are sensible, but one has to *really* understand > implications of changing MAX_ORDER before actually amending it and > ranges don't help here. > > Drop ranges in definition of ARCH_FORCE_MAX_ORDER and make its prompt > visible only if EXPERT=y > > Acked-by: Kirill A. Shutemov > Reviewed-by: Zi Yan > Signed-off-by: Mike Rapoport (IBM) Reviewed-by: Kefeng Wang > --- > arch/arm64/Kconfig | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index e60baf7859d1..7324032af859 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1487,11 +1487,9 @@ config XEN > # 16K | 27 | 14 | 13 | 11 | > # 64K | 29 | 16 | 13 | 13 | > config ARCH_FORCE_MAX_ORDER > - int "Maximum zone order" if ARM64_4K_PAGES || ARM64_16K_PAGES > + int "Maximum zone order" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES) > default "13" if ARM64_64K_PAGES > - range 11 13 if ARM64_16K_PAGES > default "11" if ARM64_16K_PAGES > - range 10 15 if ARM64_4K_PAGES > default "10" > help > The kernel memory allocator divides physically contiguous memory