From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B632EC61DF4 for ; Fri, 24 Nov 2023 19:41:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 355CD6B0605; Fri, 24 Nov 2023 14:41:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3061A6B0606; Fri, 24 Nov 2023 14:41:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1588A6B0607; Fri, 24 Nov 2023 14:41:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 03E656B0605 for ; Fri, 24 Nov 2023 14:41:05 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CF6CB160655 for ; Fri, 24 Nov 2023 19:41:04 +0000 (UTC) X-FDA: 81493866048.06.67B7BCF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 8FBAF140004 for ; Fri, 24 Nov 2023 19:41:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cmi8JwnF; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700854862; a=rsa-sha256; cv=none; b=ffkJVj1nH+FM1EboLPvDMG/wg0U/SsSkCyT2C4hgtwxzI7mf8XZ6tHylJ3qtMJDXp5Ii1J WO3W/eMxEc3cK4nIoX10/WgkfCHOH3HY5Rq1UGOfKR5hLF8MSQLkw0RGjNv2piDgmcFryQ NdqVZ4UswbNI/BrMgAhYLLYfVu3ZonM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cmi8JwnF; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700854862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l7H6pu8nkSic7rPSXh8wGAQ480LZx0Q6bv1ihMXvDxs=; b=4C3aNASZPq5wTNGykCBAwrSGs0Yo+3TpckmVsY51YZCDLc7Ql3yoMubC4MmkDJjqXsGHhg 1LDtc2C6rsv2QQi6IIOA856YJhdjUoxWkkfDlm5LJSeXPzuK4GCTffrUqHY/6NCHTg2d5r +RuuDXtkM/XqytdZkltq/5qJCnW5ctA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700854861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=l7H6pu8nkSic7rPSXh8wGAQ480LZx0Q6bv1ihMXvDxs=; b=cmi8JwnFJlOjPQmdBDqQemlGTEGXufH3vxEoWO973EuK0V1YiFZHiqcZ3E3+v1fbm5kRex ZKqdDm2+fzWkMW0Tts1gIIgPTTp8NRDqBgeKSni33PQyM/jA5vLUxKlK2Gu2uDy8B7i+dL Ec9IpgQijuvptx4/ivOEVwFLEx3kXrk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-375-ISDQ3TgPNYucvf5niIq5Pg-1; Fri, 24 Nov 2023 14:41:00 -0500 X-MC-Unique: ISDQ3TgPNYucvf5niIq5Pg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40a36dd4a58so12407725e9.3 for ; Fri, 24 Nov 2023 11:41:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700854859; x=1701459659; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l7H6pu8nkSic7rPSXh8wGAQ480LZx0Q6bv1ihMXvDxs=; b=jFTmUkLvmL7qOkNljVuwWTpeSml74C+SZqfO0JdyPIlUROmAP/Ie6DjdAFnywQ4RYt NCmLIMegFsjgfLeHe5aZjtWZoRQ5plS2kSC2JyR9j8INvDNbZRkOg0B2ZmLMhW/ee5Z9 ii8yjUpl+yEFpGXCuTWVDH9U4pqsYgTw7oBSPtc/ZTttc9ztBMz9HkMgFZQaXXlN5dAh r8/v/o+4MR8DHWqlRvVrxaCiWbdQ6qMitANgT6LrxxLXdl/boTR+s6rS0FUbtislLqCK 3YalwOiF0R0/tUZs78gWHAWFBdFkkVlgHOqZYLwxFEGZkT1z+M+js6/aUap7PQkPs2QM A24Q== X-Gm-Message-State: AOJu0Yz1Bppoj2QHZGA8o6DTge2qtq/l75VxXxCx44iz8AV89igcPjX7 q4EXZ8LSaPAsp0Mv33hX4lmrH+V6IfjkNCmyUFM/5GbBZoDCBUWuXapMI3QiVo+Kc/TQH5xU6XL rcI+absTPoDQ= X-Received: by 2002:a05:600c:1c0d:b0:40b:3d92:de42 with SMTP id j13-20020a05600c1c0d00b0040b3d92de42mr1468717wms.8.1700854858878; Fri, 24 Nov 2023 11:40:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHIa0Ag7nDmLb2STet/Q4xvrchyDOT8XsLNG+hJoGxgGenmCCkTOk+e6C/hGzb6XbqyhNhLmA== X-Received: by 2002:a05:600c:1c0d:b0:40b:3d92:de42 with SMTP id j13-20020a05600c1c0d00b0040b3d92de42mr1468683wms.8.1700854858417; Fri, 24 Nov 2023 11:40:58 -0800 (PST) Received: from ?IPV6:2003:cb:c721:a000:7426:f6b4:82a3:c6ab? (p200300cbc721a0007426f6b482a3c6ab.dip0.t-ipconnect.de. [2003:cb:c721:a000:7426:f6b4:82a3:c6ab]) by smtp.gmail.com with ESMTPSA id m18-20020a05600c3b1200b00405959469afsm5921177wms.3.2023.11.24.11.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Nov 2023 11:40:58 -0800 (PST) Message-ID: Date: Fri, 24 Nov 2023 20:40:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 12/27] arm64: mte: Add tag storage pages to the MIGRATE_CMA migratetype To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-13-alexandru.elisei@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231119165721.9849-13-alexandru.elisei@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8FBAF140004 X-Stat-Signature: f735rzebcuuz5ifkebj3stur5rfrn8no X-Rspam-User: X-HE-Tag: 1700854862-410240 X-HE-Meta: U2FsdGVkX199leWNobkhmEgNyWRYUniT9z3IUkD1FrOB4B/Mi4xcOtCqtpZlZIHBZB+7rGqo7e5XnpHhF/FKzjhH6FghBG3aGHX95Jul2FenMuBR5yaKR6nH3z8cOS0D2dTUXskfQD0CczARwL6kKmF3D8UNP3NpPGM7Rb0573GVBGwSjQdG2jF8kLsGdXPH5xuS+A4AUx1n+X8cFQjLqGfPTckS/uArXvjD61SiMPGzjPtYsbk1wgteDbKsv9moOSRXjPFMqm6uHssIxX5ZV3YLGyfjlpAR5Xm4y27S9OR+6wDlV0GfHayPVvr/hhmUvsdVd4j65hpATrYSnX1ZearvqewIqJthU5gTjSYTtuMPwIrwQm1DnrWlFDdLfwtR53kcN3fSdKOeKprrLEk7iYVPQZd4ObV1ambAe4TgGnFUM0BAETzpb7rnQXzgyxDILsmLYPWEt7NCGAnIEF4ESfVT7cgRbTr5DJB5RsAYVFjEQ7LxouXZRupfkjjtPon4GODo5Ir905t7+2S6a0bYq5TOSkCUVmU1d0R+d29Dq2128ZLxAbJ/AKkBjKU1cgzcSx/2NFAcnc+Drwf2hEGxD7D0vcNQxiH8eVW2xFEoRmgZxZQBXl8njtKC+RjjChTg0T+5I8CzpvM/ub0cYo1rpFnHDSWdHuhvD2ibRvN6fdGlxy9Ys7lMLgCIVaWT2CKzorEIm3v2YKLWGVREeDUgoFj/6A986jIPdL1Apx8h+F9zkuwP7CZ/NLlYbP1WGsPrC4OLhoAwFiX+GrOofb/S0Hifycr384KYmYhZKu7jJ3fBYqM17dCfujnxZj90C+X09X+odWTzIEpHQ+4NatUHddb07OgG9qX4MJMOyAy6zh7XylqWbiG+jXAPP8Tp8kmqI5b/Yak3QMy6siZXXOi/aOWL34ElUNtkY9n/a2fvWwx2RpCF7usMj0G/p1DY1tzsNP4Wb1LCRIxsLfB9nDF A8OnxhMq cl/7T9T/hRm2+TqY/tpaMugd9ftb75LWvJfiEr0wJHiadzltxrvSrpYqcYAK+CG6aJns78ay9FjyqyCVt7u1g4x3F1NHZ+pXJ6tPpoMOaqiK4DBiFELDtECHpdlqp7/0Ef/eXuprxIGORKfwrEQtdz40EdKL/yyzq8tjaccQucGjUCCXEqltTWQIzunw8cSJSgjLBkKXhZqKQV1iQfPMR3G/4czwYHyUgsjrZdnr09TKhkICb86I6ZFGzNcyOtPL34/W9JBEvhFB+JbXvNDOqlQxj9akFrn5T7S+rwPWlN8vfEyOjOhIO6n/Io0lwPIMnKnnuOJczS1lgwZAlld0dl4ZmST4ywhlSnl6OkeFGLQgxwPEtktYrt8gZxgRl7OUE6ffr7vOgdZGZwNirG/oQzsWzUmt9zGoxHqAfntOQOpVyHbPM8gO1hDG8vN0wixU0iLqZw4bLaGbLfBQIqpud+DxnKfZ6ThKORKmDj3fYkbnz7fYXpGSWdjvsDUmhEUkvz7FUrS7zaGqEQ76do5OvfW7ymQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.11.23 17:57, Alexandru Elisei wrote: > Add the MTE tag storage pages to the MIGRATE_CMA migratetype, which allows > the page allocator to manage them like regular pages. > > Ths migratype lends the pages some very desirable properties: > > * They cannot be longterm pinned, meaning they will always be migratable. > > * The pages can be allocated explicitely by using their PFN (with > alloc_contig_range()) when they are needed to store tags. > > Signed-off-by: Alexandru Elisei > --- > arch/arm64/Kconfig | 1 + > arch/arm64/kernel/mte_tag_storage.c | 68 +++++++++++++++++++++++++++++ > include/linux/mmzone.h | 5 +++ > mm/internal.h | 3 -- > 4 files changed, 74 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index fe8276fdc7a8..047487046e8f 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -2065,6 +2065,7 @@ config ARM64_MTE > if ARM64_MTE > config ARM64_MTE_TAG_STORAGE > bool "Dynamic MTE tag storage management" > + select CONFIG_CMA > help > Adds support for dynamic management of the memory used by the hardware > for storing MTE tags. This memory, unlike normal memory, cannot be > diff --git a/arch/arm64/kernel/mte_tag_storage.c b/arch/arm64/kernel/mte_tag_storage.c > index fa6267ef8392..427f4f1909f3 100644 > --- a/arch/arm64/kernel/mte_tag_storage.c > +++ b/arch/arm64/kernel/mte_tag_storage.c > @@ -5,10 +5,12 @@ > * Copyright (C) 2023 ARM Ltd. > */ > > +#include > #include > #include > #include > #include > +#include > #include > #include > #include > @@ -189,6 +191,14 @@ static int __init fdt_init_tag_storage(unsigned long node, const char *uname, > return ret; > } > > + /* Pages are managed in pageblock_nr_pages chunks */ > + if (!IS_ALIGNED(tag_range->start | range_len(tag_range), pageblock_nr_pages)) { > + pr_err("Tag storage region 0x%llx-0x%llx not aligned to pageblock size 0x%llx", > + PFN_PHYS(tag_range->start), PFN_PHYS(tag_range->end), > + PFN_PHYS(pageblock_nr_pages)); > + return -EINVAL; > + } > + > ret = tag_storage_get_memory_node(node, &mem_node); > if (ret) > return ret; > @@ -254,3 +264,61 @@ void __init mte_tag_storage_init(void) > pr_info("MTE tag storage region management disabled"); > } > } > + > +static int __init mte_tag_storage_activate_regions(void) > +{ > + phys_addr_t dram_start, dram_end; > + struct range *tag_range; > + unsigned long pfn; > + int i, ret; > + > + if (num_tag_regions == 0) > + return 0; > + > + dram_start = memblock_start_of_DRAM(); > + dram_end = memblock_end_of_DRAM(); > + > + for (i = 0; i < num_tag_regions; i++) { > + tag_range = &tag_regions[i].tag_range; > + /* > + * Tag storage region was clipped by arm64_bootmem_init() > + * enforcing addressing limits. > + */ > + if (PFN_PHYS(tag_range->start) < dram_start || > + PFN_PHYS(tag_range->end) >= dram_end) { > + pr_err("Tag storage region 0x%llx-0x%llx outside addressable memory", > + PFN_PHYS(tag_range->start), PFN_PHYS(tag_range->end)); > + ret = -EINVAL; > + goto out_disabled; > + } > + } > + > + /* > + * MTE disabled, tag storage pages can be used like any other pages. The > + * only restriction is that the pages cannot be used by kexec because > + * the memory remains marked as reserved in the memblock allocator. > + */ > + if (!system_supports_mte()) { > + for (i = 0; i< num_tag_regions; i++) { > + tag_range = &tag_regions[i].tag_range; > + for (pfn = tag_range->start; pfn <= tag_range->end; pfn++) > + free_reserved_page(pfn_to_page(pfn)); > + } > + ret = 0; > + goto out_disabled; > + } > + > + for (i = 0; i < num_tag_regions; i++) { > + tag_range = &tag_regions[i].tag_range; > + for (pfn = tag_range->start; pfn <= tag_range->end; pfn += pageblock_nr_pages) > + init_cma_reserved_pageblock(pfn_to_page(pfn)); > + totalcma_pages += range_len(tag_range); > + } You shouldn't be doing that manually in arm code. Likely you want some cma.c helper for something like that. But, can you elaborate on why you took this hacky (sorry) approach as documented in the cover letter: "The arm64 code manages this memory directly instead of using cma_declare_contiguous/cma_alloc for performance reasons." What is the exact problem? -- Cheers, David / dhildenb