From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59595C36010 for ; Fri, 4 Apr 2025 16:56:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D36B66B0008; Fri, 4 Apr 2025 12:56:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0D3E6B000A; Fri, 4 Apr 2025 12:56:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD4EC6B000C; Fri, 4 Apr 2025 12:56:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9F9496B0008 for ; Fri, 4 Apr 2025 12:56:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 24EA2C056E for ; Fri, 4 Apr 2025 16:56:40 +0000 (UTC) X-FDA: 83296965360.21.C2B1962 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf27.hostedemail.com (Postfix) with ESMTP id B680240012 for ; Fri, 4 Apr 2025 16:56:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KYgTyC9y; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743785798; a=rsa-sha256; cv=none; b=u9MkzhEIL8vJhnzgOatMd4ycE25d9pkTU29+KuqfEsyk5cKNzPB5YCkNOKj6OsmK0UdUbn TLkgI6TOWU3O/gZjclkZrQp6CaaHWmdgyIH1hIqZP+PEMUxPS2bMKebRAC8SsM88rTFUvY ggotQfUygiARUIXK8QEE4SfvW8Ok248= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KYgTyC9y; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743785798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZECnDiub07zAGiJebytNOBSlRftv//2dV9FqWXMpaB8=; b=Twv6kBfUyOq2Ohrd9xIW0Wqj62xOGeR9FQqO75l0dzSJ0tnt0pbSDn6rik/NsT+RYLMhKF KEWIRYqQbULQlqKz3eG/iYsHCf7JbaQ58jJ5wnI6KfKJjH+4VmRej/WVhJM07iGHMKPBCn yukxLlUlYtnM2tnJVvryiwrIMtCf0bo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743785798; x=1775321798; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=uSI/mNDOWuv8z6wXM4ATudMQnMeI2qrBbdXzg2XE6UM=; b=KYgTyC9yLwEzfNVDW0NT/L6DMb+ynxK1z1J6ZkxnjgNcJLUkRMDfVGFR xyTGqv08NXIgsO8x681lTQJCajogsHT7Wf061XxfZLIAZkdx3mT3+50uS 5kSZehNDKi5qFajz1LnQRhV5jr0/ruilTH9q3wKKbnl1LvbYvwnNnxzQK QCgsYxNYwaRTbXfn9HDsCJ8RAoLWAdk4geViFkUYbdi2W3NfeQ+3BTIwS Le/BceXlRePKs+PaiInZEDcf/1PeL7vA20riYnMexEnr4A/+fOGp0VOUX 71FbpQq3HoAKO0UwzmifKpKATULosyx4hbNmFvEtHLLmiS0RBK4apK/jI A==; X-CSE-ConnectionGUID: b/8O+f6KRiGeTWJOxPrkSw== X-CSE-MsgGUID: fb4iQ8TiQDqFGUwbm8HErw== X-IronPort-AV: E=McAfee;i="6700,10204,11394"; a="47944701" X-IronPort-AV: E=Sophos;i="6.15,188,1739865600"; d="scan'208";a="47944701" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2025 09:56:36 -0700 X-CSE-ConnectionGUID: Y7QpnuiMSQu9Veya9py4Qg== X-CSE-MsgGUID: 5LEvsRX7R6CbR5uFxiPhsQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,188,1739865600"; d="scan'208";a="127875138" Received: from daliomra-mobl3.amr.corp.intel.com (HELO [10.124.223.29]) ([10.124.223.29]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2025 09:56:33 -0700 Message-ID: Date: Fri, 4 Apr 2025 09:56:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/14] x86: Physical address comparisons in fill_p*d/pte To: Maciej Wieczor-Retman , hpa@zytor.com, hch@infradead.org, nick.desaulniers+lkml@gmail.com, kuan-ying.lee@canonical.com, masahiroy@kernel.org, samuel.holland@sifive.com, mingo@redhat.com, corbet@lwn.net, ryabinin.a.a@gmail.com, guoweikang.kernel@gmail.com, jpoimboe@kernel.org, ardb@kernel.org, vincenzo.frascino@arm.com, glider@google.com, kirill.shutemov@linux.intel.com, apopple@nvidia.com, samitolvanen@google.com, kaleshsingh@google.com, jgross@suse.com, andreyknvl@gmail.com, scott@os.amperecomputing.com, tony.luck@intel.com, dvyukov@google.com, pasha.tatashin@soleen.com, ziy@nvidia.com, broonie@kernel.org, gatlin.newhouse@gmail.com, jackmanb@google.com, wangkefeng.wang@huawei.com, thiago.bauermann@linaro.org, tglx@linutronix.de, kees@kernel.org, akpm@linux-foundation.org, jason.andryuk@amd.com, snovitoll@gmail.com, xin@zytor.com, jan.kiszka@siemens.com, bp@alien8.de, rppt@kernel.org, peterz@infradead.org, pankaj.gupta@amd.com, thuth@redhat.com, andriy.shevchenko@linux.intel.com, joel.granados@kernel.org, kbingham@kernel.org, nicolas@fjasle.eu, mark.rutland@arm.com, surenb@google.com, catalin.marinas@arm.com, morbo@google.com, justinstitt@google.com, ubizjak@gmail.com, jhubbard@nvidia.com, urezki@gmail.com, dave.hansen@linux.intel.com, bhe@redhat.com, luto@kernel.org, baohua@kernel.org, nathan@kernel.org, will@kernel.org, brgerst@gmail.com Cc: llvm@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, x86@kernel.org References: <926742095b7e55099cc48d70848ca3c1eff4b5eb.1743772053.git.maciej.wieczor-retman@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <926742095b7e55099cc48d70848ca3c1eff4b5eb.1743772053.git.maciej.wieczor-retman@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B680240012 X-Stat-Signature: sbh7hoqs1nza1hny9ks97y48c8pysquc X-HE-Tag: 1743785797-393387 X-HE-Meta: U2FsdGVkX193/P7+l36n+0TX0Jpf9KAzaCecBafxvfod33no3LQ4STUdgzdIhGoEFVVbgEa2xmt/NpVhIyyO9mCQHVEn7LAQ32sEt+sCJ++6Rtm4fhTBFNnNd5FTzr2MoYszQnbG/k+N1gZR+BAR5t7eFQs3MZ3dohoXioM3cZ6d2rxBSJ99uguZgyG4GVeEtIK88n4rco7ss8rZcVZesAwsS7mEMHmcAFEPoDKN3QOUf1v/ZUxL6Bo8eIGJ2ClfOd2D1ly9OR0ki7eqB5/k5frK9G8j4bby3BJZchYFc9ZSJ8xHfitVbDGgxHVK66OTJ6v/0ZLJ+ROP1/YB6k9MV7sM/ETpk10se8O7cAVqi2865IwNlqkawqbkBXUg1kTv1dsBdDx7cGoEFam6jCGTRsvRFO8gtWvkegMAK4o5gdq+LWgFMmy9Ix5CFrXYnAtjqTTkHTAAK7Bmp+AADLtePrAOoYiVU6SOB4nPT31UZuPFR1DXgIQI91xlfdl0TGl6Vp5cPgpxRYyNIRAtH1BesEU1W5ordtMhG+LDmPNdYumUbifbKrN0T66vXvsqm9R0H9O1jJ/qW3CN04Jd1R66EM8odVcEdlK/nw38Al+st2Ai/4Xll0r1HsU+w33ot73Q74x1WH2uVPVmi4LOiQ5O+Z/xK9/PCfdRGFRpKtkKv+sh4fajB0k3dkz3qQYs+E9mO/T9M6HmhdKYNqb2s9CPFdQEyup6tQ4/yEHlRBNudLcMelNrjfL5yzE9W2cELdKTKsCBcYXqtFnPtk3qALerALZ+K2PWYS+5EHOmAOh0huFg1SeMwsEVAuuQxI1eeiJN5N8KlVh23NsBBpZy6WFYJlVNwIuWJxsaFLmxniwxFL7roEdrPCpWrmPQXQDW5OdfSNd83mORm+942fR0QaaD0hIBLduCFoad+f2F/zeUL+O9QrKN4GPAqdP5W7hTFDBMg4D7ufC9K+ffx+dWGQQ CESE2EnC vo8qPPbQ+WcqIo9MMAO0LX3+cPqU8ZOvFs1TuqScsFxTQRDsFzY6YYJBltcGIlxraREQfghFJ01V0yQT4VycmKQCdbIMqdZNR1bSdBA6bKrPvIAv9vwMfRAWoAo7Zr3JkabQcaBPj9yIP/fTmy3l5yLRzRly8Ebwz0fwoLK2qSbLyY1cgvq5PKglxAfKdBCs2m0GpstUQEjNrdkNH2+9TOP4FmeiM5kZApglV5QbDv8amf14dmQZ4kQgigN5wf9Lc75BT/rseoM+uK4t9P3AruUfwBuR0F2J2flBBRo3eP/DUQm3caiK51JFh0TVwJsusjdfLFXQYG5TrkQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/25 06:14, Maciej Wieczor-Retman wrote: > + if (__pa(p4d) != (pgtable_l5_enabled() ? > + (unsigned long)pgd_val(*pgd) & PTE_PFN_MASK : > + __pa(pgd))) > printk(KERN_ERR "PAGETABLE BUG #00! %p <-> %p\n", This one is pretty fugly. But I guess it's just one place and it probably isn't worth refactoring this and the other helpers just for a debug message.