From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C1EC41513 for ; Tue, 1 Aug 2023 19:22:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FBF72800F0; Tue, 1 Aug 2023 15:22:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AC9C2800C8; Tue, 1 Aug 2023 15:22:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 373A62800F0; Tue, 1 Aug 2023 15:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 27BBB2800C8 for ; Tue, 1 Aug 2023 15:22:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E85DC120654 for ; Tue, 1 Aug 2023 19:22:03 +0000 (UTC) X-FDA: 81076506126.06.4D37650 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by imf05.hostedemail.com (Postfix) with ESMTP id 6AA5510000F for ; Tue, 1 Aug 2023 19:22:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690917721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AiVX7lmk7YHTzndLDWnoOHwTkgXpMySSwVOQ4qPXS9I=; b=8rIIJ1YcAbM6cSROlFPoULqDBw7bagBbgtP+/EsG6KSa2szJ+C8ZYe2SPZ9lVvsDkk2urh DKs0hcsmeYoqUc6CHGvRv7CgEfBBKn7GtooAGOkVdffKmC2m+6xCayB5ZTINm0AwtyE3Jz a8k8aorXf9yM2ZSOzyayutDbX+7oPuI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690917721; a=rsa-sha256; cv=none; b=63UckgleqDMuSUU0pX0q3uKcRTPMlH5sfTsMcfAVDFCn5gHfjWIpylY7ELskE8uQ4o9+pV Z37AJR9xCKjwuIcQ5JtK5QcXae86KtxJH/fW39pGgVW495cGcGYAcG1fXAoFtHIAfAygYf K7anPTZCTfVTi57xluVCnm25eYcYzmQ= Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qQuwF-001bwY-Bp; Tue, 01 Aug 2023 21:21:47 +0200 Received: from p57ae5424.dip0.t-ipconnect.de ([87.174.84.36] helo=suse-laptop.fritz.box) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qQuwF-001Voi-33; Tue, 01 Aug 2023 21:21:47 +0200 Message-ID: Subject: Re: [PATCH v8 11/19] sh: add including From: John Paul Adrian Glaubitz To: Arnd Bergmann , Geert Uytterhoeven , Baoquan He Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Christophe Leroy , Mike Rapoport , Matthew Wilcox , Alexander Gordeev , Kefeng Wang , Niklas Schnelle , Stafford Horne , David Laight , Helge Deller , Nathan Chancellor , Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Guenter Roeck Date: Tue, 01 Aug 2023 21:21:45 +0200 In-Reply-To: <09094baf-dadf-4bce-9f63-f2a1f255f9a8@app.fastmail.com> References: <20230706154520.11257-1-bhe@redhat.com> <20230706154520.11257-12-bhe@redhat.com> <0f771b11539d5a3871691af901315ee2034b577c.camel@physik.fu-berlin.de> <09094baf-dadf-4bce-9f63-f2a1f255f9a8@app.fastmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.174.84.36 X-ZEDAT-Hint: PO X-Rspam-User: X-Stat-Signature: yout65pzk8uerxg4pxqei9gae8fsgrx4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6AA5510000F X-HE-Tag: 1690917721-592449 X-HE-Meta: U2FsdGVkX19/qsm8vqfBDcVhIrjAZZxpfJ13hpCA3d6pfRVgo1xKgySLc1Dyva2mWT3wi8SdgaEttUSal/YgQPmfhOnxX1azcK1Hj53J6QbIa8W4UgWTqfVaFH9/WBtvOZiCa2qeZTbTw2bAsA8JtjKdBh7XE1ASmmrz7w0KygY4VU5Wy7C6L7Bb2c8dWKJ1wy5mA8myrkIUQnoSQPJk6xJi9h3gLi3kQJhZxUNZc6AnfWCWKPd0wjM9C618l244uSLebmubngxkbjR6i0XmsC//qZNoNTA6nRgdXkfxCpCbr1o6wqZEiHblRL8jR4vTyU02Hwgc2/Pa5koJHNjl8f/nxHqcHfr165ZJsm5bwTWy8oSuxTOxa9bih31JbstITTmTBsL4rQbbiBoYOezkA9tdXvdpVnwLUgBt8+YUgLY5GTmWinPQVKNwZzp0n8BxcOcWdcKEfywnLZiWaCuWXS0MBa8MmjEPS3SO7Rnm3ezZeNHpEcihucGHkohcxfmRCbCljpe9nhG+UWgYeOGBz0e+rvuPJ3vYlPPHh9WawkXqHLa+HgQ1PuqL3mLYPvFaGuQ8+hnIJMJq57M/Iuva+1GkNGSceVK2hHBRpu3+lJ/mKEypyGtdHvTEHOwejkdWbh4cmDJbgCC4vaDI2fy1K+LBP7IPfF84ezI64odHrOxA41M8Yh1jv0Rcmx/IU9o89a+LdZph8weS/f/7AySPPftH4PpNWwJg6GAjr24VWacHazYH/GqpG2SgGdBbMVrGyFwF+eKRl48Fep6wY58nRflxw5i/hX6Qrxb4i4OMbVco+pwfriVlS1qXiqQIz04nWVgNStMItEHNdLVpc3GBuu6k057Q0PVFYv4ISP8c4dv1AA6fEsXUhjZCit2j1PlJDPjep57UTBTCiqaWjmXXLlYIf1O7n7Jud5nidpcXdPuI8TZl7oPvendQsPPPWHXhj0qyGuYsbeeN7MH8iS5 IHp802Fc bvU/PeDThRXznp+wZ4pY4U1qG4546uCSarJtbezJxw3NmXEzN7mtw3z8gbAgXxoiWHc00KuzxRJkerpHQZdTHPrVBo7lYRRCdAbgtmmp43ZLD/AnBRfmIszlAFxltGKMEtTfYT1UIIVAhzEw/gBxIvpik9fb+r8r+y+1/uc9svxONQkNvgSCA57MZnfjkx2+c53wNZT8/kmY8pMsgTa8VSrfEhTGjaRVQVKlBInxGaIbhEGAkdnInvcZ2OkwvTUlKWR4ybwRXu9urbL3D9T55xfp7Uw0mUNnHEWHG8VvEyAQccIxe7vc3ooDNAbKawkKLUvKt7X66v89OE4g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Arnd! On Mon, 2023-07-10 at 12:47 +0200, Arnd Bergmann wrote: > It looks like only the "noioport" variant got some of the > extra macro definitions, but the version for PCI still needs the > same six macros, plus the ones of inb/outb etc, something like > this: >=20 > diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h > index 24c560c065ec7..2135e32145c54 100644 > --- a/arch/sh/include/asm/io.h > +++ b/arch/sh/include/asm/io.h > @@ -241,6 +241,26 @@ __BUILD_IOPORT_STRING(q, u64) > =20 > #endif > =20 > +#define inb(addr) inb(addr) > +#define inw(addr) inw(addr) > +#define inl(addr) inl(addr) > +#define outb(x, addr) outb((x), (addr)) > +#define outw(x, addr) outw((x), (addr)) > +#define outl(x, addr) outl((x), (addr)) > + > +#define inb_p(addr) inb(addr) > +#define inw_p(addr) inw(addr) > +#define inl_p(addr) inl(addr) > +#define outb_p(x, addr) outb((x), (addr)) > +#define outw_p(x, addr) outw((x), (addr)) > +#define outl_p(x, addr) outl((x), (addr)) > + > +#define insb insb > +#define insw insw > +#define insl insl > +#define outsb outsb > +#define outsw outsw > +#define outsl outsl > =20 > #define IO_SPACE_LIMIT 0xffffffff > =20 > diff --git a/arch/sh/include/asm/io_noioport.h b/arch/sh/include/asm/io_n= oioport.h > index 5ba4116b4265c..12dad91f41c1e 100644 > --- a/arch/sh/include/asm/io_noioport.h > +++ b/arch/sh/include/asm/io_noioport.h > @@ -46,20 +46,6 @@ static inline void ioport_unmap(void __iomem *addr) > BUG(); > } > =20 > -#define inb_p(addr) inb(addr) > -#define inw_p(addr) inw(addr) > -#define inl_p(addr) inl(addr) > -#define outb_p(x, addr) outb((x), (addr)) > -#define outw_p(x, addr) outw((x), (addr)) > -#define outl_p(x, addr) outl((x), (addr)) > - > -#define insb insb > -#define insw insw > -#define insl insl > -#define outsb outsb > -#define outsw outsw > -#define outsl outsl > - > static inline void insb(unsigned long port, void *dst, unsigned long cou= nt) > { > BUG(); I am fine with this fix. Acked-by: John Paul Adrian Glaubitz > I think ideally all the I/O port stuff in arch/sh/ could just be > removed after the conversion to asm-generic/io.h, but the > microdev_ioport_map() function oddity gets in the way of that, > unless someone wants to clean up that platform. As far as I > can tell, the ethernet, display, USB and PCI devices on it already > broke at some point (afbb9d8d5266b, 46bc85872040a), so it might > be easier to remove it entirely. I don't have this particular hardware, so I cannot comment on this. > > I'm not happy though that this patch is in linux-next without being Ack= ed by me > > or being reviewed by anyone. We should always make sure first that the = code > > actually builds and has been tested on real hardware. >=20 > I think that if the series has been posted eight times, you had > your chance to do a review, especially since I pointed out that > merging this one would have avoid the unxlate_dev_mem_ptr() bug > as well. I have only been the maintainer of arch/sh for a few weeks, so it's natural that I am not doing a perfect job and might miss something. Also, I am not getting paid for this work, I am doing this in my free time. > Having the series go into linux-next sounds appropriate like this, > the entire purpose of that is to find such bugs and Andrew can jus > fold the fixup into the broken patch.=20 >=20 > Let me know if you prefer the simple version with the extra > #defines or if we should just use the generic inb/outb implementation > immediately and drop microdev in a separate patch. Please go ahead with the simple version. Thanks, Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913