From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFDAC021B8 for ; Wed, 26 Feb 2025 08:44:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02D2A280008; Wed, 26 Feb 2025 03:44:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1FBD280007; Wed, 26 Feb 2025 03:44:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC08D280008; Wed, 26 Feb 2025 03:44:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BCE50280007 for ; Wed, 26 Feb 2025 03:44:39 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 433A01A0F70 for ; Wed, 26 Feb 2025 08:44:39 +0000 (UTC) X-FDA: 83161459878.25.CBAE0D8 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by imf17.hostedemail.com (Postfix) with ESMTP id 3130D40012 for ; Wed, 26 Feb 2025 08:44:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=amazon.co.uk header.s=amazon201209 header.b=Lj45Fsga; spf=pass (imf17.hostedemail.com: domain of "prvs=14584be8e=roypat@amazon.co.uk" designates 72.21.196.25 as permitted sender) smtp.mailfrom="prvs=14584be8e=roypat@amazon.co.uk"; dmarc=pass (policy=quarantine) header.from=amazon.co.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740559477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=12yv0TKYhFE27VJGLR2M6EZlfXB9G3C2ZSi56M7sI+I=; b=H5qG/kxJquwHEMkz02BoFcsxQXP5M1Dd7FvTD13W+viP/RUdYSyGWNXEMX/I7GXMfWdhJy DVx/zRYZXawz0v3eFTniuU/b9B41ccTOb3SnWjo9eQPKs4/NYl/XtTxs46VTralVUs6jFp T32zAbEZX0Y8kQcLACd++r424SU4zMM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=amazon.co.uk header.s=amazon201209 header.b=Lj45Fsga; spf=pass (imf17.hostedemail.com: domain of "prvs=14584be8e=roypat@amazon.co.uk" designates 72.21.196.25 as permitted sender) smtp.mailfrom="prvs=14584be8e=roypat@amazon.co.uk"; dmarc=pass (policy=quarantine) header.from=amazon.co.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740559477; a=rsa-sha256; cv=none; b=arqKrinDkTdfNMjBbzExTW5YIY28wHL9LOO+L8XJPo4ZA3M+sQ6C4zyK8FjX+AHnsGPF9Q VSnDfKQMaB0KYRZCESg/dREN/N7PaBZJDJysRQt10P1byC0KoRbK7OtFkjWJ+JLbM6Hn5f gEUB/GHQC2Tk++Vxz4YyvcVCn0IlhOI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1740559477; x=1772095477; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=12yv0TKYhFE27VJGLR2M6EZlfXB9G3C2ZSi56M7sI+I=; b=Lj45FsgaF56Ye9+gd7w2tH2EXlhe2fYJ2I5X2LUK1BynKn7FkxG4ok7i GiTXmX1Ed3aDjj0aq9laDeH3uRaLHmnqMoat4X2nSKQkR1j48YSF9jCSJ M4ctwJAr2xt3ka1P+zMDIQ4HQ3iMQhdncfLUoU+3ESGgwy6aGWX/tBpvJ A=; X-IronPort-AV: E=Sophos;i="6.13,316,1732579200"; d="scan'208";a="470078821" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 08:44:31 +0000 Received: from EX19MTAUWC002.ant.amazon.com [10.0.21.151:34974] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.7.176:2525] with esmtp (Farcaster) id dc3e5d47-4ff6-4e54-90f4-b1104b684e2a; Wed, 26 Feb 2025 08:44:30 +0000 (UTC) X-Farcaster-Flow-ID: dc3e5d47-4ff6-4e54-90f4-b1104b684e2a Received: from EX19D003UWC001.ant.amazon.com (10.13.138.144) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Wed, 26 Feb 2025 08:44:29 +0000 Received: from EX19MTAUWB001.ant.amazon.com (10.250.64.248) by EX19D003UWC001.ant.amazon.com (10.13.138.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Wed, 26 Feb 2025 08:44:29 +0000 Received: from email-imr-corp-prod-iad-all-1b-af42e9ba.us-east-1.amazon.com (10.25.36.214) by mail-relay.amazon.com (10.250.64.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 08:44:29 +0000 Received: from [127.0.0.1] (dev-dsk-roypat-1c-dbe2a224.eu-west-1.amazon.com [172.19.88.180]) by email-imr-corp-prod-iad-all-1b-af42e9ba.us-east-1.amazon.com (Postfix) with ESMTPS id 6C410406C3; Wed, 26 Feb 2025 08:44:24 +0000 (UTC) Message-ID: Date: Wed, 26 Feb 2025 08:44:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/12] mm/secretmem: set AS_NO_DIRECT_MAP instead of special-casing To: David Hildenbrand , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20250221160728.1584559-1-roypat@amazon.co.uk> <20250221160728.1584559-3-roypat@amazon.co.uk> From: Patrick Roy Content-Language: en-US Autocrypt: addr=roypat@amazon.co.uk; keydata= xjMEY0UgYhYJKwYBBAHaRw8BAQdA7lj+ADr5b96qBcdINFVJSOg8RGtKthL5x77F2ABMh4PN NVBhdHJpY2sgUm95IChHaXRodWIga2V5IGFtYXpvbikgPHJveXBhdEBhbWF6b24uY28udWs+ wpMEExYKADsWIQQ5DAcjaM+IvmZPLohVg4tqeAbEAgUCY0UgYgIbAwULCQgHAgIiAgYVCgkI CwIEFgIDAQIeBwIXgAAKCRBVg4tqeAbEAmQKAQC1jMl/KT9pQHEdALF7SA1iJ9tpA5ppl1J9 AOIP7Nr9SwD/fvIWkq0QDnq69eK7HqW14CA7AToCF6NBqZ8r7ksi+QLOOARjRSBiEgorBgEE AZdVAQUBAQdAqoMhGmiXJ3DMGeXrlaDA+v/aF/ah7ARbFV4ukHyz+CkDAQgHwngEGBYKACAW IQQ5DAcjaM+IvmZPLohVg4tqeAbEAgUCY0UgYgIbDAAKCRBVg4tqeAbEAtjHAQDkh5jZRIsZ 7JMNkPMSCd5PuSy0/Gdx8LGgsxxPMZwePgEAn5Tnh4fVbf00esnoK588bYQgJBioXtuXhtom 8hlxFQM= In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 7jabstcisix8ckocuhhgamomhdj1gmz3 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3130D40012 X-HE-Tag: 1740559477-834987 X-HE-Meta: U2FsdGVkX1/Fe2lUocBAtAb+/fpf0fbtEZPpEvMeWqRmGZ7ScW/2korJD65IMSUOBMQPzFAPSzGbXp9GA/61UM4Bkm/YCHcLu69nKDvUHRiSE9IvsyNspEBx4JLg8YhZ3f3ixL1OGjeY94+giK+DDnXrEtsPmXc5g95guV/YQyhyHnM3S8PzuSZwx/g8jFWQ8ZHby7jpIb/Y8e17LMUUsg11Jzq318acJvbI25a1PD1nk6HI5cti3Czy2RkCvmJ/dCTZgoz6iygfSsqXoeLrlNp46qn+mCrH37vI/iAcbfo21uFl9wdIcLKCy0jomowasoa7As+Jyj7H4ZURTh4B6YY+7PD1aKWcx2GpUgHl+4HX5QZMhLQaHEmcRtB5VCx79iifFM5r3SNDLzJ7/qtM4GYgtUFxTtkG54C127Zmkmu2JQ4lXa+fSjXYKYNlLsdoS/2xYBF6GOafQRjEMs1TBElEBderuTcP+BTwX/DzVM1nI2aNlGP0+HoJ1tTqDywrChlGAarkV/XGPP9xZIp7ld8ReZCnb/FV7J/4M00YgtgwxQVEkQu/N78es6rqZZsNhCbU6MkPMpG8lsnGcUS3fuwlcDJkBgjqoxr/sC/84rqLPvKC0mM2kIgO1pfMFnKFbvsaTOZhZ/g6mD09z7nGuOFsX4oNDXPYaYiK3qofs4jsQHqRVVkzTpd3jyCjoRw1aM/ZvHbZZ+VO+euTAhQomk6fX0OJkUGspoRCE0jkenZaGKxPadyQyh2JhLf3ALq9wI98Yqt1T8NqSkK16qyolr+KV5b22VT+2AZLIw0Ck3WuMlG/fUEQmIrJu44ZG+TjnF9mQAqLLO+SCxCDs7qiX+e+Eo/5iQN6YdrwB09iVX1TVZd/mlGGwKQ4XveuM8qse4AKtO6VdxMGCBIumA9Hjg31iV3DW2IC6qrL5FjP9qcdA3+8JGEwYRYgynk4fwGt/jrm6NmzNhPc/JQ43pT 67L/Su0g M08yqhzd7rteOIa/w+Hk7SFNDy+L/C7l90N/UklKlU1mfPhMDz3JUH0OwdpkcoKOl/1gmoulzWMf5SGiD34DPpiXM0z3Et+ZKAZj9qio8lBoG21dnHjjeBbgmjpN7Oe51XIf0O9jXWPlXdmz+RcfiN1TfE0Z+V6u72pO0aM/ckXtxE7SWq3Xg9R2bZi8+mnxAEw7V/sY/10e6IcoH2l0qmaysqISHmabbE9oLwnC0mnr/AH1UMclk1/9Dgr/aHZvgdBmtQA/F8uyfRpBD8JDw3+r1gnSDJ4XRfxN0PRuTcefHcyyxN9IPqNdwZ+BCAt5FDquNV5cWrJ1lUx50RHjxEBP3ohxxYKv++86etKJedarnJZzXgnS4scZ3R+KXqKVxiWBivwm81Suk0GxMFw4hUOGUvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000303, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2025-02-25 at 16:52 +0000, David Hildenbrand wrote:> On 21.02.25 17:07, Patrick Roy wrote: >> Make secretmem set AS_NO_DIRECT_MAP on its struct address_space, to drop >> all the vma_is_secretmem()/secretmem_mapping() checks that are based on >> checking explicitly for the secretmem ops structures. >> >> This drops a optimization in gup_fast_folio_allowed() where >> secretmem_mapping() was only called if CONFIG_SECRETMEM=y. secretmem is >> enabled by default since commit b758fe6df50d ("mm/secretmem: make it on >> by default"), so the secretmem check did not actually end up elided in >> most cases anymore anyway. >> >> Signed-off-by: Patrick Roy >> --- > > Ah, there it is. Can both patches somehow be squashed? Yeah, I'm happy to squash them. I separated them out based on feedback on the v2, but checking back I realized that I actually just misunderstood/misremembered what you and Mike were telling me. Sorry about that, they'll be squashed together in the next posting :) > -- > Cheers, > > David / dhildenb > Best, Patrick