From: Patrick Roy <roypat@amazon.co.uk>
To: David Hildenbrand <david@redhat.com>, <rppt@kernel.org>,
<seanjc@google.com>
Cc: <pbonzini@redhat.com>, <corbet@lwn.net>, <willy@infradead.org>,
<akpm@linux-foundation.org>, <song@kernel.org>,
<jolsa@kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
<andrii@kernel.org>, <martin.lau@linux.dev>, <eddyz87@gmail.com>,
<yonghong.song@linux.dev>, <john.fastabend@gmail.com>,
<kpsingh@kernel.org>, <sdf@fomichev.me>, <haoluo@google.com>,
<Liam.Howlett@oracle.com>, <lorenzo.stoakes@oracle.com>,
<vbabka@suse.cz>, <jannh@google.com>, <shuah@kernel.org>,
<kvm@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-mm@kvack.org>, <bpf@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <tabba@google.com>,
<jgowans@amazon.com>, <graf@amazon.com>, <kalyazin@amazon.com>,
<xmarcalx@amazon.com>, <derekmn@amazon.com>,
<jthoughton@google.com>
Subject: Re: [PATCH v4 02/12] mm/secretmem: set AS_NO_DIRECT_MAP instead of special-casing
Date: Wed, 26 Feb 2025 08:44:22 +0000 [thread overview]
Message-ID: <c48e7708-d100-4ecc-9944-e71f39d00ae6@amazon.co.uk> (raw)
In-Reply-To: <d686092d-bc86-4a65-b580-04f0e42e96dc@redhat.com>
On Tue, 2025-02-25 at 16:52 +0000, David Hildenbrand wrote:> On 21.02.25 17:07, Patrick Roy wrote:
>> Make secretmem set AS_NO_DIRECT_MAP on its struct address_space, to drop
>> all the vma_is_secretmem()/secretmem_mapping() checks that are based on
>> checking explicitly for the secretmem ops structures.
>>
>> This drops a optimization in gup_fast_folio_allowed() where
>> secretmem_mapping() was only called if CONFIG_SECRETMEM=y. secretmem is
>> enabled by default since commit b758fe6df50d ("mm/secretmem: make it on
>> by default"), so the secretmem check did not actually end up elided in
>> most cases anymore anyway.
>>
>> Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
>> ---
>
> Ah, there it is. Can both patches somehow be squashed?
Yeah, I'm happy to squash them. I separated them out based on feedback
on the v2, but checking back I realized that I actually just
misunderstood/misremembered what you and Mike were telling me. Sorry
about that, they'll be squashed together in the next posting :)
> --
> Cheers,
>
> David / dhildenb
>
Best,
Patrick
next prev parent reply other threads:[~2025-02-26 8:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 16:07 [PATCH v4 00/12] Direct Map Removal for guest_memfd Patrick Roy
2025-02-21 16:07 ` [PATCH v4 01/12] mm: introduce AS_NO_DIRECT_MAP Patrick Roy
2025-02-25 16:52 ` David Hildenbrand
2025-03-03 9:29 ` Vlastimil Babka
2025-02-21 16:07 ` [PATCH v4 02/12] mm/secretmem: set AS_NO_DIRECT_MAP instead of special-casing Patrick Roy
2025-02-25 16:52 ` David Hildenbrand
2025-02-26 8:44 ` Patrick Roy [this message]
2025-02-21 16:07 ` [PATCH v4 03/12] KVM: guest_memfd: Add flag to remove from direct map Patrick Roy
2025-02-25 16:54 ` David Hildenbrand
2025-02-26 8:48 ` Patrick Roy
2025-02-26 9:08 ` David Hildenbrand
2025-02-26 15:14 ` Patrick Roy
2025-02-26 15:30 ` David Hildenbrand
2025-03-19 7:53 ` Patrick Roy
2025-02-21 16:07 ` [PATCH v4 04/12] KVM: Add capability to discover KVM_GMEM_NO_DIRECT_MAP support Patrick Roy
2025-02-25 16:55 ` David Hildenbrand
2025-02-26 8:37 ` Patrick Roy
2025-02-21 16:07 ` [PATCH v4 05/12] KVM: Documentation: document KVM_GMEM_NO_DIRECT_MAP flag Patrick Roy
2025-02-21 16:07 ` [PATCH v4 06/12] KVM: selftests: load elf via bounce buffer Patrick Roy
2025-02-21 16:07 ` [PATCH v4 07/12] KVM: selftests: set KVM_MEM_GUEST_MEMFD in vm_mem_add() if guest_memfd != -1 Patrick Roy
2025-02-21 16:07 ` [PATCH v4 08/12] KVM: selftests: Add guest_memfd based vm_mem_backing_src_types Patrick Roy
2025-02-25 14:12 ` Patrick Roy
2025-02-21 16:07 ` [PATCH v4 09/12] KVM: selftests: stuff vm_mem_backing_src_type into vm_shape Patrick Roy
2025-02-21 16:07 ` [PATCH v4 10/12] KVM: selftests: adjust test_create_guest_memfd_invalid Patrick Roy
2025-02-21 16:07 ` [PATCH v4 11/12] KVM: selftests: set KVM_GMEM_NO_DIRECT_MAP in mem conversion tests Patrick Roy
2025-02-21 16:07 ` [PATCH v4 12/12] KVM: selftests: Test guest execution from direct map removed gmem Patrick Roy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c48e7708-d100-4ecc-9944-e71f39d00ae6@amazon.co.uk \
--to=roypat@amazon.co.uk \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=david@redhat.com \
--cc=derekmn@amazon.com \
--cc=eddyz87@gmail.com \
--cc=graf@amazon.com \
--cc=haoluo@google.com \
--cc=jannh@google.com \
--cc=jgowans@amazon.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jthoughton@google.com \
--cc=kalyazin@amazon.com \
--cc=kpsingh@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=martin.lau@linux.dev \
--cc=pbonzini@redhat.com \
--cc=rppt@kernel.org \
--cc=sdf@fomichev.me \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tabba@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=xmarcalx@amazon.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox