From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C60C43334 for ; Thu, 16 Jun 2022 07:07:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4B866B0072; Thu, 16 Jun 2022 03:07:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFA676B0073; Thu, 16 Jun 2022 03:07:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC2236B0074; Thu, 16 Jun 2022 03:07:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BCC496B0072 for ; Thu, 16 Jun 2022 03:07:53 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9095414F4 for ; Thu, 16 Jun 2022 07:07:53 +0000 (UTC) X-FDA: 79583219226.15.FEE906C Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf22.hostedemail.com (Postfix) with ESMTP id 8DDC5C0011 for ; Thu, 16 Jun 2022 07:07:52 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LNtWl0HKXzjXjV; Thu, 16 Jun 2022 15:06:43 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 16 Jun 2022 15:07:48 +0800 Subject: Re: [PATCH 5/7] mm/khugepaged: use helper macro __ATTR_RW To: Yang Shi CC: Andrew Morton , Andrea Arcangeli , Matthew Wilcox , Vlastimil Babka , David Howells , NeilBrown , Alistair Popple , David Hildenbrand , Suren Baghdasaryan , Peter Xu , Linux MM , Linux Kernel Mailing List References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-6-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Thu, 16 Jun 2022 15:07:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655363273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hJdbX+NsLPzFaEa8pAKKDnldt+rPmXjiKWxRDTJ8AHs=; b=q75L8CUAYizYqVcWXLMrRIi7SqKPZ4grJrL1xoDNNcl2ZFikwuhMN1EXSbQ0oHvqxQgyYL jgzxc+mOKxpkSVnJT4gvjJQmQUBldiC7S90yGHZXrQquUTyocJf7E8isTa0LDS2mNKAJv2 4nJ3P7q3iYL1VIzE6xWI5xMCQKPN5jU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655363273; a=rsa-sha256; cv=none; b=58xGkTM6c+gfk1fGyllzKw36wOfZh1Sz75AcB503+FREXrVT5OxTW0Q7qMJtz/XsH485MN 1gUjVUrSibUNoDWdhF013p7ph55hg0WhgVhTSirVSZjhZ0fJ196o8ECQk+CwDk4Q5GvTW1 5fPb3+O88FDvf0cCFTLMfyTsnDTB63U= X-Rspamd-Queue-Id: 8DDC5C0011 X-Rspam-User: X-Stat-Signature: bw41nzgy8ij9tmpyybmr6qc85g78sbft Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam04 X-HE-Tag: 1655363272-682437 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/16 5:28, Yang Shi wrote: > On Sat, Jun 11, 2022 at 1:47 AM Miaohe Lin wrote: >> >> Use helper macro __ATTR_RW to define the khugepaged attributes. Minor >> readability improvement. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/khugepaged.c | 37 +++++++++++++++---------------------- >> 1 file changed, 15 insertions(+), 22 deletions(-) >> >> diff --git a/mm/khugepaged.c b/mm/khugepaged.c >> index 8e6fad7c7bd9..142e26e4bdbf 100644 >> --- a/mm/khugepaged.c >> +++ b/mm/khugepaged.c >> @@ -147,8 +147,7 @@ static ssize_t scan_sleep_millisecs_store(struct kobject *kobj, >> return count; >> } >> static struct kobj_attribute scan_sleep_millisecs_attr = >> - __ATTR(scan_sleep_millisecs, 0644, scan_sleep_millisecs_show, >> - scan_sleep_millisecs_store); >> + __ATTR_RW(scan_sleep_millisecs); >> >> static ssize_t alloc_sleep_millisecs_show(struct kobject *kobj, >> struct kobj_attribute *attr, >> @@ -175,8 +174,7 @@ static ssize_t alloc_sleep_millisecs_store(struct kobject *kobj, >> return count; >> } >> static struct kobj_attribute alloc_sleep_millisecs_attr = >> - __ATTR(alloc_sleep_millisecs, 0644, alloc_sleep_millisecs_show, >> - alloc_sleep_millisecs_store); >> + __ATTR_RW(alloc_sleep_millisecs); >> >> static ssize_t pages_to_scan_show(struct kobject *kobj, >> struct kobj_attribute *attr, >> @@ -200,8 +198,7 @@ static ssize_t pages_to_scan_store(struct kobject *kobj, >> return count; >> } >> static struct kobj_attribute pages_to_scan_attr = >> - __ATTR(pages_to_scan, 0644, pages_to_scan_show, >> - pages_to_scan_store); >> + __ATTR_RW(pages_to_scan); >> >> static ssize_t pages_collapsed_show(struct kobject *kobj, >> struct kobj_attribute *attr, >> @@ -221,13 +218,13 @@ static ssize_t full_scans_show(struct kobject *kobj, >> static struct kobj_attribute full_scans_attr = >> __ATTR_RO(full_scans); >> >> -static ssize_t khugepaged_defrag_show(struct kobject *kobj, >> +static ssize_t defrag_show(struct kobject *kobj, >> struct kobj_attribute *attr, char *buf) > > Why do you rename all the functions? Seems unnecessary and less intriguing TBH. It's because e.g. __ATTR_RW(defrag) expects the defrag_show and defrag_store instead of khugepaged_defrag_show and khugepaged_defrag_store. Thanks. > >> { >> return single_hugepage_flag_show(kobj, attr, buf, >> TRANSPARENT_HUGEPAGE_DEFRAG_KHUGEPAGED_FLAG); >> } >> -static ssize_t khugepaged_defrag_store(struct kobject *kobj, >> +static ssize_t defrag_store(struct kobject *kobj, >> struct kobj_attribute *attr, >> const char *buf, size_t count) >> { >> @@ -235,8 +232,7 @@ static ssize_t khugepaged_defrag_store(struct kobject *kobj, >> TRANSPARENT_HUGEPAGE_DEFRAG_KHUGEPAGED_FLAG); >> } >> static struct kobj_attribute khugepaged_defrag_attr = >> - __ATTR(defrag, 0644, khugepaged_defrag_show, >> - khugepaged_defrag_store); >> + __ATTR_RW(defrag); >> >> /* >> * max_ptes_none controls if khugepaged should collapse hugepages over >> @@ -246,13 +242,13 @@ static struct kobj_attribute khugepaged_defrag_attr = >> * runs. Increasing max_ptes_none will instead potentially reduce the >> * free memory in the system during the khugepaged scan. >> */ >> -static ssize_t khugepaged_max_ptes_none_show(struct kobject *kobj, >> +static ssize_t max_ptes_none_show(struct kobject *kobj, >> struct kobj_attribute *attr, >> char *buf) >> { >> return sysfs_emit(buf, "%u\n", khugepaged_max_ptes_none); >> } >> -static ssize_t khugepaged_max_ptes_none_store(struct kobject *kobj, >> +static ssize_t max_ptes_none_store(struct kobject *kobj, >> struct kobj_attribute *attr, >> const char *buf, size_t count) >> { >> @@ -268,17 +264,16 @@ static ssize_t khugepaged_max_ptes_none_store(struct kobject *kobj, >> return count; >> } >> static struct kobj_attribute khugepaged_max_ptes_none_attr = >> - __ATTR(max_ptes_none, 0644, khugepaged_max_ptes_none_show, >> - khugepaged_max_ptes_none_store); >> + __ATTR_RW(max_ptes_none); >> >> -static ssize_t khugepaged_max_ptes_swap_show(struct kobject *kobj, >> +static ssize_t max_ptes_swap_show(struct kobject *kobj, >> struct kobj_attribute *attr, >> char *buf) >> { >> return sysfs_emit(buf, "%u\n", khugepaged_max_ptes_swap); >> } >> >> -static ssize_t khugepaged_max_ptes_swap_store(struct kobject *kobj, >> +static ssize_t max_ptes_swap_store(struct kobject *kobj, >> struct kobj_attribute *attr, >> const char *buf, size_t count) >> { >> @@ -295,17 +290,16 @@ static ssize_t khugepaged_max_ptes_swap_store(struct kobject *kobj, >> } >> >> static struct kobj_attribute khugepaged_max_ptes_swap_attr = >> - __ATTR(max_ptes_swap, 0644, khugepaged_max_ptes_swap_show, >> - khugepaged_max_ptes_swap_store); >> + __ATTR_RW(max_ptes_swap); >> >> -static ssize_t khugepaged_max_ptes_shared_show(struct kobject *kobj, >> +static ssize_t max_ptes_shared_show(struct kobject *kobj, >> struct kobj_attribute *attr, >> char *buf) >> { >> return sysfs_emit(buf, "%u\n", khugepaged_max_ptes_shared); >> } >> >> -static ssize_t khugepaged_max_ptes_shared_store(struct kobject *kobj, >> +static ssize_t max_ptes_shared_store(struct kobject *kobj, >> struct kobj_attribute *attr, >> const char *buf, size_t count) >> { >> @@ -322,8 +316,7 @@ static ssize_t khugepaged_max_ptes_shared_store(struct kobject *kobj, >> } >> >> static struct kobj_attribute khugepaged_max_ptes_shared_attr = >> - __ATTR(max_ptes_shared, 0644, khugepaged_max_ptes_shared_show, >> - khugepaged_max_ptes_shared_store); >> + __ATTR_RW(max_ptes_shared); >> >> static struct attribute *khugepaged_attr[] = { >> &khugepaged_defrag_attr.attr, >> -- >> 2.23.0 >> >> > . >