From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F09C282C6 for ; Tue, 4 Mar 2025 02:31:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFBD7280002; Mon, 3 Mar 2025 21:31:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9083280001; Mon, 3 Mar 2025 21:31:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4C71280002; Mon, 3 Mar 2025 21:31:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 96B04280001 for ; Mon, 3 Mar 2025 21:31:23 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 024EB1212B5 for ; Tue, 4 Mar 2025 02:31:22 +0000 (UTC) X-FDA: 83182292046.15.DCF4931 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 2EEC240006 for ; Tue, 4 Mar 2025 02:31:19 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=heWNcmmC; spf=pass (imf12.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741055481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A6T+mpuirUlxFXXDmZQp4DlzJljahRMUsKAZ4wXM54o=; b=Us6uQrbcCpvRKeZVm/llrw8D3etHYA3y9krKEQDwMJxZe3Oqa6CNUwBGwh/YLawVIk1XI4 MotRcSlL+6xbfUPPTsrBEU+qU3SwwENJKuLBGWnhZcz0b1IZll+ByMRK59YPsZvEfsV8v6 ohmQoG3JIsM1vEpjfin0cCYEj7JaN6A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741055481; a=rsa-sha256; cv=none; b=UWGIqWGYhi+ZGHLaLshLdTXZnrLyeG0plMNiOQ3WOX143jqlkcLe26slNKLIbc7pVxbfa2 5ErBk6T4mFHDYo0mgbe82HeyxSgdz30irZy7acqRo1JKfE3OnCZok9tRe5pVUbF52v/HwV D4B0XhQgQu9XSRrRWOztw65o+zknSjc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=heWNcmmC; spf=pass (imf12.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22334203781so97092055ad.0 for ; Mon, 03 Mar 2025 18:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1741055478; x=1741660278; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=A6T+mpuirUlxFXXDmZQp4DlzJljahRMUsKAZ4wXM54o=; b=heWNcmmCg0bEAiZlQUqH792pPoz/RAGd5RnjAJ2Ls07NlzRi/p+SoVwFz+BPEqPf06 gD7pSwd8RZNjD8m85EcA1wSXLXrwvxaVPTVb6zF0kPJS7K6GYf4gl3pn6Dlsvps5+Wks 7WD2p1mWjkiQjGrc5pUC1mvdr+auIS0t/bcQzpzyCkTnWVvF94YINWyzKFMaSUC0IodI kHvjwrO48IHfF/eNbBSfosl5H9M6Pn4331iJrc/cnKvNZgtLTrgdD5Jtuau/0TO7/ZfV 2W01U/9TVHSG1bnp4UlJtEg6ggEYvtb7rgzZDH0SHcAyXOPBxTR1Azdq1GAC1slQ0MDc Il4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741055478; x=1741660278; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A6T+mpuirUlxFXXDmZQp4DlzJljahRMUsKAZ4wXM54o=; b=IPiN1jbI0Y0lJGwlphII6xkWDFTTrzphuUloRowlYcokPYkFboZ09rUtrbIesx4+c6 Z2hlFvbqhA2sdhjITwHYmsVqijGjcs+RKjI5/uwR4IWHMwidxtW1s8obV9aCEhG9fmfF zb1KJfUazCW1lfaNov20pBDFjtZ2EmdwiXHDeadE0ybmnoK1neKGCiXh+oR7pz4UPQOX hdax1tqpzpnC3D9VzHOQadL9JruFAezOP1eCkaQQn/XTbG0lH/bCERvNqLuAi8Y4C+xD ipG8AQbkPZ7ycQ4DyOrNmZgzJ1TfgKc1LMEd9OVPQEH7Lmtm78FO0vO1TTOYDfgzM2hP T3FA== X-Forwarded-Encrypted: i=1; AJvYcCUAsqPrUhpxx7y39LA7Gb2QsSOHIB3Z/K0e0/HdhVYj65CSfQqXz+8fBGy6ASYj4JLZ7vJqsH4dGA==@kvack.org X-Gm-Message-State: AOJu0Yzr0V3ZhPo+0Ko9i2G0Gk2bBET2mMQF+1M+xgVRGmrbSf1wWkWN lQv/xp5Hu4TSiajjbo19FLYeoKkDyP1QTw+673PV7QIZE9/WOBZJWKE9Yq4N+9U= X-Gm-Gg: ASbGncv2Q8CA3Qu59Olk3RYdVbIzH6LIX43iSaQc3CRgjWOe5L3/fZmZhqYAVtSZ7Ns NmWR0Q8c0zeejQMgJ6Desbs8Cd+UoLKSL4a2hZfyG3/D4epK9TyT63HKbHkGPZHxuvzdM+uKhV+ 5r/pDyLH1sQbib2ywnyazK2UpoDzY3sfN2M2rvkMQ8lzu630LBhh04Vd/nBwzrQyzZ4XB0w8qd8 1pOZT54DsrTOJujlBMbNZuySJeV/otOTSL+8oIYMrYKDkUZmDRglcT6HY2MsGOyUuzvUzZRUCKu mkXxO+Z82mublv1JGzehM6ldQgR6LY0lZIhkao0rn7uqlUWj11kqJwtn9JK6DYiqQdgo X-Google-Smtp-Source: AGHT+IGfyVS9QzXp3fDXv9OSff0zyYBlNLrDj9vPIT6lOO0LqcIFLuDQltej9EU6VX3nefPaL9P2pQ== X-Received: by 2002:a05:6a21:6b18:b0:1f3:383e:7739 with SMTP id adf61e73a8af0-1f3391176eamr2284458637.7.1741055478523; Mon, 03 Mar 2025 18:31:18 -0800 (PST) Received: from [10.68.122.90] ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-aee7ddf242bsm8911768a12.13.2025.03.03.18.31.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 18:31:18 -0800 (PST) Message-ID: Date: Tue, 4 Mar 2025 10:31:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6 update] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() To: Andrew Morton Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Geert Uytterhoeven References: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> <20250303072603.45423-1-zhengqi.arch@bytedance.com> <20250303155331.de9b2fff9b04984a255a7bc2@linux-foundation.org> From: Qi Zheng In-Reply-To: <20250303155331.de9b2fff9b04984a255a7bc2@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4n4d7d3je9pb4ca991f8n1tbaysqtinj X-Rspamd-Queue-Id: 2EEC240006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741055479-190061 X-HE-Meta: U2FsdGVkX1/XHCY+W5xoFd5SMxoT0DeTCtoXcROIhu9LjypTCufr1+pYvTGxcyq8VvA8z8w7OXx0gFs9gScZqsN4rmC0CJjLvJGMGqGE2H31swQf5rqbqScea+DjJVd3gecqpCffjFnyvxNOHFMS7MIoa/3BNWPAspzIsIjIneW9ecnh/uSyCKdGidjLhVINiPQlALs9HjOHvXA4mjEzFySeX2paB7jl69Ghzhj1MnJl0m3U1jOO1pKLghaAsxfHvZ6Zx4KdJwzeprdoleUwafRKYsYZ7gN+O4TkDwepgNCAbBq9imjNWEwhoqjNjwwOi5HGfS9eJX97JWGBrkZsfN2OtkLr8Ypkn+D+dslz65WUg+2GfWzVu+nqBFHmzaBRjYL7nj1dZ3yBPeI9AyJG/dj6UjteIOwOsG286NDREydV9SALbLHmA+L9nm7QexFd622kqKGLlx+S5hp+nuL9KBnNDzJzl4LVCK49jAz8njpimNFsR2SXFXW5PUTPMFqbnDwhP9EOVYm78F3PuRLccDFqkEYENtiCyW/o2EIW74OyFffoFmZ2441tNbO8epQEoU90PGuYmAQjL3hVievyxrvmKHqMNsCjZ2s6MZdz6aeGAYTjj9GM7zAiWT9bvlyogagh/kWSPfPMOP+vZwnl0M4ZK7gfl9hF2EH6yC48PlhV/A76e1tV2wbOctzayMITOBriUzWtB8++//nX2JCct/CjhaiqXRjSPBQoR7SKrSxU+SLF03psbcXFJpycSey8CAV4avkN39/95spCLOvPQYQRHuNuleulbED8iiaMlYHc7+TzhavDulqcxAMwmli6Gxm1LVZY5muAsza6yJ8/cfiu4drzPS1SXQkx2swbV8hV4HXd17eRPDpdd99+19drrSkdyhpIpykryfDqlkDmy+rmqKsyfPRcTXZXRF+UTjUC/ZyrP5Ho9L0Pi1zy8EC3Vvh3g4+ROnwK1erIwqK KZZcW3OH xSksTZt/9mN2RFZjgjNH/nfvRnyASGqek7GnReJxffkF3PNDysLsd6alFF406slYn1/3jGxSdviBoGJ+ewOfpX++dgFjQOFXv/Q3beeLRgD+UoWmfkcPZLuUlsPT2DzlMvH/4nSdIeZnxhDK5IJMzcaD8H9DagjTMSTh9LfKYL2kPsSrlhCjCI3NEv7BXg9B4GLJLBubz/rDuBmq3S6QVTMEk6OOfaktQ3lCslggp8zRH2LDS6LKKZhXOAUNYWt5COrXCPYu2rKlKkJrOfzByUWAbxUgOFagtnuamINpTZcJuk6+n9P8kX2CsYWZjbTTs2oRQEPyqz2dFLPsI6P4IMyDj8/uL1cCjPyO1brTE3NcZnjSVzoL3l3Nge7JwBqKBo84r4Qv/pD7moiNVHrtpOOz/2JQ/ALppxOVjuMCbGQ1S3AJxP/go9S3VPFiOrlzCdBv2/1f4r84nKv1h1kLLe3WcsyQFc/3ZqitI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/4/25 7:53 AM, Andrew Morton wrote: > On Mon, 3 Mar 2025 15:26:03 +0800 Qi Zheng wrote: > >> Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, >> nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, >> and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of >> tlb_remove_page()). This is the same as the implementation of >> tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so >> convert these architectures to use tlb_remove_ptdesc(). >> > > checkpatch warns. > > Do these things have to be macros? Switching to static inline fixes > the unused-arg warning in a nice fashion. This can be switched to static inline. In addition, I found that alpha, arc, microblaze, parisc, sparc32 and xtensa also have the unused-arg issue. Do I need to add a new patch to fix all of them, or just fix the newly added 11 warnings? > > I'll fix the trailing-semicolon issue locally. Thanks! > > WARNING: Argument 'address' is not used in function-like macro > #51: FILE: arch/csky/include/asm/pgalloc.h:64: > +#define __pte_free_tlb(tlb, pte, address) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'addr' is not used in function-like macro > #66: FILE: arch/hexagon/include/asm/pgalloc.h:90: > +#define __pte_free_tlb(tlb, pte, addr) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'address' is not used in function-like macro > #80: FILE: arch/loongarch/include/asm/pgalloc.h:58: > +#define __pte_free_tlb(tlb, pte, address) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); > > WARNING: macros should not use a trailing semicolon > #80: FILE: arch/loongarch/include/asm/pgalloc.h:58: > +#define __pte_free_tlb(tlb, pte, address) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); > > WARNING: Argument 'addr' is not used in function-like macro > #95: FILE: arch/m68k/include/asm/sun3_pgalloc.h:20: > +#define __pte_free_tlb(tlb, pte, addr) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'address' is not used in function-like macro > #110: FILE: arch/mips/include/asm/pgalloc.h:51: > +#define __pte_free_tlb(tlb, pte, address) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'addr' is not used in function-like macro > #125: FILE: arch/nios2/include/asm/pgalloc.h:31: > +#define __pte_free_tlb(tlb, pte, addr) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'addr' is not used in function-like macro > #139: FILE: arch/openrisc/include/asm/pgalloc.h:67: > +#define __pte_free_tlb(tlb, pte, addr) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'addr' is not used in function-like macro > #153: FILE: arch/sh/include/asm/pgalloc.h:35: > +#define __pte_free_tlb(tlb, pte, addr) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'address' is not used in function-like macro > #167: FILE: arch/um/include/asm/pgalloc.h:28: > +#define __pte_free_tlb(tlb, pte, address) \ > + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) > > WARNING: Argument 'address' is not used in function-like macro > #176: FILE: arch/um/include/asm/pgalloc.h:33: > +#define __pmd_free_tlb(tlb, pmd, address) \ > + tlb_remove_ptdesc((tlb), virt_to_ptdesc(pmd)) > > WARNING: Argument 'address' is not used in function-like macro > #185: FILE: arch/um/include/asm/pgalloc.h:38: > +#define __pud_free_tlb(tlb, pud, address) \ > + tlb_remove_ptdesc((tlb), virt_to_ptdesc(pud)) > > total: 0 errors, 12 warnings, 122 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/mm-pgtable-convert-some-architectures-to-use-tlb_remove_ptdesc-v2.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. >