From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544CFC678D5 for ; Wed, 8 Mar 2023 10:23:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA9A16B0072; Wed, 8 Mar 2023 05:23:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D587B280001; Wed, 8 Mar 2023 05:23:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD22F6B0075; Wed, 8 Mar 2023 05:23:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AAD336B0072 for ; Wed, 8 Mar 2023 05:23:29 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6E6D41408BF for ; Wed, 8 Mar 2023 10:23:29 +0000 (UTC) X-FDA: 80545344138.18.D9AEF5F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 6BE96A000A for ; Wed, 8 Mar 2023 10:23:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="HqA9T/sn"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iVsYRuHo; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678271007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5oyXynkh60CJXXg36k6qmlCFCaHiUgRLQaqjGCWpxkY=; b=dzBH4CJ/oHfy1n2frqNIHe6QOXatyhpg5C3AQXaGlYNQZ7Y4wXfWwrqYJXNvVW+hV2AoEz xIWPAeOL8ppaz54smkKvYXPNOcC3aOq3kt5ToT5S175DRYmpMXZDRZ/AYLt7Yqd0bNHdSg KcRM4Ss9IjYdk5lSBZm03JHmP5DWO7c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="HqA9T/sn"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iVsYRuHo; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678271007; a=rsa-sha256; cv=none; b=4tvr6dI0V6g0R+EP6qsDtOmmrcdzXxsYk1DrKhvvfwCUcuBP2hX7u+d9xsKENuDmy3cED6 X/d2lJsy6nw99r9Ceu1HDAJx/WgGDAzJ+wNuweN5NR3hYmfMToGex8A3HYmlNAHqEWQLhR 8jzQ7mm+/lpVEuGNdzu7CtSQK1QR2d8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2F11F1FE3C; Wed, 8 Mar 2023 10:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678271006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5oyXynkh60CJXXg36k6qmlCFCaHiUgRLQaqjGCWpxkY=; b=HqA9T/snvtOWPVahyw1DoiTJTKFTw3CDK52mCgXmz75QqNcX1Ns9VVKHdpoHlSrEma//fP HBmu3FKw5D8Ef/CXYo6Y1+Jc6CxEOvxyp4uAZ/Uo5hWYPRCSIPnukfPqkwLoW4rIXVhC/k 3p9Iy/Ms0rR/7ypXZSNeZ8PLLxyn4Dg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678271006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5oyXynkh60CJXXg36k6qmlCFCaHiUgRLQaqjGCWpxkY=; b=iVsYRuHoa7MmGUtveN83sOYKjJn7La9KrbP/OXybajtI4R/BbNU5VtR6nU5EcmNafjoerR LH1qaK28HFbcqcAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0E391391B; Wed, 8 Mar 2023 10:23:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /rLiNR1iCGS1WgAAMHmgww (envelope-from ); Wed, 08 Mar 2023 10:23:25 +0000 Message-ID: Date: Wed, 8 Mar 2023 11:23:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V2 2/2] mm: compaction: Limit the value of interface compact_memory Content-Language: en-US To: ye.xingchen@zte.com.cn, mcgrof@kernel.org Cc: keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <202303061405242788477@zte.com.cn> From: Vlastimil Babka In-Reply-To: <202303061405242788477@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6BE96A000A X-Stat-Signature: 4qotfb449ysn8m5ypk9rr7yjmwakhwfp X-HE-Tag: 1678271007-573300 X-HE-Meta: U2FsdGVkX1+LjYDpGGKMApo+BdzWH+v3MNltcexvtxpnyGKOj8sU37UiyXuGsTFxcVLhsHMsBecXcKGX2/b+962omTmuRqoM6N18fsyLzr4dtIyr0ciKJOhosVJ22h2GZXPvW210n/2HTMBf+AHuszKeHfVIL4nEsOBQS44TuzeHPmzUHiqbAehFTSvjTeFhrcBPCazg6P8QrIfk0GD2Zy//QPz8eE+JV7BU71uV7uCffrefi33k4hHrLhiws4p8o/T4A3rNKiUjbOBsN9PveAg33isBZXvdP9GM6vackyXFMh1aw2OkvmziUAEDcAI2inkq7Kd5oEX5IEajpORIXlHdnmAp5x9+2TD2tsG6yF7lHJiIc5NK2XvRKCLqbwJiHtDyV244cizmLolOCAgkSfuFhKzg1ssxFb9WSKt4Of50LOvVBH5vmJcrKX9NUy305bmUdBXheYqkc0nZ8/3FOGtUdGFB5Wayo0xTOVnXWlhUtywrEj1I5XSlVyErXP3Nn3NPeAsv4coDFk8SSvU+duMCLLhQ5/Jcs+XoRofL6SJruruiFJLtgCUDBoVagiGrgiLafPMSmhCmfdDHVTFhkBd7qhbq6P4FdO+VBAs/b7gwOvmrRRbzQoCOzKQWMR3BoPvXdmrlB4p1JtbNvJCJLBUWh5sXyMQFcMz79rOse/BdVx+dAjw+am8LF9dpKt6huayB5nNrYubepFNZVwt77SaF+que3WdIUIKLV8ZE0FNxXFzsGDy+TwGt2W6Mmqh2xnDHGc1nAQawQz0hTlm7ukzllEtsxS/GB2QxfcIfvDsUXURVW5n65kIzqmIBzyBqu6IhdmHp/GfISCyne5U7Qfiz9x0+hCx+3H5DsTBmrCWlcEpuJveZQ90V6Jg8UvHj9aUe4rj7Znh9NKpCFhkZgwNyEv8vPoh7lTXzuSTmAGBRWHsfMn03ppuqpgvC1z2zskh+MzAGEn0dQgI5Oui VltwQJH4 J594NxxNHu4h17iheiU5qpDWGoWYOiX86kMgrKb35gSBYhn96MOL2S1it02ZIB/7C1d9UvT7IPR7O7QRR293rTJ87A8cU/jvE7drxm17z1pyRPst7tQyCz65JRfeVxSsTL0OtHDpve3LzqLPwPy94WFPSD7w0XVlEbz+xVrU+yaODZsvny+JibBnPoe4+tR9I9ue6I+Mk+a7Koy/JN08MT2M08LEsma2d6bonMmrO1K2JvAtYRbwZOWnGXqP7gSY1XcFO2pbo3yOstQId7/pVTdPZqUQ7qdf6v3BUZ8XDDXyiSKKDcbR5SB+CIkJHVd23r1y6CCr+cMs/lZdF4Ox/vmhDNh+LjSuoTGWyMQTx/XQ4h4ZUsWFyo/Z8Gwvm/2CVEdDAkJKIV+cV/nLbGRii01hqO3BuViS6NCjim5FZ2DOupr4gJRE+jUpTbmZF3EgHbWrc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/6/23 07:05, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > Available only when CONFIG_COMPACTION is set. When 1 is written to > the file, all zones are compacted such that free memory is available > in contiguous blocks where possible. > But echo others-parameter > compact_memory, this function will be > triggered by writing parameters to the interface. > > Applied this patch, > sh/$ echo 1.1 > /proc/sys/vm/compact_memory > sh/$ sh: write error: Invalid argument > The start and end time of printing triggering compact_memory. > > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/ > Signed-off-by: Minghao Chi > Signed-off-by: Ye Xingchen > --- > mm/compaction.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 5a9501e0ae01..2c9ecc4b9d23 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2763,6 +2763,8 @@ int compaction_proactiveness_sysctl_handler(struct ctl_table *table, int write, > return 0; > } > > +/* The written value is actually unused, all memory is compacted */ > +int sysctl_compact_memory; > /* > * This is the entry point for compacting all nodes via > * /proc/sys/vm/compact_memory > @@ -2770,8 +2772,16 @@ int compaction_proactiveness_sysctl_handler(struct ctl_table *table, int write, > int sysctl_compaction_handler(struct ctl_table *table, int write, > void *buffer, size_t *length, loff_t *ppos) > { > - if (write) > + int ret; > + > + ret = proc_dointvec_minmax(table, write, buffer, length, ppos); > + if (ret) > + return ret; > + if (write) { > + pr_info("compact_nodes start\n"); > compact_nodes(); > + pr_info("compact_nodes end\n"); I'm not sure we want to start spamming the dmesg. This would make sense if we wanted to deprecate the sysctl and start hunting for remaining callers to be fixed. Otherwise ftrace can be used to capture e.g. the time. > + } > > return 0; > }