From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88941C7115B for ; Wed, 18 Jun 2025 08:20:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F035A6B0095; Wed, 18 Jun 2025 04:20:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDAE26B0096; Wed, 18 Jun 2025 04:20:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC9436B0098; Wed, 18 Jun 2025 04:20:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CC8386B0095 for ; Wed, 18 Jun 2025 04:20:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 49C5A160C52 for ; Wed, 18 Jun 2025 08:20:54 +0000 (UTC) X-FDA: 83567825628.05.2B937AB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id D7DFB4000B for ; Wed, 18 Jun 2025 08:20:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JW5n5uBt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750234850; a=rsa-sha256; cv=none; b=cu8Zt/FuUchr2JrGj/EAnwWfdj99bE1Qpnoa0J0cyMTCe7p3pLitYBvcbBN9Dgubj8bxll lF2EwYA8UysgXtOxbPC3HIiSAh42oXhJPhxgscROOAY6HD5SmdCIxzInDXDYWeTvfpE8WN zttPpLs4F4u2+wOj3mdYM8xc/loayMM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JW5n5uBt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750234850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LBhYV9k9KeT6OsgTMg9dQH6Ku3lWlrWw3bTdhHVaJvs=; b=weDmyYZEZLa/czQQ+8wNhWmkMnjQIRMVtArA447mmTjEoa0HQl65grygBPdK4RSE/WtIHp KTDySvL+Wl+VkISWAAMpYsgIaa/2b0Xgv8tPIqDLyPZ4wXHdV74J57tyLQL0yN7e87sgvG 9tP8nNENSFL19CsazQO01PTAwsv4qI8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750234850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LBhYV9k9KeT6OsgTMg9dQH6Ku3lWlrWw3bTdhHVaJvs=; b=JW5n5uBtXncMVVpYOwXaPSkeFTRbdFbnod0sfR1MXDgEbPQPJ3h5tkIQvSFMEZY0XVSbdZ uQcIrb7cS3j8DSivuiZJ7qoilckvVbBPgX7WMbLMhhjb9Ik6HzNFm7xk11TwKomhjX3nYd vO6djq3VDnrsk8okoKOItfL7ChvMvpw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-9fMZ95JoM2aPV3Pwpz8ZEA-1; Wed, 18 Jun 2025 04:20:49 -0400 X-MC-Unique: 9fMZ95JoM2aPV3Pwpz8ZEA-1 X-Mimecast-MFC-AGG-ID: 9fMZ95JoM2aPV3Pwpz8ZEA_1750234848 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450d6768d4dso42749135e9.2 for ; Wed, 18 Jun 2025 01:20:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750234848; x=1750839648; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LBhYV9k9KeT6OsgTMg9dQH6Ku3lWlrWw3bTdhHVaJvs=; b=G4ohy5Kfz87+aNzM2zMthS6nmE80ZKGs10anWC4R02GyKgShq1T8k/WOLnijdvgGnW Qt22+yMzHuQy/FlQhixQiu9HX8jwfOitVs/7LKx7DagCiN/m3nz8ijO0D9rzrwshskWr Y7aT2XEQ6eYlz7Uet2lCKT9jwU/eewbAiYgZa/vNm4znmKs1cnVuWNuJu7RiFBF8JFhs AVGIlPcIIJzMgm1oh3GpJBJfwflxgkQIlzPIT6/EHbSvyIgV+HjcZBe4LfmbkOyl2yfW UitGa9UG+MnwLZlF1E56QCkBjloSP0qehTPEgBcajWa5PB1nObqkHVkPDQBYDbHZRDLn 5UIQ== X-Forwarded-Encrypted: i=1; AJvYcCUP0W4UBt1CBxNvpDXaZIQsrs7dYWIFNfeOtt3t1S0PaT7AIhdAoz74ikXQfbsRwc5aQ61Guzcoxw==@kvack.org X-Gm-Message-State: AOJu0Yxs+CUlqQUlPbId+kDCtMgJH0y0BcBH9zYKMWr62MTtfuCrZK2G U+WwKh8fXgLc/pX1Ibtkdsiz3Q+pjZiATk43PjehArzEDY+F6IhK6G8rwh1HhKjXMnf6WnHl4br CBE+OO+p9jua6H3mHDqIXdPFcum6XYAqmQ172BE4Vm/7HP17oMtrC X-Gm-Gg: ASbGncuYF/lQxLpCHE2jNJ0q1MTORgDW/uOl1UXwUxVZ7qSy35grgKlmZA/Ip8mvAVa h+AbGqkDSek8Lhr7cs+C8GiTpcZzrkORr5/ThltmE5dcFtrFB4VoZouXZVTb6PgG0Qxu21MqXzV e7eu/IYVz+YNptkaxxqpeo1jmon1ZQwuoZaGZBNhqHyk/gintU3Cys7I5z738+c6v14DGKTKEJA t4Ois4TA5U5eQAFBNTFEczWRzxSflRxX+JMswM+pXw+JBSzdwtslbh7OePuHKCGbKvAqJ7QlL6z 3BcJiGdC4DQX9kLs8lT+1Wn6QdB/xd13McchG93i9z8X6jvWzONhAK8xOuL69x89gu7Z+dzzipP Fr5Z3j6r5dVK2eAdCdEgNZIklwJkumB9bdLsTeeg6uNrbphA= X-Received: by 2002:a05:600c:3513:b0:453:a95:f086 with SMTP id 5b1f17b1804b1-45343d2c0c4mr141770255e9.12.1750234847967; Wed, 18 Jun 2025 01:20:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyZwcfG8Crxxelq6mFOYe2ppW5H6yz4v1Ci/xgNUQ8CxoknbuH/NzdmMPo6KHsgWenCeTQyg== X-Received: by 2002:a05:600c:3513:b0:453:a95:f086 with SMTP id 5b1f17b1804b1-45343d2c0c4mr141769695e9.12.1750234847518; Wed, 18 Jun 2025 01:20:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:2400:4052:3b5:fff9:4ed0? (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b79f45sm16165095f8f.101.2025.06.18.01.20.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 01:20:47 -0700 (PDT) Message-ID: Date: Wed, 18 Jun 2025 10:20:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() To: lizhe.67@bytedance.com, jgg@ziepe.ca Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, peterx@redhat.com References: <20250617152210.GA1552699@ziepe.ca> <20250618062820.8477-1-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250618062820.8477-1-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RS5NTCipXqg_c7Bo2R0MTaJLr0EGKaOsxjxogSxm_jQ_1750234848 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: daky7qigt85ibe9x171rizzt5cfkzkep X-Rspamd-Queue-Id: D7DFB4000B X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750234850-481910 X-HE-Meta: U2FsdGVkX18j4xqCPRcFR2hD29Ceup1V9DG3StpMR0Gf57n8XcnMfDyHP1fAsPR+T3x3/PJ3hCoPM0rCi/g+jr0w++Of3Y0zzRR3kAiqUtIhzeeZ9THbIFB7SZorNrZQGb8wNdM4dh+/SdE95lyKjKXespNAxlFgY3i7eK18FVCpPo17pzCn/F8RC9m7KAeCNZaoReB5yrb/k+qmAOBhMMG9SynryvRguO5rfG/nkPQzGJkQdmCiuKN2qVXFCgI4wRRVb0tqv/F6FMprdKaMK6WC8IrpvoAG1SKRfWO9L5y/MQ/C53lS0wAvLBUOik0Fbujfw/1sZrirqre6EPcyQl1lxlia50vY2xrLli7inT8Pxx7HDVOTTAnlpgiMPKGd6JEG53xZ27CGgnOxxYBUysDi9iJ8YE29Dc4CwwDKJpUGLJcaqy+1CDOtjdhGDz3YdFS1+Uc/IFotV1z9e7ZfzxuwoHbVtDVFURJ+yzA/fzmgSXxAP1MNjA36SvfJ8ONW8DrewSawglnB5Rn5HWEwAu4SVlGvaQITV3PsWdMo9MUYlqBngqKnazP77zm4SPAKZ9E5UBSyOxoydCBhdYeNfYKgh9Yr0gC1OLNWruVNkNhXv2uo/EZQZz/XUwZZr7MW2gv0REeiDIOPhHZtwvvyNwPgyAzgzRWmhuNN7dMSwnE++zA71KiAzE1gGGdO2rtq4rTcADW7K3Px2J4HP2NIe3y7F+5qsqIntf3onHDm8XvCN9W3RrQxWGy7/e8TWda3cBOg6M3T28Uot/ckGyjt5CZoCxeFaBb41QrPVN8XbOuoHfVQYSPqJuhcTagybNuqrz+ZAMBOd9Nz8Nu5BGd23YO6dMjedsmFx8B0vj4t/8cfyCk84tZVA3JWpi74xbTf4/p6qngGQUEGE9EtWydGUAX1NhCCNkxfCMBW9AKF32QtdE0O8R81ZUsdoG/MhKrTK71aSjl2fLSuh3rjprC gj+RYT8l 696tmu8H76AOl2ndsirWzdukyJFcnXisvNbvjBgqgq30hHYznLghaEJwR01YtoCm3OB7yCBkvxbQkrV9ZadYulJGr/P11PcADNbh7D3k36Nrpvdu3LSs4nNnJtN+MsQ26gdPevMyHMi7NYaxJytPlTiaBiqUxW2mKmCUbV3uf5kIuQHs2mimt6eoCBYE4rKbTV2uzxh/7igdj9b4C9sKlkUsvY+0IIPL3ClWK+yckk3nUoqwCZKH+2EkAODv90cXFpShqBqsfRiRNlv9RBKKi323ag/Z7GIGB31gIOwfRcs7Dd2rHHJiLs7nv1JE4tMKsvCl8Uk56c03aWWDVKp7iZzaLcvg6jHhB/02B99YwjbU5Jwdl/ivI2omuDnCwiezzp4ofsqUOyPK5xbiUj0Q2ub+c2won7sW+tMdeYDhKv5bcTY+9hRTxDHkVnYXzJKBiuX90ROdG5wWJiZ38kHxEXDOi9WVfZqhQyuRoTR8BPMch/oyGl5bXzif3HeiNbohyxsvtIRX66EQnuPBD6BLBZaGEFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.25 08:28, lizhe.67@bytedance.com wrote: > On Tue, 17 Jun 2025 12:22:10 -0300, jgg@ziepe.ca wrote: > >> Weird, but I would not expect this as a general rule, not sure we >> should rely on it. >> >> I would say exported function should not get automatically >> inlined. That throws all the kprobes into chaos :\ >> >> BTW, why can't the other patches in this series just use >> unpin_user_page_range_dirty_lock? The way this stuff is supposed to >> work is to combine adjacent physical addresses and then invoke >> unpin_user_page_range_dirty_lock() on the start page of the physical >> range. This is why we have the gup_folio_range_next() which does the >> segmentation in an efficient way. >> >> Combining adjacent physical is basically free math. >> >> Segmenting to folios in the vfio side doesn't make a lot of sense, >> IMHO. >> >> drivers/vfio/vfio_iommu_type1.c | 35 +++++++++++++++++++++++++++++---- >> 1 file changed, 31 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >> index e952bf8bdfab..159ba80082a8 100644 >> --- a/drivers/vfio/vfio_iommu_type1.c >> +++ b/drivers/vfio/vfio_iommu_type1.c >> @@ -806,11 +806,38 @@ static long vfio_unpin_pages_remote(struct vfio_dma *dma, dma_addr_t iova, >> bool do_accounting) >> { >> long unlocked = 0, locked = vpfn_pages(dma, iova, npage); >> - long i; >> >> - for (i = 0; i < npage; i++) >> - if (put_pfn(pfn++, dma->prot)) >> - unlocked++; >> + while (npage) { >> + long nr_pages = 1; >> + >> + if (!is_invalid_reserved_pfn(pfn)) { >> + struct page *page = pfn_to_page(pfn); >> + struct folio *folio = page_folio(page); >> + long folio_pages_num = folio_nr_pages(folio); >> + >> + /* >> + * For a folio, it represents a physically >> + * contiguous set of bytes, and all of its pages >> + * share the same invalid/reserved state. >> + * >> + * Here, our PFNs are contiguous. Therefore, if we >> + * detect that the current PFN belongs to a large >> + * folio, we can batch the operations for the next >> + * nr_pages PFNs. >> + */ >> + if (folio_pages_num > 1) >> + nr_pages = min_t(long, npage, >> + folio_pages_num - >> + folio_page_idx(folio, page)); >> + >> + unpin_user_folio_dirty_locked(folio, nr_pages, >> + dma->prot & IOMMU_WRITE); > > Are you suggesting that we should directly call > unpin_user_page_range_dirty_lock() here (patch 3/3) instead? > > BTW, it appears that implementing unpin_user_folio_dirty_locked() > as an inline function may not be viable for vfio, given that > gup_put_folio() is not exported. The compiler seems to properly inline like before, so I think we can keep that. @Jason correct me if I am wrong. -- Cheers, David / dhildenb