From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399E0CD80B5 for ; Tue, 10 Oct 2023 11:47:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9BD88D00B6; Tue, 10 Oct 2023 07:47:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4B3A8D0002; Tue, 10 Oct 2023 07:47:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 939FE8D00B6; Tue, 10 Oct 2023 07:47:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85BE38D0002 for ; Tue, 10 Oct 2023 07:47:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 61141402E6 for ; Tue, 10 Oct 2023 11:47:40 +0000 (UTC) X-FDA: 81329377080.21.E8E91C6 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 8E7DE140012 for ; Tue, 10 Oct 2023 11:47:38 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6w98R1D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696938458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CftwnpLquRpM9GMm5zasd0JkCBM4xu/DWgAa2TbouK4=; b=uyJUllq3Ge5Uh+HjBuxcn7IwP3HfRmtXP/m1thAl08dvT0VqR1mobHjQvBVh9eA4t8SnyM jXRRBDkRa/HJzrD7bClwZMcsSlJVajOcw7VAK3cjOdzVRDYTYs0lYtmuCXTQt9SJVW6ENm 7sncsWL1KFlm0frtbvUfex6mm6m2HzE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6w98R1D; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696938458; a=rsa-sha256; cv=none; b=JCgFK88myc4RaXqBznz5E9DDcnKlv/jV5ldE+mdNrp2AcGtroRlKOSvnuFsxhByCdk26MQ QxqyX66dutgL78YEI8ayk6Rthr7i6alNdBBnJpsS0OoWXTqqyMUlX0fczplKnxIwuEVp4m 0ZjcuyZ1xEKzclQzfXyV8miYcRyOkAY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 01B39B81B72; Tue, 10 Oct 2023 11:47:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43271C433C7; Tue, 10 Oct 2023 11:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696938456; bh=dGsrZo+vQ1VzJbbq+maOQwDfORosg5+dHAq6SOZW1fU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z6w98R1DPjR+hK+Pvfba9+Oe+swBF1fj3sbhODwLVVzS4l0cNsbvPqOyQNlKURMDu 6nadmgt7plrPizzdJ1voklnWCigMP4z+cRGtDLbXCHx/2WfSMk7JBIB9BF0wh8X22S 1rSBtn7QQKsiWKay3ZeX2JPUILNKfQIuC03XZbHWENdHW++GPegW8rCBjUhHnc/He8 60QYi96y4h0xXS2JqshRiHKYttFtMk2O/l6Hgl5Bqx5AdHjOg5b+S3lKeY+nhBWNNK o+BhRIn+ukTgFldxd7spQOCVf6FCTGaw825s99Q3IfZ+8HxKxT3szW5RMNhEk6DuP8 3DvuSsMmkMm5A== Date: Tue, 10 Oct 2023 12:47:19 +0100 From: Mark Brown To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, catalin.marinas@arm.com, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 05/20] arm64: context switch POR_EL0 register Message-ID: References: <20230927140123.5283-1-joey.gouly@arm.com> <20230927140123.5283-6-joey.gouly@arm.com> <20231010095423.GA2098677@e124191.cambridge.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c1gCxq1Eu5WP02VS" Content-Disposition: inline In-Reply-To: <20231010095423.GA2098677@e124191.cambridge.arm.com> X-Cookie: I feel partially hydrogenated! X-Rspamd-Queue-Id: 8E7DE140012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bi5pz4bsi5frdmfwsbswmzpyxkzm3ikb X-HE-Tag: 1696938458-465922 X-HE-Meta: U2FsdGVkX18i9G92md3xVdpSsLpmRJBVXtrgE9HdrJCuESh1grhBOMuFuQO0t2QZF/n7clfdwYDx8JwpgmWBEqv5L5nBX7wWXZgLm6t2WiVif2+prjou0qfhlWMA9J9lHWw4x1udubbwr6SyYKBLEgFnrhmlJiW1FZnzveYtyy0NnFF1n48kPgxbJ0SdMCSFImZ8eLF2VMxiE52oQE0bCQANOlzQ/mCfKrl02laSiR3Cw5OcChVI2qe8Zf6GyxIVjUt+CPwKw7+GwhvqcldrANhsJUltyf7UQ+Hkk0y7KkA920HC0t0yHjY5ssvYkFaHqyz86k1gEtN9tsS/gCvn1wb1yPi3208oE38mEzsibIxkDwCdEpNPe9FO5MmVSfXRKMuRostUAkeT9H99JXVyL0Qg6lbqAkvluQrdcGqRg+BEvut+k1BU7Jt+tw3Rw2sbGa2/fhdFG9pLp/bwauJrFSsqm6H91MM9tGleVF27ER8BkjlsgsI0ghKDwJYO/K9jsm64chKk3zyrOP0stfGAd9Le5+HEH03rX8DcSaSIRCuO2Y1lRK6vC0imKq5jLkpLVZ2obADWqELwyHTMKOospav1rg/6BUjsrt8Atk/Y7Xu/SP1Lsz5hRpD1dnDSmwt+9pfWe7Caj2nzNIv8o2s2m+tLpeWkVr7Mp92iWeOHmroe13y5ZWrbHzxx90wuhh8FE2RjRlWlwciu8TyNkLRmXg2eTZEBLBTAnVoLiQ6l0B5GmFMQVnoDrbb3njFKJeEwuK86bq/fHA2k9czhpz3qrhNcQ1mB3sLXPEBoJiq9i5H/X/fbQtFvKGp3skcgxu98NM3lQs5Es59/Mk1z6QdWfJO4wUVBSF2vLp4r0QX3LMtZHCXts8HQ4Llulbe10zhL3XwAKSEFGUwHYyqlfQ2Q09m/PMZtDw6bt46sunqZ3w8il7SYUgOLqgfrSO40HsRQ8y72JXdhq661idTD16W 7SbcnUTR SEL2WXFkB3cGrtdQxhtepWAduHO8jJpaa2fSw18w1bbmKS+byekZ10YQR4vWFsdt5xzr03u6bBeWWl9Oq8adGa7+5Q5w99v3NFBleACjWfgsvK2no59uE8pNUSi6H9zhAW+XFKJfSX0cW9dwMgbFv1+WsY2fmWCF0vU2AbuBK4RUyKNv/3EYLE/IOc8zcJtBa8xq962X2/l1teEdhBCZWMmmnUPm97UUMRaPcM8Y5ioK10blAKe6LT36I46/IVzys6L8NwBld5PYgDU8GE20KqWrpdEAdx0XjNzPrMO2ZHUMZfLNVunQAqK5LQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --c1gCxq1Eu5WP02VS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 10, 2023 at 10:54:23AM +0100, Joey Gouly wrote: > On Thu, Oct 05, 2023 at 03:14:50PM +0100, Mark Brown wrote: > > On Wed, Sep 27, 2023 at 03:01:08PM +0100, Joey Gouly wrote: > > > + if (alternative_has_cap_unlikely(ARM64_HAS_S1POE)) { > > Why the _unlikely here? > The only options are alternative_has_cap_{likely,unlikely}(). > I went with unlikely as currently it is unlikely! Oh, if you have to pick one it doesn't really matter and that seems sensible. Usually they're optional so outside of very hot paths they tend to be an antipattern. --c1gCxq1Eu5WP02VS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUlOcYACgkQJNaLcl1U h9CHBQf/ZXcCmrREeYk6HjwOAXBpILDhJEYF552Me/bljo1xHTcfrJ29itnqdzJd tJO760glWJ/CT+tmsH2Td0cYKaRZENARTmvlIpF0Dn0gUkdvusyYk8MD7s+2gmx1 BaKOAAD0/WcE+4bWknMiYw7au2dFq6unT9xlXJY5ykHubP5YS/EqRrMBM+AEKpY/ tnnjr5FboCv+867dluZHV4RGf09RsTf48iGGGJZjpKmoCB1I4UKMP9PfRJ492+dS Dy9i0DtFr+dq552w6Sk5FhUV9tsvf5RD0XNUu73vQnBDFQ9TgCkzLOwnjaC/nxh7 2OLfAXCgeMqpBYoe5PHtp6VuSE9Qiw== =Qpeh -----END PGP SIGNATURE----- --c1gCxq1Eu5WP02VS--