From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E56AC7619A for ; Mon, 27 Mar 2023 05:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8881A6B0071; Mon, 27 Mar 2023 01:56:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8372A6B0072; Mon, 27 Mar 2023 01:56:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D7536B0074; Mon, 27 Mar 2023 01:56:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5BC896B0071 for ; Mon, 27 Mar 2023 01:56:35 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1AF14160546 for ; Mon, 27 Mar 2023 05:56:35 +0000 (UTC) X-FDA: 80613618750.01.89C9455 Received: from mout.web.de (mout.web.de [212.227.15.3]) by imf09.hostedemail.com (Postfix) with ESMTP id ED6B214000C for ; Mon, 27 Mar 2023 05:56:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=wVADs5LH; spf=pass (imf09.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.15.3 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679896593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NbwAOPMrDQxUEIt6QthT83wL1c/Cwpr53Iu46jtcHVo=; b=jZAenDbuyhlmICmL9A6fWYEUoMt82DOd59BP4pC5fprPK0HWtRJ/yrszYdfQ17Kx7SQAEB L9E64FHXWT8O5Tcuu1/XBVF8E7nFAO48u5g64oC5otZn6DWQK/J3eeXsK1M9FBJ8nwWUfY B8HIaQnTVdNRldOJ4AT6AhOfJqmXsPA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=wVADs5LH; spf=pass (imf09.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.15.3 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679896593; a=rsa-sha256; cv=none; b=DyBzhcLJoaQCTRx9AaSp1S9l5ovFiickH8rgaRoSYE7hZjS2AMwtP4BTXkxDOonLoA2ROn Kh3mdyLnGknVYsGVg2RQ2rFdxsxNz6RZQQuhSZNKFoouiX7mYLW0BNvpMbitJnlnWHDRiO KN07LH9Ml2iJRAlCluxN5JG3ix2Jx8I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1679896565; i=markus.elfring@web.de; bh=pz/J0Hn4+9u+G26gPwGVXPtbTt3MxR2I7unMqST3Igg=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=wVADs5LHX7spvpSubZ+v4nPIXGVfrzNkf8ibwxU2UHb06xMXH+EE/6JbxjYPzYIdY znDbAvGe2zq0IWPd0BS72QMrKxIQdRsmnSwDz7SpjZ8uj7cqJsYRq9+uuGOB/w0y26 l9k6N7EYK6P9WDMLkHscHsra2HpIKCTXfwuHauD/CcQ2Tibk1ewrj6ZLSJ/ubpwPTt zUK09KQc3VPIjHSjsqYhZ1nuMoi7YTWddo3HT57bBgKzFyrfJwbjS1nmFE3D/XJwI6 ptoVTvMAzAFyhi3E4I7ReXeuwL6NXj8r5F5/Ekc1VOODRMTuZGYaRIEmZqyxHq7OqA JOKqtpnoKJ4Xg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.88.83]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MRk0k-1psFKh1zhK-00TI8R; Mon, 27 Mar 2023 07:56:05 +0200 Message-ID: Date: Mon, 27 Mar 2023 07:56:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] selftests: cgroup: Fix exception handling in test_memcg_oom_group_score_events() Content-Language: en-GB To: David Vernet , kernel-janitors@vger.kernel.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jay Kamat , Johannes Weiner , Michal Hocko , Muchun Song , Roman Gushchin , Shakeel Butt , Shuah Khan , Tejun Heo , Zefan Li , Lorenzo Stoakes Cc: cocci@inria.fr, LKML References: <5b7921c9-ee5d-c372-b19b-2701bcf33148@web.de> <20230326213900.GJ363182@maniforge> From: Markus Elfring In-Reply-To: <20230326213900.GJ363182@maniforge> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:1gwnZkH0S7NOslRRW02w5YeQ2GC+UHGP08MEPPAyTvxz2nKDWMC HJFhFZ9TyIlWXP9d3nb1XbmaYsbPRASZsmUfWzWarfWlnIgolNeKexeBYmRCI1WHybLcw1K teafLPSrb0FP+fXa/4ZQjfeE3QEtOiQmoFhjTgH4xxYTul0SH7X/CqfVCQmNEhpa+e6qqHL tSkaSSyK7nE7iTodcf/4A== UI-OutboundReport: notjunk:1;M01:P0:Htzphb0YYVI=;6y+XyO+AN5hu4AW+bfxbV3QzUDG 9bcm+ocGOjQrpbGJI99ku1L3oJsNv9nnXcxI+su8i/Ahr7TSHkrbh1bL3jEsMly/+2jCdHk7s MMyhwqofXY9WeEG5KW7/pVWjqCwXc4LTxiCls35O1G20/gThnLvs7nNTJ2B3sMhiMu1jQruU8 28rnxOqka+u+teftx94THlhfTHwe6H5ekQ25VomXdxEhfeTynQuOA3DzfRamnGNONM33+WNZu nIlw4q5Xeqa/OD4jDLnZ9OCskK7tCFuAc8LpCjwvYDmNWgNkh1iZWQQD4q4a/+jP/bz+qkKR4 jWAgdkWRusUJBnfOTuJQ+02cFXNzeYv+lzjpMuo08JJeprv1jBIzCYt2l96PI2UI43NnlmAMJ fLnXQ9QGx3nc0Z2XGOjqLtNbr0UvFS+OtcN2GnQdVEaD/I1mymFh4KClTbndB4Yu6cWQLGLz+ UV/MULYvvyg5bo8W1kEoJAngo1h1UNYY3ZdMbROGpu6FTGYiZmr4CBNDFeIsuiTdjAf8DcrKF IyZKE7jb96H1N98WCE/LkMBJYnYt708PskGu2iAnttpasZgyCIgfPPhGlh295P7ELxPLZqc89 FHa8MnIsvaTbPVQ/Ns0GbVRrFBcLYERrlN7frycaR/8tQn5Zmm29WB7Q2mdQ8miTJ0cyopO9T ua+CmxAOq0Al5I+B3qzqGoIC/67OOF/Y3ZBM5FWDiS++w0FqYX7CL0SQyVpSGP9BGw7Di64dl Smy+MOGgpxnWmrvkwt3DUqTnXiTzlzmbvRU3SAUAzs6li++DH9x1qjpbqiLPBWVgql9D5I1rr nC9nQFppBcrRPdxS/2ZcSAeOnHefnbETgOISLTYp+o1YQM9bzPOiHCMjvp68JUz89gxKqFwx1 rzWptgXaDBrz60cSF4cm9KzYKWJDRYG3eEtHOmcPjHpefVme2svuKTXao X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bgu7g3thoybena7dnewuts7a8bejhe9d X-Rspamd-Queue-Id: ED6B214000C X-HE-Tag: 1679896592-624490 X-HE-Meta: U2FsdGVkX1+DJeN7wlNCk2IDQ4YtjpJwyZmikdxTK8rOUTIqBnzrxpYvHgO+FHqhQAmrPB/qTA/hPxnC7mhC8/bcHZII9IVvPD4EM/i+RrHu8JwcdUs6efcgFevIvwoOQ4rJDtypC5bZyE5UfxRRnczF1kLyDS39AjZaj3y0SzyBl373Gbs9ZPJbmG5ZgKz6hn3D8GFX1PHP6fjwweuJU+RdJc2g+ejxSXnWo4LwC7Aq+XjOGQH/YeGuXcoK5CsjVB4itqd7f88mryTXkwnHvAMSvEbICwVLxpenRo6+6TT1fHZsOWEDWPBulKcg+0oz9GIh+q0pBlucv4+UxyYI0Z47DC3Cfv5wK5NKUiDxudnnMkqpB5U31guC6FRBKypFujp8OXiOgzSe0Nf/WFoXxd1fjA+8IhLwzMR40KAdhR/YC3MpgDjliMXBGKKcNWYcf5emTtkUYFLQVuPnnDmz8m82Sesn5pEz/Y/zTf+HHUta5LM74H13IMPAMWQemZDbWrqWyeb+QprNO5+lBFYzLk3X7q+Pmd9yGcj2SQZdplCkFsAFUSaefUMwXnaLkSlBnHl/l4FumOD8C10e6RG82H2KvwVRjztZKK+u3I+uCFczAxlPu+1VyYG20vUYyfsU9kNJiL7ZVrJ7aIxCsnh5KUKO6lqv6oedbuANnGZSmuayU+lGfLxSj8Cc3puzPdXbIVpsO3L5A6SsJVuyUb4JH0AeBRc5fbPhqonmUS22KIg8Z5G2W8QITtJJMQilZXgQwYJXSgj+LG87YCaHWLnweCja9DZtGDNFHjNvxYslrPq1RrgO0Exe+DNoNSHkL9Ryt+040eUTS+7d6LF8KGDe9S1a+S+yXjZTMTeK50QvB9frBBb2+3IhLeEco2T+8NDxSUE8L7f4517JwoVwGXlT0ilPzBnG+GbcrZ8ZJh3bbXZiQmPk7MPcLa35vm0+lgF2wQ0neM4kTphB0JLRPa7 eFUU6Xoe zGSN047Il8ZR2QY95Uiy54n0GxsZLI2LL1Wb+jcqu5PQuvlSUQT5y4g82958HNBjn58XKrvU8u1R4XM6SwRCtT+nlqGXSYYVYmUdE5cAUXFoEz2B3Yz1IYCQRVA2fKfWZCrKPSbIUOWD5MUjYhxjqtTe6L3bQpqBRBuhGXQmnuXBhkBVEhnrrPzJjRE9iNV6dg6NNU/smH+9eQz/COncdlK4seVRyatL0Nciu2tAPUQGYsy8XNZNeDhV4xkRL/VXBd9jyL2a1Bw9TtQERnIBYxsETc0fr5srkT+iuI0UEwpQdDns= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> 2. Can a cg_destroy() call ever work as expected if a cg_create() call = failed? > > Perhaps next time you can answer your own question by spending 30 > seconds actually reading the code you're "fixing": > > int cg_destroy(const char *cgroup) > { =E2=80=A6 > ret =3D rmdir(cgroup); =E2=80=A6 > if (ret && errno =3D=3D ENOENT) <<< that case is explicitly hand= led here > ret =3D 0; > > return ret; > } Is it interesting somehow that a non-existing directory (which would occas= ionally not be found) is tolerated so far? https://elixir.bootlin.com/linux/v6.3-rc3/source/tools/testing/selftests/c= group/cgroup_util.c#L285 Should such a function call be avoided because of a failed cg_create() cal= l? Regards, Markus