From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0E5C38142 for ; Tue, 24 Jan 2023 16:28:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26B276B0075; Tue, 24 Jan 2023 11:28:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 217236B0078; Tue, 24 Jan 2023 11:28:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B80B6B007B; Tue, 24 Jan 2023 11:28:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EB2256B0075 for ; Tue, 24 Jan 2023 11:28:31 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9571D1A0BF5 for ; Tue, 24 Jan 2023 16:28:31 +0000 (UTC) X-FDA: 80390225622.26.453E06F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 3D904C000B for ; Tue, 24 Jan 2023 16:28:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idv7JaA+; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674577709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ySlJVrmItDOerr+H1CEk6K2XPX97r28SzTHxaNzIPCg=; b=w14X35RBlr13yHQZUht+woyY9/mo4WFiQWw6pX3uLJikunLxZA6GFX889ErueOuq1evZRr VT9ee3B3NH0VCNnTlSD8deaqU4hs1sEqfUIeTf9u7x50BdY8jCwNSPH7UP1QAJhqNIef2X +POt3mV51mpEo8kmmzTfbnZt3JTTXW8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idv7JaA+; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674577709; a=rsa-sha256; cv=none; b=axKuE9Br5wqcmmpw8uBR7xg4kBDfOWL2Zt245urkO+nQAsKdXLde5fgTnBIQZ/sbIKGBus dkeHBnrnP50Li6SdedgsuZULklvZRbqpwmiw2pYhUj7k3m9sgtmRpGiUSh2OHY0n/2KzZr /gFaWrjwdlP3XLYh4qbsi0MAESiH2LE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674577708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ySlJVrmItDOerr+H1CEk6K2XPX97r28SzTHxaNzIPCg=; b=idv7JaA+Vx8gaDNNpKTSfu5nMIdSAkoCc9qNZxmVjZgzJ8lNxXmg3BaIiOrexcYSVpF6B9 Yy8SPbab4pfhBDAl9EXon2iHBPLCcJseIW8vHjW1X0Lz15G1iGpMmegz1xXY+zZg0dPf+1 B51vyfTu8zU33wK3jkKGaWjKNsyp/04= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-591-wiEP_uL0N_mryA6e08vIvw-1; Tue, 24 Jan 2023 11:28:27 -0500 X-MC-Unique: wiEP_uL0N_mryA6e08vIvw-1 Received: by mail-wm1-f70.google.com with SMTP id k34-20020a05600c1ca200b003db30c3ed63so7575194wms.2 for ; Tue, 24 Jan 2023 08:28:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ySlJVrmItDOerr+H1CEk6K2XPX97r28SzTHxaNzIPCg=; b=sgKoKBMb0XuBHhxXCqxoonC1LWclQVek/fiy8ECSrcVv0mdKmQ2b0s7Wflh7pW1Ptg AnT2G2tSIhS7HU1qXpGtmvOHC3bOrP0Z2Xizmiq61kFK23+X3+K+DlzdRo7L8TAjpS2P giMWVfBEQHOfVzMhSxLAQqgYVdim3jmDpRLdwDHD+36gE6oB7rr2TcGZrfSEVeCY5tlo QjkxfwPRTfTxUB+xzF16+tj4wvcwGTjIr1O6vv9BNIUHZr1RugTaHS5rWmf3nmiia3fL t5UAooqeoRppapHiRJez0KMDKWivQ9LQWpZnaI32VLDLqwvNw39gb+B2HQosyiNFKVHq vK7A== X-Gm-Message-State: AFqh2kqwb7lJcUSkyiT6rlAO5N0w+gsx63q9qOHxJr9B83zj9uQGv6Wl CoQhxf9KAnZWWFf4vP7cmnRkYl6/sJJqxX4WJlwP2l6skzWv2lDv67TxHCDt6jiFg7zjcktlvtX rB+4+kEb8+4k= X-Received: by 2002:adf:df10:0:b0:26a:3eee:dde4 with SMTP id y16-20020adfdf10000000b0026a3eeedde4mr23657044wrl.8.1674577706140; Tue, 24 Jan 2023 08:28:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXv9Sv+gszxHCBZj/Xm9GV3TOnkrQ2UmBhTzEl1d7Z6kmqZ7MMwUJonsHw8WPEvQXnKOrfZd7Q== X-Received: by 2002:adf:df10:0:b0:26a:3eee:dde4 with SMTP id y16-20020adfdf10000000b0026a3eeedde4mr23657025wrl.8.1674577705812; Tue, 24 Jan 2023 08:28:25 -0800 (PST) Received: from ?IPV6:2003:cb:c707:9d00:9303:90ce:6dcb:2bc9? (p200300cbc7079d00930390ce6dcb2bc9.dip0.t-ipconnect.de. [2003:cb:c707:9d00:9303:90ce:6dcb:2bc9]) by smtp.gmail.com with ESMTPSA id bv17-20020a0560001f1100b002be2f18938csm2248680wrb.41.2023.01.24.08.28.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 08:28:25 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 17:28:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v5 10/39] x86/mm: Introduce _PAGE_COW To: "Edgecombe, Rick P" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "bp@alien8.de" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "x86@kernel.org" , "mike.kravetz@oracle.com" , "Yang, Weijiang" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" , "akpm@linux-foundation.org" Cc: "Yu, Yu-cheng" References: <20230119212317.8324-1-rick.p.edgecombe@intel.com> <20230119212317.8324-11-rick.p.edgecombe@intel.com> <634aa365-1f51-8684-24ae-3b68aba1e12a@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3D904C000B X-Stat-Signature: fbuqoptscmyhid8omx8pr9thxj9s6wn7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674577709-800942 X-HE-Meta: U2FsdGVkX18zWbS4tcLEcCt95WGz40nXQND30uPHq6vG67BLj6jUqor7LYGlnj9hCHaGQMd61p0tTwLdemWAlC7iGzKCiH0fNtAyNM1rbp4nSAHIXDV4n0/22lrMezI3s5lkvqJc6zDYQU2UAw3wYSlQK55gegdDT+pgpZ96TmAMMvuRfWytGCEL0C9tY0s+oVJEHqAThIT2MQ0JlwUws3TflKegVRApzoUnKCZOcXMTNtG2DhK1II/W29Pcj1mEVQcT/4+kznxDBLXp9bnI4f76O/46J4zI1SFWbCeo4dcSmXZJ0bAWeHG+KIrSH995fUIYP+28iy5tqxCiKcc9Hc+/tNP4k+IZL3wZkg4Up3zDoO5qFYwA+9CuiVKVucthoGoDWqje0Tu6/mPX720i2/jVsSDzQp0RnOQd/Le6SyK6ldd6LGy+n1zMBnNf5b11O5292KomlUm+gStyVYmZ2eOrJHp/n/jtd6O57Xy10NseG1urREx4WWgGXDnBF6rIcIsUcTAuDAab+nSLBkk4Q8xNaeB0Pny6suoNwuNU8i1c6pUTzKXnZEZ+rs1S3KeLAsYQcQ4NO8o1BsrN9kIpoQgXE9Bi4m++7EQdUw4y0oth9OtifIf/9ASdyVH56+a8eDyFowlgSnVdz0n2rOpn1r/svGIx8OpGiiZIcPwH21QjnWpWgXlciWU+4DBE3mc0VblGP5sO3NMXhpic9wrf40rrQHl2QcR9feEbLqvKgKMK99TYlJKhP1m9NOsLARRCH4x6nsgRxaulo6PSetjuR8l1I0wRD5pE9orryRJwp5+W78vUprUEKql54Xw8m2XGSu0LImQ1caicMEuCuPNFVkSsbDlivLXgoncWP/xCXVOFckUhu3CYbJqeyFH/i8z10Vbt5/Y8WvCOVvJYHCQRRVJLfJmqxHijB+MgMou+tfEZaSY0lmGzAf+Fdt7mptpbzQNXGUBcofcIxVW2Rnb qHZXvEg0 NvdxxnP78gHdPFU7+Y767b9dB2clIDrYxul8th3tCLaNZgrco06OdQIHuzLAEE204XWEGFc5kEYXd9dZmMCufl1FRJMspvMS6xz+UHD8J1D46O8odZH3CQjkfDBxtnxs0aZ429kb51fInZUnGdzdszyoEVMimaOKFnh6C4DV089+ktDZwbhjeRCAa2Ny85MR2sg44Q75BOXUQvSOEdZbKojHgJ8GtIeE/xo9FsbsXD9J0OSnwru9zcFRv+vhRgp3CYjYO7nS63Q3Fz9HOe5I1WwoFovW/63/26fRKBBosF76wRiLq5IOME2MswbbnukksH0cIgUcTZNS6bRKYiw7cpU2xPgkc+lmu1Nj1Q5e3BEKG5WOIhdxERxYeiTu0iFlcx7BWSzofxqaama8EOIpLgZDqBND5Q5hmagrn3eTI6hdBz9INxpCv+1YVgDV6QoqGWKnebTqJflx13CtL9iiAln4ehl3GMoiqABoSwmy0pz6EhbRTKplbAY804x1/XhHz7k7ltZD8sBMCr0HGpYiE5KUMtPdapOFCaJF1/AcepG7zdnpXdJ1ewk/tQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.01.23 21:56, Edgecombe, Rick P wrote: > Trying to answer both questions to this patch on this one. > > On Mon, 2023-01-23 at 10:28 +0100, David Hildenbrand wrote: >>> +/* >>> + * Normally COW memory can result in Dirty=1,Write=0 PTEs. But in >>> the case >>> + * of X86_FEATURE_USER_SHSTK, the software COW bit is used, since >>> the >>> + * Dirty=1,Write=0 will result in the memory being treated as >>> shadow stack >>> + * by the HW. So when creating COW memory, a software bit is used >>> + * _PAGE_BIT_COW. The following functions pte_mkcow() and >>> pte_clear_cow() >>> + * take a PTE marked conventionally COW (Dirty=1) and transition >>> it to the >>> + * shadow stack compatible version of COW (Cow=1). >>> + */ >> >> TBH, I find that all highly confusing. >> >> Dirty=1,Write=0 does not indicate a COW page reliably. You could >> have >> both, false negatives and false positives. >> >> False negative: fork() on a clean anon page. >> >> False positives: wrpotect() of a dirty anon page. >> >> >> I wonder if it really has to be that complicated: what you really >> want >> to achieve is to disallow "Dirty=1,Write=0" if it's not a shadow >> stack >> page, correct? > > The other thing is to save that the PTE is/was Dirty=1 somewhere (for > non-shadow stack memory). A slightly different but related thing. But > losing that information would would introduce differences for > pte_dirty() between when shadow stack was enabled or not. GUP/COW > doesn't need this anymore but there are lots of other places it gets > checked. > > Perhaps following your GUP changes, _PAGE_COW is just now the wrong > name for it. _PAGE_SAVED_DIRTY maybe? It goes into the direction of my other proposal/idea, yes. Not sure if _PAGE_SAVED_DIRTY would currently mimic what's happening here ... _PAGE_COW is certainly wrong and misleading. -- Thanks, David / dhildenb