From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03258C54E41 for ; Sat, 24 Feb 2024 07:03:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D4D46B006E; Sat, 24 Feb 2024 02:03:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 484B76B0071; Sat, 24 Feb 2024 02:03:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34C3E6B0072; Sat, 24 Feb 2024 02:03:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 25ECD6B006E for ; Sat, 24 Feb 2024 02:03:19 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A666540236 for ; Sat, 24 Feb 2024 07:03:18 +0000 (UTC) X-FDA: 81825806076.05.D849FA7 Received: from smtp.smtpout.orange.fr (smtp-22.smtpout.orange.fr [80.12.242.22]) by imf11.hostedemail.com (Postfix) with ESMTP id 86D0A40009 for ; Sat, 24 Feb 2024 07:03:15 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=VSvZBdZK; dmarc=pass (policy=quarantine) header.from=wanadoo.fr; spf=pass (imf11.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.22 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708758195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zaAjgqWRp0nSEMfAmosrEZOp1z8vjHJIuWxUPoa7WkA=; b=4RTSlvFYSlV1E8RKgGLfOYUK34jz02G3a1uG/LAqH7gNznkO5yrrS5HeaE1HX6MzDD4t8i svhA3NcjVjuzMh9xROtW5w1BLZ1YVZALjixxjLzIbUUC/tbuDnsBd/MeCSbYyKXGpigrZF +FsZP6zA6pvxz/F4d+9+CZ9OqjBa8DI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=VSvZBdZK; dmarc=pass (policy=quarantine) header.from=wanadoo.fr; spf=pass (imf11.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.22 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708758195; a=rsa-sha256; cv=none; b=Ux1EFJaAsrTHItrLgUtCLVdEBos+uayj/cFrEMkxWzOX97bqNDsRkFZumMlORDon09NeYT lxCTlRpS9v7s7mutXs8U+9W6y4X4HNXoNMXxM2LEy5M8cHxs8xMMsajbWI5QkJKiRFYedS azZ/arEQwcdq9TOLpBYwbuNdJoLOYDE= Received: from [192.168.1.18] ([92.140.202.140]) by smtp.orange.fr with ESMTPA id dm40rzOJHZc8Edm40rwRmA; Sat, 24 Feb 2024 08:03:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1708758194; bh=zaAjgqWRp0nSEMfAmosrEZOp1z8vjHJIuWxUPoa7WkA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=VSvZBdZKYhsNiDW8JxPaQzxWnHDOaMaKcAM4JqFg4F8d/+vG7jv38iWioTRuuUQfC iveiJ+tP6CGRu92fGMWoyQuc7AuEYUP1SsAUfHg/MAd7zHj1z/ZItqswOSUxYbdptC Vf17LRufwaS6QS7q+ietTgBokFSY8o8U1+7/p/pdU+MSIupxCZThLpFweD77KA9OY1 dXr6/qUlsEZy8XocbC1FFuAF8H7qpP972BOtd8ZebxEo6LVNkVd+oLy6WexFwrx7DL U9GpjYXnJZTjocKqkpE2lCBmo6Rlp3S3/dEWaxeMBTy0kOeTtyBmSe/B8On8FaVKIC eIoaEw9xkOOyg== X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 24 Feb 2024 08:03:14 +0100 X-ME-IP: 92.140.202.140 Message-ID: Date: Sat, 24 Feb 2024 08:03:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] mm: enumerate all gfp flags To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, petr@tesarici.cz, keescook@chromium.org, pasha.tatashin@soleen.com, mhocko@suse.com, kernel-team@android.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240224015800.2569851-1-surenb@google.com> Content-Language: en-MW From: Christophe JAILLET In-Reply-To: <20240224015800.2569851-1-surenb@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 86D0A40009 X-Stat-Signature: zksow3ye9zsnaksuypdhnr48u5xtxofd X-Rspam-User: X-HE-Tag: 1708758195-141803 X-HE-Meta: U2FsdGVkX18fN4qQJzf6F6Mjk51xp6NWLsOGTuMHPGHlC4/a/EEEhlLOsznexstauSl/j72lXFlUxY3p27yU6dlbxL4CySa4xQcKaxGXdry/HiojYdtnKtcWQFfbi9MI4VQL4n0W6GsZ6rNO71grBYffnyJ4xEZ7w05hE8ZK6l6E4KxX1G8Lr25GAk90FfcXEIeZ9C4Yq7Rdo+X1tYNBWRsPV2eqScLmtZMxE+5c0Yy7Z8oUeYBqFGr9/FKuJDP3LAjCty4yXaIJi1AKcbqhlGhFVwNgd26rfqu6icCJjit9x7fe4oLoPotyUp2jWd0LaMce/e+QY9cVAARbsoa9B9j5EOUadPg+NwqP5KCNQcqPG131tAd7W/6NxJfm4+zM8feC6aYtaXkIujlh9UfCZzXVTXvxUlsUk+nnL95TWkWAHE5tUNEU9h7nANA6+q6ASFAU/TyLHJOeVztVH1/XSs8jAjgy4MC6XKSWKu/NamUjiJ4WOdE0SOPm84Ha2bWw6DTQ9EusTFNomjYNb90qNGiZd1CKM9IXgnYtq3oZstF1T0c8wxj87TmMoUMUwsVV8Bujyicvhs9eb2Zrjw/WaZj5appnv0Wvh6/r1sqm4z1I2iBzYg/1JlDq1Ineoy0Slma2xQw34u8cjo0cjDK0m5Ao0s0ShQYrcNMPMC6JKeISA6Z3Ln5X90oQ0g/sxds2ZxRUQuklB+NFdpY6NHtaIp/JwpxJO4hcHpxHRHPImjgBBWftnl5oa9mKbhFMZwi44VLawi4qWxlnWxzG3Wcur+xUaBA5IPr2xe2Ge2ebOHuKMDxomN+Apv5QpQqqplTcqJR5uvI31Fs+c71MsKQOW1IXBMooUm+MiKccRC6gBh29whQhmLAHdpKxnWqYBTucC4zAtuS8pCzpSP/uiPH7RY5NdW7lEg8YkoAzyIQTIOFZWkJGjRvb6Mb20SeAPYPmsyDwU/quR1yNxTww90r Zbic1pLD FToFJ29BavWC5u2ZM5UW0MiJXah0Kr8PCa5x+23WSEKG2L8LzbqI86Qr0ik6lSBAL5C3yj/Lj3Mfqwv3hgLjmDjmQoYp+TjcuPPH7opv6voyYPINVH9vZ4xVhbai3JXQGnBE+61oh8RdBCdvyiXdpaEg+d6vy3Ur3yjjLezuRLr1SSQbcgGBkO99YIoVtL/p+qZHi5pcsz7tSeVMvx9ZLjx177ip25Q978KtylUo6hnRYhaNNbkpxqowwzXUOv6kNua6Gd8wq1jI/mCHPmD7NjPnEKgRrAVmvm3CWn8sGGJf4CBtQNdLR92aKxAadVnLxtmc/vY8C7vellxmghLrC95ffzHfqrr8egspkLnsPDwZ4UAbnkrC2OxvfiVJxllUlXOMWLQRu+fKWYF7XvcvRkXrjdY8+P/55L4LmJ5XXDdG5xftkFfFTLKkufsTcJIVGYily74yqzoflmHfhCT11CUNtj8/KZwOSL5+UsWVaizwHAKtdKSwmXyO2MZ1SKqv6roR1qN8x9dNVXS+q7/WOHyp1VOGSKRJtkynz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 24/02/2024 à 02:58, Suren Baghdasaryan a écrit : > Introduce GFP bits enumeration to let compiler track the number of used > bits (which depends on the config options) instead of hardcoding them. > That simplifies __GFP_BITS_SHIFT calculation. > > Suggested-by: Petr Tesařík > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Kees Cook > Reviewed-by: Pasha Tatashin > Acked-by: Michal Hocko > --- > Changes from v4 [1]: > - Split from the series [2] as a stand-alone patch, per Michal Hocko > - Added Reviewed-by, per Pasha Tatashin > - Added Acked-by, per Michal Hocko > > [1] https://lore.kernel.org/all/20240221194052.927623-7-surenb@google.com/ > [2] https://lore.kernel.org/all/20240221194052.927623-1-surenb@google.com/ > > include/linux/gfp_types.h | 90 +++++++++++++++++++++++++++------------ > 1 file changed, 62 insertions(+), 28 deletions(-) > > diff --git a/include/linux/gfp_types.h b/include/linux/gfp_types.h > index 1b6053da8754..868c8fb1bbc1 100644 > --- a/include/linux/gfp_types.h > +++ b/include/linux/gfp_types.h > @@ -21,44 +21,78 @@ typedef unsigned int __bitwise gfp_t; > * include/trace/events/mmflags.h and tools/perf/builtin-kmem.c > */ > > +enum { > + ___GFP_DMA_BIT, > + ___GFP_HIGHMEM_BIT, > + ___GFP_DMA32_BIT, > + ___GFP_MOVABLE_BIT, > + ___GFP_RECLAIMABLE_BIT, > + ___GFP_HIGH_BIT, > + ___GFP_IO_BIT, > + ___GFP_FS_BIT, > + ___GFP_ZERO_BIT, > + ___GFP_UNUSED_BIT, /* 0x200u unused */ Hi, what is the need to have this ___GFP_UNUSED_BIT now? > + ___GFP_DIRECT_RECLAIM_BIT, > + ___GFP_KSWAPD_RECLAIM_BIT, > + ___GFP_WRITE_BIT, > + ___GFP_NOWARN_BIT, > + ___GFP_RETRY_MAYFAIL_BIT, > + ___GFP_NOFAIL_BIT, > + ___GFP_NORETRY_BIT, > + ___GFP_MEMALLOC_BIT, > + ___GFP_COMP_BIT, > + ___GFP_NOMEMALLOC_BIT, > + ___GFP_HARDWALL_BIT, > + ___GFP_THISNODE_BIT, > + ___GFP_ACCOUNT_BIT, > + ___GFP_ZEROTAGS_BIT, > +#ifdef CONFIG_KASAN_HW_TAGS > + ___GFP_SKIP_ZERO_BIT, > + ___GFP_SKIP_KASAN_BIT, > +#endif > +#ifdef CONFIG_LOCKDEP > + ___GFP_NOLOCKDEP_BIT, > +#endif > + ___GFP_LAST_BIT > +}; Does it make sense to have something like: BUILD_BUG_ON(___GFP_LAST_BIT > BITS_PER_LONG, "blah"); (should we need to use BIT_ULL() one day) > + > /* Plain integer GFP bitmasks. Do not use this directly. */ > -#define ___GFP_DMA 0x01u > -#define ___GFP_HIGHMEM 0x02u > -#define ___GFP_DMA32 0x04u > -#define ___GFP_MOVABLE 0x08u > -#define ___GFP_RECLAIMABLE 0x10u > -#define ___GFP_HIGH 0x20u > -#define ___GFP_IO 0x40u > -#define ___GFP_FS 0x80u > -#define ___GFP_ZERO 0x100u > +#define ___GFP_DMA BIT(___GFP_DMA_BIT) > +#define ___GFP_HIGHMEM BIT(___GFP_HIGHMEM_BIT) > +#define ___GFP_DMA32 BIT(___GFP_DMA32_BIT) > +#define ___GFP_MOVABLE BIT(___GFP_MOVABLE_BIT) > +#define ___GFP_RECLAIMABLE BIT(___GFP_RECLAIMABLE_BIT) > +#define ___GFP_HIGH BIT(___GFP_HIGH_BIT) > +#define ___GFP_IO BIT(___GFP_IO_BIT) > +#define ___GFP_FS BIT(___GFP_FS_BIT) > +#define ___GFP_ZERO BIT(___GFP_ZERO_BIT) > /* 0x200u unused */ Keeping this comment here is now useless, IMHO. CJ > -#define ___GFP_DIRECT_RECLAIM 0x400u > -#define ___GFP_KSWAPD_RECLAIM 0x800u > -#define ___GFP_WRITE 0x1000u > -#define ___GFP_NOWARN 0x2000u > -#define ___GFP_RETRY_MAYFAIL 0x4000u > -#define ___GFP_NOFAIL 0x8000u > -#define ___GFP_NORETRY 0x10000u > -#define ___GFP_MEMALLOC 0x20000u > -#define ___GFP_COMP 0x40000u > -#define ___GFP_NOMEMALLOC 0x80000u > -#define ___GFP_HARDWALL 0x100000u > -#define ___GFP_THISNODE 0x200000u > -#define ___GFP_ACCOUNT 0x400000u > -#define ___GFP_ZEROTAGS 0x800000u > +#define ___GFP_DIRECT_RECLAIM BIT(___GFP_DIRECT_RECLAIM_BIT) > +#define ___GFP_KSWAPD_RECLAIM BIT(___GFP_KSWAPD_RECLAIM_BIT) > +#define ___GFP_WRITE BIT(___GFP_WRITE_BIT) > +#define ___GFP_NOWARN BIT(___GFP_NOWARN_BIT) > +#define ___GFP_RETRY_MAYFAIL BIT(___GFP_RETRY_MAYFAIL_BIT) > +#define ___GFP_NOFAIL BIT(___GFP_NOFAIL_BIT) > +#define ___GFP_NORETRY BIT(___GFP_NORETRY_BIT) > +#define ___GFP_MEMALLOC BIT(___GFP_MEMALLOC_BIT) > +#define ___GFP_COMP BIT(___GFP_COMP_BIT) > +#define ___GFP_NOMEMALLOC BIT(___GFP_NOMEMALLOC_BIT) > +#define ___GFP_HARDWALL BIT(___GFP_HARDWALL_BIT) > +#define ___GFP_THISNODE BIT(___GFP_THISNODE_BIT) > +#define ___GFP_ACCOUNT BIT(___GFP_ACCOUNT_BIT) > +#define ___GFP_ZEROTAGS BIT(___GFP_ZEROTAGS_BIT) > #ifdef CONFIG_KASAN_HW_TAGS > -#define ___GFP_SKIP_ZERO 0x1000000u > -#define ___GFP_SKIP_KASAN 0x2000000u > +#define ___GFP_SKIP_ZERO BIT(___GFP_SKIP_ZERO_BIT) > +#define ___GFP_SKIP_KASAN BIT(___GFP_SKIP_KASAN_BIT) > #else > #define ___GFP_SKIP_ZERO 0 > #define ___GFP_SKIP_KASAN 0 > #endif > #ifdef CONFIG_LOCKDEP > -#define ___GFP_NOLOCKDEP 0x4000000u > +#define ___GFP_NOLOCKDEP BIT(___GFP_NOLOCKDEP_BIT) > #else > #define ___GFP_NOLOCKDEP 0 > #endif > -/* If the above are modified, __GFP_BITS_SHIFT may need updating */ > > /* > * Physical address zone modifiers (see linux/mmzone.h - low four bits) > @@ -249,7 +283,7 @@ typedef unsigned int __bitwise gfp_t; > #define __GFP_NOLOCKDEP ((__force gfp_t)___GFP_NOLOCKDEP) > > /* Room for N __GFP_FOO bits */ > -#define __GFP_BITS_SHIFT (26 + IS_ENABLED(CONFIG_LOCKDEP)) > +#define __GFP_BITS_SHIFT ___GFP_LAST_BIT > #define __GFP_BITS_MASK ((__force gfp_t)((1 << __GFP_BITS_SHIFT) - 1)) > > /** > > base-commit: 603c04e27c3e9891ce7afa5cd6b496bfacff4206