From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92460C7EE25 for ; Mon, 15 May 2023 19:55:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 152D0900004; Mon, 15 May 2023 15:55:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1034B900002; Mon, 15 May 2023 15:55:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0D27900004; Mon, 15 May 2023 15:55:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E01F6900002 for ; Mon, 15 May 2023 15:55:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AEA1F1604CF for ; Mon, 15 May 2023 19:55:44 +0000 (UTC) X-FDA: 80793544608.19.898E06C Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by imf06.hostedemail.com (Postfix) with ESMTP id 17C12180005 for ; Mon, 15 May 2023 19:55:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=BCWyQw0m; spf=pass (imf06.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.179 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684180542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eP6gErIx4YH4NGO5e9TOO4EyxDdPvqOfbtAqJSgrrUw=; b=l9MukdJrumEWluSCKBaVOgmKhxeQ5SDyKSYVDYBTK9FVFMdpLZT1/OxJVh8GrHpKLXIhOz tDXV/dfEV8Y4JfRbvOrCPlqBRcSJj5k9JGzbjSYuJLD236hBWpL5NTV4A0DMrTNcvzGOmG bEujBnB5H4lhgJM3sdap8OPjlBRGV5E= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=BCWyQw0m; spf=pass (imf06.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.179 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684180542; a=rsa-sha256; cv=none; b=k+5e+eeiyOgHCwdd9sHKrnplzxXZJbi8OeRqijiToXGZmwUMBBWQYmI+P+LrRDAWQ5Cg/n sgdLc39PMm0MYPNMMonN8zuFqn0tXZnEsahRPEbwHk0WeqIU1M1QXB7HoVDcAZMrVGiKB0 4DRkGuAd/osInn1GhJdwy88mdxwgXbk= Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-334d0f0d537so3850515ab.0 for ; Mon, 15 May 2023 12:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1684180541; x=1686772541; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eP6gErIx4YH4NGO5e9TOO4EyxDdPvqOfbtAqJSgrrUw=; b=BCWyQw0mDG8PUE2P9cmJlB519vHPXHbntbFnNnbkKzNif9qWqrBfTQbKPKN7qmBca6 dP4FZxbQD4m2WdjZWqcwzj3viM7yPrEGIB92FmyQxFtHR7oAb7uhqpEy9CM/JPp1bMNY xyWNRZmN2rK6BjAB1a3uXYmyBjanEC22eb+/b2K1Yosr+j70fmB4bAiaCylRWFnZLISt dk5NsKcFoL5JwEf7MIFopajKeA9S/gmSkyGl7+r0XSNwbWuzxSDL/q4vkdgUN6FMqupO Pp9QcJdfKZZc9z89NXYBLn27oRLDK8Vo4zZUhRbhVpClZVj+dY7g4IXQIOT5XvKNneDE BiSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684180541; x=1686772541; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eP6gErIx4YH4NGO5e9TOO4EyxDdPvqOfbtAqJSgrrUw=; b=Ct/rkryFmepW6OslzVOO0rbdAl7kDodiuWSB9bd6kgQB0Rkd+FnpYHZMT7U9qOccgG 3SiS5Etr/SjbThOeUdU1DPBrEd7LXA1FEjBOD9PYsc89PWQ9h56DJyJpB8T/9jTmGE4Z dtj0X7eBsZRUeSLMAGCcQcdtQzxDQiGSuSf7fTOvFnPVGWdXM5FTNdZcNgwgMG9boSMC 06IysnSz0dRiRejR2rW6/ZrOemnZinZXwchXJ2l7M89yODvmIMMBlpPQeM/KrF16XHp5 3ylhvLOcEzoaLzlTuq96Tz8pegktlzGwQpjWHlVR448H71LDHl22Oggx/gMM8Tpw5qgV RSjg== X-Gm-Message-State: AC+VfDwa81lK6PnvsZ6SkzoDnXx6xYiIqjznFdli8J5D8dDrrKsyYEiA uMMoFNpmTzy/PBmGBfTpb6qz0A== X-Google-Smtp-Source: ACHHUZ5rJ2De8akBony3bYEhb8qsybCB8JhJ6D24MoOXnAHLUN1yyk7C43ZDv6xNI1JKHjcHFiEipQ== X-Received: by 2002:a6b:b2c7:0:b0:76c:6fa4:4df4 with SMTP id b190-20020a6bb2c7000000b0076c6fa44df4mr336763iof.2.1684180540777; Mon, 15 May 2023 12:55:40 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id q3-20020a027b03000000b0041672c963b3sm6021255jac.50.2023.05.15.12.55.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 12:55:39 -0700 (PDT) Message-ID: Date: Mon, 15 May 2023 13:55:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 4/6] io_uring: rsrc: delegate VMA file-backed check to GUP Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , David Hildenbrand , Pavel Begunkov , io-uring@vger.kernel.org, Jason Gunthorpe , John Hubbard References: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> From: Jens Axboe In-Reply-To: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: xazksary4tqs6bmt3nw8zsbb58s78gth X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 17C12180005 X-Rspam-User: X-HE-Tag: 1684180541-105850 X-HE-Meta: U2FsdGVkX1++kvIxBcuLvreLbdbUMQbms6NYL/nhLcVoCXfBKDfygd+3nD2BxgDxCPJT0GCgPWq47OfSL6Eb0OLs4n6dBQw3J6I2xDY6lSOurU7egk7bpdwZehYfo7p5rCy+oOCVI65GAw3KSaCliijDEtugQHtES/HCHptf233gv6WHydi0UxQG8f/pvE7hh7sZV1s7BInoIOwG7AzCK8oMDGC1bJSjdbSxYl0x7yixBjttGxwgVOzpqnvjuZRIaeJjybHZJDbnPGAWT2ZZikNsQ5E2NgGzaQljiu7RTm2VXpc2twakXo5YSlq5fSGh2+Azy0kZeCBCGrlSVVYF8CK213Z6tdU3gjB0bIiW+KcheYdb5RRP2u1KpXc8n0UlNiCseisQ61m9vMr5KmQODdmJ2nY6U4osDcOUYjmeAeuN78nyjBYeTqNmD2Zyuuvlv5SEkHAF3FLtlpoK2450QIcdaWX8OAEfMHPUBnNvY2mMXX5bH77Bb6P4l4jAdScJGik6DO+/i8DPHU4/E58IFJVvXZN6vRYb3brgLJpvfxVigouFX9tdMZpsdsFk5vHi6yIdRycgaERQb6MMhkzutWFv6AYcsjbcXHuIZUq7T5J/K5ZZzeYbMjwpTHXyat+q2vYzcQptzmsak2qEzlWU2qDPsGVwjzgRKAg6CDpO/T88j8Lzr/ivNKYjP/PLqz1fhN/x7aSSeovTZwzn4FTKmHEXkZruEbN/xEq60OqQnoy2NWi79G3zLXH0h7l+UmeoIaOyEBwB8vTsalwCNmO/BV6hEBt6V3qObdBITMqhiOpWxnu/6cAjBF/a1dVpXuN0bXQFjbH4pPFj6gi0RT6ttczdui1bWUcHxpIQYOG2ZMaoxuQ2feSbjyEUS+g08uxZPEwLVva0CWR79CSZ3X4a5YwkxpkUUhIAe9dYTCoZtZX7qCz2gfufe2B6vPOEBOnQUtDYa8XtmYfY7oJGXzP 6CdfL9zk FqDNPqCU4eqTHFK+5PukpRBBrOTkgwR14vapEBeTEFlZhYuCzosEQupumJ3KnIZEOM8AcGXA7I7Ur8j+ZN8ubfkUWbCaMjEji8ngKvJwCJphJVhWFtAblNwacqKE56pr5WcFr10xIbUfLm96Rlm0qVC0sqRCIxUsqQAzsOMm/ivOlWx8yKqR1GCMMmdyybeSq12UxNGAZoBzUy74JEx7cP0lSQ20/9xBMbsqd2ZUfg5zwMnugPog8mJ5v6/kxaYo5qU8TRDFW1dRDlmxo3wL8W6nSY9cmLr/h+AkbzBUfClRzYw6e4hukMh+goxtCTEI4VH9eYYybQ5rkLGyIFidCOExU7PU6YUTGZkp0Blwo4mgqbNux6lsVovG+gkY5ahGHI7oaaTWebLKT9gB5LY32m6v6/MTtYNIV+y8v5gZ+zZekT51ACqc7luYvZ6rVhroeibMi/VSlK0Tb2DebWMB/PkIcHe6JmUMIK8RzKsMzFnzQZRTFl0nZZcqIl/k9kr/256oF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/14/23 3:26 PM, Lorenzo Stoakes wrote: > Now that the GUP explicitly checks FOLL_LONGTERM pin_user_pages() for > broken file-backed mappings in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast > writing to file-backed mappings", there is no need to explicitly check VMAs > for this condition, so simply remove this logic from io_uring altogether. Don't have the prerequisite patch handy (not in mainline yet), but if it just moves the check, then: Reviewed-by: Jens Axboe -- Jens Axboe