From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91F8C021A4 for ; Fri, 14 Feb 2025 19:55:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48AC7280006; Fri, 14 Feb 2025 14:55:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43936280001; Fri, 14 Feb 2025 14:55:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28BEE280006; Fri, 14 Feb 2025 14:55:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 09584280001 for ; Fri, 14 Feb 2025 14:55:40 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F8C3A02DC for ; Fri, 14 Feb 2025 19:55:39 +0000 (UTC) X-FDA: 83119605198.30.E6953B7 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf10.hostedemail.com (Postfix) with ESMTP id 52F19C0005 for ; Fri, 14 Feb 2025 19:55:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IYEA2Asg; spf=pass (imf10.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739562937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4+LoXpfrgDSf4eTxSryrK2E9ZTYHSXCtzs4AgfEb7jA=; b=NMmCkyOBiVGlvwS0MYH5ULOIvcxBXL+QKE3AyGHd0J6dfeC1O2F6zXUyXSThyfjyqie45l xGGCi/rblZdh3hf2cVr5wodPTthVZBf+UMN1ujFjNy1t4nQFOEKo3w8RllYVL40FvN6ocZ 3hvO7+m7OV0SXDGTUCkJ/s5/hh6Zm5g= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IYEA2Asg; spf=pass (imf10.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739562937; a=rsa-sha256; cv=none; b=CndjrG0i71o8Zsqi4oxi7bFC4lFNaBa5sP1L8y0Sx5Cn5h4DeTazBTl0TGA3DmWeUQXHcA X/AmR/vdSgUSwxMgkwN5nNQD7XLOUvU88aGnMcu2kE3bX9ZbSfu0OkjX6YnL1/8KYAVFXs OVaF1pWny5/V8V4i+sCpcOTwdS23WbQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739562938; x=1771098938; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=OYYhEDQ1tch4O5reJkYOXYrvSejqt7GywKWwMTBWQOA=; b=IYEA2AsglzWBK13fnshitwXIt13iaPDmkMgV+NR6pi7xXYPz7665dDPc xYQU51jlATCgYNTqnSpa8E1Cv6/4oK8U21cnSMYGDVaARImM3B5sobWrV poQpQydlGWlQxx4o3fs4zjV3wYOm+CWRr3grMLMTpFOsUHikxTIjgzrz3 CxnBqCxyyma7sPWbiRx3NJw9iOhKZfBuqqFiVQlcti+LTX7XqMaWbkUCz O9q8goBNQdYW8RBKGx77Az6lk9LsKNonvUR7RLYiRGBe9cXn2t4iDgq9P DC79PhPAY6vL7izbPch04e6RJROJPltNs8EUftYoeThOKH6GAa2CS/Akn A==; X-CSE-ConnectionGUID: yke/BuRDT7qMpBOd0Wda7w== X-CSE-MsgGUID: OmaahVvmSK6lM/bkbgY3BA== X-IronPort-AV: E=McAfee;i="6700,10204,11345"; a="40247141" X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="40247141" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 11:55:36 -0800 X-CSE-ConnectionGUID: QEDwI6BIQDioSNA4kmn/pQ== X-CSE-MsgGUID: Me5V3t4gT4yvmI0AE7PoUQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="118649613" Received: from tjmaciei-mobl5.ger.corp.intel.com (HELO [10.125.109.21]) ([10.125.109.21]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 11:55:34 -0800 Message-ID: Date: Fri, 14 Feb 2025 11:55:38 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes To: Peter Zijlstra Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-7-riel@surriel.com> <20250214194013.GA2198@noisy.programming.kicks-ass.net> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250214194013.GA2198@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 52F19C0005 X-Stat-Signature: bywasfd8q856f4syxsbkjcwodgs9oqyo X-HE-Tag: 1739562937-731966 X-HE-Meta: U2FsdGVkX19XzN4qZbXMmUq1rCSYQtIypL4kGnO+hXnUfsOzJHiYiZ8+KBZkG6d9k//CvpcheFcfiRuUDE8IfCoVi74eJIpHCt9BgoIREHFXf+dub24uuEOb+lNmgwOlzV0TQw7ZUFCz6cSkOI3p7yuLoM0mBdPYozZYdkhdvuxPI6MeuXs/f1LQVP881tYHVioXpRbBh7kAHSL5kY4pEKlUZuPylYfX9JPkryG85f09mDU41/kQzomaUncYbPVhAI2krYDXnDqphbHAjJfNZcuIrtxCx3UHNzQ4EAYRXhFEv7E8elW+o5vzP57LuY8Lc2qpwULud460N+TXmH/SArgOPwTYpxEz0+xEUckP1xnyr3NfPBlExlQRyhjI51EM07pWbFMzThU8i9UqEOduT5jvH0nvLE1pgEEaZLX8lDivBA6DyzHgyVuBt0i20cWSwvgxGePfgYn4CNaRWk9WI1oRVUlrhS9PtuMXxKNlhc3TYkMtUa4mub6qyoJsfDddHMq7e8QcL3jwIGm5PvJsH91/tgvZ1jnGb2RufcCtD79VEsRGnItW3Vx7PPKSE/VU8+HDwb9/Z6+EgtVt8hTi/Q5LVXk8cH2k62c/oHjiomz42yVXFy459XT5YC8L9wCXIeaNYoxXtRL1YdbBDW8/UQ00p905It8dXCWwfEbOAS72ZRVt2UG7ebXkRfNFWso2WKC+cR/RHYXpHKMSvWimQxZuDWyOzyYjOXG3ofyfLhTgCixAgAAvCMHLLgHte6f0//pQroW/S6aGB3MW1J210scjB4m8zOEQa4WbngrWSxOLEl0Hz9L4+kvtWNQ/LF784Q/vQKnkitLquTdkMaxwJC3hFulLqxFjSqpfRLCQer2p7GUa5H2icZr8QFm5WNXiJoFhBPyF+uikzgBHJvbVT6U+RRnATgBiCDCEKzyY5cRhY0s6vF3fxK8+Fnp9elTVxACawb+Lpws25maMZl9 1AOi5SSC JcJucZVeui13s5n87Ci5ndiNUgjbvB0scJ1kYagLqxe4gRE905zUfGbeFyaOGBcWHFGaSnRS/z8qBMGrhH4GWO+/E1c6WO9aZl09JAUCQLRq77LCdM9GxGWmlrd6p46DYZVEcOBq3zqU3VJ9A6kPsoPgSA1zXN0mc96Q6Tu6NdYgCK2+VcHqf4UBMxTTVwe7um2sHh6EQS1UdTNOWl65CRQmGCfoEWkhvuZlfXXJH0q3km/sPNoiC+bp+P83hw0EwlXKrunVZtxKrMK6ENyBzYAoDIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/25 11:40, Peter Zijlstra wrote: > On Fri, Feb 14, 2025 at 10:35:40AM -0800, Dave Hansen wrote: >> On 2/13/25 08:13, Rik van Riel wrote: >>> - if (info->end == TLB_FLUSH_ALL) >>> + if (broadcast_kernel_range_flush(info)) >>> + ; /* Fall through. */ >>> + else if (info->end == TLB_FLUSH_ALL) >>> on_each_cpu(do_flush_tlb_all, NULL, 1); >>> else >>> on_each_cpu(do_kernel_range_flush, info, 1); >> We've got to find a better name for broadcast_kernel_range_flush(). >> Because IPIs are broadcast too. The naming makes it confusing. Why would >> be broadcast, and then start trying IPIs that are also broadcast? > IIRC the more general name is indeed broadcast tlbi; as in other > architectures use this naming to mean this very thing too. > > But yes, I see the confusion, but I don't think changing the naming > really helps a lot here :-/ Fair enough. If we don't have a better name, we can at least do: if (new_bad_name()) { new_thing(); } else { old_thing(); } My real heartburn is with: if (new_bad_name()) { new_thing(); } else if (need_thing_1()) { old_thing1(); } else { old_thing2(); } Where new and old are logically squished together.