From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6BC9C52D7B for ; Wed, 14 Aug 2024 10:20:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 422986B0082; Wed, 14 Aug 2024 06:20:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D2896B0083; Wed, 14 Aug 2024 06:20:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24C2E6B0085; Wed, 14 Aug 2024 06:20:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F12A56B0082 for ; Wed, 14 Aug 2024 06:20:45 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5CA31A7F97 for ; Wed, 14 Aug 2024 10:20:45 +0000 (UTC) X-FDA: 82450457250.26.578C159 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf01.hostedemail.com (Postfix) with ESMTP id 6B1744000A for ; Wed, 14 Aug 2024 10:20:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="d5n/xgrF"; spf=pass (imf01.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723630808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hS8lGCxtgdQMkLEIv96JQJSW30lCVa7QFTqxjW3g+JE=; b=o91oUz7ZmeSXGdqVrbPTFOFjFpDEMNF6S+ySJuAOHD5XAe75DS/eobNbUf7if6Z0w5I891 i2B6+ZIivO6s1C71KCUxRJZywrNvCsk4OEIlL8EZ7DEbPqeuU+ZTTUOpMRC6JRIhLF5FsF iFc8MTA+KQlkJ1M84lNwUnZfFugMxS4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="d5n/xgrF"; spf=pass (imf01.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723630808; a=rsa-sha256; cv=none; b=GOtXQNAs6wxfZ42FCJJr9/TG623aoE0/03AiTGZ8vHCit2n/7+epTDc7h78+FQB6wjnsCB qRJRjy5k/umn9yUMPqxrEdHldu0JKs66zviuGtxwNdJKcWvyJg5aYNgEBOSMuCxMNH1eKF Z3H5bnGfye6bTzKE5E8OkI1JShNWuME= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a7a9cf7d3f3so752535066b.1 for ; Wed, 14 Aug 2024 03:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723630842; x=1724235642; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hS8lGCxtgdQMkLEIv96JQJSW30lCVa7QFTqxjW3g+JE=; b=d5n/xgrFuU7ZI32CvCefD8ajAci/bV7K4bk14eEe5jMrSoW+r/DsfSWiupnyCWoIkf BmyR/cFPq1HmIzEZDF8BKPz63ZmuNEo8fQARk4TKcDZ85+ELqiAO6VxsPUuR8oZItoKZ BbNBCJjTkt01n671ZPdD399z6uCAXuZ4y/kaiVRkPV3rOfPvgaJtdglNABWwO4yHzGNR jpgQBeOHi/JFHhtfLo1dlABpXGN19i4CcRNDItmKcU9FDDGJ4JKPoox6F0RR42gHCs9q 8M7B+v+b8omuaykFWk2JxRX0sDxcOpYIqcHZ6tlsd8b7Z770g5f3WklefSnWIzlpDelK JEeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723630842; x=1724235642; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hS8lGCxtgdQMkLEIv96JQJSW30lCVa7QFTqxjW3g+JE=; b=FJb3QoflwOZU1uCBlyBA7mLbgZBa+CV9iTAhzs//OEhxKnkVDC9459IfLirCquRiAW gHH0qeYasvf17yCLWSpKqqcy7XS4fVioNJIxY+6fUP0l5xmLA3ZLzHkaPQtNT17C/1Dj GoSNbC835dtCu3twV2a6l/EuMOHGQoNwtjSNwDmOUu8LM6oznqXlJkbfTuxrf7SpEnog RbO+GyaJwTJSy8gdoJHEDk2y/16f42vshllGN4Hm9lYYlp+757KQjvZS9hKA/Jjp1TQN j5PYLIabM1QSjMrtcSYrrGB3/QfOqgRkza6Dmll4dyYjAdyB1CAmCvdomFRvZbKUSllq iSSg== X-Forwarded-Encrypted: i=1; AJvYcCVGqfjCkoHFjjnya3NWWyskMO/rClJAGJiTORjhKxkxRWRJJNojHCDlDyVkT6wzOpqwdUPZSJkEMYChtXaREa6+u08= X-Gm-Message-State: AOJu0Yzn/EEgp1WrDgrS29rfbI8sx7hj5QVjkOWEEWqnLCln6cY049X4 rLJUGoIDRo0shPXStVkHQJs0IdCmmCkflKoAOfpJQUDs6Kk+/OAm X-Google-Smtp-Source: AGHT+IEz6IAV72R1dG8IaxpUSGQ4yh+slaUPRbi03CQplRXICCbR7V3r/2VG1ZGOj+YEeOWjUIf5Rg== X-Received: by 2002:a17:907:2da2:b0:a7a:a6e1:2c60 with SMTP id a640c23a62f3a-a836711e423mr116134366b.61.1723630841458; Wed, 14 Aug 2024 03:20:41 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::4:61b7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f3fa5db7sm155096366b.58.2024.08.14.03.20.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 03:20:41 -0700 (PDT) Message-ID: Date: Wed, 14 Aug 2024 11:20:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] mm: Introduce a pageflag for partially mapped folios To: Yu Zhao Cc: akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com References: <20240813120328.1275952-1-usamaarif642@gmail.com> <20240813120328.1275952-5-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6B1744000A X-Stat-Signature: 3dyu41pjko6xsad5hoeo5toqazs9ntph X-HE-Tag: 1723630843-390477 X-HE-Meta: U2FsdGVkX18qhNbJgdyOidDbEb5uAbLz2Q//7PnEQ4BL2GI5QudhDoRrGey6GXE8Q5L2q7sbeYDeIA4YICw0SovxYRPFK4gFSk6bcYaUmI+mVl3nG1NuF+zPfTIsOHzqcNCSfVS03mQuw8gmqBDqcNC+F0nFrAHZvU3dBQLaWGNjgjuR24d3CfrJF9bGMii55zZMyyeVFFHWOgvr8MLtE+V73zLZOxpqP7/kO6HG2g/A8Yl/rHATMQyc5pZUd6ffCtoGKuT2d7OitWQHYGsp+4Qvhp6JFFnUI7whSL7Nqa9qafvStv7p8QbUjDGLuHh+Kvtgw785CKZxz0pV0ShsfbDEr/a+x6VEkQpo1Vb9rkpuG6BIRxlCwI8mOLn0Qdg34C2eAfgzlyrhwTN0rY1x53mzDCwmtSXqWoN2+5XrrbVFl4FYrKXZV9TJ3gixd0+0DUS0TOmN2OrA7IZ8EIk7wdJkaC9GsDodmIqpgXM5E6n6a5rEqBUFLum23AQUOZjsu/gjQk39Bd1b7e6FqPOdHXbqJ2Pr+jPTTXrHCtP6O++onlZ7Xnp3f5E/lMYmoJ62FjBFA+JfEKfCdkS4sgY5mf+LkikbgIF3tycqyJj10H0e5k0Z+SufU5L54Lly7YRWrhAAbvAq6o6ay7nUkSuT7/00Y8zv0AWk2+/RU78yPGiyn9T7/QFtcC7Ay6ByQ4RNcDUE/YKDW6sQGD1qfhU102lbkbiw2U2N62SVlduf2VS+urYdrtd4PdysLTbYZapcgHuULwcQF2p6EiO8c7OMzVdvjUCL45kPiThaGxKW8CoWm0idq5y51yFS0Ujm1IDuR6/QPFTzTFxYWx6jUwxl76sWWSrhVC35K/NDQtunutLUFgC+G7gGq8eksBU5BYBYaAGzX+N7doOLJjpCUPphcWLFuDi9f0FfOwtt8MO9nJzFYcGPBKHEYHwLI9AXodsEJZU/gfHoZdveSY0uFbt VDnccYls gS8+dmfl7D/NLxSGI5CMP4wvTrk6rEI5OwE25pP47nJqZAUB2XLcK018eAOqCOYJrdCtIImYgn1zkPCqdwcEM6A+wA9vgZ+6MBALxb7ZKVUjHqLovlYJ1acUd8RQT7YlbliY4YnHP6wURC4ENk8D/4k/Cmj7SaIQAITNe9FHnOzQAXJySyUXyYE61frbA4VCfXaGxNYEToFuLB4rRl4mlOF/zQyLp0IN48YeQvYbajOkC32M75jYw9TsRuNQsRULv4OQO0GAhOKsfsWHOlv3ZrTEEduwLTHBXLymEmBaw1Sfu7Rsfj7YCp9w/gcSpR1bkrRJJH9Sk9cTAOclCwA17M2H8e20I5KL6GXNrBhFDNqBmPalRm0HEa/WEKB1fa0l1HCYEOWpUtD3Pw1/7/2SIC9+o7DTNqJXXdWS9wIdxLu0sFGI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14/08/2024 04:30, Yu Zhao wrote: >> @@ -3558,7 +3564,6 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, >> next: >> folio_put(folio); >> } >> - > > Unintentional change above? Yes, unintended new line, will fix it. > >> spin_lock_irqsave(&ds_queue->split_queue_lock, flags); >> list_splice_tail(&list, &ds_queue->split_queue); >> spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index 1fdd9eab240c..2ae2d9a18e40 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1758,6 +1758,7 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, >> free_gigantic_folio(folio, huge_page_order(h)); >> } else { >> INIT_LIST_HEAD(&folio->_deferred_list); >> + folio_clear_partially_mapped(folio); > > Why does it need to clear a flag that should never be set on hugeTLB folios? > > HugeTLB does really use _deferred_list -- it clears it only to avoid > bad_page() because of the overlapping fields: > void *_hugetlb_subpool; > void *_hugetlb_cgroup; Yes, thats right, will remove it. Thanks!