From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74ECD637D0 for ; Wed, 13 Nov 2024 22:42:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 254AC6B0098; Wed, 13 Nov 2024 17:42:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DD146B0099; Wed, 13 Nov 2024 17:42:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 055EE6B009A; Wed, 13 Nov 2024 17:42:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D8F006B0098 for ; Wed, 13 Nov 2024 17:42:33 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 810241C6B15 for ; Wed, 13 Nov 2024 22:42:33 +0000 (UTC) X-FDA: 82782544362.17.719AEFE Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf01.hostedemail.com (Postfix) with ESMTP id C34C94000B for ; Wed, 13 Nov 2024 22:41:57 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UKgmm6Sa; spf=pass (imf01.hostedemail.com: domain of rientjes@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731537557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ieehf+E6LMEA4ReJKxyD53FpolrCogZOFJkea/91AC4=; b=Tl+F7+QyLfEqOOvcJVs8/k9Dy4KqiVOmidXpNNaEwBqlynuh6IN+9rb39petz8zsPEI5Bz 08vqLU1t8iRK5TONg2DcZhxHviskDX3Y4sLKh9/qxTKc6/Ocj3EUXyATypEmaowdC25tYC WGfp3aCa+KDRbzxN0mo0b+gbscW/pVs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UKgmm6Sa; spf=pass (imf01.hostedemail.com: domain of rientjes@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731537557; a=rsa-sha256; cv=none; b=2WAL8THtaWrhXNjbkSEqBkOGxr279HjXKKB4VqstlUu71ZZB9Osi8ELf4BZrA95oytR1OM 8WPWnM7zCcS9mRj1SJ+ipJEb5MXj2NJHcMM0CErJcFGVP5uM1dOWaPz9Y/RrbsiRSWt4Vl Q7lPR8BGoyPv1ZFOngJ08iz1C0UcTVM= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20c87b0332cso7255ad.1 for ; Wed, 13 Nov 2024 14:42:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731537750; x=1732142550; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=Ieehf+E6LMEA4ReJKxyD53FpolrCogZOFJkea/91AC4=; b=UKgmm6SaUzdxR0IfCxo+j5OlYNv5MqrXg3JiOvS+dlGAiiHePUwJJJL28GKNN8RGVE 26GDUQQmFxNAdhjCKuOoHtmJCTT9rdN0OeAmNyQT/h3P2yrNJfKbaMUZ/usFaEUWyD40 NdwEAqIqUSVbV91RDc+9vPmzdar3DFcWNfMRusQ65Omls7f7K8oYMloAXbBVTASm5ZJ3 KmrmDZp18b8IwVBL5mHo5cD5X1wjKlvTi8t6LyKxVxD/swmcAM7siLubht3Trw4ypgfO +p4nI0eSVGwL3T3+KlFlzV9o+whN2iSmyOGsVThBgIL07wzHgq9FLdYqesz3V+VRMo7O jbBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731537750; x=1732142550; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ieehf+E6LMEA4ReJKxyD53FpolrCogZOFJkea/91AC4=; b=X3GixL7J/6DTHG78UvVLW7oAu22yZL+M7Vb3UFxLD7GVeAk3mpiHUfVqcbo7rUK7l2 ljWN88hlmRtRzZF9qQJ/9qdKZXx2+GohawOaZXxN7NzsLzdZ2zngGbr2xPQj50TUPQmv Hk/6ZR6/e8dXgI/81TfVFXYwIozWAHqYaSyDyDsNoPuDiotRBGlt/3S4BchfHaLwl/2O gPyudsBeuGDKqUKTKU0rzbqqOPrqXgMGrmp0fcXOPfgy+jUA94Tyy2vaBsFsxdY9xSVf l61E6CAyvOR+nukC5K4d4OahKf7eyqP8aE4vSPWuJpLi8k14UkjcsCSWHOtpsQUo7XRX XmDA== X-Forwarded-Encrypted: i=1; AJvYcCUWQSMntYLMEVCnnRg9wp4qHqM+jOAo9E3X6jC4EiQhNywbxVUX462qiFRfEZH/iybyseXWXZf+PQ==@kvack.org X-Gm-Message-State: AOJu0YwIQYL8i9/bM//gz6Q+khSifAf8zLUeLwZeBo6MqhjNSAmVK5Cw bonjZ9imnBL9oN0r/McmQXuFPdjFkDb+F8vgWTAN1wXE6mAYbdfArA/08rZGuA== X-Gm-Gg: ASbGncsOVfbjUGuWowV2qE3KS4TJwcjtPMX1CkBR9htkgF1a4wQ+zmkP8OTGiwERLQs 6CCYsDizw7qmY8UVM8Ku1PzvgfOvbdgi8nHU8ata+tisxme51+QXoBP/g9eLcxvCCF0fiyVC5Mb rqn+FXgWkX9iUeMsMtQugQfDQDUnMAY4Soj0JnnZJ1bI4MDGYF+eBZAhLIKPDbmFJUJXJSOMUC6 uDyZMwZrCgnXNbZEe67EPiD4LULx60VtD8JmQ1anuf6p0b857wM9C/EbYqw0lfqxbrQ7b/6VoDK t/Dj X-Google-Smtp-Source: AGHT+IEEnqKMwGy+6M5UqJv9rrrpl3mUiwwjrWvoQVOQqROaho6ADPFiiCjrnLC1sQ4UdZv0xFkCzA== X-Received: by 2002:a17:902:ea10:b0:20b:6c3c:d495 with SMTP id d9443c01a7336-211c369658amr254265ad.25.1731537750084; Wed, 13 Nov 2024 14:42:30 -0800 (PST) Received: from [2620:0:1008:15:93ad:2d94:6e99:1a3c] ([2620:0:1008:15:93ad:2d94:6e99:1a3c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72407a18f51sm13753218b3a.155.2024.11.13.14.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 14:42:29 -0800 (PST) Date: Wed, 13 Nov 2024 14:42:29 -0800 (PST) From: David Rientjes To: Joshua Hahn cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, chris@chrisdown.name, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg In-Reply-To: Message-ID: References: <20241101204402.1885383-1-joshua.hahnjy@gmail.com> <72688d81-24db-70ba-e260-bd5c74066d27@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C34C94000B X-Stat-Signature: bjwi5abzymcg1or5bz36a5xky7kdui5m X-Rspam-User: X-HE-Tag: 1731537717-549707 X-HE-Meta: U2FsdGVkX19QPGTsooiP2RhOwrZi0vHst3/YQ2pZXVkIvE37U9dGV5JWRFp9UTjWeuyjMV9zqKhoNRXQnFCagmqjbRi2c4H76GiBK1nRi4XOoocbRr0FAos7PoJWZh4t0ey4xRgrqCjYKNMjYHuhVxsSQADMvI/2c/dHiUtkxpD2xsSuElKnZ0U2OcJnYhGaIMa1fbn7PSIezRx2XNldsaOQZ45xsl98AMb+8urX2tdAU9YjTJkd02J2CtMLjOypTZSBhGYvIIeF0FdfrbPV+EUsQ57e1UQogGfZjU8Dkwb+VEjWf4U4z3R61vIAl6CUku9qHRn492xvwm5/PZ4YhvX5JoqOjfXXdx9gPZ4SmAB4No5jR4o55nbDGzEoP9M726aj8GhbR4alkxwBe1yEQvNEx7KiAnd7uLpCDmMfcwE2QNRhIYHEhAanqjAWjk58JYYs8Ms++oC/G4SQ99LWb/rwJ6pQoVpm+ow5LszoSpBWotqcGnwm3iRQjNcEfYhbDI/vIsC0443KHwq9kntbdH1hl59+wPPtICwWQESBn+i9ApmNHDwCkO3rmqRXIVIFyQXA91BgYITwwoNE8DOB55RDDYNaP8dpLuSOCJIksVWlLis/VOzFrh2hA8y2exKbAIODeyPtTpEyrKbsqi1lKnxjoM7rs0E1jAlrfA5n8Sbu2qw4qIP3BPfRt7qZ+iy+KctI8tesIShYf8hFfISHQkufnta4cLGP5IF3XXEVHPPqZy83kUGFwIDRyQrKUPHkFFkb0z7JJAYN+KjP2pHRYp8TPk8jOUA/IwJ3iQ3/Tf0QhnTx+3KLyA/aAyiIMdOT4wvTbVLpZkrhfLNkSPw/SPDv87SGr4ttOJVk17/JvpiWvKeCROhR2ezF8hpQebaMMxTGLnN8+gJ1XvfUBU5YECur0kP57LVRKv/O82aAq0Od4EgZEHBOBbEVVlH1UQF6yg4se178OQ2p72CVSst O0KqXomY bs8ZHfHPhUm5m+URsrOKzyWzGEN0QOrVGfLvGitUFSH7CvskXYrMAtDXcUp0UFkmyLYOWADoBdxlNwSZF43ytMGeOBbq8WEk+NZiNqma4VunaKCGvXeLfao7/nxG5AeZ1a3hpbG5+J0UfhyS5BzOQK2qZYSPjX3OOGhDwx4NI1XSaOBfdC0wHbc8pxF7Q1iRhCRYzcg3TbrgvBUy6NGMUfXuk850SIiJPcvktnL+r3MGC54HZJJlMb87ik5up34FLgvymDl/g238Bp4JYKEjl+9UEQxbVhVm9+5yPUMUfYgZsa2vumX9DeOLfW0mXOC9FnpcKiNrRIO9llPYiDVuxIE/tPJZMJSgDjKuBbWmJ5dI4YsQKMvkR+3H/X1nV0J5ZJLhzd6Q4csfsXYDywZ2VrSeTrcCAfl1BrMpJS2GWo2/O6DGcdbEQTVi9k15uuDbbcEaC X-Bogosity: Ham, tests=bogofilter, spamicity=0.026181, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 11 Nov 2024, David Rientjes wrote: > > The reason that I opted not to include a breakdown of each hugetlb > > size in memory.stat is only because I wanted to keep the addition that > > this patch makes as minimal as possible, while still addressing > > the goal of bridging the gap between memory.stat and memory.current. > > Users who are curious about this breakdown can see how much memory > > is used by each hugetlb size by enabling the hugetlb controller as well. > > > > While the patch may be minimal, this is solidifying a kernel API that > users will start to count on. Users who may be interested in their > hugetlb usage may not have control over the configuration of their kernel? > > Does it make sense to provide a breakdown in memory.stat so that users can > differentiate between mapping one 1GB hugetlb page and 512 2MB hugetlb > pages, which are different global resources? > > > It's true that this is the case as well for total hugeltb usage, but > > I felt that not including hugetlb memory usage in memory.stat when it > > is accounted by memory.current would cause confusion for the users > > not being able to see that memory.current = sum of memory.stat. On the > > other hand, seeing the breakdown of how much each hugetlb size felt more > > like an optimization, and not a solution that bridges a confusion. > > > > If broken down into hugetlb_2048kB and hugetlb_1048576kB on x86, for > example, users could still do sum of memory.stat, no?> > Friendly ping on this, would there be any objections to splitting the memory.stat metrics out to be per hugepage size?