From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 912EFECAAD8 for ; Wed, 21 Sep 2022 13:34:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D07696B0072; Wed, 21 Sep 2022 09:34:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB620940007; Wed, 21 Sep 2022 09:34:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7D416B0074; Wed, 21 Sep 2022 09:34:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A58776B0072 for ; Wed, 21 Sep 2022 09:34:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7813AAAE82 for ; Wed, 21 Sep 2022 13:34:10 +0000 (UTC) X-FDA: 79936186260.08.B10D340 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf20.hostedemail.com (Postfix) with ESMTP id B41DC1C001F for ; Wed, 21 Sep 2022 13:34:09 +0000 (UTC) Received: from [192.168.10.9] (unknown [39.45.34.16]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id ADB3F6602028; Wed, 21 Sep 2022 12:06:08 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663758371; bh=nuKvXuAY4Qozyni7h0nt+ch9rX1wpz7qK5yc710ELL8=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=AP5Ygg/TB0BOpHeku/CfraDNwnteQItCpz1LXbjC5qASX68yK99F44dzXYi8lI5xp IAslEbJqK1fKFDFTQJOFObd5vIBOaN3AqL5RcyETSQUxDDOCJxh+tisaeexMV7SyGM 4BNdWykfRlqZctcj3O4JxNSxJl3+OdYN2hlW61aFxXfXyqxTcjMK8Jk2zI2S+v/OAN feFEbtBJvWYOwt0JDVoJ/1MWipBWRyir3qOLMT/mg/RLnC0WqNSKOlpteE6Hxxot9n lgxx5eAlnwPMDCiG2KNzTZXRKb/69nHz/xBceFZcLdsmdTG5+2CIYS97i3jiDfAmkR kFMZThPHEc8og== Message-ID: Date: Wed, 21 Sep 2022 16:06:03 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Cc: usama.anjum@collabora.com, kernel@collabora.com, krisman@collabora.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Joel Savitz Subject: Re: [PATCH v6 1/2] selftests: vm: bring common functions to a new file Content-Language: en-US To: Nico Pache , Andrew Morton , Shuah Khan References: <20220420084036.4101604-1-usama.anjum@collabora.com> <01f64e01-580e-abca-2b86-aa586d987bf4@redhat.com> From: Muhammad Usama Anjum In-Reply-To: <01f64e01-580e-abca-2b86-aa586d987bf4@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="AP5Ygg/T"; spf=pass (imf20.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663767250; a=rsa-sha256; cv=none; b=LZtFyTiBA80DoZrXQCAGSC2lfvwvA6FRnpZxw/bivopt9Yrw+Mc/Ey8wWfqL25N9y6DEkG vBpLhJyFFRmCOcN1gliGYXhWR6OyglEFZfEvGLO3ONXim1tV5aoLHxb8H/NJDbgd6OZHAC gmV+X2ypg7ti76fFbdjBneZhU4K/mDc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663767250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jxDgQD+3OyFBA7sLYdVi8QipIjqfG6I40w80O3T4wGI=; b=eyzFr6ECp2Kf7s7HqOqhK1LTFibpqcKYHZBI3LQsnS+aG8bL9fDm3FEheTESqLAmEzrP1l i23vN9WMf9QfQd+18GJYaXrMePFSTkqRAh4WygngLrl8ZP+BvHBOl12Go0KLOfBIHpMUlq HFYT2/q8iVKqwiGaMZH8OVekvKJH+7o= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B41DC1C001F X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="AP5Ygg/T"; spf=pass (imf20.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com X-Stat-Signature: ffw4hmumeeopu6bc4eqnbrozu7dtg7ta X-HE-Tag: 1663767249-266705 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002508, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/9/22 8:06 AM, Nico Pache wrote: > > > On 4/20/22 04:40, Muhammad Usama Anjum wrote: >> Bring common functions to a new file while keeping code as much same as >> possible. These functions can be used in the new tests. This helps in >> avoiding code duplication. > > This commit breaks a pattern in the way tests are run in the current scheme. > Before this commit the only executable (or TEST_PROGS) that was executed was > run_vmselftests.sh. Now both madv_populate and split_huge_page_test are being > run as well. >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> Changes in V6: >> - Correct header files inclusion >> >> Changes in V5: >> Keep moved code as same as possible >> - Updated macros names >> - Removed macro used to show bit number of dirty bit, added a comment >> instead >> - Corrected indentation >> --- >> tools/testing/selftests/vm/Makefile | 7 +- >> tools/testing/selftests/vm/madv_populate.c | 34 +----- >> .../selftests/vm/split_huge_page_test.c | 79 +------------ >> tools/testing/selftests/vm/vm_util.c | 108 ++++++++++++++++++ >> tools/testing/selftests/vm/vm_util.h | 9 ++ >> 5 files changed, 124 insertions(+), 113 deletions(-) >> create mode 100644 tools/testing/selftests/vm/vm_util.c >> create mode 100644 tools/testing/selftests/vm/vm_util.h >> >> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile >> index 5e43f072f5b76..4e68edb26d6b6 100644 >> --- a/tools/testing/selftests/vm/Makefile >> +++ b/tools/testing/selftests/vm/Makefile >> @@ -34,7 +34,7 @@ TEST_GEN_FILES += hugepage-mremap >> TEST_GEN_FILES += hugepage-shm >> TEST_GEN_FILES += hugepage-vmemmap >> TEST_GEN_FILES += khugepaged >> -TEST_GEN_FILES += madv_populate >> +TEST_GEN_PROGS = madv_populate > madv_populate is already being run in run_vmselftests.sh >> TEST_GEN_FILES += map_fixed_noreplace >> TEST_GEN_FILES += map_hugetlb >> TEST_GEN_FILES += map_populate >> @@ -47,7 +47,7 @@ TEST_GEN_FILES += on-fault-limit >> TEST_GEN_FILES += thuge-gen >> TEST_GEN_FILES += transhuge-stress >> TEST_GEN_FILES += userfaultfd >> -TEST_GEN_FILES += split_huge_page_test >> +TEST_GEN_PROGS += split_huge_page_test >> TEST_GEN_FILES += ksm_tests >> >> ifeq ($(MACHINE),x86_64) >> @@ -91,6 +91,9 @@ TEST_FILES := test_vmalloc.sh >> KSFT_KHDR_INSTALL := 1 >> include ../lib.mk >> >> +$(OUTPUT)/madv_populate: vm_util.c >> +$(OUTPUT)/split_huge_page_test: vm_util.c > Not sure what this does but if we add a run entry for split_huge_page_test in > run_vmselftests.sh we wont really need this patch. > > I'm not sure the reduction in code size is worth the change in run behavior. > > Unless I'm missing something I suggest we revert this patch and add a run entry > for split_huge_page_test in run_vmselftests.sh. I can do this if no one objects. The run behavior isn't being changed here. Only the build behavior is being changed as we want to keep the common code in one file. You can add the run entry as required. I don't know why do you think the Makefile has changed the run behavior. > > Cheers, > -- Nico > -- Muhammad Usama Anjum