From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3E5C02181 for ; Wed, 22 Jan 2025 10:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0285D6B0085; Wed, 22 Jan 2025 05:15:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1A576B0088; Wed, 22 Jan 2025 05:15:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE27D280001; Wed, 22 Jan 2025 05:15:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C1A896B0085 for ; Wed, 22 Jan 2025 05:15:03 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F9171A1177 for ; Wed, 22 Jan 2025 10:15:03 +0000 (UTC) X-FDA: 83034679686.22.1A2C46A Received: from esa3.hc1455-7.c3s2.iphmx.com (esa3.hc1455-7.c3s2.iphmx.com [207.54.90.49]) by imf27.hostedemail.com (Postfix) with ESMTP id EC2C940012 for ; Wed, 22 Jan 2025 10:15:00 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=fj2 header.b=ihXdJZEt; spf=pass (imf27.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 207.54.90.49 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=reject) header.from=fujitsu.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737540901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PJmqa6+5YvJSFXbCbTqFmSedjrzccVJBKvlPj7Jek3g=; b=mOBKEib65Od5K/ECIL/kDHK1Hpe1tE3a4v4w7EfrugVMxp23NrOZDspibDc0vnvmnF1xvY kasSImtrExg6s2GIaBwgG4K7w3+uqaqZk6uEP2t/S49GGsz1dY4ItycyQ3rdRMFCm3A7dZ /KMf0fNB0ONjaC1y3XMDLzKUrg7zNL4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=fj2 header.b=ihXdJZEt; spf=pass (imf27.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 207.54.90.49 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=reject) header.from=fujitsu.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737540901; a=rsa-sha256; cv=none; b=vaKSy7kiDRGLUfnAZPQ6xapj/YT7hwSlpiCQkJS7Hd5PopJFyG9R/EAC7lgyISCJ35T8DM dcqn+BZ0xVMB0pFB8nyud5IzKFL6zX42ZJea+S8Q14gaUAleX2uEE60dT6WgHaQGu52EDl 3XWGv4U+zgRLPXHMjpEY5LLtsy2SEqo= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1737540901; x=1769076901; h=message-id:date:mime-version:subject:from:to:references: in-reply-to:content-transfer-encoding; bh=iYANZ/tCqaC/edrAvwhc6Oz8GW+jNwol931n+SNpf4s=; b=ihXdJZEtQDnx9FFhQaIc26oMit3zoN866I9LVxqdqnDhlzR1bT/P+tUW +C9jUMqSc+/2f8aZu8tO0/D6xWB3i8VJUdLx+nnCfnHN6TI63le63+pn2 1vqrpYGbpioOJc05mDhBLw+x63xHwgRAOFHkr+6VRopiDu2JQx7r+9v5y MvEl8YPhTfXtuPsnx5JPBgD+r2d5Pl/y+9AOSnPSoewyduEoGMBim8/IB fYQoeTNCVVgV3UB8n6NafMmsdIZ7fMfsxlCm8NXozrfvAozFsOdbib7+3 6/lPvQhPZF2vR93FGNA15E8k2vquOjRNGu6dH7Tk9UqLhdpEGt/cJFXhn w==; X-CSE-ConnectionGUID: 2e0oNnKcTDiHDxHkR26P2g== X-CSE-MsgGUID: GlY1HPbFQoaTyWzOYwMjwg== X-IronPort-AV: E=McAfee;i="6700,10204,11322"; a="187346875" X-IronPort-AV: E=Sophos;i="6.13,224,1732546800"; d="scan'208";a="187346875" Received: from unknown (HELO oym-r1.gw.nic.fujitsu.com) ([210.162.30.89]) by esa3.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2025 19:14:58 +0900 Received: from oym-m2.gw.nic.fujitsu.com (oym-nat-oym-m2.gw.nic.fujitsu.com [192.168.87.59]) by oym-r1.gw.nic.fujitsu.com (Postfix) with ESMTP id 96510D480A for ; Wed, 22 Jan 2025 19:14:56 +0900 (JST) Received: from kws-ab4.gw.nic.fujitsu.com (kws-ab4.gw.nic.fujitsu.com [192.51.206.22]) by oym-m2.gw.nic.fujitsu.com (Postfix) with ESMTP id 70AFBBDC93 for ; Wed, 22 Jan 2025 19:14:56 +0900 (JST) Received: from edo.cn.fujitsu.com (edo.cn.fujitsu.com [10.167.33.5]) by kws-ab4.gw.nic.fujitsu.com (Postfix) with ESMTP id EF735E4776 for ; Wed, 22 Jan 2025 19:14:55 +0900 (JST) Received: from [192.168.22.105] (unknown [10.167.135.81]) by edo.cn.fujitsu.com (Postfix) with ESMTP id 53FC11A000B; Wed, 22 Jan 2025 18:14:55 +0800 (CST) Message-ID: Date: Wed, 22 Jan 2025 18:14:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drivers/base/memory: simplify outputting of valid_zones_show() From: Shiyang Ruan To: linux-mm@kvack.org, david@redhat.com, osalvador@suse.de, rafael@kernel.org References: <20250107100941.1169222-1-ruansy.fnst@fujitsu.com> <20250108015223.1522887-1-ruansy.fnst@fujitsu.com> In-Reply-To: <20250108015223.1522887-1-ruansy.fnst@fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-28938.006 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-28938.006 X-TMASE-Result: 10--11.400600-10.000000 X-TMASE-MatchedRID: a3o/0593/lqPvrMjLFD6eDjNGpWCIvfT1KDIlODIu+X6t7zbE1rC9wYE LASKZobWy0hhEFQalUBWO5mjsSOMn8oEezHJzqplTuctSpiuWyUUi4Ehat0546MQi364g884JmV 7j1WQqoeX81JAaXNO9oUTeE9cUy1MrFMDyJP7G26sxn4GpC3Y2n0tCKdnhB581B0Hk1Q1KyIOsE CO9s+GHnQdJ7XfU86eOwBXM346/+zmIpG1PX5ZAoMeljBHWvjOXOWRU0JgVdI9SPDTwyGXZzzRM nvSrUvU X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EC2C940012 X-Stat-Signature: gt9bsybasgaypsoq7sjx1q15e6xxmx9t X-Rspam-User: X-HE-Tag: 1737540900-858656 X-HE-Meta: U2FsdGVkX194KvfYfoAH1oBu4S9SmamwoxeAoZ8c8t9EJmebSjLCnaJ+hU5uG/GfMriEcvT0WwVw9UFjRpcWZVWYfxKiIC6ANLtSnwQDrpzwWqsDhd91e9U/zlb6VuGupxHTEzyTbWFrunSjA2vpfNZts8Do457PqOr6Gcb8akxeRlYy4YdfF4HlkMruEa3mb8opZOhs/VPcKJyXujh7D/r/X/AX9hCgfzeTY0UDwySYWeGyTi38qS7tg3jSBi+j335CzO/UiaSBu8iYGU/wvYqTmdF9L5zdSg6PURt0XOsczcSX+8rW3bZJ4B2ymiX5+GR+Z6SV7Nwm08x10VgofsbxHno6SR2fncXfl/Uumy1tmNJNHbNdg5btrvG3uPY4m78y9mKEIlbmt5sSthij5lTRHLnjxUC+xt62sNWWAIxJ7q1/Y+HdRmdYINOhjKu0dAknyLCF1z0opRFhFPXrVH9hwwk6/fvYv33iq3LGA/IAKTFSFqasr/rHJSO7MsDOZ8uqBZS81ep2+E/XbpN9me1mbpfjybLnKnE40OU+LPH9kDzp0Gj1qnwFFS9cl/GKoPLKZF1P2LvAxn+uJhRzKsUNte+heKYm5MDV6Qc5OiaR7FW34SyVMsG43nuNK4SdxyH+6QCgzJLmyrSNdK77eSHFCY3W23LF8VBWvph+nv+MZ4Vy+XgnJvuENGuoHxF7dZlNAwawiwBkJdBFjw4WuveiUQJRrYAczT1IV1cGoIuAe9sfv+CBPemmuqvhNlJro6puH45r+0wToRF3kUHNtEZ/fpgNB3C8RTKVtYnE/LFmL2FuN0y1MFBz+93ZUJIjkGmektUeuluE3eaAZUSS7V5Wn3AIlGlkgCk2Yxn8/Rp2UJNyBHMM8MqkAmg+OpmSmrVIkj4w/XpBZiyEZs0a+bsp96nIvMvGHsiAS9GdODazN2s8+gS8E9InniJWmhE/8YU8i/cFqR5rw1AUYSt iVWqeoCT SRpLEGBCl483eqAd//pRE3v1wIBFCa51CZURDz4nYco8Rq4HzyXvvOMTOoaRw2PkfWGHQL8B2W9Yk2CcN4/mxBGmIfPGzpla4D3eaqU80sAFwaR5k09X2cwNwaZmolSdOXwDjXUVmRaPAVeiqczf4B9nRKVMn+aDTyBZ5ddiOpBFJ6KPTfba8NNGl7TSxOyyGByCOUj/oBsgL2QD7xhqZrfF53RgqAu83iKCG6bDSHRfUkgnCc30VoNHbLxuH+SEMRMGgrjg9tm87NwniWhHiUGI6Ou3vJ9GFchotX4vCS8MAsRIn9bpqodnQ1Ul3j603mdvi7BV1HJzY3Ue5pG2G3bnRPIrQgH/9etp5gfdq2ExZkE69xQD2JsnSyp/HOTLywPcDuHN2+igHAJ61fdUY+RqxOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, ping~ Any other comments? Thanks. 在 2025/1/8 9:52, Shiyang Ruan 写道: > No need to specific position at the first writing to the buf because the > @len is always 0 at this time. Use sysfs_emit() instead to simplify it. > Also avoid setting/checking default_zone with a conditional operator. > > Signed-off-by: Shiyang Ruan > Acked-by: David Hildenbrand > --- > drivers/base/memory.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 67858eeb92ed..92e6bc6eb21e 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -455,7 +455,7 @@ static ssize_t valid_zones_show(struct device *dev, > struct memory_group *group = mem->group; > struct zone *default_zone; > int nid = mem->nid; > - int len = 0; > + int len; > > /* > * Check the existing zone. Make sure that we do that only on the > @@ -466,22 +466,18 @@ static ssize_t valid_zones_show(struct device *dev, > * If !mem->zone, the memory block spans multiple zones and > * cannot get offlined. > */ > - default_zone = mem->zone; > - if (!default_zone) > - return sysfs_emit(buf, "%s\n", "none"); > - len += sysfs_emit_at(buf, len, "%s", default_zone->name); > - goto out; > + return sysfs_emit(buf, "%s\n", > + mem->zone ? mem->zone->name : "none"); > } > > default_zone = zone_for_pfn_range(MMOP_ONLINE, nid, group, > start_pfn, nr_pages); > > - len += sysfs_emit_at(buf, len, "%s", default_zone->name); > + len = sysfs_emit(buf, "%s", default_zone->name); > len += print_allowed_zone(buf, len, nid, group, start_pfn, nr_pages, > MMOP_ONLINE_KERNEL, default_zone); > len += print_allowed_zone(buf, len, nid, group, start_pfn, nr_pages, > MMOP_ONLINE_MOVABLE, default_zone); > -out: > len += sysfs_emit_at(buf, len, "\n"); > return len; > }