From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1857C433EF for ; Fri, 1 Oct 2021 08:39:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 419A561353 for ; Fri, 1 Oct 2021 08:39:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 419A561353 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A3A279400FA; Fri, 1 Oct 2021 04:39:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E98F9400E4; Fri, 1 Oct 2021 04:39:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D7659400FA; Fri, 1 Oct 2021 04:39:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 7A9369400E4 for ; Fri, 1 Oct 2021 04:39:54 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F15E92AEEB for ; Fri, 1 Oct 2021 08:39:53 +0000 (UTC) X-FDA: 78647220666.16.560C013 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 9CDF4F000AE8 for ; Fri, 1 Oct 2021 08:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633077593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V061dyxBi+78IoBs/KlOeND72P1bErBsApycGVC5Nng=; b=YiJ4R/2aNvCEJ555Z0qnh1A7DFKqJ0zXaSRKTi18WJJYj64jr9BGhCJP0JfJgjVupAgdBi qBRfFCSXQJlS+yawOQlvA+uRllDUKGnbsQgj0i0FcicgDHnAHxIVEbX/w4gZx1pSUCY9yb jX6BQ2vYu7lcd8JoOZALvUFWScTdfA8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-601-bCOZptKkNhuvKuowbt1Qww-1; Fri, 01 Oct 2021 04:39:52 -0400 X-MC-Unique: bCOZptKkNhuvKuowbt1Qww-1 Received: by mail-wm1-f70.google.com with SMTP id v5-20020a1cac05000000b0030b85d2d479so4343699wme.9 for ; Fri, 01 Oct 2021 01:39:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=V061dyxBi+78IoBs/KlOeND72P1bErBsApycGVC5Nng=; b=RQLP0JYynOYvZ3c+IFluhKPuHliJrqR/zV+zWcp31E2Zd7pn8f5j7zb//LbAcvDeR3 6eXM0DWgacyTQD9F8UiQHfuceVM2zNLCmmGEwyR3eFf5/8LtSHAgTqBagh8EhwUv4F3x Q8j8HQeI4zJKa1FwVJX+GpEGvUKlFP1bFPNNjww3e42J+Rfi+nsNuD0QP9ik97yYPONV tiRaK3olf652/MMQ+tbsAu0U/oRFlTRqiwixQc3EjE7WyY0sfQHeFTYXsM3y20y4lVjJ 6yM4S+Dv81azvLMQwNQy5/e7gGBus41eKGIXmKlN4dOPnQV/A9VHUSREyDaEQC86UeOu /XCQ== X-Gm-Message-State: AOAM533g+6Ou9i/n6U/zYMaW4uILhH3uxpp+PRCvaF/FDj7nCkU/eN0n aoSmMAgXTguGczTko5ahAqQi2irTlorttJncO20TDi/1Crh/hXoGUBJ0lN7Kp9wFU5h5d692alP wVw8LtNj5Apo= X-Received: by 2002:a5d:4a85:: with SMTP id o5mr10946248wrq.204.1633077591007; Fri, 01 Oct 2021 01:39:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpVtk0bDeSJVGMRLap4VtU1JiiUf/IRw9giqpf8aL3wTncBSOb/fQil1j7msArUuH85CUcyg== X-Received: by 2002:a5d:4a85:: with SMTP id o5mr10946217wrq.204.1633077590775; Fri, 01 Oct 2021 01:39:50 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64da.dip0.t-ipconnect.de. [91.12.100.218]) by smtp.gmail.com with ESMTPSA id j27sm6025639wms.6.2021.10.01.01.39.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 01:39:49 -0700 (PDT) Subject: Re: [PATCH] arm64: mm: update max_pfn after memory hotplug To: Anshuman Khandual , Chris Goldsworthy , Andrew Morton Cc: Catalin Marinas , Will Deacon , Sudarshan Rajagopalan , Georgi Djakov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Florian Fainelli References: From: David Hildenbrand Organization: Red Hat Message-ID: Date: Fri, 1 Oct 2021 10:39:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9CDF4F000AE8 X-Stat-Signature: bx9kbbtshfqtcjexw7b99d4ejynb99rz Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="YiJ4R/2a"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1633077593-432266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.10.21 08:38, Anshuman Khandual wrote: > > > On 9/29/21 12:21 AM, Chris Goldsworthy wrote: >> From: Sudarshan Rajagopalan >> >> After new memory blocks have been hotplugged, max_pfn and max_low_pfn >> needs updating to reflect on new PFNs being hot added to system. >> Without this patch, debug-related functions that use max_pfn such as >> get_max_dump_pfn() or read_page_owner() will not work with any page in >> memory that is hot-added after boot. >> >> Fixes: 4ab215061554 ("arm64: Add memory hotplug support") >> Signed-off-by: Sudarshan Rajagopalan >> Signed-off-by: Chris Goldsworthy >> Acked-by: David Hildenbrand >> Cc: Florian Fainelli >> Cc: Georgi Djakov >> --- >> arch/arm64/mm/mmu.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index cfd9deb..fd85b51 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1499,6 +1499,11 @@ int arch_add_memory(int nid, u64 start, u64 size, >> if (ret) >> __remove_pgd_mapping(swapper_pg_dir, >> __phys_to_virt(start), size); >> + else { >> + max_pfn = PFN_UP(start + size); >> + max_low_pfn = max_pfn; >> + } > > Do these variables get updated on *all* platforms that support memory > hotplug via an arch_add_memory() ? If not, dont they all face similar > issues as well ? Why not just update these in generic hotplug instead > , after looking into arch_add_memory() return code. s390x sets them to the possible maximum (based on the direct mapping size) in init code. Other archs like x86-64 have to update other parameters. So I guess it just made sense to let the archs handle updating these 2 variables. -- Thanks, David / dhildenb