From: Tim Chen <tim.c.chen@linux.intel.com>
To: Yang Shi <yang.shi@linux.alibaba.com>,
ying.huang@intel.com, tim.c.chen@intel.com, minchan@kernel.org,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH 1/2] mm: swap: check if swap backing device is congested or not
Date: Fri, 21 Dec 2018 10:34:47 -0800 [thread overview]
Message-ID: <c3c77f08-f7af-7633-636d-c467759fbf20@linux.intel.com> (raw)
In-Reply-To: <1545351679-23596-1-git-send-email-yang.shi@linux.alibaba.com>
On 12/20/18 4:21 PM, Yang Shi wrote:
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -538,11 +538,17 @@ struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t gfp_mask,
> bool do_poll = true, page_allocated;
> struct vm_area_struct *vma = vmf->vma;
> unsigned long addr = vmf->address;
> + struct inode *inode = si->swap_file->f_mapping->host;
>
> mask = swapin_nr_pages(offset) - 1;
> if (!mask)
> goto skip;
>
> + if (si->flags & (SWP_BLKDEV | SWP_FS)) {
Maybe move the inode dereference here:
inode = si->swap_file->f_mapping->host;
> + if (inode_read_congested(inode))
> + goto skip;
> + }
> +
Thanks.
Tim
next prev parent reply other threads:[~2018-12-21 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 0:21 Yang Shi
2018-12-21 0:21 ` [v2 PATCH 2/2] mm: swap: add comment for swap_vma_readahead Yang Shi
2018-12-21 18:34 ` Tim Chen [this message]
2018-12-21 18:51 ` [v2 PATCH 1/2] mm: swap: check if swap backing device is congested or not Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3c77f08-f7af-7633-636d-c467759fbf20@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=tim.c.chen@intel.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox