From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A896EB64D7 for ; Wed, 28 Jun 2023 09:08:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71A0E8D0003; Wed, 28 Jun 2023 05:08:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CA5F8D0001; Wed, 28 Jun 2023 05:08:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56B7D8D0003; Wed, 28 Jun 2023 05:08:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 48E018D0001 for ; Wed, 28 Jun 2023 05:08:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1ADD0120D43 for ; Wed, 28 Jun 2023 09:08:01 +0000 (UTC) X-FDA: 80951579562.28.AC2D82A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id BB46D1C001A for ; Wed, 28 Jun 2023 09:07:58 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MGzwGI7n; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687943278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1tmOGLEvDLwTWFfXTCn0Kgw7Ibn3hUfGy18egvu84cw=; b=Mc8L0iDu+WoBKT0EX1tPc27tQ9izrYe6f0blt+9NdmG4WYlsR8SQwo2dFIhieowBifKF0k MtAklNT5s93avv5hRG7ZGXnhU1FM2rdgIiaHrZxJFrrZ53dX7uDcHJpGbgsl6L/gfPEsuQ NdKxhYximXfw8R4OTMwUPtowwFntdys= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687943278; a=rsa-sha256; cv=none; b=yDiYe7xDweGN0Bpxef9iOF5FSt9hWZ54b36u5eRufRBi5rmut0+v5eV+2jIAICgnXy52Bb KdwY6CRUqVDzkFAEsCsu2KBCmj5wKeNYabw2/XEyFW0Q3RvOyRBMrhLWG0tA+TzyRE8kbT /TVT6/y72ayCmC/6uUETFKsou2YsC8g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MGzwGI7n; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687943278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1tmOGLEvDLwTWFfXTCn0Kgw7Ibn3hUfGy18egvu84cw=; b=MGzwGI7n94UCJJZlflpAGchhKIapiHV5B2KhuOi9VjAQxmXr5SFAGdpeoyFwX8/AmAQhCw v1Vd6CP8SZMUZidsBK5KEsX88OHzjypmnddTvnj5gWzwpWnDMIKTBck4nxLyEyOUvnJf4q b0IwdUr6/dK8Z+W8dcuO97olAC5oexA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-RSVq08TTPpezzhb_DCPAMg-1; Wed, 28 Jun 2023 05:07:56 -0400 X-MC-Unique: RSVq08TTPpezzhb_DCPAMg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fa8cd898e0so20851015e9.3 for ; Wed, 28 Jun 2023 02:07:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687943275; x=1690535275; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1tmOGLEvDLwTWFfXTCn0Kgw7Ibn3hUfGy18egvu84cw=; b=Vt8WR7CakrXyHCtNw+1fMkaX5q6BqPMs3P7cdwggf4KE/l+EHKpI8PC62/VyZ/TOod pJ7jkxlc40ykUfQzBBvknQmsFYh7MRADEHqUbtZr/h4JkFunrb6yY4oQaQ/Yr6qUvDQM oJ/evnBX0cNwvVExziDjl+pw2CSrrWS/zQzqJTUSNFfn2s5ycuvITcvGaDTsrnRhoaeQ b8ai6Rks0SqmTHhA8/4qTxzEDUxRCsWdwta1ylqZ+8JyWGEKZpALABtr2aCcq60MSN9R e46Hp74G15WLr8r22G1ml+kvKbT/FmNaONO54fZ31gOcedzC/9f/58vLuF3lG8LX+W06 G95g== X-Gm-Message-State: AC+VfDwqf8JVCbXrAw0g8n8OMWKVeQyiew5OBLvGVr5GgYZcq9SdZF2G 9gPzcwTAsQOlnp+uGRuh1SOGXRxjxduqSo4bYirhJSAYMWJp4ZNvF5hIkUIBbBi6HmDdnVZ0JCL BhKLYC34mjbM= X-Received: by 2002:a1c:770a:0:b0:3f9:c04:e76c with SMTP id t10-20020a1c770a000000b003f90c04e76cmr24266397wmi.28.1687943275609; Wed, 28 Jun 2023 02:07:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Zd/AfCE3hYYcH4TTOMIl2Wfafkc2Ctr/hBivapLM6oxQ4tBDZc7EY3Znf0MnPHEb4hq1UJA== X-Received: by 2002:a1c:770a:0:b0:3f9:c04:e76c with SMTP id t10-20020a1c770a000000b003f90c04e76cmr24266377wmi.28.1687943275188; Wed, 28 Jun 2023 02:07:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:ef00:fa40:f6df:a68d:a0e4? (p200300cbc715ef00fa40f6dfa68da0e4.dip0.t-ipconnect.de. [2003:cb:c715:ef00:fa40:f6df:a68d:a0e4]) by smtp.gmail.com with ESMTPSA id p23-20020a1c7417000000b003f9b0f640b1sm13134247wmc.22.2023.06.28.02.07.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jun 2023 02:07:54 -0700 (PDT) Message-ID: Date: Wed, 28 Jun 2023 11:07:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm/ksm: delete the redundant ksm_merging_pages interafce in proc To: xu xin , sunnanyong@huawei.com Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, wangkefeng.wang@huawei.com, yang.yang29@zte.com.cn, xu.xin16@zte.com.cn References: <20230627133542.2446285-1-sunnanyong@huawei.com> <20230628031233.9734-1-xu.xin16@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230628031233.9734-1-xu.xin16@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: q7gncosp9psomgbsu7ftyem3t17iciw1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BB46D1C001A X-Rspam-User: X-HE-Tag: 1687943278-625197 X-HE-Meta: U2FsdGVkX1+ZOv82gTvZpMoVE+Y8Ls2SLlM4+n49ifDfijnk/Y5elUFWx7mYXeAzfSzvCeLtC1zrD/uBlhyBsb9K8g+yVk1nqIN4xyrM4MjhTWzhBd0Fs84zKRJwAhl3uEFqvzRipBSlJxBzP+HwWZv+MC8c7YXC2j6+HS+5IY4utwg+/npw4YqyD75+BYxPL11WlZRxCJewuowGq2+Xf1zFQuzy6rmpCWzzJBTgZVySgUewTUcZpF8zeQQW/KktMYCenxLYm+t9RUyHXPFiMdRbxplaVC1WaqixVbTHdw96fj6vDCcvYR56P5jMvyaboFa+3XgUy+xwf76BQn5xu/ucTB2v+Cn1J5Q7RFxasMPkRkh+hxIXWulFJVrKvKqv2gP+2fqEz6K0fN0zmR2TbAAIDuXz0JqtXL8zPOWTSPq48O8jeFiUhfdTUfskAv8R1ciome3K2HpggV6A0dJDX8Qw+mQK+EOp5p0fuMc6LKufY6mxvf+bIno+Mv7H3wwm/3aHzy5XkcMgtF8TPL6VznXu03xzmmfGs+X3k3o92AxzE5J45AaHkOXurvXVAPj/3pn827SiZ7q9Rzz8WIWDT4zomc3LAyB2RofhPzcmWUepoHuTC6340rIzVjhNo1HhsqsO+goQ9tf5K2pM6Lbw1h7VzjQVtZ8ppvDXgCZFCYzTZvHh9nfYoJcCtGWV/MKqQlNaepv6iGc78Y3WUkkl5bY68TespyPg6x9rLSIhtBviDvSZ+yju6I0ZeN4CE0BtrQmv3RjjK2hi4fb0KRLQb22XVz7XxaRr+hVsFPxsx3z+n/GHawD/WlTd3usNY7E5qU8yejYErsKNfPUdLXvkgX/F3RrtGuoqHKrLNG3qpn/T7X685xjdZLfTrL9tgqxf/ZYwKqC2Z7V3SjWap/6g6BzXW1Y6NG3/+jX9JNgpiwiHwR+sFXFEduGrUrotVvIlHIcr2yeijO01LZ3S0ZE QMIfOVJR Y6tayPmzgkc7JbhLm2IWysczXq04V7wusgmvufXf3UWr57bqtRsUKFO/SG+5mG61pDIuZCs9vAOAOJCykd9/BKm8lHAk56yXhOBQD6BjP+UAbxAEEKxqa/yeSZ9I6zAvGsYcmmdwj/dgCN1QJVnTisx5whLswIbGrj98BFczwsGdeihdfCIlm86N2CRcFIpsMhIX6FytpDGbiPQ1GT3jJbxC5WB+Boe3TAgHhGAhly6cqkJJ0qEvLuCgiRVkSfU8iFFCaI+jyVWRntq6bOifXl+cZpQd1E4xih3L2EcBTI6EMcF5amjjriKGOFH/Kwf4nruNe36YEvqzMMR/nEvU7Eh48pXbh61gdzzmYuK1xPkXpJzbFc5lqeUlG0JjHLeb1Hc6jlTBXD8iT6iSfqo0rkusbfvDBMby4u+dbe6OB8hF/iKVLMJpgCn38FPVOym46oTnj7NRMR7BtAwbnBHpWbGbG/XAHg6CApkiLZzJCBpi3YDDV4w151bNJAbBc8tw27K9mnsYe5xW1LnU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.06.23 05:12, xu xin wrote: >> Message-ID: <20230627133542.2446285-1-sunnanyong@huawei.com> (raw) >> >> Since the ksm_merging_pages information already included in >> /proc//ksm_stat, we can delete /proc//ksm_merging_pages to >> make the directory more clean, and can save a little bit resources. > > I think it's ok to remove it because this interface was not proposed for a long time. > I believe its users are not many yet. The earlier we delete it, the better. > Well ... it's been around since v5.19, which was released 1 year ago. ... not sure if the removal is worth the possible user space break. -- Cheers, David / dhildenb