From: David Hildenbrand <david@redhat.com>
To: xu xin <xu.xin.sc@gmail.com>, sunnanyong@huawei.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, wangkefeng.wang@huawei.com,
yang.yang29@zte.com.cn, xu.xin16@zte.com.cn
Subject: Re: [PATCH] mm/ksm: delete the redundant ksm_merging_pages interafce in proc
Date: Wed, 28 Jun 2023 11:07:53 +0200 [thread overview]
Message-ID: <c3bd72a0-6c19-b874-9942-2fc1e1f9a20b@redhat.com> (raw)
In-Reply-To: <20230628031233.9734-1-xu.xin16@zte.com.cn>
On 28.06.23 05:12, xu xin wrote:
>> Message-ID: <20230627133542.2446285-1-sunnanyong@huawei.com> (raw)
>>
>> Since the ksm_merging_pages information already included in
>> /proc/<pid>/ksm_stat, we can delete /proc/<pid>/ksm_merging_pages to
>> make the directory more clean, and can save a little bit resources.
>
> I think it's ok to remove it because this interface was not proposed for a long time.
> I believe its users are not many yet. The earlier we delete it, the better.
>
Well ... it's been around since v5.19, which was released 1 year ago.
... not sure if the removal is worth the possible user space break.
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2023-06-28 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 13:35 Nanyong Sun
2023-06-27 19:22 ` Andrew Morton
2023-06-28 2:44 ` Nanyong Sun
[not found] ` <20230628031233.9734-1-xu.xin16@zte.com.cn>
2023-06-28 9:07 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3bd72a0-6c19-b874-9942-2fc1e1f9a20b@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xu.xin.sc@gmail.com \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox