From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCCCCDB482 for ; Thu, 19 Oct 2023 07:02:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8859380091; Thu, 19 Oct 2023 03:02:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8362380090; Thu, 19 Oct 2023 03:02:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7239A80091; Thu, 19 Oct 2023 03:02:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 63B1380090 for ; Thu, 19 Oct 2023 03:02:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 365E4B664C for ; Thu, 19 Oct 2023 07:02:22 +0000 (UTC) X-FDA: 81361317324.06.BD4976C Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf05.hostedemail.com (Postfix) with ESMTP id C0BDE100005 for ; Thu, 19 Oct 2023 07:02:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697698940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3mEzKgncam9A9ksO8FwRiA8Z5Z70gGXc9rN3AOnTikk=; b=wqx/GTBMC8vARioU74Oac64/3Gm7teeJ0ROovnkwTIEbO6F5nLcUGPTFD0hDC8VhJmL6wG QvjP6a7a2719QH8WqOzpWcDX/4oFM0yPULwIsaZEmDkrOk4ivHu3ELaxxzT3RK4rJOtFdm BHE7vuy0FWDB0tdnG7tXiy9ogA6umPY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697698940; a=rsa-sha256; cv=none; b=PhdjSvk9lWL/l+8YlHy+zgAFWa6ILPGuwb6CZfe58qR8l7/V9pioZioyI2fljHse64S8sS bioxDxe88KU9m1PGRZ0/m5ifuV8Tvh5zP/vGX50uCJdmQ5E5E4ozWExZSp2n9Zsa5O9rxK /PsSPUyEPlULsq0ABNEXcCK1kucm4BI= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S9z6s6XCTzvPx5; Thu, 19 Oct 2023 14:57:25 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 19 Oct 2023 15:02:11 +0800 Message-ID: Date: Thu, 19 Oct 2023 15:02:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: cma: report correct node id Content-Language: en-US To: Christoph Hellwig CC: Andrew Morton , References: <20231019013253.2792048-1-wangkefeng.wang@huawei.com> <20231019050229.GA13957@lst.de> From: Kefeng Wang In-Reply-To: <20231019050229.GA13957@lst.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: C0BDE100005 X-Rspam-User: X-Stat-Signature: mw6z3nkt8qfrrcbfcjwr13gpnwfu7bfp X-Rspamd-Server: rspam01 X-HE-Tag: 1697698939-511124 X-HE-Meta: U2FsdGVkX18iz8CpUJTygq5t/gMn8qLknOBsIjcsIqPysE6/s9hrW8Cd78jh9+YJmNXnIX3jGMeskn25qnNT9cFp5gpXDgsfasfbUHhusYTor0/rM54glfp+gnqD/EPw28fRfSrZeqoJdFOnZu77wVQoJPA2rfzndgGHW1M/pG83nDqT0KowTdH5Cd/DFhvESA/uhuI7HGcrrf18zfTjp+v43x6qPIpMHOcxT8OmTZyIA1bkNVeJcE9OGROuVrg1BRsWZMUbOB4NHgWxWm6EvS/c035SN2n+IiWkYGuroO/ag0GNZINMWhLmsAsxkmwEIF1c+1+THS//QrSaDZxkg5lHn5IIOeC99DT4dN0QqIhumqHOG6q4Adgd5W8DQb0gmKNFtx0RW+s6EvQIakwYlg1Cflpz0QJqh5FqINoBKNA8OJgSw1sS3rctZ/SqozSvt+fVeoxAlQTF5kphDoS8OGDMAa9xpabhwFBUKuFZ+QqUVDc/mIxbKHOPOlC3XAt9r8CGPnzPFNGwbnh5orOB4dv5doq8BziyhOKeWuJuk6M/MahfBkmLmqjjqInSeOLdJqfuvEaKiwlHGX6YRL4Ts/iEN8nSszKa3j8YHRJXE3Bf1Ii3HUTS7n60J7GDJ8vjZq/JP+Ev/Z8S8jT57HbVa8HdUTzxOKMcnHSvhAmQp8iBhNFmRcF7+eKNwXjk20UgOW9iK7kKLx8Pk+xWTKNaM914BlB1fqr6Gr+7LZM9IFyIrQ0V4CDt6U1TxdOv7IUE9GVWaDOdnTFI0UNElw9EJL0BomjkLmtYVOSY28HWT3dO9VN3OmZWo4YLDI8O8sahf4v4X2v3tsefQ/LRYjfeoXm8BVJvgPbYrXnQ0dfdUtOsg2HBmPRlDipv7XrymTC0i0TIhG8lhcaTEvE5/DwBivHGcehtl8Aer1Qb8t01Gb5NOPOENy67SMdUcyZK4NwLNZS8ALcp6i4Cxugzz7K 3DanZ4GI GC7lRmRXDBMQGhTCtTGHeh/RLQkiqXQQ28Uhqi1w/Vi8xJUhSaxoKD4AVoG2zuUk6CS9IIiORzQToRlSCCS6NvxbqJvFv/Qc/uB1ZRYUXq6QUh2daqEQNd5pNBDA6YkMmRxG+YoiDZUAaEW0nqHzDu7W5ZBF+DO2cnOGKWNyEGKz8hn/B6QKoDrxhDaVDQqbw+q15PQacueVYxrBWpGgtTADMOpfmiwqGKnsYLxxSD4WxWTx7lWouLS0MnS5lfl8TmcamkyErlGa0UUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/19 13:02, Christoph Hellwig wrote: > On Thu, Oct 19, 2023 at 09:32:53AM +0800, Kefeng Wang wrote: >> Use early_pfn_to_nid() to get correct node id from base instead of >> the default NUMA_NO_NODE in cma_declare_contiguous_nid(). > > Why? before: cma: Reserved 32 MiB at 0x00000000fe000000 on node -1 after: cma: Reserved 32 MiB at 0x00000000fe000000 on node 0 I think the real nid 0 is better than -1, but yes, it is not a big deal. > >