From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B7BECAAD3 for ; Thu, 1 Sep 2022 23:20:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D7298007E; Thu, 1 Sep 2022 19:20:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 086FC8000D; Thu, 1 Sep 2022 19:20:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E902D8007E; Thu, 1 Sep 2022 19:20:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D79E98000D for ; Thu, 1 Sep 2022 19:20:02 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A822A1206FC for ; Thu, 1 Sep 2022 23:20:02 +0000 (UTC) X-FDA: 79865086644.28.691987F Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by imf12.hostedemail.com (Postfix) with ESMTP id 65B234005F for ; Thu, 1 Sep 2022 23:20:02 +0000 (UTC) Received: from omf02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1E25A1C6992; Thu, 1 Sep 2022 23:19:58 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA id A9ECF8000E; Thu, 1 Sep 2022 23:19:36 +0000 (UTC) Message-ID: Subject: Re: [RFC PATCH 28/30] Improved symbolic error names From: Joe Perches To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 01 Sep 2022 16:19:35 -0700 In-Reply-To: <20220830214919.53220-29-surenb@google.com> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-29-surenb@google.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18FfjZ7BuRv/DHsUMYX6e6vN/rFvSwIdRQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662074402; a=rsa-sha256; cv=none; b=q6EI1mbY/W6xhPqLmjvRaTi/UItqEIK3W1FzZprZPCETt9MEK1WOxdcIMottkbM1Ca97af 6hT9Y4o0TyTDu6GTC4lyYTYbCfLn0ZX1OHP4acLfHsE0hz9jTzX1a4jXgxoX6la9bMgSC4 rl1x+mk77sT2KsYCOh5wt2JohAR4FVI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=none (imf12.hostedemail.com: domain of joe@perches.com has no SPF policy when checking 216.40.44.15) smtp.mailfrom=joe@perches.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662074402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KHhjVPvWWy6GCJ08QhtRbuOecr40l67u4XmpG3GXwT4=; b=6V4C7/UleZrxA3RsH54e3PcjqaD2k6zTNi7R0IgLe4tij+nnTs018np7wnCAO78pgc3X91 UOXymu416Hu7fNMkHHd2eBGGdl+r0ejEps31NT7kcd8m2+shM5tA50xFG6qW+kCYIV/R4T TqDv7UmJND69M0EdLZFm0zhNvQy1sdg= Authentication-Results: imf12.hostedemail.com; dkim=none; spf=none (imf12.hostedemail.com: domain of joe@perches.com has no SPF policy when checking 216.40.44.15) smtp.mailfrom=joe@perches.com; dmarc=none X-Stat-Signature: iwqjhu65bfnp7s38he58qcgfcrx3mruu X-Rspamd-Queue-Id: 65B234005F X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag-Orig: 1662074376-819350 X-HE-Tag: 1662074402-275049 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2022-08-30 at 14:49 -0700, Suren Baghdasaryan wrote: > From: Kent Overstreet >=20 > This patch adds per-error-site error codes, with error strings that > include their file and line number. >=20 > To use, change code that returns an error, e.g. > return -ENOMEM; > to > return -ERR(ENOMEM); >=20 > Then, errname() will return a string that includes the file and line > number of the ERR() call, for example > printk("Got error %s!\n", errname(err)); > will result in > Got error ENOMEM at foo.c:1234 Why? Something wrong with just using %pe ? printk("Got error %pe at %s:%d!\n", ERR_PTR(err), __FILE__, __LINE__); Likely __FILE__ and __LINE__ aren't particularly useful. And using ERR would add rather a lot of bloat as each codetag_error_code struct would be unique. +#define ERR(_err) \ +({ \ + static struct codetag_error_code \ + __used \ + __section("error_code_tags") \ + __aligned(8) e =3D { \ + .str =3D #_err " at " __FILE__ ":" __stringify(__LINE__),\ + .err =3D _err, \ + }; \ + \ + e.err; \ +})