From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441D6C36000 for ; Fri, 21 Mar 2025 15:09:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C39FA280002; Fri, 21 Mar 2025 11:09:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE972280001; Fri, 21 Mar 2025 11:09:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A89BA280002; Fri, 21 Mar 2025 11:09:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8A644280001 for ; Fri, 21 Mar 2025 11:09:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A569C120160 for ; Fri, 21 Mar 2025 15:09:38 +0000 (UTC) X-FDA: 83245892436.14.90ED96C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id 3FECA18000C for ; Fri, 21 Mar 2025 15:09:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ualdCGVC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rHDuRmzb; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ualdCGVC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rHDuRmzb; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742569776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DgznpANGOBOKlm9alAYsgKxcYpu8Q4cgo8ZhvrGmDAo=; b=4+byTVTAxGqNA5o7Vu0aw0BsbDZtshYRIvCS/3jYzTmeiApqGX5hbigA4qkhmZB8Fmgzy5 Xc9kvOupT9LI285ZBh13iCDLg5v8RM29NRqaLyI4D4qbFpPPABCIhnTQRUe30ErR2KI8uz N3COWjDo/FPuSsRV+D2be9zLV36Uh6Q= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ualdCGVC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rHDuRmzb; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ualdCGVC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rHDuRmzb; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742569776; a=rsa-sha256; cv=none; b=X6g5mudgJ7Mh/oOzTaKnueCTNMesaMCve/np5eqfkzA1YmiXBCYARgllWzcAZx9lXuCttn qJ+SbOfA1IKscQG3cyzH8Ozf/zsOLKRoGlzi70TIbwGG0YOxo2JB0BW+AtOXQT9/jNYngj 8iK+SpirW5NOKtn+IP719wi+tWNnBpI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4A0101FEF7; Fri, 21 Mar 2025 15:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1742569774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DgznpANGOBOKlm9alAYsgKxcYpu8Q4cgo8ZhvrGmDAo=; b=ualdCGVCjsvY/bXsGDjJbRmm5wO9Q3vwFukMFFZljtNUV6OU8wUryyKdiXfgV3Wh+XnwKw Oi2wfjn/WtcTDqPdhGfb8wA/+TYd7UmE7Bc9ab2vx7N2YzJvbLoOjuDJ1oCo91Scmm/Og+ UXcW30xdQ4dGH5lTmbwLkaX6qcxzQMo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1742569774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DgznpANGOBOKlm9alAYsgKxcYpu8Q4cgo8ZhvrGmDAo=; b=rHDuRmzbVpwKTgAsTemQmOFzj2QTE7ogoUfMdbpUcjSib2o/X3Ia98WRvl/zHeFdEY+j94 pvCTzGGSEcZEdICg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1742569774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DgznpANGOBOKlm9alAYsgKxcYpu8Q4cgo8ZhvrGmDAo=; b=ualdCGVCjsvY/bXsGDjJbRmm5wO9Q3vwFukMFFZljtNUV6OU8wUryyKdiXfgV3Wh+XnwKw Oi2wfjn/WtcTDqPdhGfb8wA/+TYd7UmE7Bc9ab2vx7N2YzJvbLoOjuDJ1oCo91Scmm/Og+ UXcW30xdQ4dGH5lTmbwLkaX6qcxzQMo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1742569774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DgznpANGOBOKlm9alAYsgKxcYpu8Q4cgo8ZhvrGmDAo=; b=rHDuRmzbVpwKTgAsTemQmOFzj2QTE7ogoUfMdbpUcjSib2o/X3Ia98WRvl/zHeFdEY+j94 pvCTzGGSEcZEdICg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 332CE139AA; Fri, 21 Mar 2025 15:09:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id urEqDC6B3WemDwAAD6G6ig (envelope-from ); Fri, 21 Mar 2025 15:09:34 +0000 Message-ID: Date: Fri, 21 Mar 2025 16:09:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: Fix parameter passed to page_mapcount_is_type() Content-Language: en-US To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, david@redhat.com, linmiaohe@huawei.com, gehao@kylinos.cn, shan.gavin@gmail.com References: <20250321120222.1456770-1-gshan@redhat.com> <20250321120222.1456770-2-gshan@redhat.com> From: Vlastimil Babka In-Reply-To: <20250321120222.1456770-2-gshan@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 3FECA18000C X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: euj34yqe38hf5e43bmuh3y4sc58xeh6b X-HE-Tag: 1742569776-60967 X-HE-Meta: U2FsdGVkX1/3146kxTNDMuVQnHXrmpPDMsxIbCpO+EEDdrW6ganF/xzkziJ0aCGhN6yVlxEBqjnq0ggk728zKFAvJFw89NbFBmMFdFgsnXoAz/ilBtj0lhS/Eo1xHbzLdS8cgVbkELwDOamqEiEIfUR+kaMV/Sj6ZkvUZWbpUsTdsoo4uOWaQWvP74WF5pWIVsNJ4igtx341aYZDee2Yp9kBdCUnsRJCNI8et/JbTubGfyMBvS88+jyzHoLl0e2cifVFD/hxf/fKn1tRRA9iw/NNzxGILrVPpG/t+W0gRL0FZ0CO1qSxaPBFjBglZGoO/hL7m7pM8XrZE1D1xVRCSNcqcbKJMiHsuxuTTBgSUBOENh1NGVJ+dB9ziPw20kVvlg9nqNDnMcm9Of7gXQi0xo9j7efXMc+t8H0L4WYhKwQco/VKFCEeb1hxvXVLhsLFFdAmQ/o8Jpt9cdPyrWMu1N2nxaBuc4Vk7EGqBpm6zuz4v8FDRvOGTt/GOxpX550h5Ok50P1W9lBpwbEGFvq2lijHrXaUSbwdF2J7OBVCpRkWQgaex6FWZ5gxYFVau/RshUrQYKzIlociAfRFvHvFOUZQ4MpWMpLbR+L/TI9cQT1IIr2h3tqVLZDUKxkoGf4jv4dRGNBwbEfANoTGloKxd3B9+Nw8q2aXqkhsYaPXeu/qlD4PyKNNi2R87cOieyKXOOSg11c1dyh14khqdaYT3OqdWElU4Rs/YIPn6QrzDUbUBAM7k+5caV6HhMLEDaSQXrlolVeT4/o/ru6br0BEt3NI4jKlx5FCtE/dpMUAGrbHZUh/2x8K6Y1AhemRIE/2l2pTpp766BLB8vgQa+XF50xmRSG8I6iGZ5AQJpTu10BfC2RpLKAsuLKgFu+7xw+GXyrxjv/FtQNOOTzVsNVRVPgGx+yrmrY3TZyZedxzVRlr7rbAEz2jEb5DTVqMuJb/iM7Ux2GzSTcaFxlqiCE GFDZEWOi cN4NYb4LNKV153gojoc4BKwTswPiIb3g14aJIya2bKI2t00KkCnzWQ7g6IXKta6amXuUZsqTfYTEwdPPoflm/dJKgYNQMnBzltkCGLHgySyufs18P6IkzjnlmnaQeOTi0NafcqDaQpq/6QhyR3bhCkxOPstGa/0JTAthdNMQ+XCKajSrCuBr5PolzMAdqk+yRbE2NwvDBhR6lR20unfPwetwX6yBH7/Q6i4FL1mHuke3KyCddIglfHcKXkyfr/rz7XK1nBJVujs944GO8RWQ2k5QJ/jgWu5lkSXcV6YbDFcU9iE0Nrkl6/+PNgZe8ro8JJmgUPAhBvI+4k1QzIYQQuq+4c5JrHCJ6pN7LHNpLeBrCiguqqNqOli2OOJ5wxRUj1pY5OY30hP9z+bkO3+TBeyfhlMmurK9zz2GaZ+g24zYnwTo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/21/25 13:02, Gavin Shan wrote: > As the comments of page_mapcount_is_type() indicate, the parameter > passed to the function should be one more than page->_mapcount. > However, page->_mapcount (equivalent to page->page_type) is passed > to the function by commit 4ffca5a96678 ("mm: support only one page_type > per page") page_type_has_type() is replaced by page_mapcount_is_type(), > but the parameter isn't adjusted. > > Fix it by replacing page_mapcount_is_type() with page_type_has_type() > in page_has_type(). Note that the issue doesn't cause any visible impacts > due to the safety gap introduced by PGTY_mapcount_underflow limit. > > Fixes: 4ffca5a96678 ("mm: support only one page_type per page") > Signed-off-by: Gavin Shan > Acked-by: David Hildenbrand Acked-by: Vlastimil Babka > --- > include/linux/page-flags.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 36d283552f80..e1a9f84bd5ab 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -950,7 +950,7 @@ static inline bool page_mapcount_is_type(unsigned int mapcount) > > static inline bool page_has_type(const struct page *page) > { > - return page_mapcount_is_type(data_race(page->page_type)); > + return page_type_has_type(data_race(page->page_type)); > } > > #define FOLIO_TYPE_OPS(lname, fname) \