From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B57FC3ABDD for ; Thu, 15 May 2025 18:31:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1ACC6B00C1; Thu, 15 May 2025 14:31:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA5716B00BC; Thu, 15 May 2025 14:31:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 945236B00C1; Thu, 15 May 2025 14:31:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7022E6B0092 for ; Thu, 15 May 2025 14:31:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 52E5A12048B for ; Thu, 15 May 2025 18:31:16 +0000 (UTC) X-FDA: 83445984552.14.E0F8744 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf18.hostedemail.com (Postfix) with ESMTP id 4ECEC1C0011 for ; Thu, 15 May 2025 18:31:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nlC4Pa1K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=eddyz87@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747333874; a=rsa-sha256; cv=none; b=P5K8zp5LqFe2HzYyELF5JADSBvwd14R3N7EHs7QKIU3dK+Ql0v6UzAmU5YJ2/6jAGOjyiH ZenzUvIhKYP19HYwl+JNwVvVA8uSjEp04DWN1kX12ylFISqObK6dYaE3+r5qjAbDG3f5pg p2xQibdbBm0BKQXjDUzlaYnf2IJqaoA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nlC4Pa1K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=eddyz87@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747333874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V6rVl2MUL74b08/nShEq7cCkERzRMRshlzLbhmNnQ+M=; b=6CwJSn1AwRQ2UfZcIEn4DonIJF7A2aSyHW2SW5wGG+ucZnLI4BSsP9jD2BqI0fUe8SQvOn +KFdFkYfqmrAcdWDkaXcp0yG/r3tgXnlsyu7EQN/cG/r74Hc/X56ZK9gRlo00SRdE7AijO u6xogqBFR6Aw1vFRq/BcghbzetGX7SA= Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-b0b2d1f2845so909761a12.3 for ; Thu, 15 May 2025 11:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747333873; x=1747938673; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=V6rVl2MUL74b08/nShEq7cCkERzRMRshlzLbhmNnQ+M=; b=nlC4Pa1K1ILgg1tXTlNTJg+Hgm+nGKr6GKFtqcdsck+YJJjjjXJY9lMCyliZx31lsR vj2Bw6p4Up6tUeCdJ7AE2FQlSvpHLwU19tvWK3n4Fl0WxpRIMR8elwXXGyw7wLOVGVGd Gw4wIFLVbmfsOzznJ9gaoZWo/Wc3OXbeZiPHUXY5eOi2Rr8dYpfvUGABw4q5ZT27ivVL CK+tiVjOOutVfDydoLqKUJe7N7HRF1AmnlsITRwUJ0rh8HNFxhx94gxIHBXgKerjuhFr 9RwnbHWdsH/jz9XclfXb/td+i+m8ZL1E7TTpjdDwtHSYPhoQPm+4DLztd/dBFzRySbfb wFCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747333873; x=1747938673; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=V6rVl2MUL74b08/nShEq7cCkERzRMRshlzLbhmNnQ+M=; b=FUopA24yzSAwUzcUrt1q+Xvk6wbVoPvKAlFgo46cCWWcGKNolLKQFn6uGC02beHO5U /fiU/n4oaR8xUppRuOM9y4Ay13CFInJYuwDkEzx1xJ49g83JDuB1H7cDKubzsVKe/1/n MXly/KEdtrbRfp+UEVKaqRVYAWPBz6PaarYiX7BxG90oSj3H1NsTroj71gWhotYCoXm1 B74eLwP440Y8IT8OswXEncy4jfsv/SJry81S4oWqQ0N0Q81KjepV1KQ2nB+mK4VZNFJG fLE822mRrYMjuhP7YW5CKQ4IqwTIoK6gn38rYhfOFbK5WvgheMf8Gpam+WL8NlRL5Ytq F8dg== X-Forwarded-Encrypted: i=1; AJvYcCXcPS7r8/PSb32SUXiql5NGbnDONA7qw2ti7s0EpEKsNXYoQJCnThu6TratNlNca9DmfxwDwFYZqw==@kvack.org X-Gm-Message-State: AOJu0Yzz9uEkp6CsptrMSj7BU6onKPwjbxkLLaVqYNFuhoPzuAt6UmWh vS2M2iN5oKx+JSgtTSO0mU7oxMoA48hlOL/LLkNl+Es4kVlsKDojNubQ X-Gm-Gg: ASbGncvO76dUPlyJjQfeFVEJakd9Fbuam88HupeJCZ48vx3nGLe0o+mANpxl1nH8mMz HllCsYvGlPNaVxyoM0sclYfOTN+VsrBfO/P0jK1zuKCQ0xdPZRK6x+6TlIdSpV1ctNflcb08Hwz WJ8X/E9Q7KRxUgA4m+wVgZhLU4O48bcy18+0k+TVV2WLzi656+7kHJ0/otf7v0w3vNL6MUE9giF zpkxAf3+JkUI03kK389IJgHudMmDSbqNTyi/oUzdNd/QhbtC7kJPOurCX6lNE8feBlz1dBN4xh1 70JFZW9+l/abYmK9HIfp1YKkSyV+XB7AtRMQVJgNGlz40lOInr/waOkxqQ== X-Google-Smtp-Source: AGHT+IH6OY+7lX78qJzXX8XUmWkJnOnPaGJh9q4L+Bcz6Vd9CB0IOhsuPWAb1U3MJhxd+KmPtBkNvg== X-Received: by 2002:a17:902:ce87:b0:223:653e:eb09 with SMTP id d9443c01a7336-231d438a294mr6291995ad.7.1747333872812; Thu, 15 May 2025 11:31:12 -0700 (PDT) Received: from [192.168.0.56] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-231d4e98018sm917875ad.155.2025.05.15.11.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 11:31:12 -0700 (PDT) Message-ID: Subject: Re: [REGRESSION] bpf verifier slowdown due to vrealloc() change since 6.15-rc6 From: Eduard Zingerman To: Kees Cook , Shung-Hsi Yu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Andrii Nakryiko , Ihor Solodrai , Andrew Morton , Michal Hocko , Vlastimil Babka , Uladzislau Rezki , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, regressions@lists.linux.dev, Greg Kroah-Hartman , Alexei Starovoitov , Daniel Borkmann , Pawan Gupta Date: Thu, 15 May 2025 11:31:09 -0700 In-Reply-To: <202505150845.0F9E154@keescook> References: <20250515-bpf-verifier-slowdown-vwo2meju4cgp2su5ckj@6gi6ssxbnfqg> <202505150845.0F9E154@keescook> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4ECEC1C0011 X-Stat-Signature: ydrwy97zu31hakz4dw11nxsxe48cbcke X-HE-Tag: 1747333874-873803 X-HE-Meta: U2FsdGVkX19haEkRcglb7yIREVf1WUm46RFsCo1/AeUHzWEATGSI2+TcusLzQc0FWpc0kwfUUHJOfoPHjvibZwRS6qXraipRuNwhMRTJxS4Mqq+OXqTBgY+gO4PbYUoZK/18QLnQlOWDQNt3bMf/vn80JjigUgaLV+NR1srnvI149oBoN/6hyLjUABeGoo6e7f6MwSXNUJVlPwQ+exYhVg6NC4dqUXa64g4+oTeHp0GA/DFUKGAptyH5jNqCdglVQW8UQCvz9I2sfr4GO+8HRnFFCvXMWlToSPj4dXR+E0a8xVWqNDqbuCXFW9J3Yxr4+Oz78urHEilq2/973QP+WNUWYKotqav5DlUoYS9K8GxybWmmGBR+yS+P7EYNQCmzt5yPjXWxqvgG3a/Mt6/NrrbKmXls5sXP5XixG7/gi2T6p0RsaFQgf5FcIhHJhK7mw41CgCS76h9RWsJrIpX+Ai5sIJkDO5JywSGtqfsBfqvx8lR8AjAl0uEpNW7COYoyVnYQCCi5iDKuedixuLUuBR7im3cLJTTblsEuWuJ0rzysSLb/zYQtSnlcG9MMUImqfI6xCnY/s7cJkM7Sw2PPzRAMO3jTQ0wdapiLwUYwscLnePlPcHRzqYn0N76el6Ht0N63Z5T9YrvORmIPRob5mN1wpGXjIgGGs0nIJ+EDpuxHGU91qVcdqULAsjkOP0Y4L0lvz57hU77MJofMbNSnNSbaVfNUL04J1UeP2HmUFo8ttHfOSW47gESwCd8xEYDnxRulqEWlZLeuwsJonq7MKeDJmeFmVHXzAMlMfoEBcLQNQxPA7w8XOYTB5nQ/EuPAB5+licxuhi2bxP9e/Qu9JBLB8NzFCTl0ehjv4Zj2Dpv9+XmgKDokuKGXsvmS/fU9JXKOe3W2EYOM0i+AhR/qXTpe8HoAQq/F/GXAdpQVU4mR6qgYrv/RUdnUBXElF7+1hvqlqcoWQ5028Itk36K k2R/zDHE LtDr4U8oLIzI7gTOZYuhyO1cchJXWETXapO5m6R/jZE+gKS4dHU/XP5eb6Fv/gOnyqHJ5htwq+TqZAzVJEBv8Y+H6orzJUcwva2+qZFrr479d0qf+czzfw/+zkPx+BdImkZbj6CNh/ja8F7WCTW+S1Fvar4PLhUUjYM5wFVeaOQu3+kdx9smXAkBVJyT4Psf1uGh6HQkNbLzRtQYX+gYW3T/4xQRyDm4TLrpwBmSm9VdkBrc+s41N9KJFFumS48ApPGQfzcWwX1Tg1vYEFy1h7Kl29Wz1OjnhTJxDOIcx9xhvq9dZistzI30S1whi5NPgN2/H/gtPickam07124zu7nQHlAw8CovcjmIWYFvcUk0LaEk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2025-05-15 at 08:47 -0700, Kees Cook wrote: > On Thu, May 15, 2025 at 09:12:25PM +0800, Shung-Hsi Yu wrote: > > Bisect was done by Pawan and got to commit a0309faf1cb0 "mm: vmalloc: > > support more granular vrealloc() sizing"[2]. To further zoom in the >=20 > Can you try this patch? It's a clear bug fix, but if it doesn't improve > things, I have another idea to rearrange the memset. I tried this patch on top of the commit 82f2b0b97b36 ("Linux 6.15-rc6"). W/o the patch I observe the slowdown, test times out after 120 seconds, with the patch test finishes in 3 seconds. [...]