From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFECE7716C for ; Thu, 5 Dec 2024 03:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0353F6B007B; Wed, 4 Dec 2024 22:35:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F28C26B0082; Wed, 4 Dec 2024 22:35:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEF116B0083; Wed, 4 Dec 2024 22:35:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BFF6E6B007B for ; Wed, 4 Dec 2024 22:35:13 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1C4F5422DA for ; Thu, 5 Dec 2024 03:35:13 +0000 (UTC) X-FDA: 82859489412.16.18FC458 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf27.hostedemail.com (Postfix) with ESMTP id D31A94000E for ; Thu, 5 Dec 2024 03:34:51 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LQwBbIXu; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733369700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vYQ7tM72j3M6OrGfErua8grmBm66miD19usAoOvI/I4=; b=0iN4Q3/ROM1csBMCyPtqJNmveimV5vzcf2JLNSIkOzw/ffuVe4+LtuYr6k2/4L1/lZ0Xs7 A/3DSD/dgfTumW9cB9tzlqMEHaq5+dl1oruCvOrT9VxVWJnFc63oZ4MRh3fG6v07ljeWIp fMsc0T4Q4vVh1nMX6tm4TryWQ78AmqY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LQwBbIXu; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733369700; a=rsa-sha256; cv=none; b=OaneW87yYU9bsguFAYxqkdGQNBbY0TmptM0uCu/yGTJ0gApmwl+r3NwayC4BUUfVBClquQ VCBhiJrezk4zRKG3Vk0OjCyxFAUUAJ+5dbWjPt9jcId1O8LBQgmUTAmL/wgt44FfeZ/8BE z4Zee63iZx28++HRVszc4grOnTYPBC8= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2155e9dcbe7so3826775ad.3 for ; Wed, 04 Dec 2024 19:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1733369709; x=1733974509; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vYQ7tM72j3M6OrGfErua8grmBm66miD19usAoOvI/I4=; b=LQwBbIXuQxtLcOUswxpeCBHRVVYSR6F0f8GexzuGulEhqX+9C1/mkk90vIQa58rHWc RUB2/PHArcoaeXCDHawKZof97vvcrElPAeo+eVIPJ8Jf9+11gmhdVwe+6GP6Btqu0WLP nRu6X36zhZSDbeP9nP+XOIFb8pefDTfIlEJf8BTD9Cj5X7tDfKEGjbpntkHlBFKY60Qr 6hOOVR/un56TqJ9OE3xmAXf5OhBaKq3/d7SQlpOUPbq/Sv5q4UsEHeaY9FfF+WpZvov5 KT0sOZ4sq8thHuyj3wwA7aSm/lNbSorF1rGWRojBOqCMtSAViLUa4ThmhyIrClihywDM DPqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733369709; x=1733974509; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vYQ7tM72j3M6OrGfErua8grmBm66miD19usAoOvI/I4=; b=N5Mdkgc98P4y7JzQfce4Ai4KchJfFO3cTHSEtVD1VbiAdq/A1lmDcAp9J90NzKupnz VQgDyrYRb+xNr5ix2QSeBc1fYnodJUkKG7U97fhRgA3eG53jTrG/zMAEYxhZpaeikQcV PnRM5R8EbutX5Ln21xqarrtFLBqNwF0bxS8vNjWHEtZoahIAuA82+XYxtX8ioD5+5YS6 bJgEmNvemGxYHheDDmPIAwyNJaf5/N4y/ZNBBJERxb0EKXs4/LkS4pih6BhecjkxpZD5 RWLFNlnf7KhpgYNBM9Rof6cQgOfO2xgDx4B+WdGckdF2AWYnWu+FAY4CXIWR9Dugb3X0 G3Kw== X-Forwarded-Encrypted: i=1; AJvYcCWsMVG1NoJh8DfMctlixa34dp9q9+Vy9b851tktZYPHguTNn62bAtnOAC5VK9586xRyFOrpJsIOWw==@kvack.org X-Gm-Message-State: AOJu0Yy84bybwUSXLEG5qeC6nK10jSNV71TqlFsM7dphXgob/pKiCtcn UFIBR5GzqU/d2JEnmOBg1UH4NDM/7a4eZLW9Z7tdMMbQtHk0Wg3I6b2jUICLG2M= X-Gm-Gg: ASbGnctxG8nphbZE0BcQDzqnviu2BFEl+SkZzpzv+98QkwqEH4swiZsdAfTI6+4SSfD MekYuMVxcNqmZTJWCTG0oXnKvEu0L/N+KmYXuJp04V+TwNfMzpNhcnY8dJIUMb4vIm3X0FasAh5 zKXHpO/cMXZdh8RpCs3rrWC2r1BRkhwJuranKguIUI7eM39fsYYB9+1RCXBZ8bvg9BIjeAXn/Cd bcJrok76uh+zHcamLTymgmmu4YzBPwh8Z4f4q4eD5CAlK9HkjO0HkDxaRNwArGCja/8oC+/QNM= X-Google-Smtp-Source: AGHT+IE6M3/T/ty3wOo5/tgiz1/0jgbteEGUOeQLurv09QDBS2aci/DJUkBXdm0sre5R9RhN5VWtrQ== X-Received: by 2002:a17:902:f54d:b0:215:6f62:3091 with SMTP id d9443c01a7336-215bd0ecd88mr81222815ad.20.1733369708803; Wed, 04 Dec 2024 19:35:08 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215f8e6e8f4sm2853275ad.108.2024.12.04.19.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 19:35:08 -0800 (PST) Message-ID: Date: Thu, 5 Dec 2024 11:35:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/11] mm: pgtable: reclaim empty PTE page in madvise(MADV_DONTNEED) Content-Language: en-US To: Andrew Morton Cc: david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, peterx@redhat.com, mgorman@suse.de, catalin.marinas@arm.com, will@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, x86@kernel.org, lorenzo.stoakes@oracle.com, zokeefe@google.com, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <92aba2b319a734913f18ba41e7d86a265f0b84e2.1733305182.git.zhengqi.arch@bytedance.com> <20241204143625.a09c2b8376b2415b985cf50a@linux-foundation.org> From: Qi Zheng In-Reply-To: <20241204143625.a09c2b8376b2415b985cf50a@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: 11u8scu6ajy15wkfuauithqtyz856osr X-Rspamd-Queue-Id: D31A94000E X-Rspam-User: X-HE-Tag: 1733369691-520939 X-HE-Meta: U2FsdGVkX18PaR03aRKQBy6BnkJ+L+U+eBU5FJpdkykj9t3nwGCS2U5A6txrOXZ63DWyfHHhUZthOry7d9IwkepTX1+5PHvuYZGPciaaWgc3TljbKv+KOlZicUvhtjymEb6iI3ZpuzSePwBNjf//GBfudOfKoE6lnIF2uaN9v+m4NH1Gp3Ej+xKgfzK8nWYBbBReFti2uQsK3lIa1pGouTyxWVjYDR79HCTtJio//lDQ0kDmzXt5iQawXBlMY7x8cllmwm87PcUEJZcPzlnQe/YWHjak2lvAfmXBW0cteN8othhq6CejLSl7cqEg4Iv4pnMdsOjYXxg8lCJHEP1Ukl933JoC9bmDlmcMrKHMEBGxSOw4qetFsY5Fw3w9wW5X2q5X2Lulw4KiQQ0tUrY3ruL34nyqlogtRHm0vCBTRIV9z2ignQx2Wz6ctgM+5V1E2n3xiD+2JQpBt8D/nXFpMNsz/5FjKVh0GIxYP9Zc9KQGkqbtFIRQ0+yJHSbMtu/p4JtJtGKDfQWrlFLkvSmcOfxsaoKYqZ/4JUEzU2j0xnbEi7xWu7ESe2z94dr4RxOqkN7vZi8RJyBPaaAIepcY3f2SwD3UGU/XX7jUbeCOl4SrNw4dQG5Z1J8HCoW1kvizVsXkXSbe5W1GN8zq7gi8uHjUAPt1LTklMpVr2TROmGaiqhK0u6Z7S7pew4o/YDHUEwaG1bSqJ3NiLwRQ/m7bbYYN/L1q5DVlKL8Z2qccUMWddb1HoLLtDVGZFJCuesLNGM3mbZTJJQvYbUEI2+WwgS4CvQjj85wa1hKsVZETCVxDA3TlBqU9grp7DIBxTHjKYisY7c2wXdMF+yVy+zEVkb2fHPDx7iZrNbcVbk6WXpLyK29cGSM/9/IztkJ6f06dxu7TqCfSlzReTmeTDrj6PigC9zn8pZyfeKmRFyumMJL7KOspvxn+G5Nalgw5N80iEQxMdjxZCQWeQVzVN3B q1oLnM+W IBjJqYqtv/xYtmC1yz+QmCjTtGamsqXti9zHsGnwMFbI6JtiDjA44fZYVvOuHvu3zEwjOqES3OdxY8wJfqw5/gtUoaXDYB/00CHQG4RN2ehQUmpz0v7ScpSyUX02H97dn65d/bhZAswAatD6mtfHXqZx+8NJg6fJuWFQ8ooKak7aWDD2wb2QVBU5XIkQYwXL8I/qkV2tnp1AomwMQbfJJwW0jZuEaCJ/DJoqVYIQkTsu6p84H9II0GHC9fxJOi5ePalfX/8l/1ta4ib+mYde3LFQlvT4BQLvf7aSjVJEE7MOin9wC8938QYM7qGFopf298cPOB9Q9EknjQ0iFajaYIl69SV23XdZX6LJBMapFquKO2EYBI/G86r6DBxPsoSH7XQ0r+3VkBRHBCYNf3PVAVPZHnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/5 06:36, Andrew Morton wrote: > On Wed, 4 Dec 2024 19:09:49 +0800 Qi Zheng wrote: > [...] >> >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -1301,6 +1301,21 @@ config ARCH_HAS_USER_SHADOW_STACK >> The architecture has hardware support for userspace shadow call >> stacks (eg, x86 CET, arm64 GCS or RISC-V Zicfiss). >> >> +config ARCH_SUPPORTS_PT_RECLAIM >> + def_bool n >> + >> +config PT_RECLAIM >> + bool "reclaim empty user page table pages" >> + default y >> + depends on ARCH_SUPPORTS_PT_RECLAIM && MMU && SMP >> + select MMU_GATHER_RCU_TABLE_FREE >> + help >> + Try to reclaim empty user page table pages in paths other than munmap >> + and exit_mmap path. >> + >> + Note: now only empty user PTE page table pages will be reclaimed. >> + > > Why is this optional? What is the case for permitting PT_RECLAIM to e > disabled? > To reclaim the empty PTE pages, we need to free the PTE page through RCU, which requires modifying the implementation in each architecture. Making it an option will make it easier to gradually add support for each architecture. And for now, we have only added support for x86.