From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B812E6400D for ; Thu, 21 Nov 2024 19:47:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 714EC6B0088; Thu, 21 Nov 2024 14:47:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 689CB6B0089; Thu, 21 Nov 2024 14:47:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 503BC6B008A; Thu, 21 Nov 2024 14:47:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 334346B0088 for ; Thu, 21 Nov 2024 14:47:11 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D48A1814DD for ; Thu, 21 Nov 2024 19:47:10 +0000 (UTC) X-FDA: 82811134224.26.21E6C1A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 27B5840007 for ; Thu, 21 Nov 2024 19:46:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BSTGR7iB; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732218277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9vPjFHjh3yXhS4HZP/mZR+2x681KUbGOAjt5WUat2I0=; b=Y2NDc143i5JMPMJgr3gQqm1e2o9oH8hyOKSegC/3a3z8ora/XgOVoWF4VLRgnWXDSEUlKW 4kmBfDu+RhQYhm67sIDEHsNSwaCfIyVvGgmAGCXzly5jtSR1LvtUQpt3L1mD3Ymlq2UidH whwNAzelx04NPv84l1Th/mIfzBknb9c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732218277; a=rsa-sha256; cv=none; b=fq/tIGkNMwhSOR7R1Qo5ChZo/IG+GZ88tLCJxHn9Ha8ZNORMjTdaynUw8k7pdSrTbm6FG/ aiMDM3R0hS677uV3jJ3e+LMHd0C66J0GccrmwxNeCPwmzggdOWXvKxBd9W5so4+T0xCs7t eOupzogXkLvTv1SaN97+UQTC7VS/cNA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BSTGR7iB; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732218427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9vPjFHjh3yXhS4HZP/mZR+2x681KUbGOAjt5WUat2I0=; b=BSTGR7iBPI7Nc6Nd/9TeYxMoZDEmBd3apEUFVOqHZ6HNRErLvYhceF1y1q+z/Mkm3yE9Yz t9wJlDTmyFMo9+NxhIYMM4RLBVG7kdYJBV6Nq1uH6zGdYk2FeZz+i52QunGqnI9Uwz3kg7 8mZ5QVslPcZPAFVDFKTFHsaieamgk3Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-1z5JM6KOPayOXLpxPiDWwg-1; Thu, 21 Nov 2024 14:47:06 -0500 X-MC-Unique: 1z5JM6KOPayOXLpxPiDWwg-1 X-Mimecast-MFC-AGG-ID: 1z5JM6KOPayOXLpxPiDWwg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3825a721afaso714862f8f.0 for ; Thu, 21 Nov 2024 11:47:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732218425; x=1732823225; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9vPjFHjh3yXhS4HZP/mZR+2x681KUbGOAjt5WUat2I0=; b=a7IvCYWCravhu311hLQfvq+0a0NkcVgWinEYOltDbcB0dElcts6JdPoUgJUi7kAuHk Kp+xmHc2etBdL37E0GNdbq14vgWPCGZen6dxEvvpmSiO1Yw8QP3u0RdzvezfrYshcJF5 T2IK+oQGEVPOgcK7rTEKyxSzQjhEOLdneukjsWaZZzPCQ9cj4x7gOK3NSO7P4A4Yrp5t V6B48EFlXiKUtaekQlLqbGvH0Dkww3x+7KfB6Ky2mfiYzqaAxUF8utp46hxxd+YCEb7C vI3CZZg7QI8mC6CZdh1y7fo96IkiJnFsqMettgS/xWHZw7swIklind5pMyGspCdtqTwU Ckzw== X-Forwarded-Encrypted: i=1; AJvYcCWBWFbJfRWAvvVCsKr09DDzb2MHld2ELpl6M8eGAFsbMcmgVIlGlLDB+hm6DkYQrSK1GK3+lmeYuQ==@kvack.org X-Gm-Message-State: AOJu0Yy8giETw/tF1XQM6KUlLIdGZ8imjjrsjj6Q0kvPdLHGQtutycOh q3Y6ErR7lK386o3f3RUp2NMkjArUvZx8/AMvgPJaFXufnOkBmBA3k/EiyC2HhhBVThg+oVoyGTj G1S/tJhRN2A2mvyMg7YUy+dNnPTFrXFcJQqg+ehNMx9rNYMhp X-Gm-Gg: ASbGncueqlWU8wZpP9QIAPXOHyA7Hb0m7tzR+muGDxI+iBm3BsFX0dagsCEm2Ihhn0a DiHbchHy51hysX9mMsz7nyrotHauzg9JXw+Yt4ujVLEHJS5qVer8A6P+m8Fi86KMKyqD6ewdHK4 zKRc16POzEg6BCEqEzc/rBZYjGy+vbtGZltWaDOTVTBGvkcN6Sogcg5LTeFcgC26t7DO2Ze8dSD DzogvB/KTbF1dZ+bnxaJ9Q1iSGSP4HJJnufEYTX0Yig7VRKGkBwwddxN9WkBWvVTvut6OzXtH16 /zzZJU2uPix+BjJhwuNJv6eg7jeE37h0UP1KtMZ8sWnanmhbcdBdcWX8PBYa3BEsYaCH1vsNs84 = X-Received: by 2002:a5d:64a4:0:b0:382:4978:2ab9 with SMTP id ffacd0b85a97d-38260b50178mr280884f8f.5.1732218425143; Thu, 21 Nov 2024 11:47:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwjpMyfPMDn7yzJZGj2fN3hdUzm6pJror1oFSbaD9p3e5FF3gpDG0hGN0f8NMCUBM9HBDVYw== X-Received: by 2002:a5d:64a4:0:b0:382:4978:2ab9 with SMTP id ffacd0b85a97d-38260b50178mr280863f8f.5.1732218424718; Thu, 21 Nov 2024 11:47:04 -0800 (PST) Received: from ?IPV6:2003:cb:c70c:de00:1200:8636:b63b:f43? (p200300cbc70cde0012008636b63b0f43.dip0.t-ipconnect.de. [2003:cb:c70c:de00:1200:8636:b63b:f43]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fb537d4sm390281f8f.61.2024.11.21.11.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 11:47:03 -0800 (PST) Message-ID: Date: Thu, 21 Nov 2024 20:47:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/11] fs/proc/vmcore: introduce PROC_VMCORE_DEVICE_RAM to detect device RAM ranges in 2nd kernel To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton References: <20241025151134.1275575-1-david@redhat.com> <20241025151134.1275575-8-david@redhat.com> <4b07a3eb-aad6-4436-9591-289c6504bb92@redhat.com> <3ed18ba1-e4b1-461e-a3a7-5de2df59ca60@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vsPlfdO37FMnQleDxfI6dV7apqA0h2zRhXcsoupf1fg_1732218425 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 27B5840007 X-Stat-Signature: frshd7ne8gtr4empisj1rfmeqmcziq1b X-HE-Tag: 1732218360-668380 X-HE-Meta: U2FsdGVkX18RygQAB3s7nvcnzOcliGpqxgAUoJ70EzxU4cHrSb3kmodS5OUJ1x5+UD8ujEeMpJ/L22o/tt6KejU3IZmr4tvM9AAF0j6Y99mne+Q4QAqDTmeuswoEMUs/XG5t+R1fMnVK4kuDySAdWpc5KFoF7I6r8+fBrUHVF3ljW7Ie31HW99boiGU0nTl4Whs3Yv+BBs+GPZEfYp7o33iqRwc1zy/N4IB2TXFJFPNJoIftnPxzSkUMdeEe50b89wlyVhwfrlYdpFiP7GeHSEjHY/ztWcsB5jWxV53LJTP5LS/Yru3WdiQa9A5DwhddyAsmCcOG9U4+vyZUZPKiM5E7tFMInuZHqEB5GahST609JBSxFiSz//xwWPigW2JCs1KmIQUtSzdPKm0/HQXFs0aH9jTLs5m1ChJZuaB/6dEUEwkhdk1W3MaUE3oKTbDJwMzvl0Q3vUr7XUwsuaX6McjaMvF37h6yhiSa9gdA1U0dOSvvTfh0Dd8Aq4vIasyg/naIZDJE1dD4nOAzXbyO38US8eCxZNJpWZsr/IewCt8Bps1cWvTB77LByzc+GwaT0nap+Jo7br6K49bMAcjpJSMfqjcTnWDGJ7YuDcu9XIO2tj6WjCLVmVkNoR2TK9aMHsTIwiLFl5tiNQBQ3AiNf4A9wiwbc+7q06bdo9sC78gZYUUt3eiXy3o6ZnJj4U1wBHO727f/fx/ma9z6ATUf2YPZiqF2Gkn/9rhRW7mR+gJlhjAtr+Yn6seJExz4wlxR0UB59Shg1r/9N5RTR2UO8SLb8x3Wq4lrHQdBGTY87yO26p/yHsfLR5rARtztp6o8N68dWDxsGHbwVXqmJKyTuG7g4HPQWjh6K17SA8or/azXiiPkTtRz+NwVHfvsWwQQ8LZoqfxGRKSeA2GyuHyN1sUcVFSMr6gCmBUbdsHlAmxfvr/vgNUoZbbGXdO0BI4L9dfCZO6UcvsHhywj7QQ 4/+qgzeS aO1isNAquHeuSGP1shiyZ7KAOXSGqflUPIdCbx41JinkUMOVS7P1BmHfwYm5FwIA+J1pzHauC10kZpr67s2b/+bI364tnrtUPVOlEfajdnDBRgvigZCL27AUrjFFgaxW4in0AMuGwcu0FWxWFHiUflpAlrH3/ZQQc+U2a2I1EfyVTWMAPeaiQpd3U12EQvnMn2H6tYz7Y1djNIP8YNdjdIUuTRd+h+5biH8Wm9J2RTVEDm1rfGOk2hjyjf+IXWD+hkFvLP7Y6osChyeaz+QMZ4X7EXgi67nqgY0Iim2cmslHjG8iqhFAN2EDIID5urGowGlR5F7gJZzoiRGbKigLWEXBEzAkGa2RgiRK9Dg3V61blFYs0+bqkel0ZJFHgY1d6EYRo3YFRYw60WmO6qPXFQPNhoW64qIlRLE3dWbM0deeGKvlBU952d9CwCVv7AoG/XZi5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003058, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> That would work, but I don't completely like it. >> >> (a) I want s390x to select NEED_PROC_VMCORE_DEVICE_RAM instead. Staring at a >> bunch of similar cases (git grep "config NEED" | grep Kconfig, git grep >> "config ARCH_WANTS" | grep Kconfig), "select" is the common way to do it. >> >> So unless there is a pretty good reason, I'll keep >> NEED_PROC_VMCORE_DEVICE_RAM as is. > > That's easy to satify, see below: Yes, this is mostly what I have right now, except > > ============simple version===== > fs/proc/Kconfig: > config NEED_PROC_VMCORE_DEVICE_RAM > def n using "bool" here like other code. (I assume you meant "def_bool n", "bool" seems to achieve the same thing) > > config PROC_VMCORE_DEVICE_RAM > def_bool y > depends on PROC_VMCORE && VIRTIO_MEM > depends on NEED_PROC_VMCORE_DEVICE_RAM > > arch/s390/Kconfig: > config S390 > select NEED_PROC_VMCORE_DEVICE_RAM > ============================== > >> >> (b) In the context of this patch, "depends on VIRTIO_MEM" does not make >> sense. We could have an intermediate: >> >> config PROC_VMCORE_DEVICE_RAM >> def_bool n >> depends on PROC_VMCORE >> depends on NEED_PROC_VMCORE_DEVICE_RAM >> >> And change that with VIRTIO_MEM support in the relevant patch. > > Oh, it's not comment for this patch, I made the simple version based on > the whole patchset. When I had a glance at this patch, I also took > several iterations to get it after I applied the whole patchset and > tried to understand the whole code. Makes sense, I'm figuring out how I can split that up. If we can avoid the PROVIDE_* thing for now, great. Not a big fan of that myself. > >> >> >> I faintly remember that we try avoiding such dependencies and prefer >> selecting Kconfigs instead. Just look at the SPLIT_PTE_PTLOCKS mess we still >> have to clean up. But as we don't expect that many providers for now, I >> don't care. > > With the simple version, Kconfig learner as me can easily understand what > they are doing. If it took you a couple of iterations to make them as > you had mentioned earlier, and it took me several iterations to > understand them, I believe there must be room to improve the presented > ones in this patchset. These are only my humble opinion, and I am not > aware of virtio-mem at all, I'll leave this to you and other virtio-mem > dev to decide what should be taken. Thanks for your patience and > provided information, I learned a lot from this discussion. I hope I didn't express myself poorly: thanks a lot for the review and the discussion! It helped to make the Kconfig stuff better. I'll get rid of the PROVIDE_* thing for now and just depend on virtio-mem. > > =================== > fs/proc/Kconfig: > config PROVIDE_PROC_VMCORE_DEVICE_RAM > def_bool n > > config NEED_PROC_VMCORE_DEVICE_RAM > def_bool n > > config PROC_VMCORE_DEVICE_RAM > def_bool y > depends on PROC_VMCORE > depends on NEED_PROC_VMCORE_DEVICE_RAM > depends on PROVIDE_PROC_VMCORE_DEVICE_RAM > > drivers/virtio/Kconfig: > config VIRTIO_MEM > select PROVIDE_PROC_VMCORE_DEVICE_RAM if PROC_VMCORE > ~~~~~~~~~~~~~~ > > arch/s390/Kconfig: > config S390 > select NEED_PROC_VMCORE_DEVICE_RAM if PROC_VMCORE > ~~~~~~~~~~~~~~ > ======================== > > One last thing I haven't got well, If PROC_VMCORE_DEVICE_RAM has had > dependency on PROC_VMCORE, can we take off the ' if PROC_VMCORE' when > select PROVIDE_PROC_VMCORE_DEVICE_RAM and NEED_PROC_VMCORE_DEVICE_RAM? We could; it would mean that in a .config file you would end up with "NEED_PROC_VMCORE_DEVICE_RAM=y" with "#PROC_VMCORE" and no notion of "PROC_VMCORE_DEVICE_RAM". I don't particularly like that -- needing something that apparently does not exist. Not sure if there is a best practice here, staring at some examples I don't seem to find a consistent rule. I can just drop it, not the end of the world. Did you get to look at the other code changes in this patch set? Your feedback would be highly appreciated! -- Cheers, David / dhildenb