From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD99C433B4 for ; Wed, 21 Apr 2021 08:06:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41D72611F1 for ; Wed, 21 Apr 2021 08:06:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D72611F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF2136B006C; Wed, 21 Apr 2021 04:06:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA2586B006E; Wed, 21 Apr 2021 04:06:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91CD96B0070; Wed, 21 Apr 2021 04:06:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 789BB6B006C for ; Wed, 21 Apr 2021 04:06:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 35DF13633 for ; Wed, 21 Apr 2021 08:06:44 +0000 (UTC) X-FDA: 78055642728.12.CD4F67E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 926F3DE for ; Wed, 21 Apr 2021 08:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618992402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oK3rihUx7OjIP8MnUHMJzvDGc/eOqRPG2UhKmsMq4M0=; b=JL4xKflvdZEQzSuA0GJRDfkIcxtEYe0GMgduSCiAQBjT11GGsT28mhZBDrCAjLH3O+I7Bc 6ekF2BcGJwnUmLfzHD+MOlBSkCSv5i1614t5Md+0vp6k3IT3qfOq+JioLmhIce9kIzGfrV DCA5Yx41vBZs+ybvquBLu0hvqgo9noA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-trnfO3bZMUq3FRXgQmOvAQ-1; Wed, 21 Apr 2021 04:06:36 -0400 X-MC-Unique: trnfO3bZMUq3FRXgQmOvAQ-1 Received: by mail-wm1-f71.google.com with SMTP id z1-20020a7bc1410000b0290136839f16aaso121077wmi.0 for ; Wed, 21 Apr 2021 01:06:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oK3rihUx7OjIP8MnUHMJzvDGc/eOqRPG2UhKmsMq4M0=; b=H7cF2HRglvVUVKRY8sPcPjtoteZ+jkLqaBnca4E/RftScTIH0a7Z75Rv4MLq08Hby1 u6NdJ48BuK5ntNWKZ2i4NjamAoT5KxMIyZAFaGxqzh8k5nUuD/JqsoiUwxPXyfBp4++H muUz2zD4N20zlmsiPdICKzOGjxCIUEt+6QLtMmOnIYxb20HXBoOUOh41+kSdSBEGn+BC CuMwfeCHORVMAtnH0FKYLoHsCiud8LuCjns9A6zQvGOcNNXcCiAd3sx34IZT+DbhZLwt A1dH1JrShhj0eF3JU6GjEjckSJAE9gSxuDAHidqrtk3CQW7P2a82aNaXO9Sbj2eLFTdr 3ROQ== X-Gm-Message-State: AOAM532cXp5kkqnhLYvuK/p9MDntV8PJuvq9sLAtshEEX0hxpx44pBPm e1P5MHYh8rzLxkmplefukX4E/D5VHgvKj01hW+BOl5hIY7qDrP4mQw0gyZMfKJt3IyxaPkwmFMY lcMPWs5P35yU= X-Received: by 2002:a5d:424a:: with SMTP id s10mr26464901wrr.70.1618992394823; Wed, 21 Apr 2021 01:06:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh933TlcjPpXOPqkAVaIRzTS8Z39NS8E9+o0Sn0mgvIQuFp76UNqwReiF9Ybvlt4h+OULlSQ== X-Received: by 2002:a5d:424a:: with SMTP id s10mr26464883wrr.70.1618992394632; Wed, 21 Apr 2021 01:06:34 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64b8.dip0.t-ipconnect.de. [91.12.100.184]) by smtp.gmail.com with ESMTPSA id h81sm1747260wmf.41.2021.04.21.01.06.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 01:06:34 -0700 (PDT) Subject: Re: [PATCH v9 3/8] mm,memory_hotplug: Factor out adjusting present pages into adjust_present_page_count() To: Oscar Salvador , Michal Hocko Cc: Andrew Morton , Anshuman Khandual , Pavel Tatashin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210416112411.9826-1-osalvador@suse.de> <20210416112411.9826-4-osalvador@suse.de> <20210421080036.GC22456@linux> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 21 Apr 2021 10:06:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210421080036.GC22456@linux> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 926F3DE X-Stat-Signature: ao5f6cww3nxu4jyirj55cw63y7yr9swb X-Rspamd-Server: rspam02 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618992394-407023 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.04.21 10:00, Oscar Salvador wrote: > On Tue, Apr 20, 2021 at 11:45:55AM +0200, Michal Hocko wrote: >> On Fri 16-04-21 13:24:06, Oscar Salvador wrote: >>> From: David Hildenbrand >>> >>> Let's have a single place (inspired by adjust_managed_page_count()) where >>> we adjust present pages. >>> In contrast to adjust_managed_page_count(), only memory onlining/offlining >>> is allowed to modify the number of present pages. >>> >>> Signed-off-by: David Hildenbrand >>> Signed-off-by: Oscar Salvador >>> Reviewed-by: Oscar Salvador >> >> Not sure self review counts ;) > > Uhm, the original author is David, I just added my signed-off-by as a deliverer. > I thought that in that case was ok to stick my Reviewed-by. > Or maybe my signed-off-by carries that implicitly. > >> Acked-by: Michal Hocko >> >> Btw. I strongly suspect the resize lock is quite pointless here. >> Something for a follow up patch. > > What makes you think that? > I have been thinking about this, let us ignore this patch for a moment. > > If I poked the code correctly, node_size_lock is taken in: > > remove_pfn_range_from_zone() > move_pfn_range_to_zone() > > both of them handling {zone,node}->spanned_pages > > Then we take it in {offline,online}_pages() for {zone,node}->present_pages. > > The other places where we take it are __init functions, so not of interest. > > Given that {offline,online}_pages() is serialized by the memory_hotplug lock, > I would say that {node,zone}->{spanned,present}_pages is, at any time, stable? > So, no need for the lock even without considering this patch? > > Now, getting back to this patch. > adjust_present_page_count() will be called from memory_block_online(), which > is not holding the memory_hotplug lock yet. > But, we only fiddle with present pages out of {online,offline}_pages() if > we have vmemmap pages, and since that operates on the same memory block, > its lock should serialize that. > > I think I went down a rabbit hole, I am slightly confused now. We always hold the device hotplug lock when onlining/offlining memory. I agree that the lock might be unnecessary (had the same thoughts a while ago), we can look into that in the future. -- Thanks, David / dhildenb