From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD03C433EF for ; Mon, 25 Apr 2022 21:08:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CD106B00B2; Mon, 25 Apr 2022 17:08:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77BCC6B00B3; Mon, 25 Apr 2022 17:08:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61C1A6B00B4; Mon, 25 Apr 2022 17:08:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 526476B00B2 for ; Mon, 25 Apr 2022 17:08:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 331BE121F25 for ; Mon, 25 Apr 2022 21:08:55 +0000 (UTC) X-FDA: 79396641030.30.68CDE8F Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 41E70A003E for ; Mon, 25 Apr 2022 21:08:48 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id z12so1096413ilp.8 for ; Mon, 25 Apr 2022 14:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dj+5dMDCvTEJVrzKshB6b4DWctTjsJvqWQXJDIVQeFI=; b=T7qeLWhHLe2L9Vg52i6AG8Hs+RgH6Mmrb8hHTcn5yaZhHwEoLdKdU2Clgb5TM/+tRS opYDp6Pg0WTZbd6StdorlMTT/7PjvKuNne2tok460ybXxEP1zB2tjYUtzRFztm8vlcee qU4up4WkTz3KBH7CLgVC3kqgMpyIT7MAb5K+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dj+5dMDCvTEJVrzKshB6b4DWctTjsJvqWQXJDIVQeFI=; b=X0uBseCnT0zQM9NIYrDblFuZ00oRhjjZq5RLv8whvtflUEsA4sSNh+PQRSBbMmCRXy hc0nbyl7w8ppRy0RT3cGVyHrN7V6nWmd1ewFcUeAxZ1GMYrB4NyqkmXdfutrApCUVbK1 IqxCj8RF0X/nZr4FAREfM7ZGGTQJLu4c+C9DU0DrCbGCTafK9uOdntLluW6DeOuv0qZM y7sPz9nu+1U5lqtDnOgwUzPMlaaQ/bh+yffrVV1k7F093EUEpqM020m2NvXcefWvXfWq x29STbeN5aJKO6kaNpFA/HCUKnqm60PzE+ZMw8fBhVDFNyoz3SAEleRWKwmZUc0tA7z/ YoxA== X-Gm-Message-State: AOAM533K1NvWgm7PpvSGfsteza8yRMADVEpZ2hF1q9dx+XrLac/1N2PO 1pwhdgXweT4iP9vk6RhwNgx4kg== X-Google-Smtp-Source: ABdhPJwBA6xDBIMr99W5DdIl70hnEvTF5gi4r05yFSv1MS8iw9Qcz39YRvxWB1lgM6Hvmq4zXvCikA== X-Received: by 2002:a05:6e02:1a6b:b0:2cc:1eef:9c8c with SMTP id w11-20020a056e021a6b00b002cc1eef9c8cmr8143340ilv.256.1650920933998; Mon, 25 Apr 2022 14:08:53 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id f10-20020a05660215ca00b0064d25228248sm8430892iow.11.2022.04.25.14.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 14:08:53 -0700 (PDT) Subject: Re: [PATCH V3 0/4] selftests: Remove duplicate CPUID wrappers To: Reinette Chatre , shuah@kernel.org, linux-kselftest@vger.kernel.org Cc: dave.hansen@linux.intel.com, sandipan@linux.ibm.com, fweimer@redhat.com, desnesn@linux.vnet.ibm.com, mingo@kernel.org, bauerman@linux.ibm.com, mpe@ellerman.id.au, msuchanek@suse.de, linux-mm@kvack.org, chang.seok.bae@intel.com, bp@suse.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, luto@kernel.org, x86@kernel.org, Shuah Khan References: From: Shuah Khan Message-ID: Date: Mon, 25 Apr 2022 15:08:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 41E70A003E X-Stat-Signature: eti9ekqfhjak7w83yh7zufy3drehswxj X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=T7qeLWhH; spf=pass (imf25.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam09 X-HE-Tag: 1650920928-302730 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/25/22 3:01 PM, Reinette Chatre wrote: > Changes since V2: > - V2: https://lore.kernel.org/lkml/cover.1647360971.git.reinette.chatre@intel.com/ > - Rebased against v5.18-rc4, no functional changes. > - Add text in cover letter and first patch to highlight that > the __cpuid_count() macro provided is not a new implementation but > copied from gcc. > > Changes since V1: > - V1: https://lore.kernel.org/lkml/cover.1644000145.git.reinette.chatre@intel.com/ > - Change solution to not use __cpuid_count() from compiler's > cpuid.h but instead use a local define of __cpuid_count() > provided in kselftest.h to ensure tests continue working > in all supported environments. (Shuah) > - Rewrite cover letter and changelogs to reflect new solution. > > A few tests that require running CPUID do so with a private > implementation of a wrapper for CPUID. This duplication of > the CPUID wrapper should be avoided. > > Both gcc and clang/LLVM provide wrappers for CPUID but > the wrappers are not available in the minimal required > version of gcc, v3.2, that the selftests need to be used > in. __cpuid_count() was added to gcc in v4.4, which is ok for > kernels after v4.19 when the gcc minimal required version > was changed to v4.6. > > Copy gcc's __cpuid_count() to provide a local define of > __cpuid_count() to kselftest.h to ensure that selftests can > still work in environments with older stable kernels (v4.9 > and v4.14 that have the minimal required version of gcc of > v3.2). Update tests with private CPUID wrappers to use the > new macro. > > Cc: Dave Hansen > Cc: Sandipan Das > Cc: Florian Weimer > Cc: "Desnes A. Nunes do Rosario" > Cc: Ingo Molnar > Cc: Thiago Jung Bauermann > Cc: Michael Ellerman > Cc: Michal Suchanek > Cc: linux-mm@kvack.org > Cc: Chang S. Bae > Cc: Borislav Petkov > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Andy Lutomirski > > Reinette Chatre (4): > selftests: Provide local define of __cpuid_count() > selftests/vm/pkeys: Use provided __cpuid_count() macro > selftests/x86/amx: Use provided __cpuid_count() macro > selftests/x86/corrupt_xstate_header: Use provided __cpuid_count() > macro > > tools/testing/selftests/kselftest.h | 15 ++++++++++++ > tools/testing/selftests/vm/pkey-x86.h | 21 ++-------------- > tools/testing/selftests/x86/amx.c | 24 ++++++------------- > .../selftests/x86/corrupt_xstate_header.c | 16 ++----------- > 4 files changed, 26 insertions(+), 50 deletions(-) > > > base-commit: af2d861d4cd2a4da5137f795ee3509e6f944a25b > Thank you. I will queue this up for Linux 5.19-rc1 thanks, -- Shuah