From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 560F1C0219B for ; Tue, 11 Feb 2025 16:56:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D18056B008A; Tue, 11 Feb 2025 11:56:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC7F96B008C; Tue, 11 Feb 2025 11:56:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B68556B0092; Tue, 11 Feb 2025 11:56:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 61B616B008A for ; Tue, 11 Feb 2025 11:56:00 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 61ABFA0399 for ; Tue, 11 Feb 2025 16:55:59 +0000 (UTC) X-FDA: 83108266038.05.46A9A92 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf02.hostedemail.com (Postfix) with ESMTP id 950A880006 for ; Tue, 11 Feb 2025 16:55:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739292957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xanTZxOKNQDjJGLeEsUNpC0KWxk6yVa3sdFEd8+5ytM=; b=tcFP6fn5SdCGbxYRzxfzCXkMedvQWIBAQ/kHJYd62FE+FDe4qfZt+/rdgIzVaijB1vRBdY KoReos9vE6UHxEvzPtAHweAw2C/CVwGK9bRyfhki2/Itm8nQGywb+2pVcgT5btFpJKaPPg wpIzZWRlQGOOk05fbQxmmKaM/Pw5eTM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739292957; a=rsa-sha256; cv=none; b=t6CCYgCFmLlUsIEk6wHFfTF184MgT530tpHfqvZ4rMEX9sKInGqnayAMqL9BTdCMqvpI/c FIk624QvcVxKuJz7UHI5CwGhsWfoI4ULfLiQONtlRMasuXDPCky5xfEsFFzmV50kAkwy71 /izOOOHDY8pPRfgg6giu3L/Wuovqtg4= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YsnYw2HZNz6L54D; Wed, 12 Feb 2025 00:52:52 +0800 (CST) Received: from frapeml100006.china.huawei.com (unknown [7.182.85.201]) by mail.maildlp.com (Postfix) with ESMTPS id BB3081400DD; Wed, 12 Feb 2025 00:55:49 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100006.china.huawei.com (7.182.85.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 11 Feb 2025 17:55:49 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Tue, 11 Feb 2025 17:55:49 +0100 From: Shiju Jose To: Fan Ni CC: "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , "Jonathan Cameron" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , tanxiaofei , "Zengtao (B)" , "Roberto Sassu" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm , "a.manzanares@samsung.com" , "nmtadam.samsung@gmail.com" , "anisa.su887@gmail.com" Subject: RE: [PATCH v19 00/15] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers Thread-Topic: [PATCH v19 00/15] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers Thread-Index: AQHbeW7q+yAlb0l8b0m3xpFA4TlX9rNAxY6AgAF8IfA= Date: Tue, 11 Feb 2025 16:55:49 +0000 Message-ID: References: <20250207144445.1879-1-shiju.jose@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.157.58] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 950A880006 X-Stat-Signature: u3dysyoikw7rfhesdj7b5u388ydmrm97 X-HE-Tag: 1739292955-310083 X-HE-Meta: U2FsdGVkX18r334I/42tc+AgQpUtcGTP0QU9ol0LdS1g2tynkJdygzeNB4Y66NBX7qmO2002kySvI+PPU+A/X0cIJJMjiK/b3HoucG0pJIPVWVqupTgxmsBkAVBwtgHHmBXCf1ynzx+MCFHkue71xsrEUUDE5ndVsGNRRr8OrrUCpOEwz83sgDqu92dUYtKkCk0lvfucJOyLlWWb6HSroErzRLsrInULH8GPzm2G+tfvLJdbVpEBXQlKL1vOb/+BsMDXMNXQlKR/OIhL2KZ3u0nPp4Plqz6K3P0Vurvet1/3jl8hxZCxQARX97FyN+nIdqPD2fp7G0EKYfjkK9xp2DxWmw3TUNZvLGfncdE4tDVa+teASoTR0uO4E5rIQ7ncyy2GQkwoWfAYmJvqqoAA3VMakWZ1po/4yyvF4vAstluOPuMSNhdzXj2wzEnaRZXMouQGjFa1pLu6nYCI+a9I/Rldo8HeQAAtfPx77gxekmnmzOYWcuP5RbYYA3WV+GBYYqrVbw+kIEhgMqKhvaaA2uew4qsx3jG9miDh/6sCohxzHoEtP4tAdOM2oVQcN+ZCntP1sNzSzZalvXJmjGdA1ImmN1EPNfhjKyIJfh9SkLFTEOD3bUpaBv7XDQimcjoV92EjQBoaSKmGEvDdQVZz2xKD1/FxUL4PX6YLGk37dA9uJmVQLycSoNHdbjzckauGABVbYMcSL9xl4iDpfuMm5yWhl8msF00tV/p3yfvLZ00Imj38tcPAgvmx6gtpK5UQIRXPG4jRCRjTLsdO825xMZuA1+U0TpSHgB+DgaqJ7A/SWnlC14mj7brYyYsFD94cvccGqeiThNW3yK4zA/2WJlFsfXj46q2ie+fLt4lXQWrgsdKUqSFEBCjlIgfDMG7P8o5eiOrhqHcWCnv23r8ei6kb5gmCVdKy8LzoD1CAt5nzDSmqGcETdWLEnqb/h8Eo3RcwVXMaWP6o32NTAq2 wmPbNLXe Yn+B7B5EYfG4Badeecv+bOOX4SIbKqRhp0kvltqt7hP5quSrQJy5L2C5Bus2ZdqkPxKZpyYKUg8Ne3h60OFnPT2bzNGUe6uITgxeivRZw5QkADawchmBlfbGxzxLOtpNWMydq+eviqur3MYOAb0H0CdykukcJZ15eLAbj4EZffWK6Um6LMUU4IooEMWpOUNxdOeF7qxUjSSHvTCkJcGV7420B3H15VR04HP87sSNemj9ZkoHqZRHLHtt+GmZmZMk4AdmyWOUwQaUY2VerC3lprxoC2ZBka1eo5PwsFlB3ws4SyT4Or7PHcS6lc4kmrgMGI6miZaWd9A6ZX5NhMJVS/lVNECoxZbAeGahImkvmbhOlh+hMM1Mz78XnI2WKvAUa5edixNoeMI82OyYVrglurUPT1x0u1kLHM2GXN2GPotTJjew5zsiZVMG89Vo/W/GMfSVE/r057SydwW9k94z1IoRWnaRxzGlpVpSDnClhixf4ZcIONLhyNJU86SBewMLy/MOch1w73hxYXxQrAKMYPwTYAqX3AuAV/grIgBJbh2exX/PC1rjRYfP9uIGpBpg2dsOTBXZW6IAgXy75UePQccdDTlQhTJ7B32CNzrRxhF27jQ3q/9rn+hXC5NYMml5l90vYLivAabrLX5syxpM4RHpvjKDb7Wk/LH1yjHrTPaG8KQ8/hZOBucX2tuHYokqtyDiVDcCB8dEh1r/PvgoSqlsDsvs+CapshtrdGf+XuBw7wx0x7exn2emTtHU2g1KdFhj/b8lgpP/60G85abT/6I/WWbDfvRUtovl3vf0lEcMuUzkYxSBzMSsen4Gd9R/McZ3cVsvl/DDcddallFozpVSzMPv/F1GMCbULGHs3hfVtvjt7uh2o/e5FSxjP+dJsFtcgJJgk4M/xMuPr5mkrlCsBJUZeI3jOUmzhvMomyUhrkef8Mo1+aGXEj1CKJjGR/XDs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Fan Ni >Sent: 10 February 2025 17:53 >To: Shiju Jose >Cc: linux-edac@vger.kernel.org; linux-cxl@vger.kernel.org; linux- >acpi@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; >linux-doc@vger.kernel.org; bp@alien8.de; tony.luck@intel.com; >rafael@kernel.org; lenb@kernel.org; mchehab@kernel.org; >dan.j.williams@intel.com; dave@stgolabs.net; Jonathan Cameron >; dave.jiang@intel.com; >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; >david@redhat.com; Vilas.Sridharan@amd.com; leo.duran@amd.com; >Yazen.Ghannam@amd.com; rientjes@google.com; jiaqiyan@google.com; >Jon.Grimm@amd.com; dave.hansen@linux.intel.com; >naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com; >somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; >duenwen@google.com; gthelen@google.com; >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; >wbs@os.amperecomputing.com; nifan.cxl@gmail.com; tanxiaofei >; Zengtao (B) ; Roberto >Sassu ; kangkang.shen@futurewei.com; >wanghuiqiang ; Linuxarm >; a.manzanares@samsung.com; >nmtadam.samsung@gmail.com; anisa.su887@gmail.com >Subject: Re: [PATCH v19 00/15] EDAC: Scrub: introduce generic EDAC RAS >control feature driver + CXL/ACPI-RAS2 drivers > >On Fri, Feb 07, 2025 at 02:44:29PM +0000, shiju.jose@huawei.com wrote: >> From: Shiju Jose >> >> The CXL patches of this series has dependency on Dave's CXL fwctl >> series [1]. >> >> The code is based on v3 of CXL fwctl series [1] posted by Dave and >> v3 of FWCTL series [2] posted by Jason and rebased on top of >> v6.14-rc1. >> >> [1]: >> https://lore.kernel.org/linux-cxl/20250204220430.4146187-1-dave.jiang@ >> intel.com/ >> [2]: >> https://lore.kernel.org/linux-cxl/0-v3-960f17f90f17+516-fwctl_jgg@nvid >> ia.com/#r >> >> >> Userspace code for CXL memory repair features [3] and sample >> boot-script for CXL memory repair [4]. >> >> [3]: >> https://lore.kernel.org/lkml/20250207143028.1865-1-shiju.jose@huawei.c >> om/ >> [4]: >> https://lore.kernel.org/lkml/20250207143028.1865-5-shiju.jose@huawei.c >> om/ >> > >Hi Shiju, >Is this series the same as in branch >https://github.com/shijujose4/linux/tree/edac-enhancement-ras-features_v19= ? > >I hit some compile errors wen trying to test with the above branch directl= y. > >Here are two cases where I found the code cannot compile. Please check if = it is a >false alarm. > >Case 1: CONFIG_CXL_RAS_FEATURES=3Dm > >fan:~/cxl/linux-edac$ cat .config | egrep -i "edac|cxl|ras" | grep -v "^#" >CONFIG_ACPI_RAS2=3Dy >CONFIG_ACPI_APEI_EINJ_CXL=3Dy >CONFIG_PCIEAER_CXL=3Dy >CONFIG_CXL_BUS=3Dy >CONFIG_CXL_PCI=3Dy >CONFIG_CXL_MEM_RAW_COMMANDS=3Dy >CONFIG_CXL_ACPI=3Dy >CONFIG_CXL_PMEM=3Dy >CONFIG_CXL_MEM=3Dy >CONFIG_CXL_FWCTL=3Dy >CONFIG_CXL_PORT=3Dy >CONFIG_CXL_SUSPEND=3Dy >CONFIG_CXL_REGION=3Dy >CONFIG_CXL_REGION_INVALIDATION_TEST=3Dy >CONFIG_CXL_RAS_FEATURES=3Dm >CONFIG_MMC_SDHCI_OF_ARASAN=3Dy >CONFIG_EDAC_ATOMIC_SCRUB=3Dy >CONFIG_EDAC_SUPPORT=3Dy >CONFIG_EDAC=3Dy >CONFIG_EDAC_LEGACY_SYSFS=3Dy >CONFIG_EDAC_DEBUG=3Dy >CONFIG_EDAC_DECODE_MCE=3Dm >CONFIG_EDAC_GHES=3Dm >CONFIG_EDAC_SCRUB=3Dy >CONFIG_EDAC_ECS=3Dy >CONFIG_EDAC_MEM_REPAIR=3Dy >CONFIG_EDAC_IGEN6=3Dm >CONFIG_RAS=3Dy >CONFIG_MEM_ACPI_RAS2=3Dy >CONFIG_DEV_DAX_CXL=3Dm >fan:~/cxl/linux-edac$ > > >fan:~/cxl/linux-edac$ make -j16 >mkdir -p /home/fan/cxl/linux-edac/tools/objtool && make >O=3D/home/fan/cxl/linux-edac subdir=3Dtools/objtool --no-print-directory -= C objtool > CALL scripts/checksyscalls.sh > INSTALL libsubcmd_headers > UPD include/generated/utsversion.h > CC init/version-timestamp.o > KSYMS .tmp_vmlinux0.kallsyms.S > AS .tmp_vmlinux0.kallsyms.o > LD .tmp_vmlinux1 >ld: vmlinux.o: in function `cxl_region_probe': >/home/fan/cxl/linux-edac/drivers/cxl/core/region.c:3456:(.text+0x7b296f): >undefined reference to `devm_cxl_region_edac_register' >ld: vmlinux.o: in function `cxl_mem_probe': >/home/fan/cxl/linux-edac/drivers/cxl/mem.c:188:(.text+0x7b8ad1): undefined >reference to `devm_cxl_memdev_edac_register' >make[2]: *** [scripts/Makefile.vmlinux:77: vmlinux] Error 1 >make[1]: *** [/home/fan/cxl/linux-edac/Makefile:1226: vmlinux] Error 2 >make: *** [Makefile:251: __sub-make] Error 2 > >When compile with CONFIG_CXL_RAS_FEATURES=3Dy, it can compile. > Hi Fan, Thanks for checking this and reporting. This error is with CONFIG_CXL_RAS_FEATURES=3Dm and CONFIG_CXL_BUS=3Dy and C= ONFIG_CXL_MEM=3Dy. Now changed CONFIG_CXL_RAS_FEATURES for tristate -> boolean as this imple= mented only interface functions for the CXL RAS features. > >CASE 2: CONFIG_EDAC=3Dm > >fan:~/cxl/linux-edac$ cat .config | egrep -i "edac|cxl|ras" | grep -v "^#" >CONFIG_CRASH_RESERVE=3Dy >CONFIG_CRASH_DUMP=3Dy >CONFIG_CRASH_HOTPLUG=3Dy >CONFIG_CRASH_MAX_MEMORY_RANGES=3D8192 >CONFIG_ARCH_SUPPORTS_CRASH_DUMP=3Dy >CONFIG_ARCH_DEFAULT_CRASH_DUMP=3Dy >CONFIG_ARCH_SUPPORTS_CRASH_HOTPLUG=3Dy >CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION=3Dy >CONFIG_ACPI_RAS2=3Dy >CONFIG_ACPI_APEI_EINJ_CXL=3Dy >CONFIG_PCIEAER_CXL=3Dy >CONFIG_CXL_BUS=3Dy >CONFIG_CXL_PCI=3Dy >CONFIG_CXL_MEM_RAW_COMMANDS=3Dy >CONFIG_CXL_ACPI=3Dy >CONFIG_CXL_PMEM=3Dy >CONFIG_CXL_MEM=3Dy >CONFIG_CXL_FWCTL=3Dy >CONFIG_CXL_PORT=3Dy >CONFIG_CXL_SUSPEND=3Dy >CONFIG_CXL_REGION=3Dy >CONFIG_CXL_REGION_INVALIDATION_TEST=3Dy >CONFIG_CXL_RAS_FEATURES=3Dy >CONFIG_MMC_SDHCI_OF_ARASAN=3Dy >CONFIG_EDAC_ATOMIC_SCRUB=3Dy >CONFIG_EDAC_SUPPORT=3Dy >CONFIG_EDAC=3Dm >CONFIG_EDAC_LEGACY_SYSFS=3Dy >CONFIG_EDAC_DEBUG=3Dy >CONFIG_EDAC_DECODE_MCE=3Dm >CONFIG_EDAC_GHES=3Dm >CONFIG_EDAC_SCRUB=3Dy >CONFIG_EDAC_ECS=3Dy >CONFIG_EDAC_MEM_REPAIR=3Dy >CONFIG_EDAC_IGEN6=3Dm >CONFIG_RAS=3Dy >CONFIG_MEM_ACPI_RAS2=3Dy >CONFIG_DEV_DAX_CXL=3Dm >fan:~/cxl/linux-edac$ > >fan:~/cxl/linux-edac$ make -j16 >mkdir -p /home/fan/cxl/linux-edac/tools/objtool && make >O=3D/home/fan/cxl/linux-edac subdir=3Dtools/objtool --no-print-directory -= C objtool > CALL scripts/checksyscalls.sh > INSTALL libsubcmd_headers > UPD include/generated/utsversion.h > CC init/version-timestamp.o > KSYMS .tmp_vmlinux0.kallsyms.S > AS .tmp_vmlinux0.kallsyms.o > LD .tmp_vmlinux1 >ld: vmlinux.o: in function `devm_cxl_region_edac_register': >/home/fan/cxl/linux- >edac/drivers/cxl/core/memfeature.c:1720:(.text+0x7b665d): undefined >reference to `edac_dev_register' >ld: vmlinux.o: in function `devm_cxl_memdev_edac_register': >/home/fan/cxl/linux- >edac/drivers/cxl/core/memfeature.c:1697:(.text+0x7b7241): undefined >reference to `edac_dev_register' >ld: vmlinux.o: in function `ras2_probe': >/home/fan/cxl/linux-edac/drivers/ras/acpi_ras2.c:363:(.text+0xb0ecc8): >undefined reference to `edac_dev_register' >make[2]: *** [scripts/Makefile.vmlinux:77: vmlinux] Error 1 >make[1]: *** [/home/fan/cxl/linux-edac/Makefile:1226: vmlinux] Error 2 >make: *** [Makefile:251: __sub-make] Error 2 > Here the symbol 'edac_dev_register' can't find with CONFIG_CXL_BUS=3Dy CON= FIG_CXL_RAS_FEATURES=3Dy and=20 CONFIG_EDAC=3Dm. Modified CXL_RAS_FEATURES depends on EDAC=3Dy || (CXL_BUS=3Dm && EDAC=3Dm) to fix this. > > >Fan > > Thanks, Shiju