From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D7BC433EF for ; Mon, 6 Sep 2021 15:00:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E0B360F92 for ; Mon, 6 Sep 2021 15:00:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2E0B360F92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 522C06B0071; Mon, 6 Sep 2021 11:00:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D2B06B0072; Mon, 6 Sep 2021 11:00:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 399DF900002; Mon, 6 Sep 2021 11:00:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 2704C6B0071 for ; Mon, 6 Sep 2021 11:00:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9C426181AEF32 for ; Mon, 6 Sep 2021 15:00:20 +0000 (UTC) X-FDA: 78557459400.19.B1A5D0E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id 19566F000209 for ; Mon, 6 Sep 2021 15:00:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DAAEB2216F; Mon, 6 Sep 2021 15:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1630940418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GtLd8PUpY6ySmzB9TkCpxL+dEFac492sN/Mn+31uQ0U=; b=BhuvVGKDj60z0dkWsv4qdFmsOnGwz1TLLKU/zpLaeePDixldVArrP4lmpbxkZjxOVMOwWr lAFwNVKoD90qrBtgQQkUherK7Spcnr2bYpljOR438F2lXQz6+FazlDE1KbFUvndZwSqQ9/ MewKYNs8NXt9WX5ekcDgnEB4Z/nHluQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1630940418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GtLd8PUpY6ySmzB9TkCpxL+dEFac492sN/Mn+31uQ0U=; b=GPZjcmZiIdad9Kf9zwg04zZi4k5osODlRR4zLakyoDaCJOk4OKV76hfywsq2P+wN4xl616 r5j7oMollVgh8QAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B612813C29; Mon, 6 Sep 2021 15:00:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jSa+KwItNmHUZwAAMHmgww (envelope-from ); Mon, 06 Sep 2021 15:00:18 +0000 Message-ID: Date: Mon, 6 Sep 2021 17:00:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH v2] mmap_lock: Change trace and locking order Content-Language: en-US To: Liam Howlett , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Steven Rostedt , Michel Lespinasse , Matthew Wilcox References: <20210903022041.1843024-1-Liam.Howlett@oracle.com> From: Vlastimil Babka In-Reply-To: <20210903022041.1843024-1-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 19566F000209 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BhuvVGKD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GPZjcmZi; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam01 X-Stat-Signature: dwphpqqugiootejwqj1hj9ccc836j67p X-HE-Tag: 1630940419-505323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/3/21 04:21, Liam Howlett wrote: > Print to the trace log before releasing the lock to avoid racing with > other trace log printers of the same lock type. That description could use more details maybe? > Signed-off-by: Liam R. Howlett > Suggested-by: Steven Rostedt (VMware) Acked-by: Vlastimil Babka