From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FDAC54E58 for ; Thu, 21 Mar 2024 19:08:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05FE16B0088; Thu, 21 Mar 2024 15:08:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00F676B008A; Thu, 21 Mar 2024 15:08:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCB3E6B008C; Thu, 21 Mar 2024 15:08:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CBF696B0088 for ; Thu, 21 Mar 2024 15:08:12 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4C491C03B2 for ; Thu, 21 Mar 2024 19:08:12 +0000 (UTC) X-FDA: 81921981624.06.0B9D23C Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2133.outbound.protection.outlook.com [40.107.93.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 5FEA040005 for ; Thu, 21 Mar 2024 19:08:09 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=eePb8MhT; spf=pass (imf12.hostedemail.com: domain of svetly.todorov@memverge.com designates 40.107.93.133 as permitted sender) smtp.mailfrom=svetly.todorov@memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711048089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FoApNzr/LQq5DDBgX9rakpL9wg7ul2g+0pvEW5GgUFA=; b=0J1UTGvproLr7LXi81HEtnlpQDo/gzJ6NCuXey+N3ZeiO0EDIi78QoO1q2fcK/fHfNtKKR kSqGOdWnjk37HkBSZzpNGqZBNkmb84U9JFqncSLbwoFZ5+fXi3Y6/QDUS2wmPH9sQoc1Q4 7Up2veArd4Ki/wEgKYhR7Wm6G7NcZ90= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=eePb8MhT; spf=pass (imf12.hostedemail.com: domain of svetly.todorov@memverge.com designates 40.107.93.133 as permitted sender) smtp.mailfrom=svetly.todorov@memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1711048089; a=rsa-sha256; cv=pass; b=mcIdBny0FIQVED0t/MNujme71CMljWyOlGLLEspQNKrxpfpHdmX32mMrmvIN5cC9ENvmgo JMs9pBFFZw9vFL5Yhc8OpKV4Z73E6ul2W6xWAN/Syg/SdQw6PKRhxgsDuRktjgVPUhDoVK k7kQc7gD6ufzDP/v9UIiZD7jyer8qfs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzoZRne/F0zKtHxzrA9ItNIa/bw5k8L/lQC3wTUVwMwq1b8O7JxNX3AGW8XxEaobxvL21g0Jm3ZcPEeO9vp2fy8TXuUZq1tjV46Zv23VTPZ+NIi5cmcLyxHwouQnfN26Stn4RPpqNuXhy2XjrMhkRFdrEzMW7b8O95OT8VW8e5zVbgNvH5ALLHg9jPG1xZkDDo7RKcnMJVswhkiW5Pyrct54LDpPr6Z6TUd6g5ULkWhN0r3rADswsLjtt9HdDJnDq6ljwmM1bCZJ5Yv2wk4C9IuT6qDW63JNxswtxXVIduLV6k50vRLZ6XJODKWaUfk6WgBoYJO23od8VSUUel28gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FoApNzr/LQq5DDBgX9rakpL9wg7ul2g+0pvEW5GgUFA=; b=Pym9s+spD9hDpnXRUnZffAM4Kzz+f01FvOnT8Nop4uZ8uEMuCektAVZmWYISngWMzjNzEaiFn8kLX5j2+fZafR8s8SIZNTOOXIXXFmznhWx0rMLjG+7AXHeZQ7dL/uJ06vDHG77vc/C+Dcj2cbB0QEIMwcQ6jKk9d7jqrcQC9QZFv4gQC5EvGi+/uq5VTfa5JwKNhDON3Mp7M0cuNM+BrD4cF+6Bw8iN9KyPpR3WFpaGPgtjejfkkYYI6XyBVv8Rb+Q9eH4lA8EN72S0m4vj3h+WLXCUkmyA4nbCE0XveQutD0UF6E4S6xEMLMndO/29ULbtdJUmgWqyoMd2poGFOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FoApNzr/LQq5DDBgX9rakpL9wg7ul2g+0pvEW5GgUFA=; b=eePb8MhTC5/N4Ap8G8cAlGJNY22Ql8N1yCrey/tIY9DqcxxKGQIQUl+3rfwfE41PKmCa1kpiOQ4+fUyu7uOMnwq4xWRPEPoSvfw6sgAFvQbRcrqpve7NgqAL2hxIXcDxbqS0Arg+TGP6W1MzwyiJJfwI2L/ULJDqtnurB4/0zWY= Received: from IA0PR17MB6347.namprd17.prod.outlook.com (2603:10b6:208:435::22) by PH0PR17MB5487.namprd17.prod.outlook.com (2603:10b6:510:b6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.34; Thu, 21 Mar 2024 19:08:04 +0000 Received: from IA0PR17MB6347.namprd17.prod.outlook.com ([fe80::200e:df84:29a9:8c9a]) by IA0PR17MB6347.namprd17.prod.outlook.com ([fe80::200e:df84:29a9:8c9a%6]) with mapi id 15.20.7386.031; Thu, 21 Mar 2024 19:08:04 +0000 Message-ID: Date: Thu, 21 Mar 2024 12:08:01 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] kpageflags: respect folio head-page flag placement To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gregory.price@memverge.com, wangkefeng.wang@huawei.com, akpm@linux-foundation.org, david@redhat.com, vbabka@suse.cz, naoya.horiguchi@linux.dev References: <20240320-kpageflags-svetly-v3-1-b6725843bfa7@memverge.com> Content-Language: en-US From: Svetly Todorov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR11CA0098.namprd11.prod.outlook.com (2603:10b6:a03:f4::39) To IA0PR17MB6347.namprd17.prod.outlook.com (2603:10b6:208:435::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR17MB6347:EE_|PH0PR17MB5487:EE_ X-MS-Office365-Filtering-Correlation-Id: 70203356-ed13-4153-8118-08dc49da3c21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PWu4AilVmTqYpzCpbbnFjn7NgkAx0MLc93cfNE01RHDRtjxqt8WutDSUnaNueEZb3yGJ4/hKCO5Iwr9F+aDJNFa4tTculvc89ge/h35svGEP3tucwIfbI7gbQY3Aq8i58FeghNUyfjLfxFL/5HwJlMTEIc1HhOAo/cLWhFbj0W9tby+OGykCS4QGoOI3rS+xft3ECSfH5U9aUQeidRjO2Yv/4zKRcTqiE5wkDhqEPoROgRkM7bsBRsN1Bf2wXgcGiGM/HtQLYvQC43Wtl4lCVKv7sbs4Qh4Iy+J8YCFm3y/9x99wjhFqCz5xbfdhLoz9OFRTStAPg+SQJhQN5RfNMfF63UDGmkE5kovDBipLLfmcwSr0cKREI304pr1m46Ovq/QUAJ4hHhkYnTK/U+6TEkE9ViAbkaM7kqzCpHbPWec8nWa1nOJd0Jq13MM1L7kwqi+BGgs6X8CUkATbAK3WfZ4BrsJfdGbU2Er0taEtN0TCRV5aOks/HlHETyvLcsdTX0r6f59B0bPIlK0Dg6Eg04MZ/Ywj2qKOWcPOCxJmybLq0+AgytbYz1k44HdWPQo+u3ayDNJ0WwFxiAp/g8evcPjzLVSPdkyi7H8XHbOCq+y9UkA85zhe+BG2iF5/7AiwjpjOSs5LGhLP7+vo21mm8M9M8IeDP2le56IW8ElELqw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR17MB6347.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TENkWEhoZVh0bkJxL2p2MXpkL3NkdldZY2swanJLQXBvQStRMGFLVmtCNThT?= =?utf-8?B?RGZPM0hpc1BmZ3poeTJUVmpxTlNUWTEwV0tKN0Vzcm5XdnVRWkVhK2ZHTnEr?= =?utf-8?B?UGJHbmJiZEY3eDI0ZGhyZ1ZFV3JzOFdVbEE0WjBQcUZIb3dtRVk5SXg5QU5x?= =?utf-8?B?eS9vTk04OTB1T1VUTUdYSzB5WHkxNGtlbE40Wk1TcXh0V1V0OCtnY2x4aWRE?= =?utf-8?B?S2h0MFlMUzBIVVhuQ2U5Q05hOUNyZFcybTIxY2IzVVlZRWVuWWVhaWxZbGtF?= =?utf-8?B?ZWdSVGJwVGJIb3dnVXlrYUZ1ckpKRGN1Z2d3b2ljTEZOT0p2MVpSVnJRencz?= =?utf-8?B?V2hEdjJLMmkxbmtmZkhjYWhidnVyc3NKYkdIbyt3Uk5BMy8wdm5BZE1UVm9M?= =?utf-8?B?V0pUcDJVNFhrL3NuNXgrNGwzZGNicER4b2s1NjRreERYMkQySUZGcDJ5OEpT?= =?utf-8?B?eHUzTXdRSkYvWE9kc1hCKzBGMHUyZ0FFYUNyTHd1TjZabXJHbnp0U09pM3I0?= =?utf-8?B?djZxSk5WM2ZucUZ0a2QvZDUybUcycElwL2dCTkFOMnU1cVl0YkFXVVQ3L3Vz?= =?utf-8?B?emdDOThTdUlMR1ZTU2N4Uzl0eEV5MUEwSkYwamxJeVZqczVsWU5YMGl1VGRM?= =?utf-8?B?emw1RXFpdXFYdXlPdTlaWUlkV0RoMTUzL1c1dGUyM2dJTFpjVkpXdlhaelBI?= =?utf-8?B?dTRxVm9qSHNBNEUvR2hLcElLR1dGaXdldjh4L0dlOEFhbkN4bm9INStyU2pI?= =?utf-8?B?dzFvS1ZNS2dxUVRRdDN4Y05CQ3BEWmloQjJrTHJ3MDdvLzZQaGdSU3ZEclMz?= =?utf-8?B?NFJDTDljTjBmZjdxejZnL3lSeEl1ME9PTE0ybnNKL0IzajI5VDNncUFqVUhF?= =?utf-8?B?Z1grbXQ0UjRKTFF0R3YvMEFsakgvZDM4dStaaitHTEpJSGtldWlReW95bU4z?= =?utf-8?B?UFFJdUs0cHlWUVVocCswaE5ycE9tOUtSREhWRklWMS9OS0lzNll4Y3hxQURt?= =?utf-8?B?VHVlWW9vTkYyWUVKQnFQa0dGREtsZS95eis0TzVoRG0wOUlwOXg2RkhTM1Qr?= =?utf-8?B?MXZvQW51ZzJPZkVYYzBkQVNpS29ONE9zZE1QMGpWbXFrRDc2cHFtTk82MzdX?= =?utf-8?B?ODh6bFYvbktVMzFtbkxycXgyR3pSVUpRZXNtNEJTVzl5NUtIYmtTeHV0dHV2?= =?utf-8?B?eTZYQVpYQys3QXN6MVlEZGpCNVhOcVdrb1pQTHdUOTRQWjdIUUx2UGRwcllY?= =?utf-8?B?REN4UENKbXlWTkdGc1kzUlduSWh3Rjlmb0EwUTF1QTU4RVNBT3Z5NVNDUHJn?= =?utf-8?B?MVA4MEJidWhVK203OFNaMDVLWkJMZlRxMmFUSktXbXJ1OXdRa0kzYXZzMkN2?= =?utf-8?B?NzJwRjZIaWl5Y2ozTnJ6YTQycEdZdUFnZW1ZVE1xOWI5RE9mUElCVVlCN0Vl?= =?utf-8?B?QnhSZkY2ZW5jeVVxK290VHcwTjZrRHhGZ015QVQ4MnBqbXJidWx6V1FLYVJ4?= =?utf-8?B?cmczT2x4L2pDSFk5N3dSUWJCdGo2Zk1VMUpFa05kTlVKeG83TzNOODdNTFAz?= =?utf-8?B?blRZU01BbTVTZjZzMnBlclVrQzI4T0t4OGtKUXpEaUZzdHE1c0VMZkppMVlK?= =?utf-8?B?TUp2NEg4RWtUSFVoekNQK2FFYmdGdE1HMGR3c3hMZ3JqRVIvU2F1M1ArU0Rl?= =?utf-8?B?M284RDdSUXBtVnI1aUt0b3prdnJHdmRMNWZVbXZPc1hWSk92UG5CbDVSNmdQ?= =?utf-8?B?dHZkQ1AvNDA1bExrM0wyOVhlMUZ2b01Od0llT0YvMXZNK3EvT0didUVhN2ZE?= =?utf-8?B?NkwvNXFTaldSTUVxd1ZrbWFmMFU4TGpyQTdrajIvTmZQTkFwSjMxbmhDNVZ6?= =?utf-8?B?U05kOUQranVqQTBybVJSTG5GNzhOYWZ0T0xYZ0hxSUpoWkZyb2cwdTdxYzlm?= =?utf-8?B?OHJYUWNyL3FEbTRMQWFsaVFjOUwyZm95RnhPWVBVK2pyaDhuZVZkbFB0a3lJ?= =?utf-8?B?VDN5MnhmR2grZ3BDWHlmeVpMRnpzUi82Y1lMOTZRKzZFcHZiaExNNHFzU0dN?= =?utf-8?B?Yi9Ncjh1d0RubHBGcUt3ejNVbFNRcm5TVk92eVFJYkN4M1hPQVFzV21oTWpC?= =?utf-8?B?ZUdiMVJLdTRqT3puRXdFcTlSM2hnNDZBcGg4Rnl0RnZOMy9iM3g0aHp0aW9B?= =?utf-8?B?TUE9PQ==?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70203356-ed13-4153-8118-08dc49da3c21 X-MS-Exchange-CrossTenant-AuthSource: IA0PR17MB6347.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 19:08:04.1963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JSAdq+MY8Do9tPQE8otrFjo/R6D8fK5wjPFEvgkuNPA7uFZD2oZb405FM3qJKCYsOCxBG8yls2ttfYk7X1uzqoH1OUK8a4vdRbVl59RtMpo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR17MB5487 X-Rspamd-Queue-Id: 5FEA040005 X-Rspam-User: X-Stat-Signature: 9ydqprpceqfn7u5x65f7m18jwjzhkasp X-Rspamd-Server: rspam01 X-HE-Tag: 1711048089-506279 X-HE-Meta: U2FsdGVkX1+FSNobWAyr+xENAIz0NhoVwdD/XHDlrL2RLv6CEP7Tb4a/g6tRL/35zdAvsitKX+eTHah1VORmYwbnuT50BmuiIg9Mdp/j5QXmEwPedSKbbRv7W8oBXjguPZV1Ml20REv46jeTFDB+FUBF7yAVBTzbKTrjLF+HS6AovO3gbYqFDLdj5jl+6k/MeYZ9k9CsdViYaXpR6EuH9FRZfcnTNckS+V9np973ZpnXpgiJTdRKEjus6NCK7rED7vs2NdLk5RLbL2adP1xl6zAC5k3+s8bDM00jVgNfG1ISgqzcR5uha0Dm7kF0qtnACV7p0TVXuWTntzuRyVI9/Efc9JuLWxQhIfySdkeduHZ1CTw4IP3AR9416XQd79VpWuVcP6ssgxEOD4UWDYV7rkO7oWx+qJpwM0SybnYkou6BcjngbnptVzoKkmQ+EGCxC8Q95d0mkZV9WrK7foICLokDKClNxvKH8F+iqQa+cajJsFWItnZ5My7Hc9IbfRrrciwo7hgEn5Lz7Kv40wNDeE1tL8Jx1qeX57mVO3STYegK9xieL1dkbNg2GUXqVIFVVIXYwSL1akjLRv5/Uug4B936Rvcr5sUvCRva1CsQYej6fJRJgQJSuGcrMIZFQdkj/0DW3H1XWjN9OBR7KPfggCpluoCCxG5Cy4Aac5EcWm+8w9cAyK/xFEU/z5GsgVCf59qtA+sMYVkFteGB3BAvjzMbljpIdG5Pe3uuQTBX8IvGXq3fPKFxMyAsp016jrf33pBjyTAs0Zol+YgvSFWgufx/lYYNRayyQ4QILfCA8bjmmuXrR6M1IDEspq39beQaur0l7VqBQvzngGru2HIPMQBpV2PEklAt1GBpkPuPdHULXzFcSSzv7lUUYMcQUL95haGg4dKcJ5ollMVvnwWc71wOpbS7o3sNYY36W6CWsrbK69OKHawRvuYpFb3oBbx83tMRWT6+zCQDw7g9LCz TmPucGJS kpvAJEwCrW3Aw9coKFI9rJ639s/6W8Gorp/HTvoSLWFvxVfSnbwNgWeJtjagU9tnKpzjqpHBzgz7ZYuqEhaAVx49ClOEkkVs0HZ12MkYe2y0UfK9IO+qEea6Y5p8qPW61RQNby7uSVOIWa8l332De7KLUMxWyJuFG/x+f/Wt1NMaobNDGL3WqvArKI0EyT6DHMY84KzSgGwcoPn3yots3QOjNt6aIqtENkThWZ+xnwZDg32MPnAEKHzeKWBeDRI/11sbb9zNsrUJmSJyMUk+DEyxKKjqCG6A1Gfjjs49rL1L2NnvScKtnIde4xYXbuo+9KH84WvcV++xlBwzmhU5fxWAKow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Thanks for your careful review. No problem!! It's a valuable learning experience for me. >>> - if (PageKsm(page)) >>> + if (mapping & PAGE_MAPPING_KSM) >>> u |= 1 << KPF_KSM; >> This might need an #ifdef? >> Say mapping is movable and anon -- then (mapping & PAGE_MAPPING_KSM) is >> true. Before, we called PageKsm, which falls through to a PG_ksm check. >> If !CONFIG_KSM then that flag is always false. But now, we're liable to >> report KPF_KSM even if !CONFIG_KSM. > > I'm not sure where you see a PG_ksm check: > > static __always_inline bool folio_test_ksm(const struct folio *folio) > { > return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) == > PAGE_MAPPING_KSM; > } > > static __always_inline bool PageKsm(const struct page *page) > { > return folio_test_ksm(page_folio(page)); > } My bad. What I meant was, if CONFIG_KSM is undefined, then > #ifdef CONFIG_KSM > ... > static __always_inline bool PageKsm(struct page *page) > { > return folio_test_ksm(page_folio(page)); > } will fall through to > # else > TESTPAGEFLAG_FALSE(Ksm, ksm) > #endif And you're right -- there is no PG_ksm comparison -- but the autogenerated PageKsm will always return false: > #define TESTPAGEFLAG_FALSE(uname, lname) \ > ... > static inline int Page##uname(const struct page *page) > { > return 0; > } But given your comments below, I'm realizing this isn't as important as I thought it was. > There's no such thing as a movable anon page -- the two bits in the > bottom of the mapping pointer mean: > > 00 file (or NULL) > 01 anon > 10 movable > 11 KSM > > Perhaps it might be clearer to say that anon pages are inherently > movable; the movable type really means that the reset of the mapping > pointer refers to a movable_operations instead of a mapping or anon_vma. I see. I misunderstood how the flags are applied. I thought that 11 == (01 | 10) -- i.e. that KSM was an intersection of MOVABLE and ANON. But they're more like mutually-exclusive states. And I doubt that a page will end up in the KSM "state" if CONFIG_KSM is disabled. So we don't need to rely on PageKsm() for the CONFIG_KSM check. That said, won't if (mapping & PAGE_MAPPING_KSM) return true even if a mapping is ANON (01) or MOVABLE (10) but not KSM (11)? Shouldn't this at least be if (mapping & PAGE_MAPPING_KSM == PAGE_MAPPING_KSM) ? >>> /* >>> * compound pages: export both head/tail info >>> * they together define a compound page's start/end pos and order >>> */ >>> - if (PageHead(page)) >>> - u |= 1 << KPF_COMPOUND_HEAD; >>> - if (PageTail(page)) >>> + if (page == &folio->page) >>> + u |= kpf_copy_bit(k, KPF_COMPOUND_HEAD, PG_head); >>> + else >>> u |= 1 << KPF_COMPOUND_TAIL; >> This makes sense but it'd require changes to the documentation. >> I ran a python3 memhog to see if anonymous pages are currently reported >> as COMPOUND_HEAD or COMPOUND_TAIL and it seems to be a no on both. >> But with this, I think every pfn will have one of the two set. >> Unless you can have a page outside of a folio -- not sure. > > I see your confusion. We have three cases; head, tail and neither > (obviously a page is never both head & tail). If a page is neither, > it's order-0 and it is the only page in the folio. So we handle head > or neither in the first leg of the 'if' where we set KPF_COMPOUND_HEAD > if PG_head is set, and tail in the 'else' leg. Dumb mistake on my part. For some reason, I thought that every folio->page had its PG_head set. > It's not so much the performance as it is the atomicity. I'm doing my > best to get an atomic snapshot of the flags and report a consistent > state, even if it might be stale by the time the user sees it. I see. That makes sense. Cool! Thanks for bearing with me. Beyond the KSM stuff, my only hangup is that this patch doesn't account for the handful of remaining per-page flags (KPF_HWPOISON, KPF_ARCH_*). Should I take this diff, tack those on in a second commit, and then put up a v4? Forgive me, I'm very green to the kernel dev process...