From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB83C433EF for ; Thu, 16 Jun 2022 20:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22DEC6B0071; Thu, 16 Jun 2022 16:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DD656B0073; Thu, 16 Jun 2022 16:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07EC66B0074; Thu, 16 Jun 2022 16:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EBEEA6B0071 for ; Thu, 16 Jun 2022 16:19:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B94EE34431 for ; Thu, 16 Jun 2022 20:19:58 +0000 (UTC) X-FDA: 79585215276.09.E3B2FE1 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf03.hostedemail.com (Postfix) with ESMTP id 438B5200A3 for ; Thu, 16 Jun 2022 20:19:56 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id y12so2599575ior.7 for ; Thu, 16 Jun 2022 13:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dfkm2dRdVxtt3SV4LQI+L9Ln4V2YzTGpPhRrTLCNvI8=; b=QSWpvu9pWfaUPtZWEVpGfTPlC4TAzgLKTQazq9FVTmXWjrP7M8kNlU8AN8oqhkIvad fQdfo6nlia4m120WWW67tUJiMptbuycHSVLtE4oGfB+/dQMM2VypdNmh+s1ID6SP3flH fUryY1g6P4hWm6WOsHv/RZ0oncfsgXIOoT2EQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dfkm2dRdVxtt3SV4LQI+L9Ln4V2YzTGpPhRrTLCNvI8=; b=oT3IePEn2ybZ9Z1o90Gob4YlbFckcwQHa9tYE1EgRGTUUOBf89wBpxyGNRV+x7Dy6q np9/0ucvQdUx8KDNe+PjOkyf4VjPKUlyF+UoOV7w63Jc+3EfKaBBFq5ebpAju32TkJPx jZlqjxdWQcxP/MaSv78cpv0OHUt56YNzP3DOPCpSk18l7mU5c3kbBz+yMYrzfz1PYXKI O4U8FNlRrgcIM2EQ0PI2G9LKNON3YMo2EWAZqWmiYpSh2Ux8e0Vh30CffN/6pFputpVB ExG/1Wgv3XrxY+/l0LEaHC+rUpwStiFTtnYWADxI1a4f49mNVmUN936++DbBbNsC+45q utkg== X-Gm-Message-State: AJIora/HZfrXvHCGO2uadeF0uos7iC+7hURzOzeW1u28m5y31/Q372HS kv+t3HIC+LBczjxPkbLOG8VA8Q== X-Google-Smtp-Source: AGRyM1uhjyLP+Q7fR9PxCN3oEeMg+rYmK3g6VQVZBzwNqbTEr5ANByUlMGD6MD/qFY1p/nDnL1xa4A== X-Received: by 2002:a05:6602:29c3:b0:669:25e5:72d2 with SMTP id z3-20020a05660229c300b0066925e572d2mr3474783ioq.206.1655410795569; Thu, 16 Jun 2022 13:19:55 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id s70-20020a025149000000b00331f8fff9a3sm1286586jaa.64.2022.06.16.13.19.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 13:19:55 -0700 (PDT) Subject: Re: [PATCH] selftests: vm: Fix resource leak when return error To: Ding Xiang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220615093629.1330809-1-dingxiang@cmss.chinamobile.com> <29be48c7-7178-6f25-c99b-0d11eb967539@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Thu, 16 Jun 2022 14:19:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <29be48c7-7178-6f25-c99b-0d11eb967539@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=QSWpvu9p; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.45 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655410797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dfkm2dRdVxtt3SV4LQI+L9Ln4V2YzTGpPhRrTLCNvI8=; b=u7z0uDxPMWCJPhKj+JgH4AynkWUncoxtjGl3sogsmED8ZI5XoEbxCYIcGQ/Njnk+3nHbhc T3fH9ymRmERAPFB1XqvSyNPTlygqbQHZ/pfudQ8CiKtqTaReSqAPNRtej2g94lElMX3T0a KjrhnqRSD5wKxUy0Krx6bcpyNHLZN3M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655410797; a=rsa-sha256; cv=none; b=oXjX9p+Cth+dQgwQ1ay4FoWzxKDZuPrFuUqxBVEJ7HVOOovSyUZoMX+lcJ0sHtNpsmPh5o 4Uh24TTS/n88KnmXRZPW2FsCGuxjTIlRbCK7+K/hjG0HR9EZXJeXe4Fc6tnV0iVQZceyIR QWLEFI8ejVA+VDWzzqWvRMoHc7HqI4o= X-Rspam-User: X-Stat-Signature: ntee3kzzdhzjb7z1nxg5oy5y3n7kf8xf X-Rspamd-Queue-Id: 438B5200A3 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=QSWpvu9p; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.45 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspamd-Server: rspam05 X-HE-Tag: 1655410796-57949 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/16/22 2:11 PM, Shuah Khan wrote: > On 6/15/22 3:36 AM, Ding Xiang wrote: >> When return on an error path, file handle need to be closed >> to prevent resource leak >> >> Signed-off-by: Ding Xiang >> --- >>   tools/testing/selftests/vm/ksm_tests.c | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c >> index 2fcf24312da8..f5e4e0bbd081 100644 >> --- a/tools/testing/selftests/vm/ksm_tests.c >> +++ b/tools/testing/selftests/vm/ksm_tests.c >> @@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val) >>       } >>       if (fprintf(f, "%lu", val) < 0) { >>           perror("fprintf"); >> +        fclose(f); >>           return 1; >>       } >>       fclose(f); >> @@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val) >>       } >>       if (fscanf(f, "%lu", val) != 1) { >>           perror("fscanf"); >> +        fclose(f); >>           return 1; >>       } >>       fclose(f); >> > > Looks good to me. > > Reviewed-by: Shuah Khan > I applied this to linux-kselftest fixes for next rc. thanks, -- Shuah