From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78C3CCA480 for ; Mon, 11 Jul 2022 14:53:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3014C8E0005; Mon, 11 Jul 2022 10:53:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B18D8E0002; Mon, 11 Jul 2022 10:53:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A0078E0005; Mon, 11 Jul 2022 10:53:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0974C8E0002 for ; Mon, 11 Jul 2022 10:53:42 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id C35EB120AD0 for ; Mon, 11 Jul 2022 14:53:41 +0000 (UTC) X-FDA: 79675113042.15.7696ABD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E688C140054 for ; Mon, 11 Jul 2022 14:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657551220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WJKzatRpxuBvlw+y/WmRUjNpFDe0w/BjpatBDpchBJM=; b=JfoC/2v0koMztXy7nlpLhI0AoMujYOKff3fWmuX6J8CEZPQS7isOwwXRRP50myoB/RkD3h 7xUr0M+b2kmSQf/fJXBIKsASnXitmIL4pmX0exPXDaVkUG8xgtaV3r2IOQMbUOOpxpvNHU h7/Jq22YZ2jVxii4OLzsFeYkQvax53s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-29-oSxrkO4eOzOWj4T1RUHtDw-1; Mon, 11 Jul 2022 10:53:39 -0400 X-MC-Unique: oSxrkO4eOzOWj4T1RUHtDw-1 Received: by mail-wr1-f71.google.com with SMTP id j23-20020adfb317000000b0021d7986c07eso712314wrd.2 for ; Mon, 11 Jul 2022 07:53:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=WJKzatRpxuBvlw+y/WmRUjNpFDe0w/BjpatBDpchBJM=; b=fKgTqjaGZKRX6Dx5wubhBrM7pzHMx6+732gQvzmEnMev6kIVhJbKIjyWB9V0V8HCDa HZ0qvu2C0LMMy6ag0VfnT1hUzr7ierGuLx8jEkIFCuPCSoS5nHCvorrmRn8HGtE6FCoC Pdy3S/QqYr771vJOjmnEaZWEKAdWEJM4N4W95uIQCU+wdEbgsHQyufJOAkC0TUs4dgJ1 Z1MYS8JcGfANFYfpakBkJbMQGnJAltaCwKIy/G/wEFf2/kTfoplQMMcP8C+IEbm4ZSrY DLyrAhyDVl8xBNKqcIakbF8tVPdaSW7rKLV3WVCVYRoDycEz2goRSekglLFkY25q0KC3 kBgw== X-Gm-Message-State: AJIora9A6xxN4RuuVnCts8ySiB4PxPH1DoQomD+DHuQXmkEXrn1I2gfl VLq/eaQi3Q8z+fYtpWmP/CLF7b4q5bHyj+6VNAZMzM1U8LI5UG044D7xrSj6C8mVGPwIbPaUvde OS3GJCUSxKPs= X-Received: by 2002:a05:600c:3592:b0:3a1:9e9d:2595 with SMTP id p18-20020a05600c359200b003a19e9d2595mr16789389wmq.76.1657551217929; Mon, 11 Jul 2022 07:53:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uF7fVJz9gV/LGNy5ZuztDsIKohRmcbcs6QZEq6X8YOCi+3alMsLlZbv00GX9vpBHFadMKsmA== X-Received: by 2002:a05:600c:3592:b0:3a1:9e9d:2595 with SMTP id p18-20020a05600c359200b003a19e9d2595mr16789363wmq.76.1657551217690; Mon, 11 Jul 2022 07:53:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:1400:c3:4ae0:6d5c:1ab2? (p200300cbc702140000c34ae06d5c1ab2.dip0.t-ipconnect.de. [2003:cb:c702:1400:c3:4ae0:6d5c:1ab2]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c3b0800b003a2ead2c884sm528930wms.13.2022.07.11.07.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 07:53:37 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 16:53:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/4] mm/sparse: skip no-map memblock check when fill_subsection_map To: Li Chen , Catalin Marinas , Will Deacon , Rob Herring , Frank Rowand , Andrew Morton Cc: Li Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org References: <20220711122459.13773-1-me@linux.beauty> <20220711122459.13773-3-me@linux.beauty> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220711122459.13773-3-me@linux.beauty> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657551221; a=rsa-sha256; cv=none; b=vurciEg62W08WkxTuwEvxZz7dj45JNl2B158kRCcCWfru/LZRdkdTjuYhxBWNL/Mu8WQl2 lNJ68urQ4lQeXrm1tEcoCZetdZPsMZxgwrtk57oYjLXePYTyBCrrRHfwkyFVtjJIgUd5Kj oYTYgLTagw/McqprHyKgFj/VsnYAMHU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="JfoC/2v0"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657551221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WJKzatRpxuBvlw+y/WmRUjNpFDe0w/BjpatBDpchBJM=; b=HmAefR8zeHXiZwJo5a26qyJ7/B+Ny0NfPew8ITpgUUpxMixSK5RotrdcdAqr0Bh1HvZoEf R7t2MrqaN+hiROEExSKKmqPyoDfjz7CkV+VdFCh5MktMJoDLA+y3XuHjE5WEQilBnGnPPY 17v3Q0bz1BEFkyuCzhPjaF2dHILStks= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="JfoC/2v0"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: ughhbtcire4u98tbo5zdxzr6uqep6zj1 X-Rspamd-Queue-Id: E688C140054 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1657551220-52791 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.07.22 14:24, Li Chen wrote: > From: Li Chen > > When mhp use sparse_add_section, don't check no-map region, > so that to allow no-map reserved memory to get struct page > support. > > Signed-off-by: Li Chen > Change-Id: I0d2673cec1b66adf695251037a00c240976b226f > --- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 120bc8ea5293..a29cd1e7014f 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -690,7 +690,9 @@ static int fill_subsection_map(unsigned long pfn, unsigned long nr_pages) > > if (bitmap_empty(map, SUBSECTIONS_PER_SECTION)) > rc = -EINVAL; > - else if (bitmap_intersects(map, subsection_map, SUBSECTIONS_PER_SECTION)) > + else if (memblock_is_map_memory(PFN_PHYS(pfn)) && > + bitmap_intersects(map, subsection_map, > + SUBSECTIONS_PER_SECTION)) > rc = -EEXIST; > else > bitmap_or(subsection_map, map, subsection_map, I'm not sure I follow completely what you are trying to achieve. But if you have to add memblock hacks into mm/sparse.c you're most probably doing something wrong. Please explain why that change is necessary, and why it is safe. If the subsection map already spans memory (iow, subsection map is set) you intend to add, then something already added memory in that range? -- Thanks, David / dhildenb