From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22AD9E77188 for ; Wed, 8 Jan 2025 13:19:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F1A46B0088; Wed, 8 Jan 2025 08:19:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A13B6B0089; Wed, 8 Jan 2025 08:19:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F41B6B008A; Wed, 8 Jan 2025 08:19:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 202D56B0088 for ; Wed, 8 Jan 2025 08:19:58 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CDD021A0F4D for ; Wed, 8 Jan 2025 13:19:57 +0000 (UTC) X-FDA: 82984342434.20.606DF48 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 729F218002C for ; Wed, 8 Jan 2025 13:19:45 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijkBN2t7; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736342385; a=rsa-sha256; cv=none; b=A/NAcScFJsu5tvUaQTLX/7+OsbomEVr6ZBuZW3DwYIr1ikF1LLvyHnv6GNcXWIDhAc57sw SrNbzuPoaep0/nwpxcc0kwa+OkCYoNjnT5+XrZUkbm51or3M75Q0tiOgbmBZ/2glBmPajU 9gf9qHsrv0SujfNxBZpHOYIBJv/hR+Q= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijkBN2t7; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736342385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uwNz9RyCTrz2SGcx4HcSRlsjq7MVSxKxazMUgZRAWds=; b=gRnpLRN3JlJ6mRYbDZ4lTXy3+EVOJe70SwvGpm9jtDzgl8Hk9/unVLxSaUYr9t7+c2iGmq WMQuIGhdHGYLjGr5tXRKb6RoF4tfk9OG8uVsNJxJEZ6bLny3JbQREqWrL1pHYq9aeHF8BV xMKYbAocwTqTEn7XG3+NQc2kP8Fxg4s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736342384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uwNz9RyCTrz2SGcx4HcSRlsjq7MVSxKxazMUgZRAWds=; b=ijkBN2t7TyzZMAigRh2g0M5EDaGu7ACt++pCR5Clnb7r9qmlm8usy5WdmVNW97Yk2f+uFc IH9qcx8dnho/evzlxVKoH5IdZLf645N/gUeyBBhV/jSNZ1QX6niSFbT4/ELgZ7L21hjyN/ N8+3XPv0pCE7NhQQcB3seruNnOUyikY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-zDYesfM3Nsmbdrh1_Ieg2A-1; Wed, 08 Jan 2025 08:19:43 -0500 X-MC-Unique: zDYesfM3Nsmbdrh1_Ieg2A-1 X-Mimecast-MFC-AGG-ID: zDYesfM3Nsmbdrh1_Ieg2A Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-436289a570eso127705145e9.0 for ; Wed, 08 Jan 2025 05:19:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736342382; x=1736947182; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uwNz9RyCTrz2SGcx4HcSRlsjq7MVSxKxazMUgZRAWds=; b=EBDpVENmDbK5aR0LJChzO2pnaNVC9db3CibtfznQ15WMUFJcPdVegjSEwYpfyMaxd4 0DrINvWhWIs9M/CR8Cp13zOvMOM6BaRSYUyhMXA6s/o1ojRsPPdQ6b8kGGeWJsHNMiRn AroSS/gV3Ua+3YwGlljk8LzuaL7ySFW4t3xP0A/shJ2hjbaYfGxJBiNiSl4EpbG5YytT tYu6Lq3KtDYDOBRF2D75rfxp439nFqeCNariiG5UYhBNIpEy3jCirwwNIXnV3DRSv9iF /gWlRKvZYqnmjUNbEqAOn9/igWCzVsz9FUpM98mfkC1dwFePcBkOgSrzNnTjyCgpROpN Frsg== X-Forwarded-Encrypted: i=1; AJvYcCUrz8qzsSNVv+LxRjskZD6l6zXZcEtL898gDB1RrXmyi3e5lgpeCcwKN9heWXgVZHX5fZeF9zjWtw==@kvack.org X-Gm-Message-State: AOJu0YxPc1L2g0oT+M3Y2G4r5mWuvPUZKHmqR+BE1JSkORJy9v3xSnJg Vt1RfqvG1oJ9CeBecUel7Xf/z0HMtujU72L1hzTvq4TPBCCzHjQy38PImsh9tcO/P2RQTcYqx20 iFhFd2UkrN0wlpi3MeU3lHgjR8P71CqkDLhyU+vFn2usU6Fgq X-Gm-Gg: ASbGncuwg82Tn6Zai0Q7GicqbssGIK31Cn6HB5EXz7BN3LAwVdGopoaUFPKZvi3Ju7D x4gOJZILHKbZEO/2qYITBdIchH3U3fLkBxSno9Ylb00w4h8JooNFfX5EYPSJ+d915YvJ4nbuicf sh4mvuaHefUZx4OdmlrZWI78spkhdsylg8xeyp1vDTD4r6hhWV3tzEq37sn7vCh1qs9dKKG/Upp IF4HqcTJvTIr7GwNfVPE8wFvGMI2VdRFmc6kgtwdHgdPkJnJnuMlZGakMnxyOLxq5Ry7Ks7cvb5 x6rXqjzuasPzJ6q+E0RlIXLmNRkuMvs2y7crnNgY5ric6Xum/LeRVNzvBgKD+P9k9fRZnOxKLSg TNAoK9w== X-Received: by 2002:a05:600c:a09:b0:434:f753:6012 with SMTP id 5b1f17b1804b1-436e26aa593mr25692345e9.17.1736342382194; Wed, 08 Jan 2025 05:19:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/1t0QqCGIk5QcUTua4aoICm1+B+UWnLdTjgh4FaDkPxM0eUL+6lBB//VgUlwcbxLYHHMWtg== X-Received: by 2002:a05:600c:a09:b0:434:f753:6012 with SMTP id 5b1f17b1804b1-436e26aa593mr25692015e9.17.1736342381707; Wed, 08 Jan 2025 05:19:41 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7? (p200300cbc70d3a00d73c06a8ca9f1df7.dip0.t-ipconnect.de. [2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e92f6dsm20457255e9.41.2025.01.08.05.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 05:19:40 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 14:19:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v2] mm/hugetlb_vmemmap: fix memory loads ordering To: Yu Zhao , Andrew Morton Cc: Mateusz Guzik , "Matthew Wilcox (Oracle)" , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Will Deacon References: <20250108074822.722696-1-yuzhao@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250108074822.722696-1-yuzhao@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vaBqu0bPA8o-9Ckr604xPkaaeQEEujhQynMUP0XT9ys_1736342382 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 729F218002C X-Stat-Signature: e7fmy5gtxkpnqqbjfb65qy3y8e9f6hdk X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736342385-240262 X-HE-Meta: U2FsdGVkX189fmEtGd+H+gH3vfg+usAoiT0otUzPtZJV7bQNyU76LEhpylM38njf6CIIfj8bk31YA3VKBgrTylWeIOnTXb0lcAcOKpQDdYqZVBWaTPLoRVWnuklOkNfPT8wbPlWXXH/FT72lak2FWFW6OBjtIz9s8JxMY82SQnFnwZcV04F40tJUUP0h2/7aKM7c7K0lBpv9Yn3U9iHp2Sw4+kgnzuJ3M42knRHszAcXzZUds1S4Z+RayYAEvj0LF6wc12Fk5k+/W7iuHJumcPpM84Ic0Y4nY5dglXPkZ78zsVX7e4vtHfaEMcPi+WZtO7xuS1k8q48FPY3quZg6QEssvDge8QwQ41feoDdXDW0PYZhC7un1eHkUy0yd/X6/LDNdyEJ7Q8HJRnqFqGyIjQlGu/n7u7MkZvj1VHz0rRRs437SWPE7AQ5VPtO2xAksCkWoD9qEt7PrJD21fzOaw0dZMX1InCTVYWCPrtjqVc7UGzZOhewiqRq+mcm3Kh5yprzYrgC0gCn6DCvebPqgQUQUDZzo/SWqvRzhjiIXVpT7+BE5Ugy/OfDGgBtEWUzdQibGYFkdkXlBYViUlxlPg18tDIsrbGxEXYGmH3Os2YXkn1Zjx+8XS+YjqaWODQJZ2LGk3uErKhPl4AkTjLXQ64u4OrpvqFtVu9UE11PduLDlidgXtepQoNFV3dvYPJaw3UPR3zTfKY33bJ75yy5MujQ5N+NIXcKrA1IKTevKPW7ua/GivXzgWy9fZsNbeweYZWCLGT8J60MW8Ckjy31PVzxLTSwz4N2E2N+3wAfm0CTRl9pQ0Olt2B0zQqVkaF4cDp8VkRpTBLBW86eXBwr4Php+zjPLnaA4+A+ykn5KZI84lWTJuHkt2C3xh7qEQMgQ+DApevgwVwhk6uOJu+NVVDuJERdf1M3dT8e5odw7aqciD0fPkGomBKZn2Z50CJiKaDFYIZTFW/w0v7hP2lZ WYn0AlRa 0gHr0Do9AFMbBt8r3vCUZH9T7/Hyv8ccoAABSN7+6+Es8uuDDoaDuUSKbimplw4wRx4JtRIvbNjPbJu1wpf6TvB5KQBaaJ5Ynx2C4OgwjFNamAAMfm/sw2Fw+NdzXnnxeo77uZezdysZTduSlCGE/v90RfD6doaTMsIMLF4hZ0lpngBDyeenjePIQiSV0XwVHBxn37Sl6RunVPEPSlw0pqLhDahzwXlwYs33GdyfU1eBGpMm5xcGXkAVH/FTmS7BW4WqFwDgzF0j7iJHyx0cHWZmWmB8uVlQJtb6wlG2X7X11wQz27q4ZtrNHUEHQYgRDbhLc2RaDpQIApUYsgk0E+ir5W9gx72meAMpTk3LnAiQQ7DQxqKKZRdJd8PLEV0dZakGjS8kjxvh5KNctW8+NPRRXMOnLrDyWkDWjm1Gv8UYWdqEs65XT9w6eDFvkFUdUjychTIW82MgRCBOQ9bFsq0ZUwypb8ug6ozHOWilkrUwDi3YMQdOY+StSyns9296qJukxde6XSIjNWXobgiBsuxrlQNPYQ9soqXLFqNrYRpW6+ARf6G56CJ736Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.01.25 08:48, Yu Zhao wrote: > Using x86_64 as an example, for a 32KB struct page[] area describing a > 2MB hugeTLB, HVO reduces the area to 4KB by the following steps: > 1. Split the (r/w vmemmap) PMD mapping the area into 512 (r/w) PTEs; > 2. For the 8 PTEs mapping the area, remap PTE 1-7 to the page mapped > by PTE 0, and at the same time change the permission from r/w to > r/o; > 3. Free the pages PTE 1-7 used to map, hence the reduction from 32KB > to 4KB. > > However, the following race can happen due to improperly memory loads > ordering: > CPU 1 (HVO) CPU 2 (speculative PFN walker) > > page_ref_freeze() > synchronize_rcu() > rcu_read_lock() > page_is_fake_head() is false > vmemmap_remap_pte() > XXX: struct page[] becomes r/o > > page_ref_unfreeze() > page_ref_count() is not zero > > atomic_add_unless(&page->_refcount) > XXX: try to modify r/o struct page[] > > Specifically, page_is_fake_head() must be ordered after > page_ref_count() on CPU 2 so that it can only return true for this > case, to avoid the later attempt to modify r/o struct page[]. > > This patch adds the missing memory barrier and makes the tests on > page_is_fake_head() and page_ref_count() done in the proper order. > > Fixes: bd225530a4c7 ("mm/hugetlb_vmemmap: fix race with speculative PFN walkers") > Reported-by: Will Deacon > Closes: https://lore.kernel.org/20241128142028.GA3506@willie-the-truck/ > Signed-off-by: Yu Zhao > --- > include/linux/page-flags.h | 37 +++++++++++++++++++++++++++++++++++++ > include/linux/page_ref.h | 2 +- > 2 files changed, 38 insertions(+), 1 deletion(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 691506bdf2c5..16fa8f0cea02 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -225,11 +225,48 @@ static __always_inline const struct page *page_fixed_fake_head(const struct page > } > return page; > } > + > +static __always_inline bool page_count_writable(const struct page *page, int u) > +{ > + if (!static_branch_unlikely(&hugetlb_optimize_vmemmap_key)) > + return true; > + > + /* > + * The refcount check is ordered before the fake-head check to prevent > + * the following race: > + * CPU 1 (HVO) CPU 2 (speculative PFN walker) > + * > + * page_ref_freeze() > + * synchronize_rcu() > + * rcu_read_lock() > + * page_is_fake_head() is false > + * vmemmap_remap_pte() > + * XXX: struct page[] becomes r/o > + * > + * page_ref_unfreeze() > + * page_ref_count() is not zero > + * > + * atomic_add_unless(&page->_refcount) > + * XXX: try to modify r/o struct page[] > + * > + * The refcount check also prevents modification attempts to other (r/o) > + * tail pages that are not fake heads. > + */ > + if (atomic_read_acquire(&page->_refcount) == u) > + return false; > + > + return page_fixed_fake_head(page) == page; > +} > #else > static inline const struct page *page_fixed_fake_head(const struct page *page) > { > return page; > } > + > +static inline bool page_count_writable(const struct page *page, int u) > +{ > + return true; > +} > #endif > > static __always_inline int page_is_fake_head(const struct page *page) > diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h > index 8c236c651d1d..544150d1d5fd 100644 > --- a/include/linux/page_ref.h > +++ b/include/linux/page_ref.h > @@ -234,7 +234,7 @@ static inline bool page_ref_add_unless(struct page *page, int nr, int u) > > rcu_read_lock(); > /* avoid writing to the vmemmap area being remapped */ > - if (!page_is_fake_head(page) && page_ref_count(page) != u) > + if (page_count_writable(page, u)) > ret = atomic_add_unless(&page->_refcount, nr, u); > rcu_read_unlock(); > LGTM, thanks! Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb