From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E1E7C021B8 for ; Tue, 4 Mar 2025 13:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E03E66B0085; Tue, 4 Mar 2025 08:44:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB24C6B0088; Tue, 4 Mar 2025 08:44:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA10A280001; Tue, 4 Mar 2025 08:44:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A97FA6B0085 for ; Tue, 4 Mar 2025 08:44:44 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 68D31A57B4 for ; Tue, 4 Mar 2025 13:44:44 +0000 (UTC) X-FDA: 83183988888.13.33DAA9A Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf27.hostedemail.com (Postfix) with ESMTP id 8D0FD4000F for ; Tue, 4 Mar 2025 13:44:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741095882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hHqK4sbBnR0tQjZ/8MDq6//LBWWEzn1uN57BPPbarpY=; b=zsLFSLsEAeun8nTG8OluJZGgV/PryZ7uio9Pw2gixvtV2eYNNNgADgC6kIyYvDDLO6O6iq qmJkOhe1joZFDxhbRExdKZOLebEmWKKlo0qQ+cvSsmi6LiDA3X1Iymhhj4zZ20nZyZSNqi t4Zzs2V9pjOLBAvxyOJQTEYwMidZLUc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741095882; a=rsa-sha256; cv=none; b=JoEfMe9CvSiRd0B9Sjdelo5AkdhwA4N4fsQCaX65+u3VvsdvdOyri7jmNF2UDv/GTwX/FG 4ZrbrSvXL2DNjz+oyf2krXpeKqaRheV6CvNoujdGASQdbLAVKS6ZJpIaqLPDZFjPo0XDRy SBAZLdozJks0gAMNf1EhwC/0/9Tf5iI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Z6cJd5V4GzvWqS; Tue, 4 Mar 2025 21:40:49 +0800 (CST) Received: from kwepemo200002.china.huawei.com (unknown [7.202.195.209]) by mail.maildlp.com (Postfix) with ESMTPS id DAAD118007F; Tue, 4 Mar 2025 21:44:36 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by kwepemo200002.china.huawei.com (7.202.195.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 4 Mar 2025 21:44:35 +0800 Message-ID: Date: Tue, 4 Mar 2025 21:44:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages To: Oscar Salvador CC: David Hildenbrand , , , , , , References: <20250225141933.3852667-1-tujinjiang@huawei.com> <44267aae-4209-c5d2-9d0a-b9eeb4bd4bf0@huawei.com> From: Jinjiang Tu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemo200002.china.huawei.com (7.202.195.209) X-Stat-Signature: i4a7qswf6i66gihdx6otfndhm1csjxtd X-Rspamd-Queue-Id: 8D0FD4000F X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741095881-316350 X-HE-Meta: U2FsdGVkX18iudIQqQfsP/n6Yb0rmIpX3VEhoxXW+YgIUb3wJflWj3VkJYytAdyIDB+8MnmrqmXrg0ZQsmaJjegkiMwWUliKKTG7uY+kW2gfjsvCPy3EEFbd7RRBIdsLFqO/ipqk8fPLhNzfe38RYzFvHLbV9IUbD/uLc/rsP4ysH2XyxEXsFKmp/aJa6sjZFtakDe8ltJ4BIFk5OidvVjP13mwSomyaoYXf8f6rbnIsNPTOOWY9yHpjAcxv7KtoLWD0dkzbBdHyr43RFbYZ2xziQZQhV3zKW+Fxh9bfNTK9+8V7Bhn+a2G8O4boaVcg4SEbEY93BpdKxkI+tS1bJsonbUFSeVFskVrMFe/kNkV4OSbGN8sr9qQdPY2cmg7rjY7PMdwZtrMcfX+slfAq7LEbqAdfZH1yOlEJKIP4RahCW+IzQoauGgHz7nvDS668vzFz6UTY8WjvNRMWQGfxzYz7gpDYWj9M7D54QWgWqchC3DpYKYXoL7FVhLtly8J/1Q5zzKkFlmWyj2uwZ0B8FN1eDWw1LJx3U9I+6B8uKPZfAnhY6+ZEJWy8vXImQdOtlY188wpMGrNkpMuvOqRTX6MrB2XK/m/HKY7fOx0TzxHcUo7t9eBjjyPIjT7bQAkZV3NncOYkuKooZcqU5L0YnQ1AC+DLbSx5wGB9flafkYT/Sm0HDwbzA9CKI7X2J5ScdJNVl+b/HAhIMdV3bfQuMQiW4rVOoSyJXN8I7uwh8T2PMZLdPV97m4A9NdDd53x6xFM7tWMRzZUwmFJCOpYh3Le4KT5a7NOqahf5GJMmZkgFQpQskQZYIYrQOLI0saFsa0D8BRmnng6JssuLWv2R2wAV3C/7b20rq6nqlK8cAZL2V+wU7IPSTgF6GhLX6fFVHH1ya7jeutA53869qlpwCCipReX/oUQb6vbkHqsjp3xOsPw/meA8hPov4iSVfq7bf4EIrar28SIBVY6MVtJ WuIClLIv YkUTknQIvYxyRXeChw7G8RTY9DB7e2Pk8uzGnhGBRoTwMiFFQ0+/78i46VwvT7N7jlttUQxfSxbkzbie620mVw5e/KrXE8MWCXdgjy2Nm4zcaBLN5YgNM8CzMdMcYHIB0NE6Ph9ALPakUIy/TpKfU47FegP3eG3xjH1LXKzZOqf+kU1AqIGY77lGpP6BUVOUNpyamKlzyXbQ5ABE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/27 14:19, Oscar Salvador 写道: > On Thu, Feb 27, 2025 at 11:11:25AM +0800, Jinjiang Tu wrote: >> The result with this patch: >>          Node 0    Node 1 >> Total     5             0 >> Free      0             0 >> Surp     5             0 > Why would node0 have any surplus pages? > > Also, this does not reproduce in my machine. > > Are you overcommitting? Are you using the hvo optimization? > If so, it might be that we cannot allocate vmemmap pages and those > hugetlb pages stay in a surplus state? > > >From bulk_vmemmap_restore_error(): > > * If unable to restore a hugetlb page, the hugetlb > * page is made a surplus page and removed from the list. So surplus pages may be free pages and not reserved. In this patch, we shouldn't subtract surplus_huge_pages from min_mount, otherwise these free pages will be subtracted twice. > >